lighthouse 9.0.0 → 9.1.0

package/flow-report/test/util-test.tsx

@@ -5,11 +5,12 @@
  */
 
 import {jest} from '@jest/globals';
+import {render} from '@testing-library/preact';
 import {renderHook} from '@testing-library/preact-hooks';
 import {FunctionComponent} from 'preact';
 import {act} from 'preact/test-utils';
 
-import {FlowResultContext, useHashState} from '../src/util';
+import {FlowResultContext, useExternalRenderer, useHashState} from '../src/util';
 import {flowResult} from './sample-flow';
 
 let wrapper: FunctionComponent;
@@ -94,3 +95,39 @@ describe('useHashState', () => {
     expect(result.current).toBeNull();
   });
 });
+
+describe('useExternalRenderer', () => {
+  it('attaches DOM subtree of render callback', () => {
+    const Container: FunctionComponent = () => {
+      const ref = useExternalRenderer<HTMLDivElement>(() => {
+        const el = document.createElement('div');
+        el.textContent = 'Some text';
+        return el;
+      });
+      return <div ref={ref}/>;
+    };
+
+    const root = render(<Container/>);
+
+    expect(root.getByText('Some text')).toBeTruthy();
+  });
+
+  it('re-renders DOM subtree when input changes', () => {
+    const Container: FunctionComponent<{text: string}> = ({text}) => {
+      const ref = useExternalRenderer<HTMLDivElement>(() => {
+        const el = document.createElement('div');
+        el.textContent = text;
+        return el;
+      }, [text]);
+      return <div ref={ref}/>;
+    };
+
+    const root = render(<Container text="Some text"/>);
+
+    expect(root.getByText('Some text')).toBeTruthy();
+
+    root.rerender(<Container text="New text"/>);
+
+    expect(root.getByText('New text')).toBeTruthy();
+  });
+});

package/flow-report/test/wrappers/category-score-test.tsx

@@ -9,7 +9,6 @@ import {render} from '@testing-library/preact';
 
 import {CategoryScore} from '../../src/wrappers/category-score';
 import {FlowResultContext} from '../../src/util';
-import {ReportRendererProvider} from '../../src/wrappers/report-renderer';
 import {I18nProvider} from '../../src/i18n/i18n';
 import {flowResult} from '../sample-flow';
 
@@ -18,11 +17,9 @@ let wrapper: FunctionComponent;
 beforeEach(() => {
   wrapper = ({children}) => (
     <FlowResultContext.Provider value={flowResult}>
-      <ReportRendererProvider>
-        <I18nProvider>
-          {children}
-        </I18nProvider>
-      </ReportRendererProvider>
+      <I18nProvider>
+        {children}
+      </I18nProvider>
     </FlowResultContext.Provider>
   );
 });

package/flow-report/test/wrappers/markdown-test.tsx

@@ -5,24 +5,12 @@
  */
 
 import {render} from '@testing-library/preact';
-import {FunctionComponent} from 'preact';
 
 import {Markdown} from '../../src/wrappers/markdown';
-import {ReportRendererProvider} from '../../src/wrappers/report-renderer';
-
-let wrapper: FunctionComponent;
-
-beforeEach(() => {
-  wrapper = ({children}) => (
-    <ReportRendererProvider>
-      {children}
-    </ReportRendererProvider>
-  );
-});
 
 describe('Markdown', () => {
   it('renders markdown text', () => {
-    const root = render(<Markdown text="Some `fancy` text"/>, {wrapper});
+    const root = render(<Markdown text="Some `fancy` text"/>);
     const text = root.getByText(/^Some.*text$/);
     expect(text.innerHTML).toEqual('Some <code>fancy</code> text');
   });

package/flow-report/types/flow-report.d.ts

@@ -20,6 +20,10 @@ declare global {
   // Expose global types in LH namespace.
   module LH {
     export type ConfigSettings = Settings.ConfigSettings;
+    export interface FlowReportOptions {
+      getReportHtml?: (flowResult: FlowResult_) => string;
+      saveAsGist?: (flowResult: FlowResult_) => void;
+    }
 
     export import FlowResult = FlowResult_;
   }

package/lighthouse-cli/cli-flags.js

@@ -225,7 +225,7 @@ function getFlags(manualArgv, options = {}) {
       .options({
         'output': {
           type: 'array',
-          default: /** @type {['html']} */ (['html']),
+          default: /** @type {const} */ (['html']),
           coerce: coerceOutput,
           describe: 'Reporter for the results, supports multiple values. choices: "json", "html", "csv"',
         },
@@ -309,9 +309,9 @@ function getFlags(manualArgv, options = {}) {
       })
 
       // Choices added outside of `options()` and cast so tsc picks them up.
-      .choices('form-factor', /** @type {['mobile', 'desktop']} */ (['mobile', 'desktop']))
-      .choices('throttling-method', /** @type {['devtools', 'provided', 'simulate']} */ (['devtools', 'provided', 'simulate']))
-      .choices('preset', /** @type {['perf', 'experimental', 'desktop']} */ (['perf', 'experimental', 'desktop']))
+      .choices('form-factor', /** @type {const} */ (['mobile', 'desktop']))
+      .choices('throttling-method', /** @type {const} */ (['devtools', 'provided', 'simulate']))
+      .choices('preset', /** @type {const} */ (['perf', 'experimental', 'desktop']))
 
       .check(argv => {
         // Lighthouse doesn't need a URL if...

package/lighthouse-core/audits/audit.js

@@ -233,21 +233,53 @@ class Audit {
   }
 
   /**
-   * @param {LH.Artifacts.ConsoleMessage} entry
-   * @return {LH.Audit.Details.SourceLocationValue | undefined}
+   * @param {LH.Artifacts.Bundle} bundle
+   * @param {number} generatedLine
+   * @param {number} generatedColumn
+   * @return {LH.Audit.Details.SourceLocationValue['original']}
    */
-  static makeSourceLocationFromConsoleMessage(entry) {
-    if (!entry.url) return;
+  static _findOriginalLocation(bundle, generatedLine, generatedColumn) {
+    const entry = bundle?.map.findEntry(generatedLine, generatedColumn);
+    if (!entry) return;
 
+    return {
+      file: entry.sourceURL || '',
+      line: entry.sourceLineNumber || 0,
+      column: entry.sourceColumnNumber || 0,
+    };
+  }
+
+  /**
+   * @param {string} url
+   * @param {number} line 0-indexed
+   * @param {number} column 0-indexed
+   * @param {LH.Artifacts.Bundle=} bundle
+   * @return {LH.Audit.Details.SourceLocationValue}
+   */
+  static makeSourceLocation(url, line, column, bundle) {
     return {
       type: 'source-location',
-      url: entry.url,
+      url,
       urlProvider: 'network',
-      line: entry.lineNumber || 0,
-      column: entry.columnNumber || 0,
+      line,
+      column,
+      original: bundle && this._findOriginalLocation(bundle, line, column),
     };
   }
 
+  /**
+   * @param {LH.Artifacts.ConsoleMessage} entry
+   * @param {LH.Artifacts.Bundle=} bundle
+   * @return {LH.Audit.Details.SourceLocationValue | undefined}
+   */
+  static makeSourceLocationFromConsoleMessage(entry, bundle) {
+    if (!entry.url) return;
+
+    const line = entry.lineNumber || 0;
+    const column = entry.columnNumber || 0;
+    return this.makeSourceLocation(entry.url, line, column, bundle);
+  }
+
   /**
    * @param {number|null} score
    * @param {LH.Audit.ScoreDisplayMode} scoreDisplayMode

package/lighthouse-core/audits/byte-efficiency/legacy-javascript.js

@@ -397,23 +397,6 @@ class LegacyJavascript extends ByteEfficiencyAudit {
     return transferRatio;
   }
 
-  /**
-   * @param {LH.Artifacts.Bundle} bundle
-   * @param {number} generatedLine
-   * @param {number} generatedColumn
-   * @return {LH.Audit.Details.SourceLocationValue['original']}
-   */
-  static _findOriginalLocation(bundle, generatedLine, generatedColumn) {
-    const entry = bundle && bundle.map.findEntry(generatedLine, generatedColumn);
-    if (!entry) return;
-
-    return {
-      file: entry.sourceURL || '',
-      line: entry.sourceLineNumber || 0,
-      column: entry.sourceColumnNumber || 0,
-    };
-  }
-
   /**
    * @param {LH.Artifacts} artifacts
    * @param {Array<LH.Artifacts.NetworkRequest>} networkRecords
@@ -456,18 +439,10 @@ class LegacyJavascript extends ByteEfficiencyAudit {
       const bundle = bundles.find(bundle => bundle.script.src === url);
       for (const match of matches) {
         const {name, line, column} = match;
-
         /** @type {SubItem} */
         const subItem = {
           signal: name,
-          location: {
-            type: 'source-location',
-            url,
-            line,
-            column,
-            original: bundle && this._findOriginalLocation(bundle, line, column),
-            urlProvider: 'network',
-          },
+          location: ByteEfficiencyAudit.makeSourceLocation(url, line, column, bundle),
         };
         item.subItems.items.push(subItem);
       }

package/lighthouse-core/audits/deprecations.js

@@ -14,6 +14,7 @@
 // TODO: when M97 is sufficiently old, drop support for console messages
 
 const Audit = require('./audit.js');
+const JsBundles = require('../computed/js-bundles.js');
 const i18n = require('../lib/i18n/i18n.js');
 
 const UIStrings = {
@@ -47,34 +48,29 @@ class Deprecations extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['ConsoleMessages', 'InspectorIssues'],
+      requiredArtifacts: ['ConsoleMessages', 'InspectorIssues', 'SourceMaps', 'ScriptElements'],
     };
   }
 
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
+  static async audit(artifacts, context) {
     const entries = artifacts.ConsoleMessages;
+    const bundles = await JsBundles.request(artifacts, context);
 
     let deprecations;
-
     if (artifacts.InspectorIssues.deprecations.length) {
       deprecations = artifacts.InspectorIssues.deprecations
         .map(deprecation => {
+          const {url, lineNumber, columnNumber} = deprecation.sourceCodeLocation;
+          const bundle = bundles.find(bundle => bundle.script.src === url);
           return {
             value: deprecation.message || '',
-            /** @type {LH.Audit.Details.SourceLocationValue} */
-            source: {
-              type: 'source-location',
-              url: deprecation.sourceCodeLocation.url,
-              urlProvider: 'network',
-              line: deprecation.sourceCodeLocation.lineNumber,
-              // Protocol.Audits.SourceCodeLocation.columnNumber is 1-indexed,
-              // but we use 0-indexed.
-              column: deprecation.sourceCodeLocation.columnNumber - 1,
-            },
+            // Protocol.Audits.SourceCodeLocation.columnNumber is 1-indexed, but we use 0-indexed.
+            source: Audit.makeSourceLocation(url, lineNumber, columnNumber - 1, bundle),
           };
         });
     } else {

package/lighthouse-core/audits/dobetterweb/geolocation-on-start.js

@@ -38,17 +38,18 @@ class GeolocationOnStart extends ViolationAudit {
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
-      requiredArtifacts: ['ConsoleMessages'],
+      requiredArtifacts: ['ConsoleMessages', 'SourceMaps', 'ScriptElements'],
     };
   }
 
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
+  static async audit(artifacts, context) {
     // 'Only request geolocation information in response to a user gesture.'
-    const results = ViolationAudit.getViolationResults(artifacts, /geolocation/);
+    const results = await ViolationAudit.getViolationResults(artifacts, context, /geolocation/);
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [

package/lighthouse-core/audits/dobetterweb/js-libraries.js

@@ -61,7 +61,7 @@ class JsLibrariesAudit extends Audit {
     const details = Audit.makeTableDetails(headings, libDetails, {});
 
     const debugData = {
-      type: /** @type {'debugdata'} */ ('debugdata'),
+      type: /** @type {const} */ ('debugdata'),
       stacks: artifacts.Stacks.map(stack => {
         return {
           id: stack.id,

package/lighthouse-core/audits/dobetterweb/no-document-write.js

@@ -54,16 +54,18 @@ class NoDocWriteAudit extends ViolationAudit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['ConsoleMessages'],
+      requiredArtifacts: ['ConsoleMessages', 'SourceMaps', 'ScriptElements'],
     };
   }
 
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
-    const results = ViolationAudit.getViolationResults(artifacts, /document\.write/);
+  static async audit(artifacts, context) {
+    const results =
+      await ViolationAudit.getViolationResults(artifacts, context, /document\.write/);
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [

package/lighthouse-core/audits/dobetterweb/notification-on-start.js

@@ -38,16 +38,18 @@ class NotificationOnStart extends ViolationAudit {
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
-      requiredArtifacts: ['ConsoleMessages'],
+      requiredArtifacts: ['ConsoleMessages', 'SourceMaps', 'ScriptElements'],
     };
   }
 
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
-    const results = ViolationAudit.getViolationResults(artifacts, /notification permission/);
+  static async audit(artifacts, context) {
+    const results =
+      await ViolationAudit.getViolationResults(artifacts, context, /notification permission/);
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [

package/lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js

@@ -37,16 +37,18 @@ class PassiveEventsAudit extends ViolationAudit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['ConsoleMessages'],
+      requiredArtifacts: ['ConsoleMessages', 'SourceMaps', 'ScriptElements'],
     };
   }
 
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
-    const results = ViolationAudit.getViolationResults(artifacts, /passive event listener/);
+  static async audit(artifacts, context) {
+    const results =
+      await ViolationAudit.getViolationResults(artifacts, context, /passive event listener/);
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [

package/lighthouse-core/audits/errors-in-console.js

@@ -12,6 +12,7 @@
 
 const log = require('lighthouse-logger');
 const Audit = require('./audit.js');
+const JsBundles = require('../computed/js-bundles.js');
 const i18n = require('../lib/i18n/i18n.js');
 
 const UIStrings = {
@@ -39,7 +40,7 @@ class ErrorLogs extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['ConsoleMessages'],
+      requiredArtifacts: ['ConsoleMessages', 'SourceMaps', 'ScriptElements'],
     };
   }
 
@@ -75,20 +76,22 @@ class ErrorLogs extends Audit {
   /**
    * @param {LH.Artifacts} artifacts
    * @param {LH.Audit.Context} context
-   * @return {LH.Audit.Product}
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts, context) {
+  static async audit(artifacts, context) {
     /** @type {AuditOptions} */
     const auditOptions = context.options;
+    const bundles = await JsBundles.request(artifacts, context);
 
     /** @type {Array<{source: string, description: string|undefined, sourceLocation: LH.Audit.Details.SourceLocationValue|undefined}>} */
     const consoleRows = artifacts.ConsoleMessages
       .filter(item => item.level === 'error')
       .map(item => {
+        const bundle = bundles.find(bundle => bundle.script.src === item.url);
         return {
           source: item.source,
           description: item.text,
-          sourceLocation: Audit.makeSourceLocationFromConsoleMessage(item),
+          sourceLocation: Audit.makeSourceLocationFromConsoleMessage(item, bundle),
         };
       });
 

package/lighthouse-core/audits/installable-manifest.js

@@ -21,7 +21,7 @@ const UIStrings = {
   'columnValue': 'Failure reason',
   /**
    * @description [ICU Syntax] Label for an audit identifying the number of installability errors found in the page.
-  */
+   */
   'displayValue': `{itemCount, plural,
     =1 {1 reason}
     other {# reasons}
@@ -56,9 +56,9 @@ const UIStrings = {
   'manifest-missing-suitable-icon': `Manifest does not contain a suitable icon - PNG, SVG or WebP format of at least {value0}\xa0px is required, the sizes attribute must be set, and the purpose attribute, if set, must include "any".`,
 
   /**
-  * @description Error message explaining that the manifest does not supply an icon of the correct format.
-  * @example {192} value0
-  */
+   * @description Error message explaining that the manifest does not supply an icon of the correct format.
+   * @example {192} value0
+   */
   'no-acceptable-icon': `No supplied icon is at least {value0}\xa0px square in PNG, SVG or WebP format, with the purpose attribute unset or set to "any"`,
 
   /** Error message explaining that the icon could not be downloaded. */
@@ -95,6 +95,8 @@ const UIStrings = {
   'warn-not-offline-capable': `Page does not work offline. The page will not be regarded as installable after Chrome 93, stable release August 2021.`,
   /** Error message explaining that Lighthouse failed while detecting a service worker, and directing the user to try again in a new Chrome. */
   'protocol-timeout': `Lighthouse could not determine if there was a service worker. Please try with a newer version of Chrome.`,
+  /** Message logged when the web app has been uninstalled o desktop, signalling that the install banner state is being reset. */
+  'pipeline-restarted': 'PWA has been uninstalled and installability checks resetting.',
 };
 /* eslint-enable max-len */
 
@@ -146,6 +148,11 @@ class InstallableManifest extends Audit {
         continue;
       }
 
+      // Filter out errorId 'pipeline-restarted' since it only applies when the PWA is uninstalled.
+      if (err.errorId === 'pipeline-restarted') {
+        continue;
+      }
+
       // @ts-expect-error errorIds from protocol should match up against the strings dict
       const matchingString = UIStrings[err.errorId];
 

package/lighthouse-core/audits/no-unload-listeners.js

@@ -6,6 +6,7 @@
 'use strict';
 
 const Audit = require('./audit.js');
+const JsBundles = require('../computed/js-bundles.js');
 const i18n = require('./../lib/i18n/i18n.js');
 
 const UIStrings = {
@@ -29,15 +30,16 @@ class NoUnloadListeners extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['GlobalListeners', 'JsUsage'],
+      requiredArtifacts: ['GlobalListeners', 'JsUsage', 'SourceMaps', 'ScriptElements'],
     };
   }
 
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
+  static async audit(artifacts, context) {
     const unloadListeners = artifacts.GlobalListeners.filter(l => l.type === 'unload');
     if (!unloadListeners.length) {
       return {
@@ -45,6 +47,8 @@ class NoUnloadListeners extends Audit {
       };
     }
 
+    const bundles = await JsBundles.request(artifacts, context);
+
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
@@ -74,14 +78,9 @@ class NoUnloadListeners extends Audit {
         };
       }
 
+      const bundle = bundles.find(bundle => bundle.script.src === url);
       return {
-        source: {
-          type: 'source-location',
-          url,
-          urlProvider: 'network',
-          line: listener.lineNumber,
-          column: listener.columnNumber,
-        },
+        source: Audit.makeSourceLocation(url, listener.lineNumber, listener.columnNumber, bundle),
       };
     });
 

package/lighthouse-core/audits/seo/canonical.js

@@ -38,11 +38,6 @@ const UIStrings = {
    * @example {https://example.com/} url
    */
   explanationPointsElsewhere: 'Points to another `hreflang` location ({url})',
-  /**
-   * @description Explanatory message stating that there was a failure in an audit caused by a URL pointing to a different domain.
-   * @example {https://example.com/} url
-   * */
-  explanationDifferentDomain: 'Points to a different domain ({url})',
   /** Explanatory message stating that the page's canonical URL was pointing to the domain's root URL, which is a common mistake. "points" refers to the action of the 'rel=canonical' referencing another link. "root" refers to the starting/home page of the website. "domain" refers to the registered domain name of the website. */
   explanationRoot: 'Points to the domain\'s root URL (the homepage), ' +
     'instead of an equivalent page of content',
@@ -174,15 +169,6 @@ class Canonical extends Audit {
       };
     }
 
-    // bing and yahoo don't allow canonical URLs pointing to different domains, it's also
-    // a common mistake to publish a page with canonical pointing to e.g. a test domain or localhost
-    if (!URL.rootDomainsMatch(canonicalURL, baseURL)) {
-      return {
-        score: 0,
-        explanation: str_(UIStrings.explanationDifferentDomain, {url: canonicalURL.href}),
-      };
-    }
-
     // another common mistake is to have canonical pointing from all pages of the website to its root
     if (
       canonicalURL.origin === baseURL.origin &&

package/lighthouse-core/audits/seo/font-size.js

@@ -196,9 +196,11 @@ function findStyleRuleSource(baseURL, styleDeclaration, parentNode) {
       }
     }
 
-    const url = stylesheet.sourceURL;
+    const source = Audit.makeSourceLocation(stylesheet.sourceURL, line, column);
+    source.urlProvider = urlProvider;
+
     return {
-      source: {type: 'source-location', url, urlProvider, line, column},
+      source,
       selector,
     };
   }

package/lighthouse-core/audits/seo/is-crawlable.js

@@ -126,9 +126,9 @@ class IsCrawlable extends Audit {
             const line = robotsTxt.getMatchingLineNumber(mainResource.url) || 1;
             blockingDirectives.push({
               source: {
-                type: /** @type {'source-location'} */ ('source-location'),
+                type: /** @type {const} */ ('source-location'),
                 url: robotsFileUrl.href,
-                urlProvider: /** @type {'network'} */ ('network'),
+                urlProvider: /** @type {const} */ ('network'),
                 line: line - 1,
                 column: 0,
               },

package/lighthouse-core/audits/third-party-summary.js

@@ -216,12 +216,12 @@ class ThirdPartySummary extends Audit {
         return {
           ...stats,
           entity: {
-            type: /** @type {'link'} */ ('link'),
+            type: /** @type {const} */ ('link'),
             text: entity.name,
             url: entity.homepage || '',
           },
           subItems: {
-            type: /** @type {'subitems'} */ ('subitems'),
+            type: /** @type {const} */ ('subitems'),
             items: ThirdPartySummary.makeSubItems(entity, summaries, stats),
           },
         };

package/lighthouse-core/audits/valid-source-maps.js

@@ -110,7 +110,7 @@ class ValidSourceMaps extends Audit {
           scriptUrl: scriptElement.src,
           sourceMapUrl: sourceMap && sourceMap.sourceMapUrl,
           subItems: {
-            type: /** @type {'subitems'} */ ('subitems'),
+            type: /** @type {const} */ ('subitems'),
             items: errors,
           },
         });

package/lighthouse-core/audits/violation-audit.js

@@ -6,14 +6,18 @@
 'use strict';
 
 const Audit = require('./audit.js');
+const JsBundles = require('../computed/js-bundles.js');
 
 class ViolationAudit extends Audit {
   /**
    * @param {LH.Artifacts} artifacts
+   * @param {LH.Audit.Context} context
    * @param {RegExp} pattern
-   * @return {Array<{source: LH.Audit.Details.SourceLocationValue}>}
+   * @return {Promise<Array<{source: LH.Audit.Details.SourceLocationValue}>>}
    */
-  static getViolationResults(artifacts, pattern) {
+  static async getViolationResults(artifacts, context, pattern) {
+    const bundles = await JsBundles.request(artifacts, context);
+
     /**
      * @template T
      * @param {T} value
@@ -26,7 +30,10 @@ class ViolationAudit extends Audit {
     const seen = new Set();
     return artifacts.ConsoleMessages
         .filter(entry => entry.url && entry.source === 'violation' && pattern.test(entry.text))
-        .map(Audit.makeSourceLocationFromConsoleMessage)
+        .map(entry => {
+          const bundle = bundles.find(bundle => bundle.script.src === entry.url);
+          return Audit.makeSourceLocationFromConsoleMessage(entry, bundle);
+        })
         .filter(filterUndefined)
         .filter(source => {
           // Filter out duplicate entries since they are not differentiable to the user