lighthouse 8.6.0-dev.20211108 → 8.6.0-dev.20211109

package/lighthouse-cli/run.js

@@ -175,7 +175,7 @@ async function potentiallyKillChrome(launchedChrome) {
   /** @type {NodeJS.Timeout} */
   let timeout;
   const timeoutPromise = new Promise((_, reject) => {
-    timeout = setTimeout(() => reject(new Error('Timed out waiting to kill Chrome')), 5000);
+    timeout = setTimeout(reject, 5000, new Error('Timed out waiting to kill Chrome'));
   });
 
   return Promise.race([

package/lighthouse-core/audits/deprecations.js

@@ -11,6 +11,8 @@
  * that contain deprecated API warnings sent by Chrome.
  */
 
+// TODO: when M97 is sufficiently old, drop support for console messages
+
 const Audit = require('./audit.js');
 const i18n = require('../lib/i18n/i18n.js');
 
@@ -45,7 +47,7 @@ class Deprecations extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      requiredArtifacts: ['ConsoleMessages'],
+      requiredArtifacts: ['ConsoleMessages', 'InspectorIssues'],
     };
   }
 
@@ -56,16 +58,36 @@ class Deprecations extends Audit {
   static audit(artifacts) {
     const entries = artifacts.ConsoleMessages;
 
-    const deprecations = entries.filter(log => log.source === 'deprecation')
-    // TODO(M91): Temporary ignore until Chrome M91 became stable version.
-    // M91 doesn't throw deprecation on ::-webkit-details-marker.
-    .filter(log => !log.text.includes('::-webkit-details-marker'))
-    .map(log => {
-      return {
-        value: log.text,
-        source: Audit.makeSourceLocationFromConsoleMessage(log),
-      };
-    });
+    let deprecations;
+
+    if (artifacts.InspectorIssues.deprecations.length) {
+      deprecations = artifacts.InspectorIssues.deprecations
+        .map(deprecation => {
+          return {
+            value: deprecation.message || '',
+            /** @type {LH.Audit.Details.SourceLocationValue} */
+            source: {
+              type: 'source-location',
+              url: deprecation.sourceCodeLocation.url,
+              urlProvider: 'network',
+              line: deprecation.sourceCodeLocation.lineNumber,
+              // Protocol.Audits.SourceCodeLocation.columnNumber is 1-indexed,
+              // but we use 0-indexed.
+              column: deprecation.sourceCodeLocation.columnNumber - 1,
+            },
+          };
+        });
+    } else {
+      // Backcompat for <M97.
+      // https://bugs.chromium.org/p/chromium/issues/detail?id=1248484
+      deprecations = entries.filter(log => log.source === 'deprecation')
+        .map(log => {
+          return {
+            value: log.text,
+            source: Audit.makeSourceLocationFromConsoleMessage(log),
+          };
+        });
+    }
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [

package/lighthouse-core/config/constants.js

@@ -81,10 +81,9 @@ const screenEmulationMetrics = {
   desktop: DESKTOP_EMULATION_METRICS,
 };
 
-// eslint-disable-next-line max-len
-const MOTOG4_USERAGENT = 'Mozilla/5.0 (Linux; Android 7.0; Moto G (4)) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4590.2 Mobile Safari/537.36 Chrome-Lighthouse';
-// eslint-disable-next-line max-len
-const DESKTOP_USERAGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4590.2 Safari/537.36 Chrome-Lighthouse';
+
+const MOTOG4_USERAGENT = 'Mozilla/5.0 (Linux; Android 7.0; Moto G (4)) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4695.0 Mobile Safari/537.36 Chrome-Lighthouse'; // eslint-disable-line max-len
+const DESKTOP_USERAGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4695.0 Safari/537.36 Chrome-Lighthouse'; // eslint-disable-line max-len
 
 const userAgents = {
   mobile: MOTOG4_USERAGENT,

package/lighthouse-core/fraggle-rock/gather/session.js

@@ -150,10 +150,9 @@ class ProtocolSession {
     const timeoutPromise = new Promise((resolve, reject) => {
       if (timeoutMs === Infinity) return;
 
-      timeout = setTimeout((() => {
-        const err = new LHError(LHError.errors.PROTOCOL_TIMEOUT, {protocolMethod: method});
-        reject(err);
-      }), timeoutMs);
+      timeout = setTimeout(reject, timeoutMs, new LHError(LHError.errors.PROTOCOL_TIMEOUT, {
+        protocolMethod: method,
+      }));
     });
 
     const resultPromise = this._session.send(method, ...params);

package/lighthouse-core/gather/driver.js

@@ -338,13 +338,9 @@ class Driver {
     let asyncTimeout;
     const timeoutPromise = new Promise((resolve, reject) => {
       if (timeout === Infinity) return;
-      asyncTimeout = setTimeout((() => {
-        const err = new LHError(
-          LHError.errors.PROTOCOL_TIMEOUT,
-          {protocolMethod: method}
-        );
-        reject(err);
-      }), timeout);
+      asyncTimeout = setTimeout(reject, timeout, new LHError(LHError.errors.PROTOCOL_TIMEOUT, {
+        protocolMethod: method,
+      }));
     });
 
     return Promise.race([

package/lighthouse-core/gather/fetcher.js

@@ -195,9 +195,7 @@ class Fetcher {
     /** @type {NodeJS.Timeout} */
     let timeoutHandle;
     const timeoutPromise = new Promise((_, reject) => {
-      timeoutHandle = setTimeout(() => {
-        reject(new Error('Timed out fetching resource'));
-      }, options.timeout);
+      timeoutHandle = setTimeout(reject, options.timeout, new Error('Timed out fetching resource'));
     });
 
     const responsePromise = this._loadNetworkResource(url);
@@ -283,17 +281,16 @@ class Fetcher {
     /* c8 ignore stop */
 
     /** @type {NodeJS.Timeout} */
-    let timeoutHandle;
+    let asyncTimeout;
     /** @type {Promise<never>} */
     const timeoutPromise = new Promise((_, reject) => {
-      const errorMessage = 'Timed out fetching resource.';
-      timeoutHandle = setTimeout(() => reject(new Error(errorMessage)), options.timeout);
+      asyncTimeout = setTimeout(reject, options.timeout, new Error('Timed out fetching resource.'));
     });
 
     const racePromise = Promise.race([
       timeoutPromise,
       requestInterceptionPromise,
-    ]).finally(() => clearTimeout(timeoutHandle));
+    ]).finally(() => clearTimeout(asyncTimeout));
 
     // Temporarily disable auto-attaching for this iframe.
     await this.session.sendCommand('Target.setAutoAttach', {

package/lighthouse-core/gather/gatherers/inspector-issues.js

@@ -69,6 +69,8 @@ class InspectorIssues extends FRGatherer {
       heavyAds: [],
       /** @type {Array<LH.Crdp.Audits.ContentSecurityPolicyIssueDetails>} */
       contentSecurityPolicy: [],
+      /** @type {Array<LH.Crdp.Audits.DeprecationIssueDetails>} */
+      deprecations: [],
     };
 
     for (const issue of this._issues) {
@@ -105,6 +107,9 @@ class InspectorIssues extends FRGatherer {
       if (issue.details.contentSecurityPolicyIssueDetails) {
         artifact.contentSecurityPolicy.push(issue.details.contentSecurityPolicyIssueDetails);
       }
+      if (issue.details.deprecationIssueDetails) {
+        artifact.deprecations.push(issue.details.deprecationIssueDetails);
+      }
     }
 
     return artifact;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "8.6.0-dev.20211108",
+  "version": "8.6.0-dev.20211109",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {
@@ -146,7 +146,7 @@
     "cpy": "^7.0.1",
     "cross-env": "^7.0.2",
     "csv-validator": "^0.0.3",
-    "devtools-protocol": "0.0.901419",
+    "devtools-protocol": "0.0.939404",
     "es-main": "^1.0.2",
     "eslint": "^7.23.0",
     "eslint-config-google": "^0.9.1",
@@ -218,6 +218,9 @@
     "yargs": "^16.1.1",
     "yargs-parser": "^20.2.4"
   },
+  "resolutions": {
+    "puppeteer/**/devtools-protocol": "0.0.939404"
+  },
   "repository": "GoogleChrome/lighthouse",
   "keywords": [
     "google",

package/third-party/chromium-synchronization/inspector-issueAdded-types-test.js

@@ -31,18 +31,26 @@ describe('issueAdded types', () => {
       .sort();
   });
 
-  // TODO: https://github.com/GoogleChrome/lighthouse/issues/13147
-  it.skip('should notify us if something changed', () => {
+  it('should notify us if something changed', () => {
     expect(inspectorIssueDetailsTypes).toMatchInlineSnapshot(`
-      Array [
-        "blockedByResponseIssueDetails",
-        "contentSecurityPolicyIssueDetails",
-        "heavyAdIssueDetails",
-        "mixedContentIssueDetails",
-        "sameSiteCookieIssueDetails",
-        "sharedArrayBufferTransferIssueDetails",
-      ]
-    `);
+Array [
+  "attributionReportingIssueDetails",
+  "blockedByResponseIssueDetails",
+  "contentSecurityPolicyIssueDetails",
+  "corsIssueDetails",
+  "deprecationIssueDetails",
+  "genericIssueDetails",
+  "heavyAdIssueDetails",
+  "lowTextContrastIssueDetails",
+  "mixedContentIssueDetails",
+  "navigatorUserAgentIssueDetails",
+  "quirksModeIssueDetails",
+  "sameSiteCookieIssueDetails",
+  "sharedArrayBufferIssueDetails",
+  "twaQualityEnforcementDetails",
+  "wasmCrossOriginModuleSharingIssue",
+]
+`);
   });
 
   // TODO: https://github.com/GoogleChrome/lighthouse/issues/13147

package/types/artifacts.d.ts

@@ -558,6 +558,7 @@ declare module Artifacts {
     blockedByResponse: LH.Crdp.Audits.BlockedByResponseIssueDetails[];
     heavyAds: LH.Crdp.Audits.HeavyAdIssueDetails[];
     contentSecurityPolicy: LH.Crdp.Audits.ContentSecurityPolicyIssueDetails[];
+    deprecations: LH.Crdp.Audits.DeprecationIssueDetails[];
   }
 
   // Computed artifact types below.

package/types/lhr/audit-details.d.ts

@@ -263,6 +263,7 @@ declare module Details {
     urlProvider: 'network' | 'comment';
     /** Zero-indexed. */
     line: number;
+    /** Zero-indexed. */
     column: number;
     /** The original file location from the source map. */
     original?: {