lighthouse 13.5.0-dev.20261019 → 13.5.0-dev.20261020

package/cli/test/smokehouse/__snapshots__/report-assert-test.js.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`getAssertionReport works (multiple failing) 1`] = `
 "X difference at cumulative-layout-shift audit.details.items.length

package/core/audits/baseline.js

@@ -18,7 +18,7 @@ const UIStrings = {
    */
   description:
     'Lists web features used on the page and their Baseline status as of {date}. ' +
-    '[Learn more about Baseline](https://webstatus.dev/).',
+    '[Learn more about Baseline](https://developer.chrome.com/docs/lighthouse/best-practices/baseline-features).',
   /** Label for the column displaying the feature ID. */
   columnFeature: 'Web-features',
   /** Label for the column displaying the feature\'s baseline status. */

package/core/audits/script-treemap-data.js

@@ -176,12 +176,23 @@ class ScriptTreemapDataAudit extends Audit {
     const nodes = [];
     /** @type {Map<string, LH.Treemap.Node>} */
     const htmlNodesByFrameId = new Map();
+    /** @type {Set<LH.Artifacts.NetworkRequest>} */
+    const seenNetworkRecords = new Set();
     const bundles = await JSBundles.request(artifacts, context);
     const duplicationByPath = await ModuleDuplication.request(artifacts, context);
 
     for (const script of artifacts.Scripts) {
       if (script.scriptLanguage !== 'JavaScript') continue;
 
+      const isInlineScript = isInline(script);
+      const networkRecord = isInlineScript ?
+        undefined :
+        getRequestForScript(networkRecords, script);
+      if (networkRecord) {
+        if (seenNetworkRecords.has(networkRecord)) continue;
+        seenNetworkRecords.add(networkRecord);
+      }
+
       const name = script.url;
       const bundle = bundles.find(bundle => script.scriptId === bundle.script.scriptId) ?? null;
       const scriptCoverage = /** @type {LH.Artifacts['JsUsage'][string] | undefined} */
@@ -246,7 +257,7 @@ class ScriptTreemapDataAudit extends Audit {
 
       // If this is an inline script, place the node inside a top-level (aka depth-one) node.
       // Also separate each iframe / the main page's inline scripts into their own top-level nodes.
-      if (isInline(script)) {
+      if (isInlineScript) {
         let htmlNode = htmlNodesByFrameId.get(script.executionContextAuxData.frameId);
         if (!htmlNode) {
           htmlNode = {
@@ -269,7 +280,6 @@ class ScriptTreemapDataAudit extends Audit {
         // Non-inline scripts each have their own top-level node.
         nodes.push(node);
 
-        const networkRecord = getRequestForScript(networkRecords, script);
         if (networkRecord) {
           const bodyTransferSize =
             networkRecord.transferSize - networkRecord.responseHeadersTransferSize;

package/core/gather/base-artifacts.js

@@ -11,6 +11,7 @@ import {
   getDevicePixelRatio,
 } from './driver/environment.js';
 import {isEqual} from '../lib/arbitrary-equality-map.js';
+import {Sentry} from '../lib/sentry.js';
 
 /**
  * @param {LH.Config.ResolvedConfig} resolvedConfig
@@ -23,6 +24,11 @@ async function getBaseArtifacts(resolvedConfig, driver, context) {
   const {userAgent, product} = await getBrowserVersion(driver.defaultSession);
   const HostDPR = await getDevicePixelRatio(driver.executionContext);
 
+  const [name, version] = product.split('/');
+  if (name && version) {
+    Sentry.setContext('browser', {name, version});
+  }
+
   return {
     // Meta artifacts.
     fetchTime: new Date().toJSON(),

package/core/gather/gatherers/full-page-screenshot.js

@@ -95,7 +95,7 @@ class FullPageScreenshot extends BaseGatherer {
       mobile: deviceMetrics.mobile,
       deviceScaleFactor: 1,
       height,
-      width: 0, // Leave width unchanged
+      width: deviceMetrics.width,
     });
 
     // Now that the viewport is taller, give the page some time to fetch new resources that
@@ -235,7 +235,7 @@ class FullPageScreenshot extends BaseGatherer {
             mobile: deviceMetrics.mobile,
             deviceScaleFactor: deviceMetrics.deviceScaleFactor,
             height: deviceMetrics.height,
-            width: 0, // Leave width unchanged
+            width: deviceMetrics.width,
           });
         }
       }

package/core/lib/i18n/i18n.d.ts

@@ -1,4 +1,3 @@
-export type LhlMessages = import("../../../shared/localization/locales").LhlMessages;
 export namespace UIStrings {
     let ms: string;
     let seconds: string;

package/core/lib/i18n/i18n.js

@@ -4,12 +4,9 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/** @typedef {import('../../../shared/localization/locales').LhlMessages} LhlMessages */
-
 import path from 'path';
 import url from 'url';
 
-import lookupClosestLocale from 'lookup-closest-locale';
 import log from 'lighthouse-logger';
 
 import {getAvailableLocales} from '../../../shared/localization/format.js';
@@ -144,12 +141,22 @@ function lookupLocale(locales, possibleLocales) {
   // Filter by what's available in this runtime.
   const availableLocales = Intl.NumberFormat.supportedLocalesOf(canonicalLocales);
 
-  // Get available locales and transform into object to match `lookupClosestLocale`'s API.
-  const localesWithMessages = possibleLocales || getAvailableLocales();
-  const localesWithmessagesObj = /** @type {Record<LH.Locale, LhlMessages>} */ (
-    Object.fromEntries(localesWithMessages.map(l => [l, {}])));
-
-  const closestLocale = lookupClosestLocale(availableLocales, localesWithmessagesObj);
+  const localesWithMessages = new Set(possibleLocales || getAvailableLocales());
+
+  /** @type {LH.Locale|undefined} */
+  let closestLocale;
+  for (const locale of availableLocales) {
+    const parts = locale.split('-');
+    while (parts.length) {
+      const candidate = /** @type {LH.Locale} */ (parts.join('-'));
+      if (localesWithMessages.has(candidate)) {
+        closestLocale = candidate;
+        break;
+      }
+      parts.pop();
+    }
+    if (closestLocale) break;
+  }
 
   if (!closestLocale) {
     // Log extra info if we're pretty sure this version of Node was built with `--with-intl=small-icu`.

package/core/lib/sentry.d.ts

@@ -3,6 +3,7 @@ export namespace Sentry {
     export { noop as captureMessage };
     export { noop as captureBreadcrumb };
     export { noop as getContext };
+    export { noop as setContext };
     export let captureException: (error: Error, options: {
         level?: string;
         tags?: {

package/core/lib/sentry.js

@@ -32,6 +32,8 @@ const sentryDelegate = {
   captureBreadcrumb: noop,
   /** @type {() => any} */
   getContext: noop,
+  /** @type {(name: string, context: {[key: string]: any} | null) => void} */
+  setContext: noop,
   /** @type {(error: Error, options: {level?: string, tags?: {[key: string]: any}, extra?: {[key: string]: any}}) => Promise<void>} */
   captureException: async () => { },
   _shouldSample() {
@@ -88,6 +90,7 @@ async function init(opts) {
     sentryDelegate.captureMessage = (...args) => Sentry.captureMessage(...args);
     sentryDelegate.captureBreadcrumb = (...args) => Sentry.addBreadcrumb(...args);
     sentryDelegate.getContext = () => extras;
+    sentryDelegate.setContext = (...args) => Sentry.setContext(...args);
 
     // Keep a record of exceptions per audit/gatherer so we can just report once
     const sentryExceptionCache = new Map();

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "13.5.0-dev.20261019",
+  "version": "13.5.0-dev.20261020",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -37,7 +37,7 @@
     "reset-link": "(yarn unlink || true) && yarn link && yarn link lighthouse",
     "clean": "rm -r dist proto/scripts/*.json proto/scripts/*_pb2.* proto/scripts/*_pb.* proto/scripts/__pycache__ proto/scripts/*.pyc *.report.html *.report.dom.html *.report.json *.devtoolslog.json *.trace.json shared/localization/locales/*.ctc.json || true",
     "clean-types": "git clean -xfq '*.d.ts' '*.d.cts' -e 'node_modules/' -e 'dist/' -e '.tmp/' -e '**/types/'",
-    "lint": "[ \"$CI\" = true ] && eslint --quiet -f codeframe . || eslint .",
+    "lint": "[ \"$CI\" = true ] && eslint --quiet . || eslint .",
     "zizmor": "uvx zizmor@1.25.2 --gh-token=\"$(gh auth token)\" .github/workflows",
     "smoke": "node --enable-source-maps cli/test/smokehouse/frontends/smokehouse-bin.js",
     "debug": "node --inspect-brk ./cli/index.js",
@@ -102,7 +102,7 @@
   "devDependencies": {
     "@eslint/js": "^9.28.0",
     "@formatjs/icu-messageformat-parser": "^2.6.2",
-    "@jest/fake-timers": "^29.7.0",
+    "@jest/fake-timers": "^30.5.2",
     "@testing-library/preact": "^3.1.1",
     "@testing-library/preact-hooks": "^1.1.0",
     "@types/archiver": "^8.0.0",
@@ -118,10 +118,7 @@
     "@types/pako": "^1.0.1",
     "@types/yargs": "^17.0.35",
     "@types/yargs-parser": "^21.0.3",
-    "@typescript-eslint/eslint-plugin": "^8.60.1",
-    "@typescript-eslint/parser": "^8.60.1",
     "acorn": "^8.5.0",
-    "angular": "^1.7.4",
     "archiver": "^8.0.0",
     "chrome-devtools-frontend": "1.0.1705227",
     "concurrently": "^9.2.1",
@@ -130,15 +127,14 @@
     "csv-validator": "^0.0.3",
     "esbuild": "0.28.0",
     "eslint": "^9.28.0",
-    "eslint-formatter-codeframe": "^7.32.1",
     "eslint-plugin-import": "^2.32.0",
-    "expect": "^28.1.0",
+    "expect": "^30.5.2",
     "firebase": "^12.14.0",
     "gh-pages": "^2.0.1",
     "globals": "^15.14.0",
     "idb-keyval": "2.2.0",
-    "jest-mock": "^29.7.0",
-    "jest-snapshot": "^29.7.0",
+    "jest-mock": "^30.5.2",
+    "jest-snapshot": "^30.5.2",
     "jsdom": "^29.1.1",
     "lighthouse-plugin-soft-navigation": "^1.1.0",
     "magic-string": "^0.25.7",
@@ -148,12 +144,12 @@
     "preact": "^10.7.2",
     "pretty-json-stringify": "^0.0.2",
     "puppeteer": "^25.12.0",
-    "rollup-plugin-polyfill-node": "^0.12.0",
     "terser": "^5.48.0",
     "testdouble": "^3.20.2",
     "tsx": "^4.23.15",
     "typed-query-selector": "^2.12.0",
     "typescript": "6.0.3",
+    "typescript-eslint": "^8.60.1",
     "wait-for-expect": "^3.0.2",
     "web-features": "^3.40.0",
     "webtreemap-cdt": "^3.2.1"
@@ -174,7 +170,6 @@
     "js-library-detector": "^6.7.0",
     "lighthouse-logger": "^2.0.2",
     "lighthouse-stack-packs": "1.12.3",
-    "lookup-closest-locale": "6.2.0",
     "open": "^8.4.0",
     "puppeteer-core": "^25.12.0",
     "robots-parser": "^3.0.1",

package/shared/localization/locales/en-US.json

@@ -708,7 +708,7 @@
     "message": "Baseline Status"
   },
   "core/audits/baseline.js | description": {
-    "message": "Lists web features used on the page and their Baseline status as of {date}. [Learn more about Baseline](https://webstatus.dev/)."
+    "message": "Lists web features used on the page and their Baseline status as of {date}. [Learn more about Baseline](https://developer.chrome.com/docs/lighthouse/best-practices/baseline-features)."
   },
   "core/audits/baseline.js | title": {
     "message": "Baseline Features"

package/shared/localization/locales/en-XL.json

@@ -708,7 +708,7 @@
     "message": "B̂áŝél̂ín̂é Ŝt́ât́ûś"
   },
   "core/audits/baseline.js | description": {
-    "message": "L̂íŝt́ŝ ẃêb́ f̂éât́ûŕêś ûśêd́ ôń t̂h́ê ṕâǵê án̂d́ t̂h́êír̂ B́âśêĺîńê śt̂át̂úŝ áŝ óf̂ {date}. [Ĺêár̂ń m̂ór̂é âb́ôút̂ B́âśêĺîńê](https://webstatus.dev/)."
+    "message": "L̂íŝt́ŝ ẃêb́ f̂éât́ûŕêś ûśêd́ ôń t̂h́ê ṕâǵê án̂d́ t̂h́êír̂ B́âśêĺîńê śt̂át̂úŝ áŝ óf̂ {date}. [Ĺêár̂ń m̂ór̂é âb́ôút̂ B́âśêĺîńê](https://developer.chrome.com/docs/lighthouse/best-practices/baseline-features)."
   },
   "core/audits/baseline.js | title": {
     "message": "B̂áŝél̂ín̂é F̂éât́ûŕêś"

package/tsconfig.json

@@ -19,7 +19,6 @@
     "types.js",
     "./types/**/*.d.ts",
     "third-party/axe/valid-langs.js",
-    "third-party/esbuild-plugins-polyfills/esbuild-polyfills.js",
     "third-party/ard/**/*.js",
 
     "core/test/results/sample_v2.json",

package/types/internal/test.d.ts

@@ -29,6 +29,7 @@ declare module 'expect' {
      */
     // tslint:disable-next-line: no-unnecessary-generics
     toMatchInlineSnapshot<U extends { [P in keyof T]: any }>(propertyMatchers: Partial<U>, snapshot?: string): R;
+    toMatchInlineSnapshot(snapshot?: string): R;
 
     // The following are custom matchers defined in expect-setup.js
 

package/third-party/esbuild-plugins-polyfills/LICENSE

@@ -1,3 +0,0 @@
-MIT
-
-https://github.com/remorses/esbuild-plugins/blob/d757c3bf5dff37a754d254168d4a3d88611e8175/package.json#L37

package/third-party/esbuild-plugins-polyfills/README.md

@@ -1,7 +0,0 @@
-# @esbuild-plugins/node-modules-polyfill
-
-This is `@esbuild-plugins/node-modules-polyfill`, with the following changes:
-
-- using a better library for polyfills as proposed by this PR ... https://github.com/remorses/esbuild-plugins/pull/19
-- ...but there are a couple correctness changes on top of the above PR, as described here: https://github.com/remorses/esbuild-plugins/pull/19#discussion_r990493080 (the PR has landed but is still broken for our use case)
-- File converted from TS to JS

package/third-party/esbuild-plugins-polyfills/esbuild-polyfills.d.ts

@@ -1,9 +0,0 @@
-export function nodeModulesPolyfillPlugin(options?: {}): {
-    name: any;
-    setup: ({ onLoad, onResolve, initialOptions }: {
-        onLoad: any;
-        onResolve: any;
-        initialOptions: any;
-    }) => void;
-};
-//# sourceMappingURL=esbuild-polyfills.d.ts.map

package/third-party/esbuild-plugins-polyfills/esbuild-polyfills.js

@@ -1,129 +0,0 @@
-// @ts-nocheck
-/* eslint-disable */
-
-import path from 'path';
-
-import escapeStringRegexp from 'escape-string-regexp';
-import {getModules as builtinsPolyfills} from 'rollup-plugin-polyfill-node/dist/modules.js';
-import polyfillLib from 'rollup-plugin-polyfill-node/dist/polyfills.js';
-
-const NAME = 'node-modules-polyfills';
-const NAMESPACE = NAME;
-
-function removeEndingSlash(importee) {
-  if (importee && importee.slice(-1) === '/') {
-    importee = importee.slice(0, -1);
-  }
-  return importee;
-}
-
-function nodeModulesPolyfillPlugin(
-  options = {}
-) {
-  const {namespace = NAMESPACE, name = NAME} = options;
-  if (namespace.endsWith('commonjs')) {
-    throw new Error(`namespace ${namespace} must not end with commonjs`);
-  }
-  // this namespace is needed to make ES modules expose their default export to require: require('assert') will give you import('assert').default
-  const commonjsNamespace = namespace + '-commonjs';
-  const polyfilledBuiltins = builtinsPolyfills();
-  const polyfilledBuiltinsNames = [...polyfilledBuiltins.keys()];
-
-  return {
-    name,
-    setup: function setup({onLoad, onResolve, initialOptions}) {
-      // polyfills contain global keyword, it must be defined
-      if (initialOptions?.define && !initialOptions.define?.global) {
-        initialOptions.define['global'] = 'globalThis';
-      } else if (!initialOptions?.define) {
-        initialOptions.define = {global: 'globalThis'};
-      }
-
-      // TODO these polyfill module cannot import anything, is that ok?
-      async function loader(
-        args
-      ) {
-        try {
-          const isCommonjs = args.namespace.endsWith('commonjs');
-          
-          const key = removeEndingSlash(args.path);
-          const contents = polyfilledBuiltins.get(key) || polyfillLib[key + '.js'];
-          const resolveDir = path.dirname(key);
-
-          if (isCommonjs) {
-            return {
-              loader: 'js',
-              contents: commonJsTemplate({
-                importPath: args.path,
-              }),
-              resolveDir,
-            };
-          }
-          return {
-            loader: 'js',
-            contents,
-            resolveDir,
-          };
-        } catch (e) {
-          console.error('node-modules-polyfill', e);
-          return {
-            contents: `export {}`,
-            loader: 'js',
-          };
-        }
-      }
-      onLoad({filter: /.*/, namespace}, loader);
-      onLoad({filter: /.*/, namespace: commonjsNamespace}, loader);
-      const filter = new RegExp(
-                polyfilledBuiltinsNames.map(escapeStringRegexp).join('|') // TODO builtins could end with slash, keep in mind in regex
-      );
-      async function resolver(args) {
-        const ignoreRequire = args.namespace === commonjsNamespace;
-
-        let key;
-        if (args.path.startsWith('\0polyfill-node.')) {
-          key = args.path.replace('\0polyfill-node.', '');
-        } else {
-          if (args.path.startsWith('.')) {
-            key = path.join(path.dirname(args.importer), args.path);
-          } else {
-            key = args.path;
-          }
-        }
-
-        if (!polyfilledBuiltins.has(key) && !polyfillLib[key + '.js']) {
-          return;
-        }
-
-        const isCommonjs =
-                    !ignoreRequire && args.kind === 'require-call';
-
-        return {
-          namespace: isCommonjs ? commonjsNamespace : namespace,
-          path: key,
-        };
-      }
-      onResolve({filter}, resolver);
-      onResolve({filter: /.*/, namespace}, resolver);
-    },
-  };
-}
-
-function commonJsTemplate({importPath}) {
-  return `
-const polyfill = require('${importPath}')
-
-if (polyfill && polyfill.default) {
-    module.exports = polyfill.default
-    for (let k in polyfill) {
-        module.exports[k] = polyfill[k]
-    }
-} else if (polyfill)  {
-    module.exports = polyfill
-}
-
-
-`;
-}
-
-export {nodeModulesPolyfillPlugin};

package/types/internal/lookup-closest-locale.d.ts

@@ -1,13 +0,0 @@
-/**
- * @license
- * Copyright 2018 Google LLC
- * SPDX-License-Identifier: Apache-2.0
- */
-
-type Locale = import('../lhr/settings.js').Locale;
-
-declare module 'lookup-closest-locale' {
-  function lookupClosestLocale(locale: string[]|string|undefined, available: Record<Locale, any>): Locale|undefined;
-
-  export = lookupClosestLocale;
-}