lighthouse 13.5.0-dev.20261014 → 13.5.0-dev.20261016

package/cli/test/smokehouse/version-check.d.ts

@@ -11,5 +11,5 @@ export function chromiumVersionCheck(opts: {
  * @param {number[]} versionA
  * @param {number[]} versionB
  */
-export function compareVersions(versionA: number[], versionB: number[]): 1 | -1 | 0;
+export function compareVersions(versionA: number[], versionB: number[]): 0 | 1 | -1;
 //# sourceMappingURL=version-check.d.ts.map

package/core/audits/baseline.d.ts

@@ -796,8 +796,10 @@ declare class Baseline extends Audit {
      * - `high`: `baseline === 'high'` (Widely Available — 30 months past `baseline_low_date`; note that
      *   `featureData.high[id]` still stores the feature's `baseline_low_date`).
      *
+     * Widely Available rows always show `baseline_low_date`, including rows promoted at runtime.
      * If a feature in `featureData.low` has reached `baseline_low_date + 30 months <= currentDate` at runtime,
-     * we dynamically promote it from `low` (Newly Available) to `high` (Widely Available).
+     * we dynamically promote it from `low` (Newly Available) to `high` (Widely Available); promotion
+     * only changes the tier.
      *
      * @param {string} featureId
      * @param {{high: Record<string, string>, low: Record<string, string>, limited: string[]}} featureData

package/core/audits/baseline.js

@@ -55,8 +55,10 @@ class Baseline extends Audit {
    * - `high`: `baseline === 'high'` (Widely Available — 30 months past `baseline_low_date`; note that
    *   `featureData.high[id]` still stores the feature's `baseline_low_date`).
    *
+   * Widely Available rows always show `baseline_low_date`, including rows promoted at runtime.
    * If a feature in `featureData.low` has reached `baseline_low_date + 30 months <= currentDate` at runtime,
-   * we dynamically promote it from `low` (Newly Available) to `high` (Widely Available).
+   * we dynamically promote it from `low` (Newly Available) to `high` (Widely Available); promotion
+   * only changes the tier.
    *
    * @param {string} featureId
    * @param {{high: Record<string, string>, low: Record<string, string>, limited: string[]}} featureData
@@ -76,11 +78,10 @@ class Baseline extends Audit {
       const lowData = /** @type {Record<string, string>} */ (featureData.low);
       const widelyAvailableDate = new Date(lowData[featureId]);
       widelyAvailableDate.setUTCMonth(widelyAvailableDate.getUTCMonth() + 30);
-      const widelyAvailableDateStr = widelyAvailableDate.toISOString().slice(0, 10);
 
       if (widelyAvailableDate <= currentDate) {
         return {
-          displayStatus: `Widely Available (${widelyAvailableDateStr})`,
+          displayStatus: `Widely Available (${lowData[featureId]})`,
           baselineTier: 'high',
         };
       } else {

package/core/audits/insights/insight-audit.js

@@ -136,36 +136,41 @@ async function adaptInsightToAuditProduct(artifacts, context, insightName, creat
   // TODO: consider adding a `estimatedSavingsText` to InsightModel, which can capture
   // the exact i18n string used by RPP; and include the same est. timing savings.
   let displayValue;
+  let wastedMs;
+
+  switch (insight.insightKey) {
+    case 'DocumentLatency':
+    case 'FontDisplay':
+    case 'RenderBlocking': {
+      wastedMs = metricSavings?.FCP ?? 0;
+      break;
+    }
 
-  if (insight.wastedBytes) {
-    displayValue = str_(i18n.UIStrings.displayValueByteSavings, {wastedBytes: insight.wastedBytes});
-  } else {
-    let wastedMs;
-
-    switch (insight.insightKey) {
-      case 'DocumentLatency':
-      case 'DuplicatedJavaScript':
-      case 'FontDisplay':
-      case 'LegacyJavaScript':
-      case 'RenderBlocking': {
-        wastedMs = metricSavings?.FCP;
-        break;
-      }
-
-      case 'LCPDiscovery':
-      case 'ModernHTTP': {
-        wastedMs = metricSavings?.LCP;
-        break;
-      }
+    case 'LCPDiscovery':
+    case 'ModernHTTP': {
+      wastedMs = metricSavings?.LCP ?? 0;
+      break;
+    }
 
-      case 'Viewport': {
-        wastedMs = metricSavings?.INP;
-        break;
-      }
+    case 'Viewport': {
+      wastedMs = metricSavings?.INP ?? 0;
+      break;
     }
+  }
+
+  if (insight.wastedBytes) {
+    displayValue = str_(i18n.UIStrings.displayValueByteSavings, {wastedBytes: insight.wastedBytes});
+  } else if (wastedMs) {
+    displayValue = str_(i18n.UIStrings.displayValueMsSavings, {wastedMs});
+  }
 
-    if (wastedMs) {
-      displayValue = str_(i18n.UIStrings.displayValueMsSavings, {wastedMs});
+  if (numericValue === undefined) {
+    if (wastedMs !== undefined) {
+      numericValue = wastedMs;
+      numericUnit = 'millisecond';
+    } else if (insight.wastedBytes !== undefined) {
+      numericValue = insight.wastedBytes;
+      numericUnit = 'byte';
     }
   }
 

package/core/config/config-helpers.js

@@ -7,8 +7,6 @@ import path from 'path';
 import {createRequire} from 'module';
 import url from 'url';
 
-import {isEqual} from 'lodash-es';
-
 import * as LH from '../../types/lh.js';
 import * as constants from './constants.js';
 import ConfigPlugin from './config-plugin.js';
@@ -16,6 +14,7 @@ import {Runner} from '../runner.js';
 import * as i18n from '../lib/i18n/i18n.js';
 import * as validation from './validation.js';
 import {getModuleDirectory} from '../../shared/esm-utils.js';
+import {isEqual} from '../lib/arbitrary-equality-map.js';
 
 const require = createRequire(import.meta.url);
 

package/core/gather/base-artifacts.js

@@ -5,12 +5,12 @@
  */
 
 import log from 'lighthouse-logger';
-import {isEqual} from 'lodash-es';
 
 import {
   getBrowserVersion, getBenchmarkIndex, getEnvironmentWarnings,
   getDevicePixelRatio,
 } from './driver/environment.js';
+import {isEqual} from '../lib/arbitrary-equality-map.js';
 
 /**
  * @param {LH.Config.ResolvedConfig} resolvedConfig

package/core/gather/driver/storage.js

@@ -41,13 +41,14 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
  * @return {Promise<LH.IcuMessage[]>}
  */
 async function clearDataForOrigin(session, url, clearStorageTypes) {
+  const origin = new URL(url).origin;
+  if (origin === 'null') return [];
+
   const status = {msg: 'Cleaning origin data', id: 'lh:storage:clearDataForOrigin'};
   log.time(status);
 
   const warnings = [];
 
-  const origin = new URL(url).origin;
-
   const typesToClear = clearStorageTypes.join(',');
 
   // `Storage.clearDataForOrigin` is one of our PROTOCOL_TIMEOUT culprits and this command is also

package/core/lib/arbitrary-equality-map.d.ts

@@ -5,9 +5,7 @@
  */
 export class ArbitraryEqualityMap {
     /**
-     * Determines whether two objects are deeply equal. Defers to lodash isEqual, but is kept here for
-     * easy usage by consumers.
-     * See https://lodash.com/docs/4.17.5#isEqual.
+     * Determines whether two objects are deeply equal.
      * @param {*} objA
      * @param {*} objB
      * @return {boolean}
@@ -44,4 +42,17 @@ export class ArbitraryEqualityMap {
      */
     _findIndexOf(key: any): number;
 }
+/**
+ * @license
+ * Copyright 2018 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+/**
+ * @param {*} a
+ * @param {*} b
+ * @param {WeakMap<object, object>=} seen
+ * @return {boolean}
+ */
+declare function deepEquals(a: any, b: any, seen?: WeakMap<object, object> | undefined): boolean;
+export { deepEquals as isEqual };
 //# sourceMappingURL=arbitrary-equality-map.d.ts.map

package/core/lib/arbitrary-equality-map.js

@@ -4,7 +4,76 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import {isEqual} from 'lodash-es';
+/**
+ * @param {*} a
+ * @param {*} b
+ * @param {WeakMap<object, object>=} seen
+ * @return {boolean}
+ */
+function deepEquals(a, b, seen) {
+  if (a === b || (Number.isNaN(a) && Number.isNaN(b))) return true;
+  if (typeof a !== 'object' || a === null || typeof b !== 'object' || b === null) {
+    return false;
+  }
+  if (a.constructor !== b.constructor) return false;
+
+  if (a instanceof Date && b instanceof Date) {
+    return a.getTime() === b.getTime() || (Number.isNaN(a.getTime()) && Number.isNaN(b.getTime()));
+  }
+  if (a instanceof RegExp && b instanceof RegExp) {
+    return a.source === b.source && a.flags === b.flags;
+  }
+  if (ArrayBuffer.isView(a) && ArrayBuffer.isView(b)) {
+    if (a.byteLength !== b.byteLength) return false;
+    const viewA = new Uint8Array(a.buffer, a.byteOffset, a.byteLength);
+    const viewB = new Uint8Array(b.buffer, b.byteOffset, b.byteLength);
+    for (let i = 0; i < viewA.length; i++) {
+      if (viewA[i] !== viewB[i]) return false;
+    }
+    return true;
+  }
+
+  if (seen) {
+    if (seen.get(a) === b) return true;
+  } else {
+    seen = new WeakMap();
+  }
+  seen.set(a, b);
+
+  if (Array.isArray(a)) {
+    const arrB = /** @type {unknown[]} */ (b);
+    if (a.length !== arrB.length) return false;
+    for (let i = 0; i < a.length; i++) {
+      if (!deepEquals(a[i], arrB[i], seen)) return false;
+    }
+    return true;
+  }
+
+  if (a instanceof Map && b instanceof Map) {
+    if (a.size !== b.size) return false;
+    for (const [k, v] of a) {
+      if (!b.has(k) || !deepEquals(v, b.get(k), seen)) return false;
+    }
+    return true;
+  }
+
+  if (a instanceof Set && b instanceof Set) {
+    if (a.size !== b.size) return false;
+    for (const v of a) {
+      if (!b.has(v)) return false;
+    }
+    return true;
+  }
+
+  const keysA = Object.keys(a);
+  const keysB = Object.keys(b);
+  if (keysA.length !== keysB.length) return false;
+  for (let i = 0; i < keysA.length; i++) {
+    const key = keysA[i];
+    if (!Object.hasOwn(b, key) || !deepEquals(a[key], b[key], seen)) return false;
+  }
+  return true;
+}
 
 /**
  * @fileoverview This class is designed to allow maps with arbitrary equality functions.
@@ -65,16 +134,14 @@ class ArbitraryEqualityMap {
   }
 
   /**
-   * Determines whether two objects are deeply equal. Defers to lodash isEqual, but is kept here for
-   * easy usage by consumers.
-   * See https://lodash.com/docs/4.17.5#isEqual.
+   * Determines whether two objects are deeply equal.
    * @param {*} objA
    * @param {*} objB
    * @return {boolean}
    */
   static deepEquals(objA, objB) {
-    return isEqual(objA, objB);
+    return deepEquals(objA, objB);
   }
 }
 
-export {ArbitraryEqualityMap};
+export {ArbitraryEqualityMap, deepEquals as isEqual};

package/core/runner.js

@@ -9,7 +9,6 @@ import path from 'path';
 
 
 import log from 'lighthouse-logger';
-import {isEqual} from 'lodash-es';
 
 import {ReportScoring} from './scoring.js';
 import {Audit} from './audits/audit.js';
@@ -24,6 +23,7 @@ import {getModuleDirectory} from '../shared/esm-utils.js';
 import {EntityClassification} from './computed/entity-classification.js';
 import UrlUtils from './lib/url-utils.js';
 import {Util} from '../shared/util.js';
+import {isEqual} from './lib/arbitrary-equality-map.js';
 
 const moduleDir = getModuleDirectory(import.meta);
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "13.5.0-dev.20261014",
+  "version": "13.5.0-dev.20261016",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -121,7 +121,6 @@
     "@types/google.analytics": "0.0.39",
     "@types/gtag.js": "0.0.20",
     "@types/jsdom": "^16.2.13",
-    "@types/lodash-es": "^4.17.12",
     "@types/mocha": "^9.0.0",
     "@types/node": "*",
     "@types/pako": "^1.0.1",
@@ -129,9 +128,8 @@
     "@types/resize-observer-browser": "^0.1.1",
     "@types/resolve": "^1.20.2",
     "@types/semver": "^5.5.0",
-    "@types/ws": "^7.0.0",
-    "@types/yargs": "^17.0.8",
-    "@types/yargs-parser": "^20.2.1",
+    "@types/yargs": "^17.0.35",
+    "@types/yargs-parser": "^21.0.3",
     "@typescript-eslint/eslint-plugin": "^8.60.1",
     "@typescript-eslint/parser": "^8.60.1",
     "acorn": "^8.5.0",
@@ -196,7 +194,6 @@
     "js-library-detector": "^6.7.0",
     "lighthouse-logger": "^2.0.2",
     "lighthouse-stack-packs": "1.12.3",
-    "lodash-es": "^4.17.21",
     "lookup-closest-locale": "6.2.0",
     "open": "^8.4.0",
     "puppeteer-core": "^25.12.0",
@@ -204,9 +201,8 @@
     "speedline-core": "^1.4.3",
     "third-party-web": "^0.30.0",
     "tldts-icann": "^7.4.16",
-    "ws": "^7.0.0",
-    "yargs": "^17.3.1",
-    "yargs-parser": "^21.0.0"
+    "yargs": "^18.2.0",
+    "yargs-parser": "^22.0.0"
   },
   "resolutions": {
     "puppeteer/**/devtools-protocol": "0.0.1704951",

package/shared/localization/swap-locale.js

@@ -4,9 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import {set} from 'lodash-es';
-import {get} from 'lodash-es';
-
 import * as format from './format.js';
 
 /**
@@ -70,9 +67,17 @@ function swapLocale(lhr, requestedLocale) {
         values = instance.values;
       }
 
+      const keys = path.replace(/\[([^\]]+)\]/g, '.$1').replace(/^\./, '').split('.');
+      /** @type {any} */
+      let parent = lhr;
+      for (let i = 0; i < keys.length - 1; i++) {
+        parent = parent?.[keys[i]];
+      }
+      const lastKey = keys[keys.length - 1];
+
       // If the path isn't valid or the value isn't a string, there's no point in trying to replace it.
       /** @type {unknown} */
-      const originalString = get(lhr, path);
+      const originalString = parent?.[lastKey];
       if (typeof originalString !== 'string') {
         continue;
       }
@@ -96,7 +101,7 @@ function swapLocale(lhr, requestedLocale) {
       }
 
       // Write string back into the LHR.
-      set(lhr, path, relocalizedString);
+      parent[lastKey] = relocalizedString;
     }
   }