lighthouse 13.4.1-dev.20260810 → 13.4.1-dev.20260820

package/cli/test/smokehouse/lighthouse-runners/bundle.js

@@ -71,11 +71,11 @@ async function runBundledLighthouse(url, config, testRunnerOptions) {
   global.Buffer = originalBuffer;
   global.process = originalProcess;
 
-  /** @type {import('../../../../core/index.js')['default']} */
+  /** @type {typeof import('../../../../core/index.js')['default']} */
   // @ts-expect-error - not worth giving test global an actual type.
   const lighthouse = global.runBundledLighthouse;
 
-  /** @type {import('../../../../core/lib/third-party-web.js')['default']} */
+  /** @type {typeof import('../../../../core/lib/third-party-web.js')['default']} */
   // @ts-expect-error
   const thirdPartyWeb = global.thirdPartyWeb;
   thirdPartyWeb.provideThirdPartyWeb(thirdPartyWebLib);

package/core/audits/webmcp-schema-validity.js

@@ -70,7 +70,7 @@ class WebMcpSchemaValidity extends Audit {
       WARNING: 2,
     };
 
-    /** @type {Record<string, {severity: Severity, description: LH.IcuMessage}>} */
+    /** @type {Record<string, {severity: typeof Severity[keyof typeof Severity], description: LH.IcuMessage}>} */
     const issueConfigs = {
       'FormModelContextMissingToolName': {
         severity: Severity.ERROR,

package/core/computed/metrics/interactive.js

@@ -88,7 +88,7 @@ class Interactive extends NavigationMetric {
   static findOverlappingQuietPeriods(longTasks, networkRecords, processedNavigation) {
     const FcpTsInMs = processedNavigation.timestamps.firstContentfulPaint / 1000;
 
-    /** @type {function(TimePeriod):boolean} */
+    /** @type {(period: TimePeriod) => boolean} */
     const isLongEnoughQuietPeriod = period =>
         period.end > FcpTsInMs + REQUIRED_QUIET_WINDOW &&
         period.end - period.start >= REQUIRED_QUIET_WINDOW;

package/core/computed/metrics/lantern-metric.js

@@ -61,7 +61,7 @@ function lanternErrorAdapter(err) {
     throw err;
   }
 
-  const code = /** @type {keyof LighthouseError.errors} */ (err.message);
+  const code = /** @type {keyof typeof LighthouseError.errors} */ (err.message);
   if (LighthouseError.errors[code]) {
     throw new LighthouseError(LighthouseError.errors[code]);
   }

package/core/computed/trace-engine-result.d.ts

@@ -25,7 +25,7 @@ declare class TraceEngineResult {
      *
      * @template {any[]} Args
      * @template {import('../lib/trace-engine.js').DevToolsIcuMessage} Ret
-     * @param {ReturnType<i18n.createIcuMessageFn>} str_
+     * @param {ReturnType<typeof i18n.createIcuMessageFn>} str_
      * @param {(...args: Args) => Ret} fn
      * @return {(...args: Args) => LH.IcuMessage}
      */
@@ -34,7 +34,7 @@ declare class TraceEngineResult {
      * Converts the input parameters given to `i18nString` usages in DevTools to a
      * LH.IcuMessage.
      *
-     * @param {ReturnType<i18n.createIcuMessageFn>} str_
+     * @param {ReturnType<typeof i18n.createIcuMessageFn>} str_
      * @param {import('../lib/trace-engine.js').DevToolsIcuMessage} traceEngineI18nObject
      * @return {LH.IcuMessage}
      */
@@ -42,7 +42,7 @@ declare class TraceEngineResult {
     /**
      * Recursively finds all DevToolsIcuMessage objects and replaces them with LH.IcuMessage.
      *
-     * @param {ReturnType<i18n.createIcuMessageFn>} str_
+     * @param {ReturnType<typeof i18n.createIcuMessageFn>} str_
      * @param {object} object
      */
     static localizeObject(str_: ReturnType<typeof i18n.createIcuMessageFn>, object: object): void;

package/core/computed/trace-engine-result.js

@@ -76,7 +76,7 @@ class TraceEngineResult {
    *
    * @template {any[]} Args
    * @template {import('../lib/trace-engine.js').DevToolsIcuMessage} Ret
-   * @param {ReturnType<i18n.createIcuMessageFn>} str_
+   * @param {ReturnType<typeof i18n.createIcuMessageFn>} str_
    * @param {(...args: Args) => Ret} fn
    * @return {(...args: Args) => LH.IcuMessage}
    */
@@ -88,7 +88,7 @@ class TraceEngineResult {
    * Converts the input parameters given to `i18nString` usages in DevTools to a
    * LH.IcuMessage.
    *
-   * @param {ReturnType<i18n.createIcuMessageFn>} str_
+   * @param {ReturnType<typeof i18n.createIcuMessageFn>} str_
    * @param {import('../lib/trace-engine.js').DevToolsIcuMessage} traceEngineI18nObject
    * @return {LH.IcuMessage}
    */
@@ -121,7 +121,7 @@ class TraceEngineResult {
   /**
    * Recursively finds all DevToolsIcuMessage objects and replaces them with LH.IcuMessage.
    *
-   * @param {ReturnType<i18n.createIcuMessageFn>} str_
+   * @param {ReturnType<typeof i18n.createIcuMessageFn>} str_
    * @param {object} object
    */
   static localizeObject(str_, object) {

package/core/computed/unused-javascript-summary.d.ts

@@ -39,7 +39,6 @@ declare const UnusedJavascriptSummaryComputed: typeof UnusedJavascriptSummary &
  * @property {string} scriptId
  * @property {number} wastedBytes
  * @property {number} totalBytes
- * @property {number} wastedBytes
  * @property {number=} wastedPercent
  * @property {Record<string, number>=} sourcesWastedBytes Keyed by file name. Includes (unmapped) key too.
  */

package/core/computed/unused-javascript-summary.js

@@ -24,7 +24,6 @@ import {makeComputedArtifact} from './computed-artifact.js';
  * @property {string} scriptId
  * @property {number} wastedBytes
  * @property {number} totalBytes
- * @property {number} wastedBytes
  * @property {number=} wastedPercent
  * @property {Record<string, number>=} sourcesWastedBytes Keyed by file name. Includes (unmapped) key too.
  */

package/core/gather/driver/wait-for-condition.d.ts

@@ -18,7 +18,7 @@ export type WaitOptions = {
         waitForCPUIdle: typeof waitForCPUIdle;
     } | undefined;
 };
-/** @typedef {InstanceType<import('./network-monitor.js')['NetworkMonitor']>} NetworkMonitor */
+/** @typedef {InstanceType<typeof import('./network-monitor.js')['NetworkMonitor']>} NetworkMonitor */
 /** @typedef {import('./network-monitor.js').NetworkMonitorEvent} NetworkMonitorEvent */
 /**
  * @template [T=void]
@@ -40,12 +40,9 @@ export type WaitOptions = {
  * Returns a promise that resolves immediately.
  * Used for placeholder conditions that we don't want to start waiting for just yet, but still want
  * to satisfy the same interface.
- * @return {{promise: Promise<void>, cancel: function(): void}}
+ * @return {CancellableWait<void>}
  */
-export function waitForNothing(): {
-    promise: Promise<void>;
-    cancel: () => void;
-};
+export function waitForNothing(): CancellableWait<void>;
 /**
  * Returns a promise that resolve when a frame has been navigated.
  * Used for detecting that our about:blank reset has been completed.

package/core/gather/driver/wait-for-condition.js

@@ -11,7 +11,7 @@ import log from 'lighthouse-logger';
 import {LighthouseError} from '../../lib/lh-error.js';
 import {ExecutionContext} from './execution-context.js';
 
-/** @typedef {InstanceType<import('./network-monitor.js')['NetworkMonitor']>} NetworkMonitor */
+/** @typedef {InstanceType<typeof import('./network-monitor.js')['NetworkMonitor']>} NetworkMonitor */
 /** @typedef {import('./network-monitor.js').NetworkMonitorEvent} NetworkMonitorEvent */
 
 /**
@@ -36,7 +36,7 @@ import {ExecutionContext} from './execution-context.js';
  * Returns a promise that resolves immediately.
  * Used for placeholder conditions that we don't want to start waiting for just yet, but still want
  * to satisfy the same interface.
- * @return {{promise: Promise<void>, cancel: function(): void}}
+ * @return {CancellableWait<void>}
  */
 function waitForNothing() {
   return {promise: Promise.resolve(), cancel() {}};

package/core/gather/gatherers/accessibility.js

@@ -15,7 +15,7 @@ import {pageFunctions} from '../../lib/page-functions.js';
  */
 /* c8 ignore start */
 async function runA11yChecks() {
-  /** @type {import('axe-core/axe')} */
+  /** @type {typeof import('axe-core/axe')} */
   // @ts-expect-error - axe defined by axeLibSource
   const axe = window.axe;
   const application = `lighthouse-${Math.random()}`;

package/core/gather/gatherers/image-elements.js

@@ -189,7 +189,7 @@ function findSizeDeclaration(rule, property) {
  * Finds the most specific directly matched CSS font-size rule from the list.
  *
  * @param {Array<LH.Crdp.CSS.RuleMatch>} matchedCSSRules
- * @param {function(LH.Crdp.CSS.CSSStyle):boolean|string|undefined} isDeclarationOfInterest
+ * @param {(style: LH.Crdp.CSS.CSSStyle) => boolean|string|undefined} isDeclarationOfInterest
  */
 function findMostSpecificMatchedCSSRule(matchedCSSRules = [], isDeclarationOfInterest) {
   let mostSpecificRule;

package/core/gather/gatherers/stacks.d.ts

@@ -13,7 +13,7 @@ export type JSLibraryDetectorTest = {
     /**
      * Returns false if library is not present, otherwise returns an object that contains the library version (set to null if the version is not detected).
      */
-    test: (arg0: Window) => JSLibraryDetectorTestResult | Promise<JSLibraryDetectorTestResult>;
+    test: (w: Window) => JSLibraryDetectorTestResult | Promise<JSLibraryDetectorTestResult>;
 };
 export type JSLibrary = {
     id: string;

package/core/gather/gatherers/stacks.js

@@ -32,7 +32,7 @@ const libDetectorSource = fs.readFileSync(
  * @property {string} icon
  * @property {string} url
  * @property {string|null} npm npm module name, if applicable to library.
- * @property {function(Window): JSLibraryDetectorTestResult | Promise<JSLibraryDetectorTestResult>} test Returns false if library is not present, otherwise returns an object that contains the library version (set to null if the version is not detected).
+ * @property {(w: Window) => JSLibraryDetectorTestResult | Promise<JSLibraryDetectorTestResult>} test Returns false if library is not present, otherwise returns an object that contains the library version (set to null if the version is not detected).
  */
 
 /**

package/core/index.cjs

@@ -6,13 +6,13 @@
 
 /**
  * @typedef ExportType
- * @property {import('./index.js')['startFlow']} startFlow
- * @property {import('./index.js')['navigation']} navigation
- * @property {import('./index.js')['startTimespan']} startTimespan
- * @property {import('./index.js')['snapshot']} snapshot
+ * @property {typeof import('./index.js')['startFlow']} startFlow
+ * @property {typeof import('./index.js')['navigation']} navigation
+ * @property {typeof import('./index.js')['startTimespan']} startTimespan
+ * @property {typeof import('./index.js')['snapshot']} snapshot
  */
 
-/** @type {import('./index.js')['default'] & ExportType} */
+/** @type {typeof import('./index.js')['default'] & ExportType} */
 const lighthouse = async function lighthouse(...args) {
   const {default: lighthouse} = await import('./index.js');
   return lighthouse(...args);

package/core/index.d.cts

@@ -6,11 +6,11 @@ export = lighthouse;
  */
 /**
  * @typedef ExportType
- * @property {import('./index.js')['startFlow']} startFlow
- * @property {import('./index.js')['navigation']} navigation
- * @property {import('./index.js')['startTimespan']} startTimespan
- * @property {import('./index.js')['snapshot']} snapshot
+ * @property {typeof import('./index.js')['startFlow']} startFlow
+ * @property {typeof import('./index.js')['navigation']} navigation
+ * @property {typeof import('./index.js')['startTimespan']} startTimespan
+ * @property {typeof import('./index.js')['snapshot']} snapshot
  */
-/** @type {import('./index.js')['default'] & ExportType} */
+/** @type {typeof import('./index.js')['default'] & ExportType} */
 declare const lighthouse: typeof import("./index.js")["default"] & ExportType;
 //# sourceMappingURL=index.d.cts.map

package/core/lib/arbitrary-equality-map.d.ts

@@ -20,9 +20,9 @@ export class ArbitraryEqualityMap {
         value: any;
     }>;
     /**
-     * @param {function(*,*):boolean} equalsFn
+     * @param {(a: any, b: any) => boolean} equalsFn
      */
-    setEqualityFn(equalsFn: (arg0: any, arg1: any) => boolean): void;
+    setEqualityFn(equalsFn: (a: any, b: any) => boolean): void;
     /**
      * @param {*} key
      * @return {boolean}

package/core/lib/arbitrary-equality-map.js

@@ -19,7 +19,7 @@ class ArbitraryEqualityMap {
   }
 
   /**
-   * @param {function(*,*):boolean} equalsFn
+   * @param {(a: any, b: any) => boolean} equalsFn
    */
   setEqualityFn(equalsFn) {
     this._equalsFn = equalsFn;

package/core/lib/deprecation-description.js

@@ -33,7 +33,7 @@ const deprecationsStr_ = i18n.createIcuMessageFn(
  */
 function getIssueDetailDescription(issueDetails) {
   let message;
-  const type = /** @type {keyof DEPRECATIONS_METADATA} */ (issueDetails.type);
+  const type = /** @type {keyof typeof DEPRECATIONS_METADATA} */ (issueDetails.type);
   const maybeEnglishMessage = DeprecationUIStrings[type];
   if (maybeEnglishMessage) {
     message = deprecationsStr_(maybeEnglishMessage);