lighthouse 12.8.2 → 13.0.0

package/core/audits/accessibility/td-has-header.js

@@ -13,15 +13,15 @@ import AxeAudit from './axe-audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 
 const UIStrings = {
-  /** Title of an accesibility audit that evaluates if all large table elements use the headers HTML attribute. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  /** Title of an accessibility audit that evaluates if all large table elements use the headers HTML attribute. This title is descriptive of the successful state and is shown to users when no user action is required. */
   title: '`<td>` elements in a large `<table>` have one or more table headers.',
-  /** Title of an accesibility audit that evaluates if all large table elements use the headers HTML attribute. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  /** Title of an accessibility audit that evaluates if all large table elements use the headers HTML attribute. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
   failureTitle: '`<td>` elements in a large `<table>` do not have table headers.',
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
       'that `<td>` elements in a large table (3 or more cells in width and height) have an ' +
       'associated table header may improve the experience for screen reader users. ' +
-      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.10/td-has-header).',
+      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.11/td-has-header).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/td-headers-attr.js

@@ -14,17 +14,17 @@ import AxeAudit from './axe-audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 
 const UIStrings = {
-  /** Title of an accesibility audit that evaluates if all table cell elements in a table that use the headers HTML attribute use it correctly to refer to header cells within the same table. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  /** Title of an accessibility audit that evaluates if all table cell elements in a table that use the headers HTML attribute use it correctly to refer to header cells within the same table. This title is descriptive of the successful state and is shown to users when no user action is required. */
   title: 'Cells in a `<table>` element that use the `[headers]` attribute refer ' +
       'to table cells within the same table.',
-  /** Title of an accesibility audit that evaluates if all table cell elements in a table that use the headers HTML attribute use it correctly to refer to header cells within the same table. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  /** Title of an accessibility audit that evaluates if all table cell elements in a table that use the headers HTML attribute use it correctly to refer to header cells within the same table. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
   failureTitle: 'Cells in a `<table>` element that use the `[headers]` attribute refer ' +
       'to an element `id` not found within the same table.',
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
       '`<td>` cells using the `[headers]` attribute only refer to other cells in the same ' +
       'table may improve the experience for screen reader users. ' +
-      '[Learn more about the `headers` attribute](https://dequeuniversity.com/rules/axe/4.10/td-headers-attr).',
+      '[Learn more about the `headers` attribute](https://dequeuniversity.com/rules/axe/4.11/td-headers-attr).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/th-has-data-cells.js

@@ -13,17 +13,17 @@ import AxeAudit from './axe-audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 
 const UIStrings = {
-  /** Title of an accesibility audit that evaluates if all table header elements have children. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  /** Title of an accessibility audit that evaluates if all table header elements have children. This title is descriptive of the successful state and is shown to users when no user action is required. */
   title: '`<th>` elements and elements with `[role="columnheader"/"rowheader"]` have ' +
       'data cells they describe.',
-  /** Title of an accesibility audit that evaluates if all table header elements have children. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  /** Title of an accessibility audit that evaluates if all table header elements have children. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
   failureTitle: '`<th>` elements and elements with ' +
       '`[role="columnheader"/"rowheader"]` do not have data cells they describe.',
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
       'table headers always refer to some set of cells may improve the experience for screen ' +
       'reader users. ' +
-      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.10/th-has-data-cells).',
+      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.11/th-has-data-cells).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/valid-lang.js

@@ -13,14 +13,14 @@ import AxeAudit from './axe-audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 
 const UIStrings = {
-  /** Title of an accesibility audit that evaluates if all lang HTML attributes are valid BCP 47 languages. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  /** Title of an accessibility audit that evaluates if all lang HTML attributes are valid BCP 47 languages. This title is descriptive of the successful state and is shown to users when no user action is required. */
   title: '`[lang]` attributes have a valid value',
-  /** Title of an accesibility audit that evaluates if all lang HTML attributes are valid BCP 47 languages. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  /** Title of an accessibility audit that evaluates if all lang HTML attributes are valid BCP 47 languages. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
   failureTitle: '`[lang]` attributes do not have a valid value',
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'Specifying a valid [BCP 47 language](https://www.w3.org/International/questions/qa-choosing-language-tags#question) ' +
       'on elements helps ensure that text is pronounced correctly by a screen reader. ' +
-      '[Learn how to use the `lang` attribute](https://dequeuniversity.com/rules/axe/4.10/valid-lang).',
+      '[Learn how to use the `lang` attribute](https://dequeuniversity.com/rules/axe/4.11/valid-lang).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/video-caption.js

@@ -13,15 +13,15 @@ import AxeAudit from './axe-audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 
 const UIStrings = {
-  /** Title of an accesibility audit that evaluates if all video elements contain a child track element that has captions describing their audio. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  /** Title of an accessibility audit that evaluates if all video elements contain a child track element that has captions describing their audio. This title is descriptive of the successful state and is shown to users when no user action is required. */
   title: '`<video>` elements contain a `<track>` element with `[kind="captions"]`',
-  /** Title of an accesibility audit that evaluates if all video elements contain a child track element that has captions describing their audio. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  /** Title of an accessibility audit that evaluates if all video elements contain a child track element that has captions describing their audio. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
   failureTitle: '`<video>` elements do not contain a `<track>` element ' +
       'with `[kind="captions"]`.',
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'When a video provides a caption it is easier for deaf and hearing impaired ' +
       'users to access its information. ' +
-      '[Learn more about video captions](https://dequeuniversity.com/rules/axe/4.10/video-caption).',
+      '[Learn more about video captions](https://dequeuniversity.com/rules/axe/4.11/video-caption).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/audit.d.ts

@@ -13,10 +13,6 @@ export type OpportunityOptions = {
     isEntityGrouped?: LH.Audit.Details.Opportunity["isEntityGrouped"] | undefined;
 };
 export class Audit {
-    /**
-     * @return {string}
-     */
-    static get DEFAULT_PASS(): string;
     /**
      * @return {LH.Audit.ScoreDisplayModes}
      */

package/core/audits/audit.js

@@ -8,8 +8,6 @@ import * as LH from '../../types/lh.js';
 import {isUnderTest} from '../lib/lh-env.js';
 import {Util} from '../../shared/util.js';
 
-const DEFAULT_PASS = 'defaultPass';
-
 /** @type {Record<keyof LH.Audit.ProductMetricSavings, number>} */
 const METRIC_SAVINGS_PRECISION = {
   FCP: 50,
@@ -45,14 +43,6 @@ const METRIC_SAVINGS_PRECISION = {
 const clampTo2Decimals = val => Math.round(val * 100) / 100;
 
 class Audit {
-  /**
-   * @return {string}
-   */
-  static get DEFAULT_PASS() {
-    // TODO(v13): remove.
-    return DEFAULT_PASS;
-  }
-
   /**
    * @return {LH.Audit.ScoreDisplayModes}
    */
@@ -494,7 +484,6 @@ class Audit {
 
       details: product.details,
       guidanceLevel: audit.meta.guidanceLevel,
-      replacesAudits: audit.meta.replacesAudits,
     };
   }
 
@@ -504,8 +493,8 @@ class Audit {
    * @returns {LH.Artifacts.MetricComputationDataInput}
    */
   static makeMetricComputationDataInput(artifacts, context) {
-    const trace = artifacts.Trace ?? artifacts.traces[Audit.DEFAULT_PASS];
-    const devtoolsLog = artifacts.DevtoolsLog ?? artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
+    const trace = artifacts.Trace;
+    const devtoolsLog = artifacts.DevtoolsLog;
     const gatherContext = artifacts.GatherContext;
     const {URL, SourceMaps} = artifacts;
     // eslint-disable-next-line max-len

package/core/audits/insights/cls-culprits-insight.js

@@ -38,7 +38,7 @@ class CLSCulpritsInsight extends Audit {
       description: insightStr_(InsightUIStrings.description),
       guidanceLevel: 3,
       requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
-      replacesAudits: ['layout-shifts', 'non-composited-animations', 'unsized-images'],
+      replacesAudits: ['layout-shifts'],
     };
   }
 

package/core/audits/insights/dom-size-insight.js

@@ -59,21 +59,21 @@ class DOMSizeInsight extends Audit {
           },
         },
         {
-          statistic: str_(UIStrings.maxChildren),
-          node: makeNodeItemForNodeId(artifacts.TraceElements, maxChildren.nodeId),
+          statistic: str_(UIStrings.maxDOMDepth),
+          node: makeNodeItemForNodeId(artifacts.TraceElements, maxDepth.nodeId),
           value: {
             type: 'numeric',
             granularity: 1,
-            value: maxChildren.numChildren,
+            value: maxDepth.depth,
           },
         },
         {
-          statistic: str_(UIStrings.maxDOMDepth),
-          node: makeNodeItemForNodeId(artifacts.TraceElements, maxDepth.nodeId),
+          statistic: str_(UIStrings.maxChildren),
+          node: makeNodeItemForNodeId(artifacts.TraceElements, maxChildren.nodeId),
           value: {
             type: 'numeric',
             granularity: 1,
-            value: maxDepth.depth,
+            value: maxChildren.numChildren,
           },
         },
       ];
@@ -85,7 +85,11 @@ class DOMSizeInsight extends Audit {
         maxChildren: maxChildren.numChildren,
         maxDepth: maxDepth.depth,
       };
-      return details;
+      return {
+        details,
+        numericValue: totalElements,
+        numericUnit: 'element',
+      };
     });
   }
 }

package/core/audits/insights/font-display-insight.js

@@ -46,7 +46,9 @@ class FontDisplayInsight extends Audit {
         url: font.request.args.data.url,
         wastedMs: font.wastedTime,
       }));
-      return Audit.makeTableDetails(headings, items);
+      const details = Audit.makeTableDetails(headings, items);
+      details.skipSumming = ['wastedMs'];
+      return details;
     });
   }
 }

package/core/audits/insights/image-delivery-insight.js

@@ -9,7 +9,7 @@ import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/ImageDeli
 
 import {Audit} from '../audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
-import {adaptInsightToAuditProduct} from './insight-audit.js';
+import {adaptInsightToAuditProduct, makeNodeItemForNodeId} from './insight-audit.js';
 import {TraceEngineResult} from '../../computed/trace-engine-result.js';
 
 // eslint-disable-next-line max-len
@@ -49,6 +49,7 @@ class ImageDeliveryInsight extends Audit {
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
         /* eslint-disable max-len */
+        {key: 'node', valueType: 'node', label: ''},
         {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL), subItemsHeading: {key: 'reason', valueType: 'text'}},
         {key: 'totalBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnResourceSize)},
         {key: 'wastedBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnWastedBytes), subItemsHeading: {key: 'wastedBytes', valueType: 'bytes'}},
@@ -57,6 +58,8 @@ class ImageDeliveryInsight extends Audit {
 
       /** @type {LH.Audit.Details.Table['items']} */
       const items = insight.optimizableImages.map(image => ({
+        node:
+          makeNodeItemForNodeId(artifacts.TraceElements, image.largestImagePaint.args.data.nodeId),
         url: image.request.args.data.url,
         totalBytes: image.request.args.data.decodedBodyLength,
         wastedBytes: image.byteSavings,

package/core/audits/insights/insight-audit.d.ts

@@ -1,23 +1,25 @@
 export type CreateDetailsExtras = {
     insights: import("@paulirish/trace_engine/models/trace/insights/types.js").InsightSet;
-    parsedTrace: LH.Artifacts.TraceEngineResult["parsedTrace"];
+    data: LH.Artifacts.TraceEngineResult["data"];
 };
 /**
  * @typedef CreateDetailsExtras
  * @property {import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet} insights
- * @property {LH.Artifacts.TraceEngineResult['parsedTrace']} parsedTrace
+ * @property {LH.Artifacts.TraceEngineResult['data']} data
  */
 /**
  * @param {LH.Artifacts} artifacts
  * @param {LH.Audit.Context} context
  * @param {T} insightName
- * @param {(insight: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightModels[T], extras: CreateDetailsExtras) => {details: LH.Audit.Details, warnings: Array<string | LH.IcuMessage>}|LH.Audit.Details|undefined} createDetails
+ * @param {(insight: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightModels[T], extras: CreateDetailsExtras) => {details: LH.Audit.Details, warnings?: Array<string | LH.IcuMessage>, numericValue?: number, numericUnit?: LH.Audit.NumericProduct['numericUnit']}|LH.Audit.Details|undefined} createDetails
  * @template {keyof import('@paulirish/trace_engine/models/trace/insights/types.js').InsightModelsType} T
  * @return {Promise<LH.Audit.Product>}
  */
 export function adaptInsightToAuditProduct<T extends keyof import("@paulirish/trace_engine/models/trace/insights/types.js").InsightModelsType>(artifacts: LH.Artifacts, context: LH.Audit.Context, insightName: T, createDetails: (insight: import("@paulirish/trace_engine/models/trace/insights/types.js").InsightModels[T], extras: CreateDetailsExtras) => {
     details: LH.Audit.Details;
-    warnings: Array<string | LH.IcuMessage>;
+    warnings?: Array<string | LH.IcuMessage>;
+    numericValue?: number;
+    numericUnit?: LH.Audit.NumericProduct["numericUnit"];
 } | LH.Audit.Details | undefined): Promise<LH.Audit.Product>;
 /**
  * @param {LH.Artifacts.TraceElement[]} traceElements

package/core/audits/insights/insight-audit.js

@@ -16,7 +16,7 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, {});
 /**
  * @param {LH.Artifacts} artifacts
  * @param {LH.Audit.Context} context
- * @return {Promise<{insights: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet|undefined, parsedTrace: LH.Artifacts.TraceEngineResult['parsedTrace']}>}
+ * @return {Promise<{insights: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet|undefined, data: LH.Artifacts.TraceEngineResult['data']}>}
  */
 async function getInsightSet(artifacts, context) {
   const settings = context.settings;
@@ -29,25 +29,25 @@ async function getInsightSet(artifacts, context) {
   const key = navigationId ?? NO_NAVIGATION;
   const insights = traceEngineResult.insights.get(key);
 
-  return {insights, parsedTrace: traceEngineResult.parsedTrace};
+  return {insights, data: traceEngineResult.data};
 }
 
 /**
  * @typedef CreateDetailsExtras
  * @property {import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet} insights
- * @property {LH.Artifacts.TraceEngineResult['parsedTrace']} parsedTrace
+ * @property {LH.Artifacts.TraceEngineResult['data']} data
  */
 
 /**
  * @param {LH.Artifacts} artifacts
  * @param {LH.Audit.Context} context
  * @param {T} insightName
- * @param {(insight: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightModels[T], extras: CreateDetailsExtras) => {details: LH.Audit.Details, warnings: Array<string | LH.IcuMessage>}|LH.Audit.Details|undefined} createDetails
+ * @param {(insight: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightModels[T], extras: CreateDetailsExtras) => {details: LH.Audit.Details, warnings?: Array<string | LH.IcuMessage>, numericValue?: number, numericUnit?: LH.Audit.NumericProduct['numericUnit']}|LH.Audit.Details|undefined} createDetails
  * @template {keyof import('@paulirish/trace_engine/models/trace/insights/types.js').InsightModelsType} T
  * @return {Promise<LH.Audit.Product>}
  */
 async function adaptInsightToAuditProduct(artifacts, context, insightName, createDetails) {
-  const {insights, parsedTrace} = await getInsightSet(artifacts, context);
+  const {data, insights} = await getInsightSet(artifacts, context);
   if (!insights) {
     return {
       scoreDisplayMode: Audit.SCORING_MODES.NOT_APPLICABLE,
@@ -65,16 +65,22 @@ async function adaptInsightToAuditProduct(artifacts, context, insightName, creat
   }
 
   const cbResult = createDetails(insight, {
-    parsedTrace,
+    data,
     insights,
   });
 
   const warnings = [...insight.warnings ?? []];
+  /** @type {number|undefined} */
+  let numericValue;
+  /** @type {LH.Audit.NumericProduct['numericUnit']|undefined} */
+  let numericUnit;
 
   let details;
-  if (cbResult && 'warnings' in cbResult) {
+  if (cbResult && 'details' in cbResult) {
     details = cbResult.details;
-    warnings.push(...cbResult.warnings);
+    if (cbResult.warnings) warnings.push(...cbResult.warnings);
+    numericValue = cbResult.numericValue;
+    numericUnit = cbResult.numericUnit;
   } else {
     details = cbResult;
   }
@@ -163,6 +169,19 @@ async function adaptInsightToAuditProduct(artifacts, context, insightName, creat
     scoreDisplayMode = Audit.SCORING_MODES.INFORMATIVE;
   }
 
+  if (numericValue !== undefined && numericUnit !== undefined) {
+    return {
+      scoreDisplayMode,
+      score,
+      numericValue,
+      numericUnit,
+      metricSavings,
+      warnings: warnings.length ? warnings : undefined,
+      displayValue,
+      details,
+    };
+  }
+
   return {
     scoreDisplayMode,
     score,

package/core/audits/insights/third-parties-insight.js

@@ -61,7 +61,7 @@ class ThirdPartiesInsight extends Audit {
    */
   static async audit(artifacts, context) {
     return adaptInsightToAuditProduct(artifacts, context, 'ThirdParties', (insight, extras) => {
-      const urlSummaries = summarizeByURL(extras.parsedTrace, extras.insights.bounds);
+      const urlSummaries = summarizeByURL(extras.data, extras.insights.bounds);
 
       const thirdPartySummaries = insight.entitySummaries
         .filter(summary => summary.entity !== insight.firstPartyEntity || null)

package/core/audits/layout-shifts.js

@@ -62,7 +62,7 @@ class LayoutShifts extends Audit {
     const SourceMaps = artifacts.SourceMaps;
     const traceEngineResult =
       await TraceEngineResult.request({trace, settings, SourceMaps}, context);
-    const clusters = traceEngineResult.parsedTrace.LayoutShifts.clusters ?? [];
+    const clusters = traceEngineResult.data.LayoutShifts.clusters ?? [];
     const {cumulativeLayoutShift: clsSavings, impactByNodeId} =
       await CumulativeLayoutShiftComputed.request(trace, context);
     const traceElements = artifacts.TraceElements

package/core/audits/predictive-perf.js

@@ -76,8 +76,8 @@ class PredictivePerf extends Audit {
       pessimisticLCP: lcp.pessimisticEstimate.timeInMs,
 
       roughEstimateOfTTFB: timingSummary.metrics.timeToFirstByte,
-      roughEstimateOfLCPLoadStart: timingSummary.metrics.lcpLoadStart,
-      roughEstimateOfLCPLoadEnd: timingSummary.metrics.lcpLoadEnd,
+      roughEstimateOfLCPLoadStart: timingSummary.metrics.lcpLoadDelay,
+      roughEstimateOfLCPLoadEnd: timingSummary.metrics.lcpLoadDuration,
     };
 
     const score = Audit.computeLogNormalScore(

package/core/audits/seo/crawlable-anchors.js

@@ -57,12 +57,10 @@ class CrawlableAnchors extends Audit {
       href,
       attributeNames = [],
       listeners = [],
-      ancestorListeners = [],
     }) => {
       rawHref = rawHref.replace( /\s/g, '');
       name = name.trim();
       role = role.trim();
-      const hasListener = Boolean(listeners.length || ancestorListeners.length);
 
       if (role.length > 0) return;
       // Ignore mailto links even if they use one of the failing patterns. See https://github.com/GoogleChrome/lighthouse/issues/11443#issuecomment-694898412
@@ -86,7 +84,8 @@ class CrawlableAnchors extends Audit {
         !attributeNames.includes('href') &&
         hrefAssociatedAttributes.every(attribute => !attributeNames.includes(attribute))
       ) {
-        return hasListener;
+        // If it has an even listener (e.g. onclick) then we can't assume it's a placeholder. Therefore we consider it failing.
+        return Boolean(listeners.length);
       }
 
       if (href === '') return true;

package/core/audits/seo/manual/structured-data.js

@@ -9,7 +9,7 @@ import * as i18n from '../../../lib/i18n/i18n.js';
 
 const UIStrings = {
   /** Description of a Lighthouse audit that provides detail on the structured data in a page. "Structured data" is a standardized data format on a page that helps a search engine categorize and understand its contents. This description is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
-  description: 'Run the [Structured Data Testing Tool](https://search.google.com/structured-data/testing-tool/) and the [Structured Data Linter](http://linter.structured-data.org/) to validate structured data. [Learn more about Structured Data](https://developer.chrome.com/docs/lighthouse/seo/structured-data/).',
+  description: 'Run the [Structured Data Testing Tool](https://developers.google.com/search/docs/appearance/structured-data/) to validate structured data. [Learn more about Structured Data](https://developer.chrome.com/docs/lighthouse/seo/structured-data/).',
   /** Title of a Lighthouse audit that prompts users to manually check their page for valid structured data. "Structured data" is a standardized data format on a page that helps a search engine categorize and understand its contents. */
   title: 'Structured data is valid',
 };

package/core/audits/server-response-time.d.ts

@@ -1,10 +1,5 @@
 export default ServerResponseTime;
 declare class ServerResponseTime extends Audit {
-    /**
-     * @param {LH.Artifacts.NetworkRequest} record
-     * @return {number|null}
-     */
-    static calculateResponseTime(record: LH.Artifacts.NetworkRequest): number | null;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/server-response-time.js

@@ -6,7 +6,7 @@
 
 import {Audit} from './audit.js';
 import * as i18n from '../lib/i18n/i18n.js';
-import {MainResource} from '../computed/main-resource.js';
+import {NavigationInsights} from '../computed/navigation-insights.js';
 
 const UIStrings = {
   /** Title of a diagnostic audit that provides detail on how long it took from starting a request to when the server started responding. This descriptive title is shown to users when the amount is acceptable and no user action is required. */
@@ -21,9 +21,6 @@ const UIStrings = {
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
-// Due to the way that DevTools throttling works we cannot see if server response took less than ~570ms.
-// We set our failure threshold to 600ms to avoid those false positives but we want devs to shoot for 100ms.
-const TOO_SLOW_THRESHOLD_MS = 600;
 const TARGET_MS = 100;
 
 class ServerResponseTime extends Audit {
@@ -38,41 +35,30 @@ class ServerResponseTime extends Audit {
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
       guidanceLevel: 1,
-      requiredArtifacts: ['DevtoolsLog', 'URL', 'GatherContext'],
+      requiredArtifacts: ['Trace', 'SourceMaps'],
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
     };
   }
 
-  /**
-   * @param {LH.Artifacts.NetworkRequest} record
-   * @return {number|null}
-   */
-  static calculateResponseTime(record) {
-    // Lightrider does not have timings for sendEnd, but we do have this timing which should be
-    // close to the response time.
-    if (global.isLightrider && record.lrStatistics) return record.lrStatistics.requestMs;
-
-    if (!record.timing) return null;
-    return record.timing.receiveHeadersStart - record.timing.sendEnd;
-  }
-
   /**
    * @param {LH.Artifacts} artifacts
    * @param {LH.Audit.Context} context
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const devtoolsLog = artifacts.DevtoolsLog;
-
-    /** @type {LH.Artifacts.NetworkRequest} */
-    const mainResource = await MainResource.request({devtoolsLog, URL: artifacts.URL}, context);
+    const settings = context.settings;
+    const trace = artifacts.Trace;
+    const SourceMaps = artifacts.SourceMaps;
+    const navInsights = await NavigationInsights.request({trace, settings, SourceMaps}, context);
+    const responseTime = navInsights.model.DocumentLatency.data?.serverResponseTime;
+    const url = navInsights.model.DocumentLatency.data?.documentRequest?.args.data.url;
 
-    const responseTime = ServerResponseTime.calculateResponseTime(mainResource);
-    if (responseTime === null) {
+    if (responseTime === undefined || !url) {
       throw new Error('no timing found for main resource');
     }
 
-    const passed = responseTime < TOO_SLOW_THRESHOLD_MS;
+    const passed =
+      Boolean(navInsights.model.DocumentLatency.data?.checklist.serverResponseIsFast.value);
     const displayValue = str_(UIStrings.displayValue, {timeInMs: responseTime});
 
     /** @type {LH.Audit.Details.Opportunity['headings']} */
@@ -84,7 +70,7 @@ class ServerResponseTime extends Audit {
     const overallSavingsMs = Math.max(responseTime - TARGET_MS, 0);
     const details = Audit.makeOpportunityDetails(
       headings,
-      [{url: mainResource.url, responseTime}],
+      [{url, responseTime}],
       {overallSavingsMs}
     );
 

package/core/computed/metrics/cumulative-layout-shift.js

@@ -162,10 +162,10 @@ class CumulativeLayoutShift {
       await processor.parse(/** @type {import('@paulirish/trace_engine').Types.Events.Event[]} */ (
         events
       ), {});
-      if (!processor.parsedTrace) {
+      if (!processor.data) {
         throw new Error('null trace engine result');
       }
-      return processor.parsedTrace.LayoutShifts.sessionMaxScore;
+      return processor.data.LayoutShifts.sessionMaxScore;
     };
     const cumulativeLayoutShift = await run(allFrameShiftEvents.map(e => e.event));
     const cumulativeLayoutShiftMainFrame = await run(mainFrameShiftEvents.map(e => e.event));

package/core/computed/metrics/lantern-metric.js

@@ -38,15 +38,15 @@ async function getComputationDataParamsFromTrace(data, context) {
 
   const graph = await PageDependencyGraph.request({...data, fromTrace: true}, context);
   const traceEngineResult = await TraceEngineResult.request(data, context);
-  const frameId = traceEngineResult.parsedTrace.Meta.mainFrameId;
+  const frameId = traceEngineResult.data.Meta.mainFrameId;
   const navigationId =
-    traceEngineResult.parsedTrace.Meta.mainFrameNavigations[0].args.data?.navigationId;
+    traceEngineResult.data.Meta.mainFrameNavigations[0].args.data?.navigationId;
   if (!navigationId) {
     throw new Error(`Lantern metrics could not be calculated due to missing navigation id`);
   }
 
   const processedNavigation = Lantern.TraceEngineComputationData.createProcessedNavigation(
-    traceEngineResult.parsedTrace, frameId, navigationId);
+    traceEngineResult.data, frameId, navigationId);
   const simulator = data.simulator || (await LoadSimulator.request(data, context));
 
   return {simulator, graph, processedNavigation};

package/core/computed/metrics/lcp-breakdown.d.ts

@@ -2,20 +2,25 @@ export { LCPBreakdownComputed as LCPBreakdown };
 declare const LCPBreakdownComputed: typeof LCPBreakdown & {
     request: (dependencies: import("../../index.js").Artifacts.MetricComputationDataInput, context: LH.Artifacts.ComputedContext) => Promise<{
         ttfb: number;
-        loadStart?: number;
-        loadEnd?: number;
+        loadDelay?: number;
+        loadDuration?: number;
+        renderDelay?: number;
     }>;
 };
+/**
+ * Note: this omits renderDelay for simulated throttling.
+ */
 declare class LCPBreakdown {
     /**
      * @param {LH.Artifacts.MetricComputationDataInput} data
      * @param {LH.Artifacts.ComputedContext} context
-     * @return {Promise<{ttfb: number, loadStart?: number, loadEnd?: number}>}
+     * @return {Promise<{ttfb: number, loadDelay?: number, loadDuration?: number, renderDelay?: number}>}
      */
     static compute_(data: LH.Artifacts.MetricComputationDataInput, context: LH.Artifacts.ComputedContext): Promise<{
         ttfb: number;
-        loadStart?: number;
-        loadEnd?: number;
+        loadDelay?: number;
+        loadDuration?: number;
+        renderDelay?: number;
     }>;
 }
 //# sourceMappingURL=lcp-breakdown.d.ts.map