lighthouse 12.8.2 → 13.0.0-dev.20251009

package/core/lib/deprecations-strings.js

@@ -1,6 +1,6 @@
 // auto-generated by build/build-cdt-strings.js
 /* eslint-disable */
-// Copyright 2025 The Chromium Authors. All rights reserved.
+// Copyright 2025 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -59,15 +59,15 @@ export const UIStrings = {
   /**
    * @description Warning displayed to developers when the Geolocation API is used from an insecure origin (one that isn't localhost or doesn't use HTTPS) to notify them that this use is no longer supported.
    */
-  GeolocationInsecureOrigin: "`getCurrentPosition()` and `watchPosition()` no longer work on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gle/chrome-insecure-origins for more details.",
+  GeolocationInsecureOrigin: "`getCurrentPosition()` and `watchPosition()` no longer work on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
   /**
    * @description Warning displayed to developers when the Geolocation API is used from an insecure origin (one that isn't localhost or doesn't use HTTPS) to notify them that this use is deprecated.
    */
-  GeolocationInsecureOriginDeprecatedNotRemoved: "`getCurrentPosition()` and `watchPosition()` are deprecated on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gle/chrome-insecure-origins for more details.",
+  GeolocationInsecureOriginDeprecatedNotRemoved: "`getCurrentPosition()` and `watchPosition()` are deprecated on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
   /**
    * @description This warning occurs when the `getUserMedia()` API is invoked on an insecure (e.g., HTTP) site. This is only permitted on secure sites (e.g., HTTPS).
    */
-  GetUserMediaInsecureOrigin: "`getUserMedia()` no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gle/chrome-insecure-origins for more details.",
+  GetUserMediaInsecureOrigin: "`getUserMedia()` no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
   /**
    * @description A deprecation warning shown to developers in the DevTools Issues tab when code tries to use the deprecated hostCandidate field, guiding developers to use the equivalent information in the .address and .port fields instead.
    */
@@ -107,7 +107,7 @@ export const UIStrings = {
   /**
    * @description Warning displayed to developers when the Notification API is used from an insecure origin (one that isn't localhost or doesn't use HTTPS) to notify them that this use is no longer supported.
    */
-  NotificationInsecureOrigin: "The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gle/chrome-insecure-origins for more details.",
+  NotificationInsecureOrigin: "The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
   /**
    * @description Warning displayed to developers when permission to use notifications has been requested by a cross-origin iframe, to notify them that this use is no longer supported.
    */

package/core/lib/emulation.d.ts

@@ -40,4 +40,14 @@ export function enableCPUThrottling(session: LH.Gatherer.ProtocolSession, thrott
  * @return {Promise<void>}
  */
 export function clearCPUThrottling(session: LH.Gatherer.ProtocolSession): Promise<void>;
+/**
+ * Tweak a useragent to have the milestone match the host's Chrome version.
+ * @param {LH.Gatherer.ProtocolSession} session
+ * @param {string} userAgent
+ * @returns {Promise<{tweakedUA: string, fullVersion: string}>}
+ */
+export function matchHostUAVersion(session: LH.Gatherer.ProtocolSession, userAgent: string): Promise<{
+    tweakedUA: string;
+    fullVersion: string;
+}>;
 //# sourceMappingURL=emulation.d.ts.map

package/core/lib/emulation.js

@@ -4,6 +4,8 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import {getBrowserVersion} from '../gather/driver/environment.js';
+
 const NO_THROTTLING_METRICS = {
   latency: 0,
   downloadThroughput: 0,
@@ -16,13 +18,11 @@ const NO_CPU_THROTTLE_METRICS = {
 };
 
 /**
- * @param {string} userAgent
+ * @param {string} fullVersion
  * @param {LH.Config.Settings['formFactor']} formFactor
  * @return {LH.Crdp.Emulation.SetUserAgentOverrideRequest['userAgentMetadata']}
  */
-function parseUseragentIntoMetadata(userAgent, formFactor) {
-  const match = userAgent.match(/Chrome\/([\d.]+)/); // eg 'Chrome/(71.0.3577.0)'
-  const fullVersion = match?.[1] || '99.0.1234.0';
+function parseUseragentIntoMetadata(fullVersion, formFactor) {
   const [version] = fullVersion.split('.', 1);
   const brands = [
     {brand: 'Chromium', version},
@@ -54,6 +54,19 @@ function parseUseragentIntoMetadata(userAgent, formFactor) {
   };
 }
 
+/**
+ * Tweak a useragent to have the milestone match the host's Chrome version.
+ * @param {LH.Gatherer.ProtocolSession} session
+ * @param {string} userAgent
+ * @returns {Promise<{tweakedUA: string, fullVersion: string}>}
+ */
+async function matchHostUAVersion(session, userAgent) {
+  const {milestone} = await getBrowserVersion(session);
+  const tweakedUA = userAgent.replace(/(Chrome\/)[\d.]+/, `$1${milestone}.0.0.0`);
+  const fullVersion = `${milestone}.0.0.0`;
+  return {tweakedUA, fullVersion};
+}
+
 /**
  * @param {LH.Gatherer.ProtocolSession} session
  * @param {LH.Config.Settings} settings
@@ -62,9 +75,10 @@ function parseUseragentIntoMetadata(userAgent, formFactor) {
 async function emulate(session, settings) {
   if (settings.emulatedUserAgent !== false) {
     const userAgent = /** @type {string} */ (settings.emulatedUserAgent);
+    const {tweakedUA, fullVersion} = await matchHostUAVersion(session, userAgent);
     await session.sendCommand('Network.setUserAgentOverride', {
-      userAgent,
-      userAgentMetadata: parseUseragentIntoMetadata(userAgent, settings.formFactor),
+      userAgent: tweakedUA,
+      userAgentMetadata: parseUseragentIntoMetadata(fullVersion, settings.formFactor),
     });
   }
   // See devtools-entry for one usecase for disabling screenEmulation
@@ -157,4 +171,5 @@ export {
   clearNetworkThrottling,
   enableCPUThrottling,
   clearCPUThrottling,
+  matchHostUAVersion,
 };

package/core/lib/legacy-javascript/legacy-javascript.js

@@ -15,21 +15,14 @@
 /** @typedef {{name: string, line: number, column: number}} PatternMatchResult */
 /** @typedef {{matches: PatternMatchResult[], estimatedByteSavings: number}} Result */
 
-import fs from 'fs';
-
-import {LH_ROOT} from '../../../shared/root.js';
-
-const polyfillModuleDataJson = fs.readFileSync(
-  `${LH_ROOT}/core/lib/legacy-javascript/polyfill-module-data.json`, 'utf-8');
+import polyfillModuleData_ from './polyfill-module-data.json' with { type: 'json' };
+import graph_ from './polyfill-graph-data.json' with { type: 'json' };
 
 /** @type {import('../../scripts/legacy-javascript/create-polyfill-module-data.js').PolyfillModuleData} */
-const polyfillModuleData = JSON.parse(polyfillModuleDataJson);
-
-const graphJson = fs.readFileSync(
-  `${LH_ROOT}/core/lib/legacy-javascript/polyfill-graph-data.json`, 'utf-8');
+const polyfillModuleData = polyfillModuleData_;
 
 /** @type {import('../../scripts/legacy-javascript/create-polyfill-size-estimation.js').PolyfillSizeEstimator} */
-const graph = JSON.parse(graphJson);
+const graph = graph_;
 
 /**
  * Takes a list of patterns (consisting of a name identifier and a RegExp expression string)

package/core/lib/network-request.d.ts

@@ -241,13 +241,6 @@ export class NetworkRequest {
      * LR loses protocol information.
      */
     _updateProtocolForLightrider(): void;
-    /**
-     * TODO(compat): remove M116.
-     * `timing.receiveHeadersStart` was added recently, and will be in M116. Until then,
-     * set it to receiveHeadersEnd, which is close enough, to allow consumers of NetworkRequest
-     * to use the new field without accounting for this backcompat.
-     */
-    _backfillReceiveHeaderStartTiming(): void;
     /**
      * LR gets additional, accurate timing information from its underlying fetch infrastructure.  This
      * is passed in via X-Headers similar to 'X-TotalFetchedSize'.

package/core/lib/network-request.js

@@ -286,7 +286,6 @@ class NetworkRequest {
     }
 
     this._updateResponseHeadersEndTimeIfNecessary();
-    this._backfillReceiveHeaderStartTiming();
     this._updateTransferSizeForLightrider();
     this._updateTimingsForLightrider();
   }
@@ -306,7 +305,6 @@ class NetworkRequest {
     this.localizedFailDescription = data.errorText;
 
     this._updateResponseHeadersEndTimeIfNecessary();
-    this._backfillReceiveHeaderStartTiming();
     this._updateTransferSizeForLightrider();
     this._updateTimingsForLightrider();
   }
@@ -329,7 +327,6 @@ class NetworkRequest {
     this.networkEndTime = data.timestamp * 1000;
 
     this._updateResponseHeadersEndTimeIfNecessary();
-    this._backfillReceiveHeaderStartTiming();
   }
 
   /**
@@ -463,19 +460,6 @@ class NetworkRequest {
     }
   }
 
-  /**
-   * TODO(compat): remove M116.
-   * `timing.receiveHeadersStart` was added recently, and will be in M116. Until then,
-   * set it to receiveHeadersEnd, which is close enough, to allow consumers of NetworkRequest
-   * to use the new field without accounting for this backcompat.
-   */
-  _backfillReceiveHeaderStartTiming() {
-    // Do nothing if a value is already present!
-    if (!this.timing || this.timing.receiveHeadersStart !== undefined) return;
-
-    this.timing.receiveHeadersStart = this.timing.receiveHeadersEnd;
-  }
-
   /**
    * LR gets additional, accurate timing information from its underlying fetch infrastructure.  This
    * is passed in via X-Headers similar to 'X-TotalFetchedSize'.

package/core/lib/proto-preprocessor.js

@@ -6,8 +6,6 @@
 
 import fs from 'fs';
 
-import esMain from 'es-main';
-
 /**
  * @fileoverview Helper functions to transform an LHR into a proto-ready LHR.
  *
@@ -24,29 +22,12 @@ function processForProto(lhr) {
   /** @type {LH.Result} */
   const reportJson = JSON.parse(JSON.stringify(lhr));
 
-  // Clean up the configSettings
-  // Note: This is not strictly required for conversion if protobuf parsing is set to
-  // 'ignore unknown fields' in the language of conversion.
+  // Drop these fields as we've omitted them from the proto for simplicity
   if (reportJson.configSettings) {
-    // The settings that are in both proto and LHR
-    const {
-      formFactor,
-      locale,
-      onlyCategories,
-      channel,
-      throttling,
-      screenEmulation,
-      throttlingMethod} = reportJson.configSettings;
-
-    // @ts-expect-error - intentionally only a subset of settings.
-    reportJson.configSettings = {
-      formFactor,
-      locale,
-      onlyCategories,
-      channel,
-      throttling,
-      screenEmulation,
-      throttlingMethod};
+    // @ts-expect-error Removing non-optional field.
+    delete reportJson.configSettings.auditMode;
+    // @ts-expect-error Removing non-optional field.
+    delete reportJson.configSettings.gatherMode;
   }
 
   // Remove runtimeError if it is NO_ERROR
@@ -126,7 +107,7 @@ function processForProto(lhr) {
 }
 
 // Test if called from the CLI or as a module.
-if (esMain(import.meta)) {
+if (import.meta.main) {
   // read in the argv for the input & output
   const args = process.argv.slice(2);
   let input;
@@ -143,6 +124,10 @@ if (esMain(import.meta)) {
     const report = processForProto(JSON.parse(fs.readFileSync(input, 'utf-8')));
     // write to output from argv
     fs.writeFileSync(output, JSON.stringify(report), 'utf-8');
+    // eslint-disable-next-line no-console
+    console.log(`file written to ${output}`);
+  } else {
+    process.exit(1);
   }
 }
 

package/core/runner.js

@@ -369,14 +369,7 @@ vs: ${JSON.stringify(normalizedAuditSettings[k], null, 2)}`);
       for (const artifactName of audit.meta.requiredArtifacts) {
         const noArtifact = artifacts[artifactName] === undefined;
 
-        // If trace/devtoolsLog required, check that DEFAULT_PASS trace/devtoolsLog exists.
-        // NOTE: for now, not a pass-specific check of traces or devtoolsLogs.
-        const noRequiredTrace = artifactName === 'traces' &&
-          !artifacts.traces?.[Audit.DEFAULT_PASS];
-        const noRequiredDevtoolsLog = artifactName === 'devtoolsLogs' &&
-          !artifacts.devtoolsLogs?.[Audit.DEFAULT_PASS];
-
-        if (noArtifact || noRequiredTrace || noRequiredDevtoolsLog) {
+        if (noArtifact) {
           log.warn('Runner',
               `${artifactName} gatherer, required by audit ${audit.meta.id}, did not run.`);
           throw new LighthouseError(

package/core/scoring.js

@@ -57,7 +57,7 @@ class ReportScoring {
         const member = {...configMember};
 
         // If a result was not applicable, meaning its checks did not run against anything on
-        // the page, force it's weight to 0. It will not count during the arithmeticMean() but
+        // the page, force its weight to 0. It will not count during the arithmeticMean() but
         // will still be included in the final report json and displayed in the report as
         // "Not Applicable".
         const result = resultsByAuditId[member.id];