lighthouse 12.8.1-dev.20250826 → 12.8.1-dev.20250827

package/cli/test/smokehouse/frontends/lib.js

@@ -10,8 +10,6 @@
  * Supports skipping and modifiying expectations to match the environment.
  */
 
-import {cloneDeep} from 'lodash-es';
-
 import smokeTests from '../core-tests.js';
 import {runSmokehouse, getShardedDefinitions} from '../smokehouse.js';
 
@@ -21,7 +19,7 @@ import {runSmokehouse, getShardedDefinitions} from '../smokehouse.js';
 async function smokehouse(options) {
   const {urlFilterRegex, skip, modify, shardArg, ...smokehouseOptions} = options;
 
-  const clonedTests = cloneDeep(smokeTests);
+  const clonedTests = structuredClone(smokeTests);
   const modifiedTests = [];
   for (const test of clonedTests) {
     if (urlFilterRegex && !test.expectations.lhr.requestedUrl.match(urlFilterRegex)) {

package/cli/test/smokehouse/frontends/smokehouse-bin.js

@@ -14,7 +14,6 @@ import path from 'path';
 import fs from 'fs';
 import url from 'url';
 
-import {cloneDeep} from 'lodash-es';
 import yargs from 'yargs';
 import * as yargsHelpers from 'yargs/helpers';
 import log from 'lighthouse-logger';
@@ -92,7 +91,7 @@ function getDefinitionsToRun(allTestDefns, requestedIds, excludedTests) {
 function pruneExpectedNetworkRequests(testDefns, takeNetworkRequestUrls) {
   const pruneNetworkRequests = !takeNetworkRequestUrls;
 
-  const clonedDefns = cloneDeep(testDefns);
+  const clonedDefns = structuredClone(testDefns);
   for (const {id, expectations, runSerially} of clonedDefns) {
     if (!runSerially && expectations.networkRequests) {
       throw new Error(`'${id}' must be set to 'runSerially: true' to assert 'networkRequests'`);

package/cli/test/smokehouse/report-assert.js

@@ -9,7 +9,6 @@
  * against the results actually collected from Lighthouse.
  */
 
-import {cloneDeep} from 'lodash-es';
 import log from 'lighthouse-logger';
 
 import {LocalConsole} from './lib/local-console.js';
@@ -317,7 +316,7 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) {
     delete obj._excludeRunner;
   }
 
-  const cloned = cloneDeep(expected);
+  const cloned = structuredClone(expected);
 
   pruneRecursively(cloned);
   return cloned;

package/core/audits/insights/image-delivery-insight.js

@@ -46,11 +46,6 @@ class ImageDeliveryInsight extends Audit {
    */
   static async audit(artifacts, context) {
     return adaptInsightToAuditProduct(artifacts, context, 'ImageDelivery', (insight) => {
-      if (!insight.optimizableImages.length) {
-        // TODO: show UIStrings.noOptimizableImages?
-        return;
-      }
-
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
         /* eslint-disable max-len */

package/core/audits/insights/insight-audit.js

@@ -79,7 +79,7 @@ async function adaptInsightToAuditProduct(artifacts, context, insightName, creat
     details = cbResult;
   }
 
-  if (!details || (details.type === 'table' && details.items.length === 0)) {
+  if (!details) {
     return {
       scoreDisplayMode: Audit.SCORING_MODES.NOT_APPLICABLE,
       score: null,
@@ -94,6 +94,17 @@ async function adaptInsightToAuditProduct(artifacts, context, insightName, creat
     details.debugData.wastedBytes = insight.wastedBytes;
   }
 
+  // TODO: FontDisplay insight (and maybe others) can return -Infinity savings when
+  // passing. That's weird. For now, just delete those.
+  if (insight.metricSavings) {
+    for (const [metric, value] of Object.entries(insight.metricSavings)) {
+      if (!Number.isFinite(value)) {
+        // @ts-expect-error
+        delete insight.metricSavings[metric];
+      }
+    }
+  }
+
   // This hack is to add metric adorners if an insight category links it to a metric,
   // but doesn't output a metric savings for that metric.
   let metricSavings = insight.metricSavings;