lighthouse 12.6.1-dev.20250611 → 12.6.1-dev.20250613

package/cli/test/smokehouse/frontends/lib.js

@@ -10,8 +10,6 @@
  * Supports skipping and modifiying expectations to match the environment.
  */
 
-/* eslint-disable no-console */
-
 import {cloneDeep} from 'lodash-es';
 
 import smokeTests from '../core-tests.js';

package/cli/test/smokehouse/frontends/smokehouse-bin.js

@@ -10,8 +10,6 @@
  * flags, start fixture webservers, then run smokehouse.
  */
 
-/* eslint-disable no-console */
-
 import path from 'path';
 import fs from 'fs';
 import url from 'url';
@@ -173,7 +171,7 @@ async function begin() {
       },
       'no-headless': {
         type: 'boolean',
-        describe: 'Launch Chrome in typical desktop headful mode, rather than our default of `--headless=new` (https://developer.chrome.com/articles/new-headless/).', // eslint-disable-line max-len
+        describe: 'Launch Chrome in typical desktop headful mode, rather than our default of `--headless=new` (https://developer.chrome.com/articles/new-headless/).',
       },
     })
     .wrap(y.terminalWidth())

package/cli/test/smokehouse/lighthouse-runners/cli.js

@@ -94,7 +94,7 @@ async function internalRun(url, tmpPath, config, logger, options) {
 
   try {
     await fs.access(outputPath);
-  } catch (e) {
+  } catch {
     throw new ChildProcessError(`Lighthouse run failed to produce a report.`, logger.getLog());
   }
 

package/cli/test/smokehouse/smokehouse.js

@@ -10,8 +10,6 @@
  * smoke tests passed.
  */
 
-/* eslint-disable no-console */
-
 /**
  * @typedef Run
  * @property {string[] | undefined} networkRequests

package/core/audits/byte-efficiency/legacy-javascript.js

@@ -25,7 +25,6 @@ import {detectLegacyJavaScript} from '../../lib/legacy-javascript/legacy-javascr
 const UIStrings = {
   /** Title of a Lighthouse audit that tells the user about legacy polyfills and transforms used on the page. This is displayed in a list of audit titles that Lighthouse generates. */
   title: 'Avoid serving legacy JavaScript to modern browsers',
-  // eslint-disable-next-line max-len
   // TODO: developer.chrome.com article. this codelab is good starting place: https://web.dev/articles/codelab-serve-modern-code
   /** Description of a Lighthouse audit that tells the user about old JavaScript that is no longer needed. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'Polyfills and transforms enable legacy browsers to use new JavaScript features. However, many aren\'t necessary for modern browsers. Consider modifying your JavaScript build process to not transpile [Baseline](https://web.dev/baseline) features, unless you know you must support legacy browsers. [Learn why most sites can deploy ES6+ code without transpiling](https://philipwalton.com/articles/the-state-of-es5-on-the-web/)',

package/core/audits/deprecations.js

@@ -13,7 +13,6 @@ import {JSBundles} from '../computed/js-bundles.js';
 import * as i18n from '../lib/i18n/i18n.js';
 import {getIssueDetailDescription} from '../lib/deprecation-description.js';
 
-/* eslint-disable max-len */
 const UIStrings = {
   /** Title of a Lighthouse audit that provides detail on the use of deprecated APIs. This descriptive title is shown to users when the page does not use deprecated APIs. */
   title: 'Avoids deprecated APIs',
@@ -32,7 +31,6 @@ const UIStrings = {
   /** Table column header for line of code (eg. 432) that is using a deprecated API. */
   columnLine: 'Line',
 };
-/* eslint-enable max-len */
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 

package/core/audits/insights/cls-culprits-insight.js

@@ -19,12 +19,10 @@ const MAX_LAYOUT_SHIFTS_PER_CLUSTER = 5;
 // eslint-disable-next-line max-len
 const insightStr_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/CLSCulprits.js', InsightUIStrings);
 
-/* eslint-disable max-len */
 const UIStrings = {
   /** Label for a column in a data table; entries in this column will be a number representing how large the layout shift was. */
   columnScore: 'Layout shift score',
 };
-/* eslint-enable max-len */
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 

package/core/audits/insights/modern-http-insight.js

@@ -37,10 +37,8 @@ class ModernHTTPInsight extends Audit {
     return adaptInsightToAuditProduct(artifacts, context, 'ModernHTTP', (insight) => {
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
-        /* eslint-disable max-len */
         {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
         {key: 'protocol', valueType: 'text', label: str_(UIStrings.protocol)},
-        /* eslint-enable max-len */
       ];
       /** @type {LH.Audit.Details.Table['items']} */
       const items =

package/core/audits/third-party-cookies.js

@@ -11,7 +11,6 @@
 import {Audit} from './audit.js';
 import * as i18n from '../lib/i18n/i18n.js';
 
-/* eslint-disable max-len */
 const UIStrings = {
   /** Title of a Lighthouse audit that provides detail on the use of third party cookies. This descriptive title is shown to users when the page does not use third party cookies. */
   title: 'Avoids third-party cookies',
@@ -25,7 +24,6 @@ const UIStrings = {
     other {# cookies found}
     }`,
 };
-/* eslint-enable max-len */
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 

package/core/audits/valid-source-maps.js

@@ -121,7 +121,6 @@ class ValidSourceMaps extends Audit {
 
     /** @type {LH.Audit.Details.TableColumnHeading[]} */
     const headings = [
-      /* eslint-disable max-len */
       {
         key: 'scriptUrl',
         valueType: 'url',
@@ -129,7 +128,6 @@ class ValidSourceMaps extends Audit {
         label: str_(i18n.UIStrings.columnURL),
       },
       {key: 'sourceMapUrl', valueType: 'url', label: str_(UIStrings.columnMapURL)},
-      /* eslint-enable max-len */
     ];
 
     results.sort((a, b) => {

package/core/computed/js-bundles.js

@@ -55,7 +55,6 @@ function computeGeneratedFileSizes(map, contentLength, content) {
     let mappingLength = 0;
     if (lastColNum !== undefined) {
       if (lastColNum > line.length) {
-        // eslint-disable-next-line max-len
         const errorMessage =
           `${map.url()} mapping for last column out of bounds: ${lineNum + 1}:${lastColNum}`;
         log.error('JSBundles', errorMessage);

package/core/computed/metrics/cumulative-layout-shift.js

@@ -159,7 +159,6 @@ class CumulativeLayoutShift {
         LayoutShifts: TraceEngine.TraceHandlers.LayoutShifts,
         Screenshots: TraceEngine.TraceHandlers.Screenshots,
       });
-      // eslint-disable-next-line max-len
       await processor.parse(/** @type {import('@paulirish/trace_engine').Types.Events.Event[]} */ (
         events
       ), {});
@@ -212,6 +211,7 @@ class CumulativeLayoutShift {
           throw new Error(`new trace engine differed. expected: ${expected}, got: ${got}`);
         }
       } catch (err) {
+        // eslint-disable-next-line no-console
         console.error(err);
         newEngineResultDiffered = true;
 

package/core/computed/trace-engine-result.js

@@ -34,7 +34,6 @@ class TraceEngineResult {
       lanternSettings.precomputedLanternData = settings.precomputedLanternData;
     }
 
-    // eslint-disable-next-line max-len
     await processor.parse(/** @type {import('@paulirish/trace_engine').Types.Events.Event[]} */ (
       traceEvents
     ), {

package/core/config/config.js

@@ -10,7 +10,7 @@ import log from 'lighthouse-logger';
 
 import {Runner} from '../runner.js';
 import defaultConfig from './default-config.js';
-import {nonSimulatedSettingsOverrides} from './constants.js'; // eslint-disable-line max-len
+import {nonSimulatedSettingsOverrides} from './constants.js';
 import {
   throwInvalidDependencyOrder,
   isValidArtifactDependency,

package/core/gather/driver/navigation.js

@@ -6,7 +6,7 @@
 
 import log from 'lighthouse-logger';
 
-import {waitForFullyLoaded, waitForFrameNavigated, waitForUserToContinue} from './wait-for-condition.js'; // eslint-disable-line max-len
+import {waitForFullyLoaded, waitForFrameNavigated, waitForUserToContinue} from './wait-for-condition.js';
 import * as constants from '../../config/constants.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 import UrlUtils from '../../lib/url-utils.js';
@@ -43,7 +43,6 @@ const DEFAULT_CPU_QUIET_THRESHOLD = 0;
 
 /** @param {NavigationOptions} options */
 function resolveWaitForFullyLoadedOptions(options) {
-  /* eslint-disable max-len */
   let {pauseAfterFcpMs, pauseAfterLoadMs, networkQuietThresholdMs, cpuQuietThresholdMs} = options;
   let maxWaitMs = options.maxWaitForLoad;
   let maxFCPMs = options.maxWaitForFcp;
@@ -56,7 +55,6 @@ function resolveWaitForFullyLoadedOptions(options) {
   if (typeof cpuQuietThresholdMs !== 'number') cpuQuietThresholdMs = DEFAULT_CPU_QUIET_THRESHOLD;
   if (typeof maxWaitMs !== 'number') maxWaitMs = constants.defaultSettings.maxWaitForLoad;
   if (typeof maxFCPMs !== 'number') maxFCPMs = constants.defaultSettings.maxWaitForFcp;
-  /* eslint-enable max-len */
 
   if (!options.waitUntil.includes('fcp')) maxFCPMs = undefined;
 

package/core/gather/driver/wait-for-condition.js

@@ -138,7 +138,6 @@ function waitForNetworkIdle(session, networkMonitor, networkQuietOptions) {
   /** @type {Promise<void>} */
   const promise = new Promise((resolve, reject) => {
     const onIdle = () => {
-      // eslint-disable-next-line no-use-before-define
       networkMonitor.once(busyEvent, onBusy);
       idleTimeout = setTimeout(() => {
         cancel();

package/core/gather/fetcher.js

@@ -10,8 +10,6 @@ import * as LH from '../../types/lh.js';
  * ignoring normal browser constraints such as CORS.
  */
 
-/* global fetch */
-
 /** @typedef {{content: string|null, status: number|null}} FetchResponse */
 
 class Fetcher {

package/core/gather/gatherers/accessibility.js

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/* global window, document, getNodeDetails */
+/* global getNodeDetails */
 
 import BaseGatherer from '../base-gatherer.js';
 import {axeSource} from '../../lib/axe.js';

package/core/gather/gatherers/anchor-elements.js

@@ -10,8 +10,6 @@ import BaseGatherer from '../base-gatherer.js';
 import {pageFunctions} from '../../lib/page-functions.js';
 import {resolveDevtoolsNodePathToObjectId} from '../driver/dom.js';
 
-/* eslint-env browser, node */
-
 /**
  * Function that is stringified and run in the page to collect anchor elements.
  * Additional complexity is introduced because anchors can be HTML or SVG elements.

package/core/gather/gatherers/cache-contents.js

@@ -4,8 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/* global caches */
-
 import BaseGatherer from '../base-gatherer.js';
 
 /**

package/core/gather/gatherers/css-usage.js

@@ -30,7 +30,6 @@ class CSSUsage extends BaseGatherer {
 
     // Force style to recompute.
     // Doesn't appear to be necessary in newer versions of Chrome.
-    /* global window, document */
     await executionContext.evaluate(() => window.getComputedStyle(document.body), {
       args: [],
     });

package/core/gather/gatherers/dobetterweb/doctype.js

@@ -6,8 +6,6 @@
 
 import BaseGatherer from '../../base-gatherer.js';
 
-/* global document */
-
 /**
  * Get and return `name`, `publicId`, `systemId` from
  * `document.doctype`

package/core/gather/gatherers/dobetterweb/domstats.js

@@ -9,7 +9,7 @@
  * and total number of elements used on the page.
  */
 
-/* global getNodeDetails document */
+/* global getNodeDetails */
 
 
 import BaseGatherer from '../../base-gatherer.js';

package/core/gather/gatherers/full-page-screenshot.js

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/* globals window getBoundingClientRect requestAnimationFrame */
+/* globals getBoundingClientRect */
 
 import BaseGatherer from '../base-gatherer.js';
 import * as emulation from '../../lib/emulation.js';

package/core/gather/gatherers/image-elements.js

@@ -15,7 +15,7 @@ import BaseGatherer from '../base-gatherer.js';
 import {pageFunctions} from '../../lib/page-functions.js';
 import * as FontSize from './seo/font-size.js';
 
-/* global window, getElementsInDocument, Image, getNodeDetails, ShadowRoot */
+/* global getElementsInDocument, getNodeDetails */
 
 /** @param {Element} element */
 /* c8 ignore start */

package/core/gather/gatherers/link-elements.js

@@ -13,7 +13,7 @@ import {MainResource} from '../../computed/main-resource.js';
 import {Util} from '../../../shared/util.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 
-/* globals HTMLLinkElement getNodeDetails */
+/* globals getNodeDetails */
 
 /**
  * @fileoverview

package/core/gather/gatherers/stacks.js

@@ -8,7 +8,6 @@
  * @fileoverview Gathers a list of detected JS libraries and their versions.
  */
 
-/* global window */
 /* global d41d8cd98f00b204e9800998ecf8427e_LibraryDetectorTests */
 
 import fs from 'fs';

package/core/gather/gatherers/stylesheets.js

@@ -74,7 +74,6 @@ class Stylesheets extends BaseGatherer {
 
     // Force style to recompute.
     // Doesn't appear to be necessary in newer versions of Chrome.
-    /* global window, document */
     await executionContext.evaluate(() => window.getComputedStyle(document.body), {
       args: [],
     });

package/core/gather/gatherers/trace-elements.js

@@ -35,7 +35,7 @@ const MAX_LAYOUT_SHIFTS = 15;
  */
 /* c8 ignore start */
 function getNodeDetailsData() {
-  const elem = this.nodeType === document.ELEMENT_NODE ? this : this.parentElement; // eslint-disable-line no-undef
+  const elem = this.nodeType === document.ELEMENT_NODE ? this : this.parentElement;
   let traceElement;
   if (elem) {
     // @ts-expect-error - getNodeDetails put into scope via stringification

package/core/gather/gatherers/viewport-dimensions.js

@@ -6,8 +6,6 @@
 
 import BaseGatherer from '../base-gatherer.js';
 
-/* global window */
-
 /**
  * @return {LH.Artifacts.ViewportDimensions}
  */

package/core/index.cjs

@@ -3,7 +3,6 @@
  * Copyright 2022 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
 
 /**
  * @typedef ExportType

package/core/index.d.cts

@@ -1,4 +1,9 @@
 export = lighthouse;
+/**
+ * @license
+ * Copyright 2022 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
 /**
  * @typedef ExportType
  * @property {import('./index.js')['startFlow']} startFlow

package/core/lib/i18n/i18n.js

@@ -17,7 +17,6 @@ import {LH_ROOT} from '../../../shared/root.js';
 import {isIcuMessage, formatMessage, DEFAULT_LOCALE} from '../../../shared/localization/format.js';
 import {getModulePath} from '../../../shared/esm-utils.js';
 
-/* eslint-disable max-len */
 const UIStrings = {
   /** Used to show the duration in milliseconds that something lasted. The `{timeInMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 63 ms) */
   ms: '{timeInMs, number, milliseconds}\xa0ms',
@@ -114,7 +113,6 @@ const UIStrings = {
   /** Table item value for the severity of a high impact, or dangerous vulnerability. Part of a ranking scale in the form: low, medium, high. */
   itemSeverityHigh: 'High',
 };
-/* eslint-enable max-len */
 
 /**
  * Look up the best available locale for the requested language through these fall backs:

package/core/lib/lantern-trace-saver.js

@@ -153,7 +153,7 @@ function convertNodeTimingsToTrace(nodeTimings) {
 
     // 0ms requests get super-messed up rendering
     // Use 0.3ms instead so they're still hoverable, https://github.com/GoogleChrome/lighthouse/pull/5350#discussion_r194563201
-    let {startTime, endTime} = timing; // eslint-disable-line prefer-const
+    let {startTime, endTime} = timing;
     if (startTime === endTime) endTime += 0.3;
 
     const requestData = {requestId: requestId.toString(), frame};

package/core/lib/lh-error.js

@@ -214,7 +214,6 @@ class LighthouseError extends Error {
     if (typeof possibleError === 'object' && possibleError !== null) {
       if (possibleError.sentinel === LHERROR_SENTINEL) {
         // Include sentinel in destructuring so it doesn't end up in `properties`.
-        // eslint-disable-next-line no-unused-vars
         const {code, stack, cause, properties} = /** @type {SerializedLighthouseError} */ (possibleError);
         const errorDefinition = LighthouseError.errors[/** @type {keyof typeof ERRORS} */ (code)];
         const lhError = new LighthouseError(errorDefinition, properties, {cause});

package/core/lib/manifest-parser.js

@@ -458,7 +458,6 @@ function parseManifest(string, manifestUrl, documentUrl) {
     };
   }
 
-  /* eslint-disable camelcase */
   const manifest = {
     name: parseName(jsonInput),
     short_name: parseShortName(jsonInput),
@@ -471,7 +470,6 @@ function parseManifest(string, manifestUrl, documentUrl) {
     theme_color: parseThemeColor(jsonInput),
     background_color: parseBackgroundColor(jsonInput),
   };
-  /* eslint-enable camelcase */
 
   /** @type {string|undefined} */
   let manifestUrlWarning;

package/core/lib/minify-devtoolslog.js

@@ -4,8 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/* eslint-disable no-console */
-
 /**
  * @fileoverview Minifies a devtools log by removing noisy header values, eliminating data URIs, etc.
  */

package/core/lib/sentry.d.ts

@@ -17,7 +17,7 @@ export namespace Sentry {
 export type Breadcrumb = import("@sentry/node").Breadcrumb;
 export type NodeClient = import("@sentry/node").NodeClient;
 export type NodeOptions = import("@sentry/node").NodeOptions;
-export type Severity = import("@sentry/node").Severity;
+export type SeverityLevel = import("@sentry/node").SeverityLevel;
 /**
  * When called, replaces noops with actual Sentry implementation.
  * @param {{url: string, flags: LH.CliFlags, config?: LH.Config, environmentData: NodeOptions}} opts

package/core/lib/sentry.js

@@ -11,7 +11,7 @@ import {initializeConfig} from '../config/config.js';
 /** @typedef {import('@sentry/node').Breadcrumb} Breadcrumb */
 /** @typedef {import('@sentry/node').NodeClient} NodeClient */
 /** @typedef {import('@sentry/node').NodeOptions} NodeOptions */
-/** @typedef {import('@sentry/node').Severity} Severity */
+/** @typedef {import('@sentry/node').SeverityLevel} SeverityLevel */
 
 const SENTRY_URL = 'https://a6bb0da87ee048cc9ae2a345fc09ab2e:63a7029f46f74265981b7e005e0f69f8@sentry.io/174697';
 
@@ -26,7 +26,7 @@ const noop = () => { };
  */
 const sentryDelegate = {
   init,
-  /** @type {(message: string, level?: Severity) => void} */
+  /** @type {(message: string, level?: SeverityLevel) => void} */
   captureMessage: noop,
   /** @type {(breadcrumb: Breadcrumb) => void} */
   captureBreadcrumb: noop,

package/core/runner.js

@@ -458,7 +458,6 @@ vs: ${JSON.stringify(normalizedAuditSettings[k], null, 2)}`);
     for (const [artifactKey, possibleErrorArtifact] of possibleErrorArtifacts) {
       const isError = possibleErrorArtifact instanceof LighthouseError;
 
-      // eslint-disable-next-line max-len
       if (isError && possibleErrorArtifact.lhrRuntimeError) {
         const errorMessage = possibleErrorArtifact.friendlyMessage || possibleErrorArtifact.message;
         // Prefer the stack trace closest to the error.

package/core/scripts/manual-chrome-launcher.js

@@ -46,5 +46,4 @@ launch({
   ignoreDefaultFlags,
   chromeFlags,
 })
-// eslint-disable-next-line no-console
 .then(v => console.log(`✨  Chrome debugging port: ${v.port}`));

package/eslint.config.mjs

@@ -0,0 +1,242 @@
+import path from 'node:path';
+import {fileURLToPath} from 'node:url';
+
+import localRules from 'eslint-plugin-local-rules';
+import _import from 'eslint-plugin-import';
+import {fixupPluginRules} from '@eslint/compat';
+import globals from 'globals';
+import tsParser from '@typescript-eslint/parser';
+import js from '@eslint/js';
+import {FlatCompat} from '@eslint/eslintrc';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+// See https://eslint.org/docs/latest/use/configure/configuration-files
+export default [{
+  files: [
+    '**/*.cjs',
+    '**/*.js',
+    '**/*.mjs',
+    '**/*.ts',
+    '**/*.tsx',
+  ],
+}, {
+  // Global ignores.
+  ignores: [
+    '.cz-config.js',
+    '**/.tmp',
+    '**/*.d.cts', // ignore d.ts files until we can properly lint them
+    '**/*.d.ts',
+    '**/dist',
+    '**/fixtures/**',
+    '**/node_modules/**',
+    '**/source-maps/**',
+    '**/third_party/**',
+    '**/third-party/**',
+    'build/test/page-functions-test-case*out*.js',
+    'core/scripts/legacy-javascript/variants/**',
+    'coverage/**',
+  ],
+}, ...compat.extends('eslint:recommended', 'google'), {
+  plugins: {
+    'local-rules': localRules,
+    'import': fixupPluginRules(_import),
+  },
+
+  languageOptions: {
+    globals: {
+      ...globals.node,
+    },
+
+    parser: tsParser,
+    ecmaVersion: 2020,
+    sourceType: 'module',
+
+    parserOptions: {
+      ecmaFeatures: {
+        globalReturn: true,
+        jsx: false,
+      },
+    },
+  },
+
+  rules: {
+    'import/order': [2, {
+      'groups': ['builtin', 'external', ['sibling', 'parent'], 'index', 'object', 'type'],
+      'newlines-between': 'always',
+    }],
+
+    'import/group-exports': 2,
+    'import/exports-last': 2,
+    'eqeqeq': 2,
+    'no-console': 2,
+
+    'indent': [2, 2, {
+      SwitchCase: 1,
+      VariableDeclarator: 2,
+
+      CallExpression: {
+        arguments: 'off',
+      },
+
+      MemberExpression: 'off',
+
+      FunctionExpression: {
+        body: 1,
+        parameters: 2,
+      },
+
+      ignoredNodes: [
+        'ConditionalExpression > :matches(.consequent, .alternate)',
+        'VariableDeclarator > ArrowFunctionExpression > :expression.body',
+        'CallExpression > ArrowFunctionExpression > :expression.body',
+      ],
+    }],
+
+    'no-floating-decimal': 2,
+
+    'max-len': [2, 100, {
+      ignorePattern: 'readJson\\(|^import ',
+      ignoreComments: true,
+      ignoreUrls: true,
+      tabWidth: 2,
+    }],
+
+    'no-empty': [2, {
+      allowEmptyCatch: true,
+    }],
+
+    'no-implicit-coercion': [2, {
+      boolean: false,
+      number: true,
+      string: true,
+    }],
+
+    'no-unused-expressions': [2, {
+      allowShortCircuit: true,
+      allowTernary: false,
+    }],
+
+    'no-unused-vars': [2, {
+      vars: 'all',
+      args: 'after-used',
+      caughtErrors: 'none', // TODO: remove for new "all" default.
+      argsIgnorePattern: '(^reject$|^_+$)',
+      varsIgnorePattern: '(^_$|^LH$|^Lantern$|^TraceEngine$|^Protocol$)',
+    }],
+
+    'no-cond-assign': 2,
+    'space-infix-ops': 2,
+    'strict': [2, 'global'],
+    'prefer-const': 2,
+    'curly': [2, 'multi-line'],
+
+    'comma-dangle': [2, {
+      arrays: 'always-multiline',
+      objects: 'always-multiline',
+      imports: 'always-multiline',
+      exports: 'always-multiline',
+      functions: 'never',
+    }],
+
+    'operator-linebreak': ['error', 'after', {
+      overrides: {
+        '?': 'ignore',
+        ':': 'ignore',
+      },
+    }],
+
+    'local-rules/require-file-extension': 2,
+    'require-jsdoc': 0,
+    'valid-jsdoc': 0,
+    'arrow-parens': 0,
+  },
+}, {
+  files: ['cli/test/smokehouse/test-definitions/**'],
+
+  rules: {
+    'max-len': 0,
+  },
+}, {
+  files: [
+    '**/build/**',
+    '**/scripts/**',
+    '**/test/**',
+  ],
+
+  rules: {
+    'no-console': 0,
+  },
+}, {
+  files: [
+    'docs/recipes/auth/**',
+  ],
+
+  rules: {
+    'new-cap': 0,
+    'no-console': 0,
+    'no-unused-vars': 0,
+  },
+}, {
+  files: [
+    '**/test/**',
+    'docs/recipes/**',
+  ],
+
+  languageOptions: {
+    globals: {
+      ...globals.jest,
+      ...globals.mocha,
+    },
+  },
+}, {
+  files: [
+    'clients/**',
+    'core/gather/gatherers/**',
+    'docs/recipes/auth/**',
+    'flow-report/**',
+    'report/**',
+    'treemap/**',
+    'viewer/**',
+  ],
+  ignores: [
+    'report/generator/**',
+    'report/test/generator/**',
+  ],
+
+  languageOptions: {
+    globals: {
+      ...globals.browser,
+    },
+  },
+}, {
+  files: [
+    'clients/**',
+  ],
+
+  languageOptions: {
+    globals: {
+      chrome: true,
+      __lighthouse: true,
+    },
+  },
+}, {
+  files: ['flow-report/**'],
+
+  languageOptions: {
+    globals: {
+      ...globals.browser,
+      ...globals.node,
+    },
+  },
+
+  rules: {
+    'no-undef': 'off',
+  },
+}];

package/flow-report/src/common.tsx

@@ -88,6 +88,7 @@ const FlowStepThumbnail: FunctionComponent<{
   }
 
   if (!width || !height) {
+    // eslint-disable-next-line no-console
     console.warn(new Error('FlowStepThumbnail requested without any dimensions').stack);
     return <></>;
   }

package/flow-report/src/i18n/i18n.tsx

@@ -26,6 +26,7 @@ function useLhrLocale() {
   const locale = firstLhr.configSettings.locale;
 
   if (flowResult.steps.some(step => step.lhr.configSettings.locale !== locale)) {
+    // eslint-disable-next-line no-console
     console.warn('LHRs have inconsistent locales');
   }
 

package/flow-report/src/util.ts

@@ -97,12 +97,14 @@ function useHashState(): LH.HashState|null {
 
     const index = Number(indexString);
     if (!Number.isFinite(index)) {
+      // eslint-disable-next-line no-console
       console.warn(`Invalid hash index: ${indexString}`);
       return null;
     }
 
     const step = flowResult.steps[index];
     if (!step) {
+      // eslint-disable-next-line no-console
       console.warn(`No flow step at index ${index}`);
       return null;
     }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.6.1-dev.20250611",
+  "version": "12.6.1-dev.20250613",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -105,6 +105,9 @@
     "@build-tracker/cli": "^1.0.0-beta.15",
     "@esbuild-kit/esm-loader": "^2.1.1",
     "@esbuild-plugins/node-modules-polyfill": "^0.1.4",
+    "@eslint/compat": "^1.3.0",
+    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/js": "^9.28.0",
     "@formatjs/icu-messageformat-parser": "^2.6.2",
     "@jest/fake-timers": "^29.7.0",
     "@testing-library/preact": "^3.1.1",
@@ -114,7 +117,7 @@
     "@types/configstore": "^6.0.2",
     "@types/cpy": "^5.1.0",
     "@types/debug": "^4.1.7",
-    "@types/eslint": "^8.2.1",
+    "@types/eslint": "^9.6.1",
     "@types/estree": "^0.0.50",
     "@types/gh-pages": "^2.0.0",
     "@types/google.analytics": "0.0.39",
@@ -131,8 +134,8 @@
     "@types/ws": "^7.0.0",
     "@types/yargs": "^17.0.8",
     "@types/yargs-parser": "^20.2.1",
-    "@typescript-eslint/eslint-plugin": "^5.48.0",
-    "@typescript-eslint/parser": "^5.48.0",
+    "@typescript-eslint/eslint-plugin": "^8.34.0",
+    "@typescript-eslint/parser": "^8.34.0",
     "acorn": "^8.5.0",
     "angular": "^1.7.4",
     "archiver": "^3.0.0",
@@ -149,7 +152,7 @@
     "csv-validator": "^0.0.3",
     "es-main": "^1.2.0",
     "esbuild": "0.19.11",
-    "eslint": "^8.4.1",
+    "eslint": "^9.28.0",
     "eslint-config-google": "^0.14.0",
     "eslint-formatter-codeframe": "^7.32.1",
     "eslint-plugin-import": "^2.25.3",
@@ -159,6 +162,7 @@
     "firebase": "^9.0.2",
     "gh-pages": "^2.0.1",
     "glob": "^7.1.3",
+    "globals": "^15.14.0",
     "idb-keyval": "2.2.0",
     "jest-mock": "^29.7.0",
     "jest-snapshot": "^29.7.0",
@@ -186,7 +190,7 @@
   },
   "dependencies": {
     "@paulirish/trace_engine": "0.0.53",
-    "@sentry/node": "^7.0.0",
+    "@sentry/node": "^9.28.1",
     "axe-core": "^4.10.3",
     "chrome-launcher": "^1.2.0",
     "configstore": "^7.0.0",

package/report/generator/file-namer.d.ts

@@ -7,6 +7,11 @@ export function getLhrFilenamePrefix(lhr: {
     finalDisplayedUrl: string;
     fetchTime: string;
 }): string;
+/**
+ * @license
+ * Copyright 2017 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
 /**
  * @fileoverview
  * @suppress {reportUnknownTypes}

package/report/generator/file-namer.js

@@ -3,7 +3,7 @@
  * Copyright 2017 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 /**
  * @fileoverview

package/report/generator/flow-report-assets.js

@@ -3,7 +3,7 @@
  * Copyright 2021 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 import fs from 'fs';
 

package/report/generator/report-assets.js

@@ -3,7 +3,7 @@
  * Copyright 2018 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 import fs from 'fs';
 

package/report/generator/report-generator.js

@@ -3,7 +3,7 @@
  * Copyright 2017 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 import {reportAssets} from './report-assets.js';
 
@@ -69,11 +69,11 @@ class ReportGenerator {
     // we want to generate a report without minification.
     const sanitizedJavascript = reportAssets.FLOW_REPORT_JAVASCRIPT.replace(/<\//g, '\\u003c/');
     return ReportGenerator.replaceStrings(reportAssets.FLOW_REPORT_TEMPLATE, [
-      /* eslint-disable max-len */
+
       {search: '%%LIGHTHOUSE_FLOW_JSON%%', replacement: sanitizedJson},
       {search: '%%LIGHTHOUSE_FLOW_JAVASCRIPT%%', replacement: sanitizedJavascript},
       {search: '/*%%LIGHTHOUSE_FLOW_CSS%%*/', replacement: reportAssets.FLOW_REPORT_CSS},
-      /* eslint-enable max-len */
+
     ]);
   }
 

package/report/renderer/i18n-formatter.js

@@ -31,6 +31,7 @@ export class I18nFormatter {
     if (granularity !== undefined) {
       const log10 = -Math.log10(granularity);
       if (!Number.isInteger(log10)) {
+        // eslint-disable-next-line no-console
         console.warn(`granularity of ${granularity} is invalid. Using 1 instead`);
         granularity = 1;
       }
@@ -50,7 +51,7 @@ export class I18nFormatter {
     }
 
     let formatter;
-    // eslint-disable-next-line max-len
+
     const cacheKey = [
       opts.minimumFractionDigits,
       opts.maximumFractionDigits,

package/report/renderer/report-renderer.js

@@ -37,6 +37,7 @@ export class ReportRenderer {
   renderReport(lhr, rootEl, opts) {
     // Allow legacy report rendering API
     if (!this._dom.rootEl && rootEl) {
+      // eslint-disable-next-line no-console
       console.warn('Please adopt the new report API in renderer/api.js.');
       const closestRoot = rootEl.closest('.lh-root');
       if (closestRoot) {

package/report/renderer/report-utils.js

@@ -159,6 +159,7 @@ class ReportUtils {
         const aVal = a[key];
         const bVal = b[key];
         if (typeof aVal !== typeof bVal || !['number', 'string'].includes(typeof aVal)) {
+          // eslint-disable-next-line no-console
           console.warn(`Warning: Attempting to sort unsupported value type: ${key}.`);
         }
         if (typeof aVal === 'number' && typeof bVal === 'number' && aVal !== bVal) {
@@ -191,7 +192,7 @@ class ReportUtils {
         break;
       case 'devtools': {
         const {cpuSlowdownMultiplier, requestLatencyMs} = throttling;
-        // eslint-disable-next-line max-len
+
         cpuThrottling = `${i18n.formatNumber(cpuSlowdownMultiplier)}x slowdown (DevTools)`;
         networkThrottling = `${i18n.formatMilliseconds(requestLatencyMs)} HTTP RTT, ` +
           `${i18n.formatKbps(throttling.downloadThroughputKbps)} down, ` +
@@ -207,7 +208,7 @@ class ReportUtils {
       }
       case 'simulate': {
         const {cpuSlowdownMultiplier, rttMs, throughputKbps} = throttling;
-        // eslint-disable-next-line max-len
+
         cpuThrottling = `${i18n.formatNumber(cpuSlowdownMultiplier)}x slowdown (Simulated)`;
         networkThrottling = `${i18n.formatMilliseconds(rttMs)} TCP RTT, ` +
           `${i18n.formatKbps(throughputKbps)} throughput (Simulated)`;

package/report/renderer/text-encoding.js

@@ -4,8 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/* global CompressionStream */
-
 const btoa_ = typeof btoa !== 'undefined' ?
   btoa :
   /** @param {string} str */