lighthouse 12.6.1-dev.20250610 → 12.6.1-dev.20250611

package/core/audits/audit.js

@@ -164,7 +164,7 @@ class Audit {
     if (results.length === 0) {
       return {
         type: 'table',
-        headings: [],
+        headings,
         items: [],
         summary,
       };
@@ -174,7 +174,7 @@ class Audit {
 
     return {
       type: 'table',
-      headings: headings,
+      headings,
       items: results,
       summary,
       sortedBy,

package/core/audits/insights/insight-audit.js

@@ -68,10 +68,11 @@ async function adaptInsightToAuditProduct(artifacts, context, insightName, creat
     parsedTrace,
     insights,
   });
-  if (!details || (details.type === 'table' && details.headings.length === 0)) {
+  if (!details || (details.type === 'table' && details.items.length === 0)) {
     return {
       scoreDisplayMode: Audit.SCORING_MODES.NOT_APPLICABLE,
       score: null,
+      details,
     };
   }
 

package/core/audits/seo/crawlable-anchors.js

@@ -18,6 +18,16 @@ const UIStrings = {
   columnFailingLink: 'Uncrawlable Link',
 };
 
+const hrefAssociatedAttributes = [
+  'target',
+  'download',
+  'ping',
+  'rel',
+  'hreflang',
+  'type',
+  'referrerpolicy',
+];
+
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class CrawlableAnchors extends Audit {
@@ -45,10 +55,14 @@ class CrawlableAnchors extends Audit {
       role = '',
       id,
       href,
+      attributeNames = [],
+      listeners = [],
+      ancestorListeners = [],
     }) => {
       rawHref = rawHref.replace( /\s/g, '');
       name = name.trim();
       role = role.trim();
+      const hasListener = Boolean(listeners.length || ancestorListeners.length);
 
       if (role.length > 0) return;
       // Ignore mailto links even if they use one of the failing patterns. See https://github.com/GoogleChrome/lighthouse/issues/11443#issuecomment-694898412
@@ -62,6 +76,19 @@ class CrawlableAnchors extends Audit {
       if (rawHref.startsWith('file:')) return true;
       if (name.length > 0) return;
 
+      // If the a element has no href attribute, then the element represents a
+      // placeholder for where a link might otherwise have been placed, if it had
+      // been relevant, consisting of just the element's contents. The target,
+      // download, ping, rel, hreflang, type, and referrerpolicy attributes must be
+      // omitted if the href attribute is not present.
+      // See https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element
+      if (
+        !attributeNames.includes('href') &&
+        hrefAssociatedAttributes.every(attribute => !attributeNames.includes(attribute))
+      ) {
+        return hasListener;
+      }
+
       if (href === '') return true;
       if (javaScriptVoidRegExp.test(rawHref)) return true;
 

package/core/config/filters.js

@@ -263,6 +263,12 @@ function filterConfigByGatherMode(resolvedConfig, mode) {
  */
 function filterConfigByExplicitFilters(resolvedConfig, filters) {
   const {onlyAudits, onlyCategories, skipAudits} = filters;
+  if (onlyAudits && !onlyAudits.length) {
+    throw new Error(`onlyAudits cannot be an empty array.`);
+  }
+  if (onlyCategories && !onlyCategories.length) {
+    throw new Error(`onlyCategories cannot be an empty array.`);
+  }
 
   warnOnUnknownOnlyCategories(resolvedConfig.categories, onlyCategories);
 

package/core/gather/gatherers/anchor-elements.js

@@ -94,6 +94,7 @@ function collectAnchorElements() {
         rel: node.rel,
         target: node.target,
         id: node.getAttribute('id') || '',
+        attributeNames: node.getAttributeNames(),
         // @ts-expect-error - getNodeDetails put into scope via stringification
         node: getNodeDetails(node),
       };
@@ -109,6 +110,7 @@ function collectAnchorElements() {
       rel: '',
       target: node.target.baseVal || '',
       id: node.getAttribute('id') || '',
+      attributeNames: node.getAttributeNames(),
       // @ts-expect-error - getNodeDetails put into scope via stringification
       node: getNodeDetails(node),
     };
@@ -160,9 +162,27 @@ class AnchorElements extends BaseGatherer {
     const anchorsWithEventListeners = anchors.map(async anchor => {
       const listeners = await getEventListeners(session, anchor.node.devtoolsNodePath);
 
+      /** @type {Set<{type: string}>} */
+      const ancestorListeners = new Set();
+      const splitPath = anchor.node.devtoolsNodePath.split(',');
+      const ancestorListenerPromises = [];
+      while (splitPath.length >= 2) {
+        splitPath.length -= 2;
+        const path = splitPath.join(',');
+        const promise = getEventListeners(session, path).then(listeners => {
+          for (const listener of listeners) {
+            ancestorListeners.add(listener);
+          }
+        }).catch(() => {});
+        ancestorListenerPromises.push(promise);
+      }
+
+      await Promise.all(ancestorListenerPromises);
+
       return {
         ...anchor,
         listeners,
+        ancestorListeners: Array.from(ancestorListeners),
       };
     });
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.6.1-dev.20250610",
+  "version": "12.6.1-dev.20250611",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -111,7 +111,7 @@
     "@testing-library/preact-hooks": "^1.1.0",
     "@types/archiver": "^2.1.2",
     "@types/chrome": "^0.0.154",
-    "@types/configstore": "^4.0.0",
+    "@types/configstore": "^6.0.2",
     "@types/cpy": "^5.1.0",
     "@types/debug": "^4.1.7",
     "@types/eslint": "^8.2.1",
@@ -189,7 +189,7 @@
     "@sentry/node": "^7.0.0",
     "axe-core": "^4.10.3",
     "chrome-launcher": "^1.2.0",
-    "configstore": "^5.0.1",
+    "configstore": "^7.0.0",
     "csp_evaluator": "1.1.5",
     "devtools-protocol": "0.0.1467305",
     "enquirer": "^2.3.6",

package/readme.md

@@ -52,7 +52,7 @@ The Chrome extension was available prior to Lighthouse being available in Chrome
 
 The Node CLI provides the most flexibility in how Lighthouse runs can be configured and reported. Users who want more advanced usage, or want to run Lighthouse in an automated fashion should use the Node CLI.
 
-> **Note**
+> [!NOTE]
 > Lighthouse requires Node 18.20 or later.
 
 **Installation**:
@@ -227,7 +227,8 @@ top of any Lighthouse HTML report and open the report in the
 In the Viewer, reports can be shared by clicking the share icon in the top
 right corner and signing in to GitHub.
 
-> **Note**: shared reports are stashed as a secret Gist in GitHub, under your account.
+> [!NOTE]
+>  shared reports are stashed as a secret Gist in GitHub, under your account.
 
 ## Docs & Recipes
 

package/types/artifacts.d.ts

@@ -363,9 +363,13 @@ declare module Artifacts {
     node: NodeDetails
     onclick: string
     id: string
+    attributeNames: Array<string>
     listeners?: Array<{
       type: Crdp.DOMDebugger.EventListener['type']
     }>
+    ancestorListeners?: Array<{
+      type: Crdp.DOMDebugger.EventListener['type']
+    }>
   }
 
   type BFCacheReasonMap = {