lighthouse 12.6.1-dev.20250604 → 12.6.1-dev.20250606

package/cli/test/smokehouse/core-tests.js

@@ -61,6 +61,7 @@ import screenshot from './test-definitions/screenshot.js';
 import seoFailing from './test-definitions/seo-failing.js';
 import seoPassing from './test-definitions/seo-passing.js';
 import seoStatus403 from './test-definitions/seo-status-403.js';
+import seoMixedLanguage from './test-definitions/seo-mixed-language.js';
 import serviceWorkerReloaded from './test-definitions/service-worker-reloaded.js';
 import shiftAttribution from './test-definitions/shift-attribution.js';
 import sourceMaps from './test-definitions/source-maps.js';
@@ -125,6 +126,7 @@ const smokeTests = [
   seoFailing,
   seoPassing,
   seoStatus403,
+  seoMixedLanguage,
   serviceWorkerReloaded,
   shiftAttribution,
   sourceMaps,

package/core/audits/insights/insight-audit.d.ts

@@ -1,11 +1,11 @@
 export type CreateDetailsExtras = {
     insights: import("@paulirish/trace_engine/models/trace/insights/types.js").InsightSet;
-    parsedTrace: LH.Artifacts.TraceEngineResult["data"];
+    parsedTrace: LH.Artifacts.TraceEngineResult["parsedTrace"];
 };
 /**
  * @typedef CreateDetailsExtras
  * @property {import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet} insights
- * @property {LH.Artifacts.TraceEngineResult['data']} parsedTrace
+ * @property {LH.Artifacts.TraceEngineResult['parsedTrace']} parsedTrace
  */
 /**
  * @param {LH.Artifacts} artifacts

package/core/audits/insights/insight-audit.js

@@ -16,7 +16,7 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, {});
 /**
  * @param {LH.Artifacts} artifacts
  * @param {LH.Audit.Context} context
- * @return {Promise<{insights: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet|undefined, parsedTrace: LH.Artifacts.TraceEngineResult['data']}>}
+ * @return {Promise<{insights: import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet|undefined, parsedTrace: LH.Artifacts.TraceEngineResult['parsedTrace']}>}
  */
 async function getInsightSet(artifacts, context) {
   const settings = context.settings;
@@ -29,13 +29,13 @@ async function getInsightSet(artifacts, context) {
   const key = navigationId ?? NO_NAVIGATION;
   const insights = traceEngineResult.insights.get(key);
 
-  return {insights, parsedTrace: traceEngineResult.data};
+  return {insights, parsedTrace: traceEngineResult.parsedTrace};
 }
 
 /**
  * @typedef CreateDetailsExtras
  * @property {import('@paulirish/trace_engine/models/trace/insights/types.js').InsightSet} insights
- * @property {LH.Artifacts.TraceEngineResult['data']} parsedTrace
+ * @property {LH.Artifacts.TraceEngineResult['parsedTrace']} parsedTrace
  */
 
 /**

package/core/audits/layout-shifts.js

@@ -62,7 +62,7 @@ class LayoutShifts extends Audit {
     const SourceMaps = artifacts.SourceMaps;
     const traceEngineResult =
       await TraceEngineResult.request({trace, settings, SourceMaps}, context);
-    const clusters = traceEngineResult.data.LayoutShifts.clusters ?? [];
+    const clusters = traceEngineResult.parsedTrace.LayoutShifts.clusters ?? [];
     const {cumulativeLayoutShift: clsSavings, impactByNodeId} =
       await CumulativeLayoutShiftComputed.request(trace, context);
     const traceElements = artifacts.TraceElements

package/core/audits/seo/link-text.js

@@ -8,95 +8,123 @@ import {Audit} from '../audit.js';
 import UrlUtils from '../../lib/url-utils.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 
-const BLOCKLIST = new Set([
+/** @type {Record<string, Set<string>>} */
+const nonDescriptiveLinkTexts = {
   // English
-  'click here',
-  'click this',
-  'go',
-  'here',
-  'information',
-  'learn more',
-  'more',
-  'more info',
-  'more information',
-  'right here',
-  'read more',
-  'see more',
-  'start',
-  'this',
+  'en': new Set([
+    'click here',
+    'click this',
+    'go',
+    'here',
+    'information',
+    'learn more',
+    'more',
+    'more info',
+    'more information',
+    'right here',
+    'read more',
+    'see more',
+    'start',
+    'this',
+  ]),
   // Japanese
-  'ここをクリック',
-  'こちらをクリック',
-  'リンク',
-  '続きを読む',
-  '続く',
-  '全文表示',
+  'ja': new Set([
+    'ここをクリック',
+    'こちらをクリック',
+    'リンク',
+    '続きを読む',
+    '続く',
+    '全文表示',
+  ]),
   // Spanish
-  'click aquí',
-  'click aqui',
-  'clicka aquí',
-  'clicka aqui',
-  'pincha aquí',
-  'pincha aqui',
-  'aquí',
-  'aqui',
-  'más',
-  'mas',
-  'más información',
-  'más informacion',
-  'mas información',
-  'mas informacion',
-  'este',
-  'enlace',
-  'este enlace',
-  'empezar',
+  'es': new Set([
+    'click aquí',
+    'click aqui',
+    'clicka aquí',
+    'clicka aqui',
+    'pincha aquí',
+    'pincha aqui',
+    'aquí',
+    'aqui',
+    'más',
+    'mas',
+    'más información',
+    'más informacion',
+    'mas información',
+    'mas informacion',
+    'este',
+    'enlace',
+    'este enlace',
+    'empezar',
+  ]),
   // Portuguese
-  'clique aqui',
-  'ir',
-  'mais informação',
-  'mais informações',
-  'mais',
-  'veja mais',
+  'pt': new Set([
+    'clique aqui',
+    'ir',
+    'mais informação',
+    'mais informações',
+    'mais',
+    'veja mais',
+  ]),
   // Korean
-  '여기',
-  '여기를 클릭',
-  '클릭',
-  '링크',
-  '자세히',
-  '자세히 보기',
-  '계속',
-  '이동',
-  '전체 보기',
+  'ko': new Set([
+    '여기',
+    '여기를 클릭',
+    '클릭',
+    '링크',
+    '자세히',
+    '자세히 보기',
+    '계속',
+    '이동',
+    '전체 보기',
+  ]),
   // Swedish
-  'här',
-  'klicka här',
-  'läs mer',
-  'mer',
-  'mer info',
-  'mer information',
+  'sv': new Set([
+    'här',
+    'klicka här',
+    'läs mer',
+    'mer',
+    'mer info',
+    'mer information',
+  ]),
+  // German
+  'de': new Set([
+    'klicke hier',
+    'hier klicken',
+    'hier',
+    'mehr',
+    'siehe',
+    'dies',
+    'das',
+    'weiterlesen',
+  ]),
   // Tamil
-  'அடுத்த பக்கம்',
-  'மறுபக்கம்',
-  'முந்தைய பக்கம்',
-  'முன்பக்கம்',
-  'மேலும் அறிக',
-  'மேலும் தகவலுக்கு',
-  'மேலும் தரவுகளுக்கு',
-  'தயவுசெய்து இங்கே அழுத்தவும்',
-  'இங்கே கிளிக் செய்யவும்',
+  'ta': new Set([
+    'அடுத்த பக்கம்',
+    'மறுபக்கம்',
+    'முந்தைய பக்கம்',
+    'முன்பக்கம்',
+    'மேலும் அறிக',
+    'மேலும் தகவலுக்கு',
+    'மேலும் தரவுகளுக்கு',
+    'தயவுசெய்து இங்கே அழுத்தவும்',
+    'இங்கே கிளிக் செய்யவும்',
+  ]),
   // Persian
-  'اطلاعات بیشتر',
-  'اطلاعات',
-  'این',
-  'اینجا بزنید',
-  'اینجا کلیک کنید',
-  'اینجا',
-  'برو',
-  'بیشتر بخوانید',
-  'بیشتر بدانید',
-  'بیشتر',
-  'شروع',
-]);
+  'fa': new Set([
+    'اطلاعات بیشتر',
+    'اطلاعات',
+    'این',
+    'اینجا بزنید',
+    'اینجا کلیک کنید',
+    'اینجا',
+    'برو',
+    'بیشتر بخوانید',
+    'بیشتر بدانید',
+    'بیشتر',
+    'شروع',
+  ]),
+};
 
 const UIStrings = {
   /** Title of a Lighthouse audit that tests if each link on a page contains a sufficient description of what a user will find when they click it. Generic, non-descriptive text like "click here" doesn't give an indication of what the link leads to. This descriptive title is shown when all links on the page have sufficient textual descriptions. */
@@ -135,8 +163,9 @@ class LinkText extends Audit {
    */
   static audit(artifacts) {
     const failingLinks = artifacts.AnchorElements
-      .filter(link => link.href && !link.rel.includes('nofollow'))
       .filter(link => {
+        if (!link.href || link.rel.includes('nofollow')) return false;
+
         const href = link.href.toLowerCase();
         if (
           href.startsWith('javascript:') ||
@@ -148,12 +177,30 @@ class LinkText extends Audit {
           return false;
         }
 
-        return BLOCKLIST.has(link.text.trim().toLowerCase());
+        const searchTerm = link.text.trim().toLowerCase();
+        if (searchTerm) {
+          // Use language if detected, otherwise look at everything.
+          if (link.textLang) {
+            const lang = link.textLang.split('-')[0];
+            if (nonDescriptiveLinkTexts[lang] && nonDescriptiveLinkTexts[lang].has(searchTerm)) {
+              return true;
+            }
+          } else {
+            for (const texts of Object.values(nonDescriptiveLinkTexts)) {
+              if (texts.has(searchTerm)) {
+                return true;
+              }
+            }
+          }
+        }
+
+        return false;
       })
       .map(link => {
         return {
           href: link.href,
           text: link.text.trim(),
+          textLang: link.textLang,
         };
       });
 

package/core/computed/metrics/lantern-metric.js

@@ -38,14 +38,15 @@ async function getComputationDataParamsFromTrace(data, context) {
 
   const graph = await PageDependencyGraph.request({...data, fromTrace: true}, context);
   const traceEngineResult = await TraceEngineResult.request(data, context);
-  const frameId = traceEngineResult.data.Meta.mainFrameId;
-  const navigationId = traceEngineResult.data.Meta.mainFrameNavigations[0].args.data?.navigationId;
+  const frameId = traceEngineResult.parsedTrace.Meta.mainFrameId;
+  const navigationId =
+    traceEngineResult.parsedTrace.Meta.mainFrameNavigations[0].args.data?.navigationId;
   if (!navigationId) {
     throw new Error(`Lantern metrics could not be calculated due to missing navigation id`);
   }
 
   const processedNavigation = Lantern.TraceEngineComputationData.createProcessedNavigation(
-    traceEngineResult.data, frameId, navigationId);
+    traceEngineResult.parsedTrace, frameId, navigationId);
   const simulator = data.simulator || (await LoadSimulator.request(data, context));
 
   return {simulator, graph, processedNavigation};

package/core/computed/page-dependency-graph.js

@@ -27,11 +27,11 @@ class PageDependencyGraph {
     if (data.fromTrace) {
       const traceEngineResult =
         await TraceEngineResult.request({trace, settings, SourceMaps}, context);
-      const traceEngineData = traceEngineResult.data;
+      const parsedTrace = traceEngineResult.parsedTrace;
       const requests =
-        Lantern.TraceEngineComputationData.createNetworkRequests(trace, traceEngineData);
+        Lantern.TraceEngineComputationData.createNetworkRequests(trace, parsedTrace);
       const graph =
-        Lantern.TraceEngineComputationData.createGraph(requests, trace, traceEngineData, URL);
+        Lantern.TraceEngineComputationData.createGraph(requests, trace, parsedTrace, URL);
       // @ts-expect-error for now, ignore that this is a SyntheticNetworkEvent instead of LH's NetworkEvent.
       return graph;
     }

package/core/computed/trace-engine-result.js

@@ -63,7 +63,7 @@ class TraceEngineResult {
     if (!processor.parsedTrace) throw new Error('No data');
     if (!processor.insights) throw new Error('No insights');
     this.localizeInsights(processor.insights);
-    return {data: processor.parsedTrace, insights: processor.insights};
+    return {parsedTrace: processor.parsedTrace, insights: processor.insights};
   }
 
   /**

package/core/gather/gatherers/anchor-elements.js

@@ -38,10 +38,49 @@ function collectAnchorElements() {
     return onclick.slice(0, 1024);
   }
 
+  /**
+   * @param {HTMLElement|SVGElement} node
+   * @return {string|null}
+   */
+  function getLangOfInnerText(node) {
+    let curNodeLang = null;
+
+    // If we find multiple languages within this element, return null.
+    for (const child of node.querySelectorAll('*')) {
+      if (!child.textContent) continue;
+
+      const childLang = child.closest('[lang]')?.getAttribute('lang');
+      if (!childLang) continue;
+
+      if (!curNodeLang) {
+        curNodeLang = childLang;
+        continue;
+      }
+
+      if (curNodeLang.split('-')[0] !== childLang.split('-')[0]) {
+        return null;
+      }
+    }
+
+    return curNodeLang ?? node.closest('[lang]')?.getAttribute('lang') ?? null;
+  }
+
   /** @type {Array<HTMLAnchorElement|SVGAElement>} */
   // @ts-expect-error - put into scope via stringification
   const anchorElements = getElementsInDocument('a'); // eslint-disable-line no-undef
 
+  // Check, if document has only one lang attribute in opening html or in body tag. If so,
+  // there is no need to run the `getLangOfInnerText()` function with multiple
+  // possible DOM traversals
+  /** @type {Array<HTMLElement|SVGElement>} */
+  // @ts-expect-error - put into scope via stringification
+  const langElements = getElementsInDocument('[lang]'); // eslint-disable-line no-undef
+  const documentHasSingleLang = langElements.length === 1 &&
+    (langElements[0].nodeName === 'BODY' || langElements[0].nodeName === 'HTML');
+  const singleLang = documentHasSingleLang ? langElements[0].getAttribute('lang') : null;
+
+  // TODO: consider Content-Language.
+
   return anchorElements.map(node => {
     if (node instanceof HTMLAnchorElement) {
       return {
@@ -51,6 +90,7 @@ function collectAnchorElements() {
         role: node.getAttribute('role') || '',
         name: node.name,
         text: node.innerText, // we don't want to return hidden text, so use innerText
+        textLang: singleLang ?? getLangOfInnerText(node) ?? undefined,
         rel: node.rel,
         target: node.target,
         id: node.getAttribute('id') || '',
@@ -65,6 +105,7 @@ function collectAnchorElements() {
       onclick: getTruncatedOnclick(node),
       role: node.getAttribute('role') || '',
       text: node.textContent || '',
+      textLang: singleLang ?? getLangOfInnerText(node) ?? undefined,
       rel: '',
       target: node.target.baseVal || '',
       id: node.getAttribute('id') || '',

package/core/gather/gatherers/trace-elements.d.ts

@@ -32,11 +32,11 @@ declare class TraceElements extends BaseGatherer {
      * that may have caused the shift.
      *
      * @param {LH.Trace} trace
-     * @param {LH.Artifacts.TraceEngineResult['data']} traceEngineResult
+     * @param {LH.Artifacts.TraceEngineResult['parsedTrace']} traceEngineResult
      * @param {LH.Gatherer.Context} context
      * @return {Promise<Array<{nodeId: number}>>}
      */
-    static getTopLayoutShifts(trace: LH.Trace, traceEngineResult: LH.Artifacts.TraceEngineResult["data"], context: LH.Gatherer.Context): Promise<Array<{
+    static getTopLayoutShifts(trace: LH.Trace, traceEngineResult: LH.Artifacts.TraceEngineResult["parsedTrace"], context: LH.Gatherer.Context): Promise<Array<{
         nodeId: number;
     }>>;
     /**

package/core/gather/gatherers/trace-elements.js

@@ -173,7 +173,7 @@ class TraceElements extends BaseGatherer {
    * that may have caused the shift.
    *
    * @param {LH.Trace} trace
-   * @param {LH.Artifacts.TraceEngineResult['data']} traceEngineResult
+   * @param {LH.Artifacts.TraceEngineResult['parsedTrace']} traceEngineResult
    * @param {LH.Gatherer.Context} context
    * @return {Promise<Array<{nodeId: number}>>}
    */
@@ -369,7 +369,7 @@ class TraceElements extends BaseGatherer {
       traceEngineResult, navigationId);
     const lcpNodeData = await TraceElements.getLcpElement(trace, context);
     const shiftsData = await TraceElements.getTopLayoutShifts(
-      trace, traceEngineResult.data, context);
+      trace, traceEngineResult.parsedTrace, context);
     const animatedElementData = await this.getAnimatedElements(mainThreadEvents);
     const responsivenessElementData = await TraceElements.getResponsivenessElement(trace, context);
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.6.1-dev.20250604",
+  "version": "12.6.1-dev.20250606",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -106,7 +106,7 @@
     "@esbuild-kit/esm-loader": "^2.1.1",
     "@esbuild-plugins/node-modules-polyfill": "^0.1.4",
     "@formatjs/icu-messageformat-parser": "^2.6.2",
-    "@jest/fake-timers": "^28.1.0",
+    "@jest/fake-timers": "^29.7.0",
     "@testing-library/preact": "^3.1.1",
     "@testing-library/preact-hooks": "^1.1.0",
     "@types/archiver": "^2.1.2",
@@ -160,8 +160,8 @@
     "gh-pages": "^2.0.1",
     "glob": "^7.1.3",
     "idb-keyval": "2.2.0",
-    "jest-mock": "^27.3.0",
-    "jest-snapshot": "^28.1.0",
+    "jest-mock": "^29.7.0",
+    "jest-snapshot": "^29.7.0",
     "jsdom": "^12.2.0",
     "lighthouse-plugin-soft-navigation": "^1.0.1",
     "magic-string": "^0.25.7",

package/types/artifacts.d.ts

@@ -357,6 +357,7 @@ declare module Artifacts {
     rawHref: string
     name?: string
     text: string
+    textLang?: string
     role: string
     target: string
     node: NodeDetails
@@ -507,7 +508,7 @@ declare module Artifacts {
   }
 
   interface TraceEngineResult {
-    data: TraceEngine.Handlers.Types.ParsedTrace;
+    parsedTrace: TraceEngine.Handlers.Types.ParsedTrace;
     insights: TraceEngine.Insights.Types.TraceInsightSets;
   }
 

package/types/internal/test.d.ts

@@ -6,7 +6,7 @@
 
 declare global {
   var expect: import('expect').Expect;
-  type Mock<T, Y extends unknown[]> = import('jest-mock').Mock<T, Y>;
+  type Mock<T> = import('jest-mock').Mock<(...args: any) => T>;
 }
 
 declare module 'expect' {