lighthouse 12.6.1-dev.20250603 → 12.6.1-dev.20250604

package/core/audits/insights/cls-culprits-insight.js

@@ -114,7 +114,7 @@ class CLSCulpritsInsight extends Audit {
         /** @type {LH.Audit.Details.Table['items']} */
         const items = events.map(event => {
           const biggestImpactNodeId = TraceElements.getBiggestImpactNodeForShiftEvent(
-            event.args.data.impacted_nodes || [], impactByNodeId, event);
+            event.args.data.impacted_nodes || [], impactByNodeId);
           return {
             node: makeNodeItemForNodeId(artifacts.TraceElements, biggestImpactNodeId),
             score: event.args.data?.weighted_score_delta,

package/core/audits/layout-shifts.js

@@ -89,7 +89,7 @@ class LayoutShifts extends Audit {
       .slice(0, MAX_LAYOUT_SHIFTS);
     for (const event of topLayoutShiftEvents) {
       const biggestImpactNodeId = TraceElements.getBiggestImpactNodeForShiftEvent(
-        event.args.data.impacted_nodes || [], impactByNodeId, event);
+        event.args.data.impacted_nodes || [], impactByNodeId);
       const biggestImpactElement = traceElements.find(t => t.nodeId === biggestImpactNodeId);
 
       // Turn root causes into sub-items.

package/core/gather/gatherers/trace-elements.d.ts

@@ -23,10 +23,9 @@ declare class TraceElements extends BaseGatherer {
      *
      * @param {LH.Artifacts.TraceImpactedNode[]} impactedNodes
      * @param {Map<number, number>} impactByNodeId
-     * @param {import('../../lib/trace-engine.js').SaneSyntheticLayoutShift} event Only for debugging
      * @return {number|undefined}
      */
-    static getBiggestImpactNodeForShiftEvent(impactedNodes: LH.Artifacts.TraceImpactedNode[], impactByNodeId: Map<number, number>, event: import("../../lib/trace-engine.js").SaneSyntheticLayoutShift): number | undefined;
+    static getBiggestImpactNodeForShiftEvent(impactedNodes: LH.Artifacts.TraceImpactedNode[], impactByNodeId: Map<number, number>): number | undefined;
     /**
      * This function finds the top (up to 15) layout shifts on the page, and returns
      * the id of the largest impacted node of each shift, along with any related nodes

package/core/gather/gatherers/trace-elements.js

@@ -152,49 +152,19 @@ class TraceElements extends BaseGatherer {
    *
    * @param {LH.Artifacts.TraceImpactedNode[]} impactedNodes
    * @param {Map<number, number>} impactByNodeId
-   * @param {import('../../lib/trace-engine.js').SaneSyntheticLayoutShift} event Only for debugging
    * @return {number|undefined}
    */
-  static getBiggestImpactNodeForShiftEvent(impactedNodes, impactByNodeId, event) {
-    try {
-      let biggestImpactNodeId;
-      let biggestImpactNodeScore = Number.NEGATIVE_INFINITY;
-      for (const node of impactedNodes) {
-        const impactScore = impactByNodeId.get(node.node_id);
-        if (impactScore !== undefined && impactScore > biggestImpactNodeScore) {
-          biggestImpactNodeId = node.node_id;
-          biggestImpactNodeScore = impactScore;
-        }
+  static getBiggestImpactNodeForShiftEvent(impactedNodes, impactByNodeId) {
+    let biggestImpactNodeId;
+    let biggestImpactNodeScore = Number.NEGATIVE_INFINITY;
+    for (const node of impactedNodes) {
+      const impactScore = impactByNodeId.get(node.node_id);
+      if (impactScore !== undefined && impactScore > biggestImpactNodeScore) {
+        biggestImpactNodeId = node.node_id;
+        biggestImpactNodeScore = impactScore;
       }
-      return biggestImpactNodeId;
-    } catch (err) {
-      // See https://github.com/GoogleChrome/lighthouse/issues/15870
-      // `impactedNodes` should always be an array here, but it can randomly be something else for
-      // currently unknown reasons. This exception handling will help us identify what
-      // `impactedNodes` really is and also prevent the error from being fatal.
-
-      // It's possible `impactedNodes` is not JSON serializable, so let's add more supplemental
-      // fields just in case.
-      const impactedNodesType = typeof impactedNodes;
-      const impactedNodesClassName = impactedNodes?.constructor?.name;
-
-      let impactedNodesJson;
-      let eventJson;
-      try {
-        impactedNodesJson = JSON.parse(JSON.stringify(impactedNodes));
-        eventJson = JSON.parse(JSON.stringify(event));
-      } catch {}
-
-      Sentry.captureException(err, {
-        extra: {
-          impactedNodes: impactedNodesJson,
-          event: eventJson,
-          impactedNodesType,
-          impactedNodesClassName,
-        },
-      });
-      return;
     }
+    return biggestImpactNodeId;
   }
 
   /**
@@ -222,7 +192,7 @@ class TraceElements extends BaseGatherer {
         const nodeIds = [];
         const impactedNodes = event.args.data.impacted_nodes || [];
         const biggestImpactedNodeId =
-          this.getBiggestImpactNodeForShiftEvent(impactedNodes, impactByNodeId, event);
+          this.getBiggestImpactNodeForShiftEvent(impactedNodes, impactByNodeId);
         if (biggestImpactedNodeId !== undefined) {
           nodeIds.push(biggestImpactedNodeId);
         }

package/core/lib/asset-saver.d.ts

@@ -102,5 +102,5 @@ export function normalizeTimingEntries(timings: LH.Result.MeasureEntry[]): void;
 /**
  * @param {LH.Result} lhr
  */
-export function elideAuditErrorStacks(lhr: LH.Result): void;
+export function elideLhrErrorStacks(lhr: LH.Result): void;
 //# sourceMappingURL=asset-saver.d.ts.map

package/core/lib/asset-saver.js

@@ -515,19 +515,31 @@ function normalizeTimingEntries(timings) {
 }
 
 /**
- * @param {LH.Result} lhr
+ * @param {string} errorStack
+ * @return {string}
  */
-function elideAuditErrorStacks(lhr) {
+function elideErrorStack(errorStack) {
   const baseCallFrameUrl = url.pathToFileURL(LH_ROOT);
+  return errorStack
+    // Make paths relative to the repo root.
+    .replaceAll(baseCallFrameUrl.pathname, '')
+    // Remove line/col info.
+    .replaceAll(/:\d+:\d+/g, '');
+}
+
+/**
+ * @param {LH.Result} lhr
+ */
+function elideLhrErrorStacks(lhr) {
   for (const auditResult of Object.values(lhr.audits)) {
     if (auditResult.errorStack) {
-      auditResult.errorStack = auditResult.errorStack
-        // Make paths relative to the repo root.
-        .replaceAll(baseCallFrameUrl.pathname, '')
-        // Remove line/col info.
-        .replaceAll(/:\d+:\d+/g, '');
+      auditResult.errorStack = elideErrorStack(auditResult.errorStack);
     }
   }
+
+  if (lhr.runtimeError?.errorStack) {
+    lhr.runtimeError.errorStack = elideErrorStack(lhr.runtimeError.errorStack);
+  }
 }
 
 export {
@@ -543,5 +555,5 @@ export {
   saveLanternNetworkData,
   stringifyReplacer,
   normalizeTimingEntries,
-  elideAuditErrorStacks,
+  elideLhrErrorStacks,
 };

package/core/runner.js

@@ -312,10 +312,8 @@ class Runner {
         if (!isEqual(normalizedGatherSettings[k], normalizedAuditSettings[k])) {
           throw new Error(
             `Cannot change settings between gathering and auditing…
-Difference found at: \`${k}\`
-    ${normalizedGatherSettings[k]}
-vs
-    ${normalizedAuditSettings[k]}`);
+Difference found at: \`${k}\`: ${JSON.stringify(normalizedGatherSettings[k], null, 2)}
+vs: ${JSON.stringify(normalizedAuditSettings[k], null, 2)}`);
         }
       }
 
@@ -451,21 +449,27 @@ vs
    * @return {LH.RawIcu<LH.Result['runtimeError']>|undefined}
    */
   static getArtifactRuntimeError(artifacts) {
+    /** @type {Array<[string, LighthouseError|object]>} */
     const possibleErrorArtifacts = [
-      artifacts.PageLoadError, // Preferentially use `PageLoadError`, if it exists.
-      ...Object.values(artifacts), // Otherwise check amongst all artifacts.
+      ['PageLoadError', artifacts.PageLoadError], // Preferentially use `PageLoadError`, if it exists.
+      ...Object.entries(artifacts), // Otherwise check amongst all artifacts.
     ];
 
-    for (const possibleErrorArtifact of possibleErrorArtifacts) {
+    for (const [artifactKey, possibleErrorArtifact] of possibleErrorArtifacts) {
       const isError = possibleErrorArtifact instanceof LighthouseError;
 
       // eslint-disable-next-line max-len
       if (isError && possibleErrorArtifact.lhrRuntimeError) {
         const errorMessage = possibleErrorArtifact.friendlyMessage || possibleErrorArtifact.message;
+        // Prefer the stack trace closest to the error.
+        const stack =
+          /** @type {any} */ (possibleErrorArtifact.cause)?.stack ?? possibleErrorArtifact.stack;
 
         return {
           code: possibleErrorArtifact.code,
           message: errorMessage,
+          errorStack: stack,
+          artifactKey,
         };
       }
     }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.6.1-dev.20250603",
+  "version": "12.6.1-dev.20250604",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {

package/types/lhr/lhr.d.ts

@@ -41,7 +41,14 @@ interface Result {
   /** List of top-level warnings for this Lighthouse run. */
   runWarnings: string[];
   /** A top-level error message that, if present, indicates a serious enough problem that this Lighthouse result may need to be discarded. */
-  runtimeError?: {code: string, message: string};
+  runtimeError?: {
+    code: string;
+    message: string;
+    /** Error stack from any fatal error. */
+    errorStack?: string;
+    /** Artifact the threw the fatal error. */
+    artifactKey?: string;
+  };
   /** The User-Agent string of the browser used run Lighthouse for these results. */
   userAgent: string;
   /** Information about the environment in which Lighthouse was run. */