lighthouse 12.4.0-dev.20250320 → 12.4.0-dev.20250321

package/core/audits/insights/use-cache-insight.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-unused-vars */ // TODO: remove once implemented.
-
 /**
  * @license
  * Copyright 2025 Google LLC
@@ -10,7 +8,7 @@ import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/UseCache.
 
 import {Audit} from '../audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
-import {adaptInsightToAuditProduct, makeNodeItemForNodeId} from './insight-audit.js';
+import {adaptInsightToAuditProduct} from './insight-audit.js';
 
 // eslint-disable-next-line max-len
 const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/UseCache.js', UIStrings);
@@ -25,8 +23,9 @@ class UseCacheInsight extends Audit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
-      guidanceLevel: 3, // TODO: confirm/change.
-      requiredArtifacts: ['traces', 'TraceElements', 'SourceMaps'],
+      guidanceLevel: 3,
+      requiredArtifacts: ['traces', 'SourceMaps'],
+      replacesAudits: ['uses-long-cache-ttl'],
     };
   }
 
@@ -36,17 +35,25 @@ class UseCacheInsight extends Audit {
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    // TODO: implement.
     return adaptInsightToAuditProduct(artifacts, context, 'UseCache', (insight) => {
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
         /* eslint-disable max-len */
+        {key: 'url', valueType: 'url', label: str_(UIStrings.requestColumn)},
+        {key: 'cacheLifetimeMs', valueType: 'ms', label: str_(UIStrings.cacheTTL), displayUnit: 'duration'},
+        {key: 'totalBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize), displayUnit: 'kb', granularity: 1},
         /* eslint-enable max-len */
       ];
       /** @type {LH.Audit.Details.Table['items']} */
-      const items = [
-      ];
-      return Audit.makeTableDetails(headings, items);
+      const items = insight.requests.map(request => ({
+        url: request.request.args.data.url,
+        cacheLifetimeMs: request.ttl * 1000,
+        totalBytes: request.request.args.data.encodedDataLength,
+      }));
+      return Audit.makeTableDetails(headings, items, {
+        sortedBy: ['totalBytes'],
+        skipSumming: ['cacheLifetimeMs'],
+      });
     });
   }
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.4.0-dev.20250320",
+  "version": "12.4.0-dev.20250321",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {