lighthouse 12.4.0-dev.20250227 → 12.4.0-dev.20250301

package/core/audits/insights/{long-critical-network-tree-insight.d.ts → duplicate-javascript-insight.d.ts}

@@ -1,5 +1,5 @@
-export default LongCriticalNetworkTreeInsight;
-declare class LongCriticalNetworkTreeInsight extends Audit {
+export default DuplicateJavaScriptInsight;
+declare class DuplicateJavaScriptInsight extends Audit {
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context
@@ -8,4 +8,4 @@ declare class LongCriticalNetworkTreeInsight extends Audit {
     static audit(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Product>;
 }
 import { Audit } from '../audit.js';
-//# sourceMappingURL=long-critical-network-tree-insight.d.ts.map
+//# sourceMappingURL=duplicate-javascript-insight.d.ts.map

package/core/audits/insights/duplicate-javascript-insight.js

@@ -0,0 +1,54 @@
+/* eslint-disable no-unused-vars */ // TODO: remove once implemented.
+
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/DuplicateJavaScript.js';
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+import {adaptInsightToAuditProduct, makeNodeItemForNodeId} from './insight-audit.js';
+
+// eslint-disable-next-line max-len
+const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/DuplicateJavaScript.js', UIStrings);
+
+class DuplicateJavaScriptInsight extends Audit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'duplicate-javascript-insight',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.title),
+      description: str_(UIStrings.description),
+      guidanceLevel: 3, // TODO: confirm/change.
+      requiredArtifacts: ['traces', 'TraceElements'],
+    };
+  }
+
+  /**
+   * @param {LH.Artifacts} artifacts
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
+   */
+  static async audit(artifacts, context) {
+    // TODO: implement.
+    return adaptInsightToAuditProduct(artifacts, context, 'DuplicateJavaScript', (insight) => {
+      /** @type {LH.Audit.Details.Table['headings']} */
+      const headings = [
+        /* eslint-disable max-len */
+        /* eslint-enable max-len */
+      ];
+      /** @type {LH.Audit.Details.Table['items']} */
+      const items = [
+      ];
+      return Audit.makeTableDetails(headings, items);
+    });
+  }
+}
+
+export default DuplicateJavaScriptInsight;

package/core/audits/insights/insight-audit.js

@@ -71,11 +71,14 @@ async function adaptInsightToAuditProduct(artifacts, context, insightName, creat
     metricSavings = {...metricSavings, LCP: /** @type {any} */ (0)};
   }
 
-  let score = insight.shouldShow ? 0 : 1;
-  // TODO: change insight model to denote passing/failing/informative. Until then... hack it.
-  if (insightName === 'LCPPhases') {
+  let score = 1;
+  if (insight.state === 'fail') {
+    score = 0;
+  } else if (insightName === 'LCPPhases') {
+    // TODO: change these insights to denote passing/failing/informative. Until then... hack it.
     score = metricSavings?.LCP ?? 0 >= 1000 ? 0 : 1;
   } else if (insightName === 'InteractionToNextPaint') {
+    // TODO: change these insights to denote passing/failing/informative. Until then... hack it.
     score = metricSavings?.INP ?? 0 >= 500 ? 0 : 1;
   }
 

package/core/audits/insights/network-dependency-tree-insight.d.ts

@@ -0,0 +1,11 @@
+export default NetworkDependencyTreeInsight;
+declare class NetworkDependencyTreeInsight extends Audit {
+    /**
+     * @param {LH.Artifacts} artifacts
+     * @param {LH.Audit.Context} context
+     * @return {Promise<LH.Audit.Product>}
+     */
+    static audit(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Product>;
+}
+import { Audit } from '../audit.js';
+//# sourceMappingURL=network-dependency-tree-insight.d.ts.map

package/core/audits/insights/{long-critical-network-tree-insight.js → network-dependency-tree-insight.js}

@@ -6,22 +6,22 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/LongCriticalNetworkTree.js';
+import {UIStrings} from '@paulirish/trace_engine/models/trace/insights/NetworkDependencyTree.js';
 
 import {Audit} from '../audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 import {adaptInsightToAuditProduct, makeNodeItemForNodeId} from './insight-audit.js';
 
 // eslint-disable-next-line max-len
-const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/LongCriticalNetworkTree.js', UIStrings);
+const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/models/trace/insights/NetworkDependencyTree.js', UIStrings);
 
-class LongCriticalNetworkTreeInsight extends Audit {
+class NetworkDependencyTreeInsight extends Audit {
   /**
    * @return {LH.Audit.Meta}
    */
   static get meta() {
     return {
-      id: 'long-critical-network-tree-insight',
+      id: 'network-dependency-tree-insight',
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.title),
       description: str_(UIStrings.description),
@@ -38,7 +38,7 @@ class LongCriticalNetworkTreeInsight extends Audit {
    */
   static async audit(artifacts, context) {
     // TODO: implement.
-    return adaptInsightToAuditProduct(artifacts, context, 'LongCriticalNetworkTree', (insight) => {
+    return adaptInsightToAuditProduct(artifacts, context, 'NetworkDependencyTree', (insight) => {
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
       ];
@@ -50,4 +50,4 @@ class LongCriticalNetworkTreeInsight extends Audit {
   }
 }
 
-export default LongCriticalNetworkTreeInsight;
+export default NetworkDependencyTreeInsight;

package/core/computed/js-bundles.d.ts

@@ -1,6 +1,6 @@
 export { JSBundlesComputed as JSBundles };
 declare const JSBundlesComputed: typeof JSBundles & {
-    request: (dependencies: Pick<import("../index.js").Artifacts, "SourceMaps" | "Scripts">, context: LH.Artifacts.ComputedContext) => ReturnType<typeof JSBundles.compute_>;
+    request: (dependencies: Pick<import("../index.js").Artifacts, "Scripts" | "SourceMaps">, context: LH.Artifacts.ComputedContext) => ReturnType<typeof JSBundles.compute_>;
 };
 declare class JSBundles {
     /**

package/core/computed/module-duplication.d.ts

@@ -1,6 +1,6 @@
 export { ModuleDuplicationComputed as ModuleDuplication };
 declare const ModuleDuplicationComputed: typeof ModuleDuplication & {
-    request: (dependencies: Pick<import("../index.js").Artifacts, "SourceMaps" | "Scripts">, context: LH.Artifacts.ComputedContext) => ReturnType<typeof ModuleDuplication.compute_>;
+    request: (dependencies: Pick<import("../index.js").Artifacts, "Scripts" | "SourceMaps">, context: LH.Artifacts.ComputedContext) => ReturnType<typeof ModuleDuplication.compute_>;
 };
 declare class ModuleDuplication {
     /**

package/core/computed/trace-engine-result.js

@@ -108,6 +108,10 @@ class TraceEngineResult {
                 // @ts-expect-error
                 values[key] = value.__i18nBytes;
                 // TODO: use an actual byte formatter. Right now, this shows the exact number of bytes.
+              } else if (value && typeof value === 'object' && 'i18nId' in value) {
+                // TODO: add support for str_ values to be IcuMessage.
+                // @ts-expect-error
+                values[key] = str_(value.i18nId, value.values).formattedDefault;
               }
             }
           }

package/core/config/default-config.js

@@ -312,13 +312,14 @@ const defaultConfig = {
     'insights/cls-culprits-insight',
     'insights/document-latency-insight',
     'insights/dom-size-insight',
+    'insights/duplicate-javascript-insight',
     'insights/font-display-insight',
     'insights/forced-reflow-insight',
     'insights/image-delivery-insight',
     'insights/interaction-to-next-paint-insight',
     'insights/lcp-discovery-insight',
     'insights/lcp-phases-insight',
-    'insights/long-critical-network-tree-insight',
+    'insights/network-dependency-tree-insight',
     'insights/render-blocking-insight',
     'insights/slow-css-selector-insight',
     'insights/third-parties-insight',
@@ -410,13 +411,14 @@ const defaultConfig = {
         {id: 'cls-culprits-insight', weight: 0, group: 'insights'},
         {id: 'document-latency-insight', weight: 0, group: 'insights'},
         {id: 'dom-size-insight', weight: 0, group: 'insights'},
+        {id: 'duplicate-javascript-insight', weight: 0, group: 'insights'},
         {id: 'font-display-insight', weight: 0, group: 'insights'},
         {id: 'forced-reflow-insight', weight: 0, group: 'insights'},
         {id: 'image-delivery-insight', weight: 0, group: 'insights'},
         {id: 'interaction-to-next-paint-insight', weight: 0, group: 'insights'},
         {id: 'lcp-discovery-insight', weight: 0, group: 'insights'},
         {id: 'lcp-phases-insight', weight: 0, group: 'insights'},
-        {id: 'long-critical-network-tree-insight', weight: 0, group: 'insights'},
+        {id: 'network-dependency-tree-insight', weight: 0, group: 'insights'},
         {id: 'render-blocking-insight', weight: 0, group: 'insights'},
         {id: 'slow-css-selector-insight', weight: 0, group: 'insights'},
         {id: 'third-parties-insight', weight: 0, group: 'insights'},

package/core/lib/bf-cache-strings.d.ts

@@ -2,126 +2,4 @@
 export const NotRestoredReasonDescription: Record<string, {
     name: LH.IcuMessage | string;
 } | undefined>;
-export namespace UIStrings {
-    let notMainFrame: string;
-    let backForwardCacheDisabled: string;
-    let relatedActiveContentsExist: string;
-    let HTTPStatusNotOK: string;
-    let schemeNotHTTPOrHTTPS: string;
-    let loading: string;
-    let wasGrantedMediaAccess: string;
-    let HTTPMethodNotGET: string;
-    let subframeIsNavigating: string;
-    let timeout: string;
-    let cacheLimit: string;
-    let JavaScriptExecution: string;
-    let rendererProcessKilled: string;
-    let rendererProcessCrashed: string;
-    let grantedMediaStreamAccess: string;
-    let cacheFlushed: string;
-    let serviceWorkerVersionActivation: string;
-    let sessionRestored: string;
-    let serviceWorkerPostMessage: string;
-    let enteredBackForwardCacheBeforeServiceWorkerHostAdded: string;
-    let serviceWorkerClaim: string;
-    let haveInnerContents: string;
-    let timeoutPuttingInCache: string;
-    let backForwardCacheDisabledByLowMemory: string;
-    let backForwardCacheDisabledByCommandLine: string;
-    let networkRequestDatapipeDrainedAsBytesConsumer: string;
-    let networkRequestRedirected: string;
-    let networkRequestTimeout: string;
-    let networkExceedsBufferLimit: string;
-    let navigationCancelledWhileRestoring: string;
-    let backForwardCacheDisabledForPrerender: string;
-    let userAgentOverrideDiffers: string;
-    let foregroundCacheLimit: string;
-    let backForwardCacheDisabledForDelegate: string;
-    let unloadHandlerExistsInMainFrame: string;
-    let unloadHandlerExistsInSubFrame: string;
-    let serviceWorkerUnregistration: string;
-    let noResponseHead: string;
-    let cacheControlNoStore: string;
-    let ineligibleAPI: string;
-    let internalError: string;
-    let webSocket: string;
-    let webTransport: string;
-    let webRTC: string;
-    let mainResourceHasCacheControlNoStore: string;
-    let mainResourceHasCacheControlNoCache: string;
-    let subresourceHasCacheControlNoStore: string;
-    let subresourceHasCacheControlNoCache: string;
-    let containsPlugins: string;
-    let documentLoaded: string;
-    let dedicatedWorkerOrWorklet: string;
-    let outstandingNetworkRequestOthers: string;
-    let outstandingIndexedDBTransaction: string;
-    let requestedNotificationsPermission: string;
-    let requestedMIDIPermission: string;
-    let requestedAudioCapturePermission: string;
-    let requestedVideoCapturePermission: string;
-    let requestedBackForwardCacheBlockedSensors: string;
-    let requestedBackgroundWorkPermission: string;
-    let broadcastChannel: string;
-    let indexedDBConnection: string;
-    let webXR: string;
-    let sharedWorker: string;
-    let webLocks: string;
-    let webHID: string;
-    let webShare: string;
-    let requestedStorageAccessGrant: string;
-    let webNfc: string;
-    let outstandingNetworkRequestFetch: string;
-    let outstandingNetworkRequestXHR: string;
-    let appBanner: string;
-    let printing: string;
-    let webDatabase: string;
-    let pictureInPicture: string;
-    let speechRecognizer: string;
-    let idleManager: string;
-    let paymentManager: string;
-    let speechSynthesis: string;
-    let keyboardLock: string;
-    let webOTPService: string;
-    let outstandingNetworkRequestDirectSocket: string;
-    let injectedJavascript: string;
-    let injectedStyleSheet: string;
-    let contentDiscarded: string;
-    let contentSecurityHandler: string;
-    let contentWebAuthenticationAPI: string;
-    let contentFileChooser: string;
-    let contentSerial: string;
-    let contentFileSystemAccess: string;
-    let contentMediaDevicesDispatcherHost: string;
-    let contentWebBluetooth: string;
-    let contentWebUSB: string;
-    let contentMediaSession: string;
-    let contentMediaSessionService: string;
-    let contentMediaPlay: string;
-    let contentScreenReader: string;
-    let embedderPopupBlockerTabHelper: string;
-    let embedderSafeBrowsingTriggeredPopupBlocker: string;
-    let embedderSafeBrowsingThreatDetails: string;
-    let embedderAppBannerManager: string;
-    let embedderDomDistillerViewerSource: string;
-    let embedderDomDistillerSelfDeletingRequestDelegate: string;
-    let embedderOomInterventionTabHelper: string;
-    let embedderOfflinePage: string;
-    let embedderChromePasswordManagerClientBindCredentialManager: string;
-    let embedderPermissionRequestManager: string;
-    let embedderModalDialog: string;
-    let embedderExtensions: string;
-    let embedderExtensionMessaging: string;
-    let embedderExtensionMessagingForOpenPort: string;
-    let embedderExtensionSentMessageToCachedFrame: string;
-    let errorDocument: string;
-    let fencedFramesEmbedder: string;
-    let keepaliveRequest: string;
-    let jsNetworkRequestReceivedCacheControlNoStoreResource: string;
-    let indexedDBEvent: string;
-    let cookieDisabled: string;
-    let webRTCSticky: string;
-    let webTransportSticky: string;
-    let webSocketSticky: string;
-}
 //# sourceMappingURL=bf-cache-strings.d.ts.map

package/core/lib/bf-cache-strings.js

@@ -544,7 +544,7 @@ const UIStrings = {
 
 };
 
-const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn('node_modules/@paulirish/trace_engine/panels/application/components/BackForwardCacheStrings.js', UIStrings);
 
 
 /** @type {Record<string, {name: LH.IcuMessage|string} | undefined>} */
@@ -707,5 +707,4 @@ const NotRestoredReasonDescription = {
 
 export {
   NotRestoredReasonDescription,
-  UIStrings,
 };

package/core/lib/deprecation-description.js

@@ -25,7 +25,8 @@ const UIStrings = {
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
-const deprecationsStr_ = i18n.createIcuMessageFn(import.meta.url, DeprecationUIStrings);
+const deprecationsStr_ = i18n.createIcuMessageFn(
+  'node_modules/@paulirish/trace_engine/generated/Deprecation.js', DeprecationUIStrings);
 
 /**
  * @param {LH.Crdp.Audits.DeprecationIssueDetails} issueDetails

package/core/lib/trace-engine.d.ts

@@ -6,7 +6,6 @@ export type SaneSyntheticLayoutShift = SyntheticLayoutShift & {
 };
 export const TraceProcessor: typeof TraceEngine.Processor.TraceProcessor;
 export const TraceHandlers: typeof TraceEngine.Handlers.ModelHandlers;
-export const RootCauses: typeof TraceEngine.RootCauses.RootCauses.RootCauses;
 export const Insights: typeof TraceEngine.Insights;
 import * as TraceEngine from '@paulirish/trace_engine';
 //# sourceMappingURL=trace-engine.d.ts.map

package/core/lib/trace-engine.js

@@ -9,12 +9,10 @@ polyfillDOMRect();
 
 const TraceProcessor = TraceEngine.Processor.TraceProcessor;
 const TraceHandlers = TraceEngine.Handlers.ModelHandlers;
-const RootCauses = TraceEngine.RootCauses.RootCauses.RootCauses;
 const Insights = TraceEngine.Insights;
 
 export {
   TraceProcessor,
   TraceHandlers,
-  RootCauses,
   Insights,
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.4.0-dev.20250227",
+  "version": "12.4.0-dev.20250301",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -183,7 +183,7 @@
     "webtreemap-cdt": "^3.2.1"
   },
   "dependencies": {
-    "@paulirish/trace_engine": "0.0.44",
+    "@paulirish/trace_engine": "0.0.46",
     "@sentry/node": "^7.0.0",
     "axe-core": "^4.10.2",
     "chrome-launcher": "^1.1.2",