lighthouse 12.1.0 → 12.2.0

package/core/gather/gatherers/seo/font-size.d.ts

@@ -1,5 +1,5 @@
 export default FontSize;
-export type NodeFontData = LH.Artifacts.FontSize['analyzedFailingNodesData'][0];
+export type NodeFontData = LH.Artifacts.FontSize["analyzedFailingNodesData"][0];
 export type BackendIdsToFontData = Map<number, {
     fontSize: number;
     textLength: number;
@@ -22,24 +22,24 @@ declare class FontSize extends BaseGatherer {
                     backendNodeId: number;
                     attributes: string[];
                     nodeName: string;
-                } | undefined;
+                };
             };
             cssRule?: {
-                type: "Inline" | "Regular" | "Attributes";
+                type: "Regular" | "Inline" | "Attributes";
                 range?: {
                     startLine: number;
                     startColumn: number;
-                } | undefined;
+                };
                 parentRule?: {
                     origin: import("devtools-protocol").Protocol.CSS.StyleSheetOrigin;
                     selectors: {
                         text: string;
                     }[];
-                } | undefined;
-                styleSheetId?: string | undefined;
-                stylesheet?: import("devtools-protocol").Protocol.CSS.CSSStyleSheetHeader | undefined;
-                cssProperties?: import("devtools-protocol").Protocol.CSS.CSSProperty[] | undefined;
-            } | undefined;
+                };
+                styleSheetId?: string;
+                stylesheet?: import("devtools-protocol").Protocol.CSS.CSSStyleSheetHeader;
+                cssProperties?: Array<import("devtools-protocol").Protocol.CSS.CSSProperty>;
+            };
         }[];
         analyzedFailingTextLength: number;
     }>;
@@ -83,24 +83,24 @@ declare class FontSize extends BaseGatherer {
                     backendNodeId: number;
                     attributes: string[];
                     nodeName: string;
-                } | undefined;
+                };
             };
             cssRule?: {
-                type: "Inline" | "Regular" | "Attributes";
+                type: "Regular" | "Inline" | "Attributes";
                 range?: {
                     startLine: number;
                     startColumn: number;
-                } | undefined;
+                };
                 parentRule?: {
                     origin: import("devtools-protocol").Protocol.CSS.StyleSheetOrigin;
                     selectors: {
                         text: string;
                     }[];
-                } | undefined;
-                styleSheetId?: string | undefined;
-                stylesheet?: import("devtools-protocol").Protocol.CSS.CSSStyleSheetHeader | undefined;
-                cssProperties?: import("devtools-protocol").Protocol.CSS.CSSProperty[] | undefined;
-            } | undefined;
+                };
+                styleSheetId?: string;
+                stylesheet?: import("devtools-protocol").Protocol.CSS.CSSStyleSheetHeader;
+                cssProperties?: Array<import("devtools-protocol").Protocol.CSS.CSSProperty>;
+            };
         }[];
     };
     /**
@@ -117,7 +117,7 @@ declare class FontSize extends BaseGatherer {
  * @param {LH.Crdp.CSS.GetMatchedStylesForNodeResponse} matched CSS rules
  * @return {NodeFontData['cssRule']|undefined}
  */
-export function getEffectiveFontRule({ attributesStyle, inlineStyle, matchedCSSRules, inherited }: LH.Crdp.CSS.GetMatchedStylesForNodeResponse): NodeFontData['cssRule'] | undefined;
+export function getEffectiveFontRule({ attributesStyle, inlineStyle, matchedCSSRules, inherited }: LH.Crdp.CSS.GetMatchedStylesForNodeResponse): NodeFontData["cssRule"] | undefined;
 /**
  * Finds the most specific directly matched CSS font-size rule from the list.
  *
@@ -125,6 +125,6 @@ export function getEffectiveFontRule({ attributesStyle, inlineStyle, matchedCSSR
  * @param {function(LH.Crdp.CSS.CSSStyle):boolean|string|undefined} isDeclarationOfInterest
  * @return {NodeFontData['cssRule']|undefined}
  */
-export function findMostSpecificMatchedCSSRule(matchedCSSRules: import("devtools-protocol").Protocol.CSS.RuleMatch[] | undefined, isDeclarationOfInterest: (arg0: LH.Crdp.CSS.CSSStyle) => boolean | string | undefined): NodeFontData['cssRule'] | undefined;
+export function findMostSpecificMatchedCSSRule(matchedCSSRules: Array<LH.Crdp.CSS.RuleMatch> | undefined, isDeclarationOfInterest: (arg0: LH.Crdp.CSS.CSSStyle) => boolean | string | undefined): NodeFontData["cssRule"] | undefined;
 import BaseGatherer from '../../base-gatherer.js';
 //# sourceMappingURL=font-size.d.ts.map

package/core/gather/gatherers/seo/robots-txt.d.ts

@@ -4,7 +4,7 @@ declare class RobotsTxt extends BaseGatherer {
      * @param {LH.Gatherer.Context} passContext
      * @return {Promise<LH.Artifacts['RobotsTxt']>}
      */
-    getArtifact(passContext: LH.Gatherer.Context): Promise<LH.Artifacts['RobotsTxt']>;
+    getArtifact(passContext: LH.Gatherer.Context): Promise<LH.Artifacts["RobotsTxt"]>;
 }
 import BaseGatherer from '../../base-gatherer.js';
 //# sourceMappingURL=robots-txt.d.ts.map

package/core/gather/gatherers/source-maps.d.ts

@@ -4,7 +4,7 @@ export default SourceMaps;
  */
 declare class SourceMaps extends BaseGatherer {
     /** @type {LH.Gatherer.GathererMeta<'Scripts'>} */
-    meta: LH.Gatherer.GathererMeta<'Scripts'>;
+    meta: LH.Gatherer.GathererMeta<"Scripts">;
     /**
      * @param {LH.Gatherer.Driver} driver
      * @param {string} sourceMapUrl
@@ -32,7 +32,7 @@ declare class SourceMaps extends BaseGatherer {
      * @param {LH.Gatherer.Context<'Scripts'>} context
      * @return {Promise<LH.Artifacts['SourceMaps']>}
      */
-    getArtifact(context: LH.Gatherer.Context<'Scripts'>): Promise<LH.Artifacts['SourceMaps']>;
+    getArtifact(context: LH.Gatherer.Context<"Scripts">): Promise<LH.Artifacts["SourceMaps"]>;
 }
 import BaseGatherer from '../base-gatherer.js';
 //# sourceMappingURL=source-maps.d.ts.map

package/core/gather/gatherers/stacks.d.ts

@@ -27,12 +27,12 @@ declare class Stacks extends BaseGatherer implements LH.Gatherer.GathererInstanc
      * @param {LH.Gatherer.Driver['executionContext']} executionContext
      * @return {Promise<LH.Artifacts['Stacks']>}
      */
-    static collectStacks(executionContext: LH.Gatherer.Driver['executionContext']): Promise<LH.Artifacts['Stacks']>;
+    static collectStacks(executionContext: LH.Gatherer.Driver["executionContext"]): Promise<LH.Artifacts["Stacks"]>;
     /**
      * @param {LH.Gatherer.Context} context
      * @return {Promise<LH.Artifacts['Stacks']>}
      */
-    getArtifact(context: LH.Gatherer.Context): Promise<LH.Artifacts['Stacks']>;
+    getArtifact(context: LH.Gatherer.Context): Promise<LH.Artifacts["Stacks"]>;
 }
 import BaseGatherer from '../base-gatherer.js';
 //# sourceMappingURL=stacks.d.ts.map

package/core/gather/gatherers/stylesheets.d.ts

@@ -8,19 +8,11 @@ declare class Stylesheets extends BaseGatherer {
      * @param {LH.Crdp.CSS.StyleSheetAddedEvent} event
      */
     _onStylesheetAdded(event: LH.Crdp.CSS.StyleSheetAddedEvent): void;
-    /**
-     * @param {LH.Gatherer.Context} context
-     */
-    startInstrumentation(context: LH.Gatherer.Context): Promise<void>;
-    /**
-     * @param {LH.Gatherer.Context} context
-     */
-    stopInstrumentation(context: LH.Gatherer.Context): Promise<void>;
     /**
      * @param {LH.Gatherer.Context} context
      * @return {Promise<LH.Artifacts['Stylesheets']>}
      */
-    getArtifact(context: LH.Gatherer.Context): Promise<LH.Artifacts['Stylesheets']>;
+    getArtifact(context: LH.Gatherer.Context): Promise<LH.Artifacts["Stylesheets"]>;
 }
 import BaseGatherer from '../base-gatherer.js';
 //# sourceMappingURL=stylesheets.d.ts.map

package/core/gather/gatherers/stylesheets.js

@@ -60,63 +60,32 @@ class Stylesheets extends BaseGatherer {
 
   /**
    * @param {LH.Gatherer.Context} context
+   * @return {Promise<LH.Artifacts['Stylesheets']>}
    */
-  async startInstrumentation(context) {
+  async getArtifact(context) {
+    const executionContext = context.driver.executionContext;
     const session = context.driver.defaultSession;
     this._session = session;
 
-    // Calling `CSS.enable` will emit events for stylesheets currently on the page.
-    // We want to ignore these events in navigation mode because they are not relevant to the
-    // navigation that is about to happen. Adding the event listener *after* calling `CSS.enable`
-    // ensures that the events for pre-existing stylesheets are ignored.
-    const isNavigation = context.gatherMode === 'navigation';
-    if (!isNavigation) {
-      session.on('CSS.styleSheetAdded', this._onStylesheetAdded);
-    }
+    session.on('CSS.styleSheetAdded', this._onStylesheetAdded);
 
     await session.sendCommand('DOM.enable');
     await session.sendCommand('CSS.enable');
 
-    if (isNavigation) {
-      session.on('CSS.styleSheetAdded', this._onStylesheetAdded);
-    }
-  }
-
+    // Force style to recompute.
+    // Doesn't appear to be necessary in newer versions of Chrome.
+    await executionContext.evaluateAsync('getComputedStyle(document.body)');
 
-  /**
-   * @param {LH.Gatherer.Context} context
-   */
-  async stopInstrumentation(context) {
-    const session = context.driver.defaultSession;
     session.off('CSS.styleSheetAdded', this._onStylesheetAdded);
 
     // Ensure we finish fetching all stylesheet contents before disabling the CSS domain
-    await Promise.all(this._sheetPromises.values());
+    const sheets = await Promise.all(this._sheetPromises.values());
 
     await session.sendCommand('CSS.disable');
     await session.sendCommand('DOM.disable');
-  }
-
-  /**
-   * @param {LH.Gatherer.Context} context
-   * @return {Promise<LH.Artifacts['Stylesheets']>}
-   */
-  async getArtifact(context) {
-    const executionContext = context.driver.executionContext;
-
-    if (context.gatherMode === 'snapshot') {
-      await this.startInstrumentation(context);
-
-      // Force style to recompute.
-      // Doesn't appear to be necessary in newer versions of Chrome.
-      await executionContext.evaluateAsync('getComputedStyle(document.body)');
-
-      await this.stopInstrumentation(context);
-    }
 
     /** @type {Map<string, LH.Artifacts.CSSStyleSheetInfo>} */
     const dedupedStylesheets = new Map();
-    const sheets = await Promise.all(this._sheetPromises.values());
 
     for (const sheet of sheets) {
       // Erroneous sheets will be reported via sentry and the log.

package/core/gather/gatherers/trace-compat.d.ts

@@ -1,13 +1,13 @@
 export default TraceCompat;
 /** @implements {LH.Gatherer.GathererInstance<'Trace'>} */
-declare class TraceCompat extends BaseGatherer implements LH.Gatherer.GathererInstance<'Trace'> {
+declare class TraceCompat extends BaseGatherer implements LH.Gatherer.GathererInstance<"Trace"> {
     /** @type {LH.Gatherer.GathererMeta<'Trace'>} */
-    meta: LH.Gatherer.GathererMeta<'Trace'>;
+    meta: LH.Gatherer.GathererMeta<"Trace">;
     /**
      * @param {LH.Gatherer.Context<'Trace'>} passContext
      * @return {Promise<LH.Artifacts['traces']>}
      */
-    getArtifact(passContext: LH.Gatherer.Context<'Trace'>): Promise<LH.Artifacts['traces']>;
+    getArtifact(passContext: LH.Gatherer.Context<"Trace">): Promise<LH.Artifacts["traces"]>;
 }
 import BaseGatherer from '../base-gatherer.js';
 //# sourceMappingURL=trace-compat.d.ts.map

package/core/gather/gatherers/trace-elements.d.ts

@@ -18,7 +18,7 @@ declare class TraceElements extends BaseGatherer {
      * @param {import('../../lib/trace-engine.js').SaneSyntheticLayoutShift} event Only for debugging
      * @return {number|undefined}
      */
-    static getBiggestImpactNodeForShiftEvent(impactedNodes: LH.Artifacts.TraceImpactedNode[], impactByNodeId: Map<number, number>, event: import('../../lib/trace-engine.js').SaneSyntheticLayoutShift): number | undefined;
+    static getBiggestImpactNodeForShiftEvent(impactedNodes: LH.Artifacts.TraceImpactedNode[], impactByNodeId: Map<number, number>, event: import("../../lib/trace-engine.js").SaneSyntheticLayoutShift): number | undefined;
     /**
      * This function finds the top (up to 15) layout shifts on the page, and returns
      * the id of the largest impacted node of each shift, along with any related nodes
@@ -30,7 +30,7 @@ declare class TraceElements extends BaseGatherer {
      * @param {LH.Gatherer.Context} context
      * @return {Promise<Array<{nodeId: number}>>}
      */
-    static getTopLayoutShifts(trace: LH.Trace, traceEngineResult: LH.Artifacts.TraceEngineResult['data'], rootCauses: LH.Artifacts.TraceEngineRootCauses, context: LH.Gatherer.Context): Promise<Array<{
+    static getTopLayoutShifts(trace: LH.Trace, traceEngineResult: LH.Artifacts.TraceEngineResult["data"], rootCauses: LH.Artifacts.TraceEngineRootCauses, context: LH.Gatherer.Context): Promise<Array<{
         nodeId: number;
     }>>;
     /**
@@ -49,7 +49,7 @@ declare class TraceElements extends BaseGatherer {
         type: string;
     } | undefined>;
     /** @type {LH.Gatherer.GathererMeta<'Trace'|'RootCauses'>} */
-    meta: LH.Gatherer.GathererMeta<'Trace' | 'RootCauses'>;
+    meta: LH.Gatherer.GathererMeta<"Trace" | "RootCauses">;
     /** @type {Map<string, string>} */
     animationIdToName: Map<string, string>;
     /** @param {LH.Crdp.Animation.AnimationStartedEvent} args */
@@ -77,9 +77,7 @@ declare class TraceElements extends BaseGatherer {
      * @param {LH.Gatherer.Context<'Trace'|'RootCauses'>} context
      * @return {Promise<LH.Artifacts.TraceElement[]>}
      */
-    getArtifact(context: LH.Gatherer.Context<'Trace' | 'RootCauses'>): Promise<LH.Artifacts.TraceElement[]>;
+    getArtifact(context: LH.Gatherer.Context<"Trace" | "RootCauses">): Promise<LH.Artifacts.TraceElement[]>;
 }
 import BaseGatherer from '../base-gatherer.js';
-import Trace from './trace.js';
-import { TraceEngineResult } from '../../computed/trace-engine-result.js';
 //# sourceMappingURL=trace-elements.d.ts.map

package/core/gather/navigation-runner.d.ts

@@ -6,7 +6,7 @@ export type NavigationContext = {
     baseArtifacts: LH.BaseArtifacts;
     computedCache: Map<string, LH.ArbitraryEqualityMap>;
 };
-export type PhaseState = Omit<Parameters<typeof collectPhaseArtifacts>[0], 'phase'>;
+export type PhaseState = Omit<Parameters<typeof collectPhaseArtifacts>[0], "phase">;
 /**
  * @param {LH.Puppeteer.Page|undefined} page
  * @param {LH.NavigationRequestor|undefined} requestor
@@ -14,8 +14,8 @@ export type PhaseState = Omit<Parameters<typeof collectPhaseArtifacts>[0], 'phas
  * @return {Promise<LH.Gatherer.GatherResult>}
  */
 export function navigationGather(page: LH.Puppeteer.Page | undefined, requestor: LH.NavigationRequestor | undefined, options?: {
-    config?: import("../../types/config.js").default | undefined;
-    flags?: import("../index.js").Flags | undefined;
+    config?: LH.Config;
+    flags?: LH.Flags;
 } | undefined): Promise<LH.Gatherer.GatherResult>;
 /**
  * @param {{driver: Driver, resolvedConfig: LH.Config.ResolvedConfig, requestor: LH.NavigationRequestor}} args
@@ -54,7 +54,6 @@ export function _cleanup({ requestedUrl, driver, resolvedConfig, lhBrowser, lhPa
 }): Promise<void>;
 import { Driver } from './driver.js';
 import { collectPhaseArtifacts } from './runner-helpers.js';
-import { LighthouseError } from '../lib/lh-error.js';
 /**
  * @param {NavigationContext} navigationContext
  * @param {PhaseState} phaseState

package/core/gather/runner-helpers.d.ts

@@ -1,5 +1,5 @@
 export type CollectPhaseArtifactOptions = {
-    driver: import('./driver.js').Driver;
+    driver: import("./driver.js").Driver;
     page: LH.Puppeteer.Page;
     artifactDefinitions: Array<LH.Config.AnyArtifactDefn>;
     artifactState: ArtifactState;
@@ -10,8 +10,8 @@ export type CollectPhaseArtifactOptions = {
     settings: LH.Config.Settings;
 };
 export type IntermediateArtifacts = Record<string, Promise<any>>;
-export type ArtifactState = Record<CollectPhaseArtifactOptions['phase'], IntermediateArtifacts>;
-export type Dependencies = LH.Gatherer.Context<LH.Gatherer.DependencyKey>['dependencies'];
+export type ArtifactState = Record<CollectPhaseArtifactOptions["phase"], IntermediateArtifacts>;
+export type Dependencies = LH.Gatherer.Context<LH.Gatherer.DependencyKey>["dependencies"];
 /** @return {ArtifactState} */
 export function getEmptyArtifactState(): ArtifactState;
 /**

package/core/gather/session.d.ts

@@ -6,7 +6,7 @@ export class ProtocolSession extends ProtocolSession_base implements LH.Gatherer
      * @param {LH.Puppeteer.CDPSession} cdpSession
      */
     constructor(cdpSession: LH.Puppeteer.CDPSession);
-    _cdpSession: import("../../types/puppeteer.js").default.CDPSession;
+    _cdpSession: import("../index.js").Puppeteer.CDPSession;
     /** @type {LH.Crdp.Target.TargetInfo|undefined} */
     _targetInfo: LH.Crdp.Target.TargetInfo | undefined;
     /** @type {number|undefined} */
@@ -17,7 +17,7 @@ export class ProtocolSession extends ProtocolSession_base implements LH.Gatherer
      * @param {E} method
      * @param {LH.CrdpEvents[E]} params
      */
-    _handleProtocolEvent<E extends keyof import("devtools-protocol/types/protocol-mapping.js").ProtocolMapping.Events>(method: E, ...params: import("devtools-protocol/types/protocol-mapping.js").ProtocolMapping.Events[E]): void;
+    _handleProtocolEvent<E extends keyof LH.CrdpEvents>(method: E, ...params: LH.CrdpEvents[E]): void;
     _targetCrashedPromise: Promise<never>;
     id(): string;
     /** @param {LH.Crdp.Target.TargetInfo} targetInfo */
@@ -40,7 +40,7 @@ export class ProtocolSession extends ProtocolSession_base implements LH.Gatherer
      * @param {LH.CrdpCommands[C]['paramsType']} params
      * @return {Promise<LH.CrdpCommands[C]['returnType']>}
      */
-    sendCommand<C extends keyof import("devtools-protocol/types/protocol-mapping.js").ProtocolMapping.Commands>(method: C, ...params: import("devtools-protocol/types/protocol-mapping.js").ProtocolMapping.Commands[C]["paramsType"]): Promise<import("devtools-protocol/types/protocol-mapping.js").ProtocolMapping.Commands[C]["returnType"]>;
+    sendCommand<C extends keyof LH.CrdpCommands>(method: C, ...params: LH.CrdpCommands[C]["paramsType"]): Promise<LH.CrdpCommands[C]["returnType"]>;
     /**
      * Send and if there's an error response, do not reject.
      * @template {keyof LH.CrdpCommands} C
@@ -48,7 +48,7 @@ export class ProtocolSession extends ProtocolSession_base implements LH.Gatherer
      * @param {LH.CrdpCommands[C]['paramsType']} params
      * @return {Promise<void>}
      */
-    sendCommandAndIgnore<C_1 extends keyof import("devtools-protocol/types/protocol-mapping.js").ProtocolMapping.Commands>(method: C_1, ...params: import("devtools-protocol/types/protocol-mapping.js").ProtocolMapping.Commands[C_1]["paramsType"]): Promise<void>;
+    sendCommandAndIgnore<C extends keyof LH.CrdpCommands>(method: C, ...params: LH.CrdpCommands[C]["paramsType"]): Promise<void>;
     /**
      * Disposes of a session so that it can no longer talk to Chrome.
      * @return {Promise<void>}

package/core/gather/session.js

@@ -113,7 +113,7 @@ class ProtocolSession extends CrdpEventEmitter {
     const timeoutMs = this.getNextProtocolTimeout();
     this._nextProtocolTimeout = undefined;
 
-    /** @type {NodeJS.Timer|undefined} */
+    /** @type {NodeJS.Timeout|undefined} */
     let timeout;
     const timeoutPromise = new Promise((resolve, reject) => {
       // Unexpected setTimeout invocation to preserve the error stack. https://github.com/GoogleChrome/lighthouse/issues/13332

package/core/gather/snapshot-runner.d.ts

@@ -4,7 +4,7 @@
  * @return {Promise<LH.Gatherer.GatherResult>}
  */
 export function snapshotGather(page: LH.Puppeteer.Page, options?: {
-    config?: import("../../types/config.js").default | undefined;
-    flags?: import("../index.js").Flags | undefined;
+    config?: LH.Config;
+    flags?: LH.Flags;
 } | undefined): Promise<LH.Gatherer.GatherResult>;
 //# sourceMappingURL=snapshot-runner.d.ts.map

package/core/gather/timespan-runner.d.ts

@@ -4,12 +4,12 @@
  * @return {Promise<{endTimespanGather(): Promise<LH.Gatherer.GatherResult>}>}
  */
 export function startTimespanGather(page: LH.Puppeteer.Page, options?: {
-    config?: import("../../types/config.js").default | undefined;
-    flags?: import("../index.js").Flags | undefined;
+    config?: LH.Config;
+    flags?: LH.Flags;
 } | undefined): Promise<{
     endTimespanGather(): Promise<LH.Gatherer.GatherResult>;
 }>;
 export namespace UIStrings {
-    const warningNavigationDetected: string;
+    let warningNavigationDetected: string;
 }
 //# sourceMappingURL=timespan-runner.d.ts.map

package/core/index.d.cts

@@ -7,11 +7,5 @@ export = lighthouse;
  * @property {import('./index.js')['snapshot']} snapshot
  */
 /** @type {import('./index.js')['default'] & ExportType} */
-declare const lighthouse: typeof import("./index.js")['default'] & ExportType;
-type ExportType = {
-    startFlow: typeof import("./index.js")['startFlow'];
-    navigation: typeof import("./index.js")['navigation'];
-    startTimespan: typeof import("./index.js")['startTimespan'];
-    snapshot: typeof import("./index.js")['snapshot'];
-};
+declare const lighthouse: typeof import("./index.js")["default"] & ExportType;
 //# sourceMappingURL=index.d.cts.map

package/core/index.d.ts

@@ -28,8 +28,8 @@ export function startFlow(page: LH.Puppeteer.Page, options?: LH.UserFlow.Options
  * @return {Promise<LH.RunnerResult|undefined>}
  */
 export function navigation(page: LH.Puppeteer.Page | undefined, requestor: LH.NavigationRequestor | undefined, options?: {
-    config?: LH.Config | undefined;
-    flags?: LH.Flags | undefined;
+    config?: LH.Config;
+    flags?: LH.Flags;
 } | undefined): Promise<LH.RunnerResult | undefined>;
 /**
  * @param {LH.Puppeteer.Page} page
@@ -37,8 +37,8 @@ export function navigation(page: LH.Puppeteer.Page | undefined, requestor: LH.Na
  * @return {Promise<{endTimespan: () => Promise<LH.RunnerResult|undefined>}>}
  */
 export function startTimespan(page: LH.Puppeteer.Page, options?: {
-    config?: LH.Config | undefined;
-    flags?: LH.Flags | undefined;
+    config?: LH.Config;
+    flags?: LH.Flags;
 } | undefined): Promise<{
     endTimespan: () => Promise<LH.RunnerResult | undefined>;
 }>;
@@ -48,8 +48,8 @@ export function startTimespan(page: LH.Puppeteer.Page, options?: {
  * @return {Promise<LH.RunnerResult|undefined>}
  */
 export function snapshot(page: LH.Puppeteer.Page, options?: {
-    config?: LH.Config | undefined;
-    flags?: LH.Flags | undefined;
+    config?: LH.Config;
+    flags?: LH.Flags;
 } | undefined): Promise<LH.RunnerResult | undefined>;
 /**
  * @template {LH.Result|LH.FlowResult} R

package/core/lib/arbitrary-equality-map.d.ts

@@ -15,10 +15,10 @@ export class ArbitraryEqualityMap {
     static deepEquals(objA: any, objB: any): boolean;
     _equalsFn: typeof ArbitraryEqualityMap.deepEquals;
     /** @type {Array<{key: *, value: *}>} */
-    _entries: {
+    _entries: Array<{
         key: any;
         value: any;
-    }[];
+    }>;
     /**
      * @param {function(*,*):boolean} equalsFn
      */

package/core/lib/asset-saver.d.ts

@@ -54,7 +54,7 @@ export function loadFlowArtifacts(basePath: string): LH.UserFlow.FlowArtifacts;
  * @param {string} pathWithBasename
  * @return {Promise<void>}
  */
-export function saveAssets(artifacts: LH.Artifacts, audits: LH.Result['audits'], pathWithBasename: string): Promise<void>;
+export function saveAssets(artifacts: LH.Artifacts, audits: LH.Result["audits"], pathWithBasename: string): Promise<void>;
 /**
  * @param {LH.Artifacts} artifacts
  * @param {LH.Result['audits']} [audits]
@@ -78,7 +78,7 @@ export function saveTrace(traceData: LH.Trace, traceFilename: string, options?:
  * @param {{gzip?: boolean}=} options
  * @return {Promise<void>}
  */
-export function saveDevtoolsLog(devtoolsLog: import("../index.js").DevtoolsLog, devtoolLogFilename: string, options?: {
+export function saveDevtoolsLog(devtoolsLog: LH.DevtoolsLog, devtoolLogFilename: string, options?: {
     gzip?: boolean;
 } | undefined): Promise<void>;
 /**
@@ -86,7 +86,7 @@ export function saveDevtoolsLog(devtoolsLog: import("../index.js").DevtoolsLog,
  * @param {string} outputPath
  * @return {Promise<void>}
  */
-export function saveLanternNetworkData(devtoolsLog: import("../index.js").DevtoolsLog, outputPath: string): Promise<void>;
+export function saveLanternNetworkData(devtoolsLog: LH.DevtoolsLog, outputPath: string): Promise<void>;
 /**
  * A replacer function for JSON.stingify of the artifacts. Used to serialize objects that
  * JSON won't normally handle.

package/core/lib/asset-saver.js

@@ -449,7 +449,7 @@ function saveDevtoolsLog(devtoolsLog, devtoolLogFilename, options = {}) {
 async function saveLanternDebugTraces(pathWithBasename) {
   if (!process.env.LANTERN_DEBUG) return;
 
-  for (const [label, nodeTimings] of Lantern.Simulation.Simulator.ALL_NODE_TIMINGS) {
+  for (const [label, nodeTimings] of Lantern.Simulation.Simulator.allNodeTimings) {
     if (lanternTraceSaver.simulationNamesToIgnore.includes(label)) continue;
 
     const traceFilename = `${pathWithBasename}-${label}${traceSuffix}`;