lighthouse 12.0.0-dev.20240605 → 12.0.0-dev.20240606

package/core/audits/metrics/interactive.d.ts

@@ -1,7 +1,7 @@
 export default InteractiveMetric;
 /**
  * @fileoverview This audit identifies the time the page is "consistently interactive".
- * Looks for the first period of at least 5 seconds after FMP where both CPU and network were quiet,
+ * Looks for the first period of at least 5 seconds after FCP where both CPU and network were quiet,
  * and returns the timestamp of the beginning of the CPU quiet period.
  * @see https://docs.google.com/document/d/1GGiI9-7KeY3TPqS3YT271upUVimo-XiL5mwWorDUD4c/edit#
  */

package/core/audits/metrics/interactive.js

@@ -18,7 +18,7 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @fileoverview This audit identifies the time the page is "consistently interactive".
- * Looks for the first period of at least 5 seconds after FMP where both CPU and network were quiet,
+ * Looks for the first period of at least 5 seconds after FCP where both CPU and network were quiet,
  * and returns the timestamp of the beginning of the CPU quiet period.
  * @see https://docs.google.com/document/d/1GGiI9-7KeY3TPqS3YT271upUVimo-XiL5mwWorDUD4c/edit#
  */

package/core/computed/metrics/lantern-interactive.js

@@ -5,7 +5,7 @@
  */
 
 import {makeComputedArtifact} from '../computed-artifact.js';
-import {LanternFirstMeaningfulPaint} from './lantern-first-meaningful-paint.js';
+import {LanternLargestContentfulPaint} from './lantern-largest-contentful-paint.js';
 import {Interactive} from '../../lib/lantern/metrics/interactive.js';
 import {getComputationDataParams, lanternErrorAdapter} from './lantern-metric.js';
 
@@ -29,8 +29,8 @@ class LanternInteractive extends Interactive {
    * @return {Promise<LH.Artifacts.LanternMetric>}
    */
   static async compute_(data, context) {
-    const fmpResult = await LanternFirstMeaningfulPaint.request(data, context);
-    return this.computeMetricWithGraphs(data, context, {fmpResult});
+    const lcpResult = await LanternLargestContentfulPaint.request(data, context);
+    return this.computeMetricWithGraphs(data, context, {lcpResult});
   }
 }
 

package/core/lib/lantern/metric.d.ts

@@ -4,7 +4,7 @@ export type Simulator = import('./simulator/simulator.js').Simulator;
 export type Extras = {
     optimistic: boolean;
     fcpResult?: LH.Artifacts.LanternMetric | undefined;
-    fmpResult?: LH.Artifacts.LanternMetric | undefined;
+    lcpResult?: LH.Artifacts.LanternMetric | undefined;
     interactiveResult?: LH.Artifacts.LanternMetric | undefined;
     speedline?: {
         speedIndex: number;
@@ -17,7 +17,7 @@ export type Extras = {
  * @typedef Extras
  * @property {boolean} optimistic
  * @property {LH.Artifacts.LanternMetric=} fcpResult
- * @property {LH.Artifacts.LanternMetric=} fmpResult
+ * @property {LH.Artifacts.LanternMetric=} lcpResult
  * @property {LH.Artifacts.LanternMetric=} interactiveResult
  * @property {{speedIndex: number}=} speedline
  */

package/core/lib/lantern/metric.js

@@ -16,7 +16,7 @@ import {RESOURCE_TYPES} from '../../lib/network-request.js';
  * @typedef Extras
  * @property {boolean} optimistic
  * @property {LH.Artifacts.LanternMetric=} fcpResult
- * @property {LH.Artifacts.LanternMetric=} fmpResult
+ * @property {LH.Artifacts.LanternMetric=} lcpResult
  * @property {LH.Artifacts.LanternMetric=} interactiveResult
  * @property {{speedIndex: number}=} speedline
  */

package/core/lib/lantern/metrics/interactive.js

@@ -66,12 +66,12 @@ class Interactive extends Metric {
    * @return {LH.Gatherer.Simulation.Result}
    */
   static getEstimateFromSimulation(simulationResult, extras) {
-    if (!extras.fmpResult) throw new Error('missing fmpResult');
+    if (!extras.lcpResult) throw new Error('missing lcpResult');
 
     const lastTaskAt = Interactive.getLastLongTaskEndTime(simulationResult.nodeTimings);
     const minimumTime = extras.optimistic
-      ? extras.fmpResult.optimisticEstimate.timeInMs
-      : extras.fmpResult.pessimisticEstimate.timeInMs;
+      ? extras.lcpResult.optimisticEstimate.timeInMs
+      : extras.lcpResult.pessimisticEstimate.timeInMs;
     return {
       timeInMs: Math.max(minimumTime, lastTaskAt),
       nodeTimings: simulationResult.nodeTimings,
@@ -84,13 +84,13 @@ class Interactive extends Metric {
    * @return {Promise<LH.Artifacts.LanternMetric>}
    */
   static async compute(data, extras) {
-    const fmpResult = extras?.fmpResult;
-    if (!fmpResult) {
-      throw new Error('FMP is required to calculate the Interactive metric');
+    const lcpResult = extras?.lcpResult;
+    if (!lcpResult) {
+      throw new Error('LCP is required to calculate the Interactive metric');
     }
 
     const metricResult = await super.compute(data, extras);
-    metricResult.timing = Math.max(metricResult.timing, fmpResult.timing);
+    metricResult.timing = Math.max(metricResult.timing, lcpResult.timing);
     return metricResult;
   }
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.0.0-dev.20240605",
+  "version": "12.0.0-dev.20240606",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {