lighthouse 11.7.0 → 12.0.0-dev.20240422

package/core/computed/trace-engine-result.js

@@ -8,6 +8,20 @@ import * as TraceEngine from '../lib/trace-engine.js';
 import {makeComputedArtifact} from './computed-artifact.js';
 import {CumulativeLayoutShift} from './metrics/cumulative-layout-shift.js';
 import {ProcessedTrace} from './processed-trace.js';
+import * as LH from '../../types/lh.js';
+
+/** @typedef {typeof ENABLED_HANDLERS} EnabledHandlers */
+
+const ENABLED_HANDLERS = {
+  AuctionWorklets: TraceEngine.TraceHandlers.AuctionWorklets,
+  Initiators: TraceEngine.TraceHandlers.Initiators,
+  LayoutShifts: TraceEngine.TraceHandlers.LayoutShifts,
+  NetworkRequests: TraceEngine.TraceHandlers.NetworkRequests,
+  Renderer: TraceEngine.TraceHandlers.Renderer,
+  Samples: TraceEngine.TraceHandlers.Samples,
+  Screenshots: TraceEngine.TraceHandlers.Screenshots,
+  PageLoadMetrics: TraceEngine.TraceHandlers.PageLoadMetrics,
+};
 
 /**
  * @fileoverview Processes trace with the shared trace engine.
@@ -15,24 +29,18 @@ import {ProcessedTrace} from './processed-trace.js';
 class TraceEngineResult {
   /**
    * @param {LH.TraceEvent[]} traceEvents
+   * @return {Promise<LH.Artifacts.TraceEngineResult>}
    */
   static async runTraceEngine(traceEvents) {
-    const engine = new TraceEngine.TraceProcessor({
-      AuctionWorklets: TraceEngine.TraceHandlers.AuctionWorklets,
-      Initiators: TraceEngine.TraceHandlers.Initiators,
-      LayoutShifts: TraceEngine.TraceHandlers.LayoutShifts,
-      NetworkRequests: TraceEngine.TraceHandlers.NetworkRequests,
-      Renderer: TraceEngine.TraceHandlers.Renderer,
-      Samples: TraceEngine.TraceHandlers.Samples,
-      Screenshots: TraceEngine.TraceHandlers.Screenshots,
-    });
+    const engine = new TraceEngine.TraceProcessor(ENABLED_HANDLERS);
     // eslint-disable-next-line max-len
     await engine.parse(/** @type {import('@paulirish/trace_engine').Types.TraceEvents.TraceEventData[]} */ (
       traceEvents
     ));
     // TODO: use TraceEngine.TraceProcessor.createWithAllHandlers above.
-    return /** @type {import('@paulirish/trace_engine').Handlers.Types.TraceParseData} */(
-      engine.data);
+    if (!engine.traceParsedData) throw new Error('No data');
+    if (!engine.insights) throw new Error('No insights');
+    return {data: engine.traceParsedData, insights: engine.insights};
   }
 
   /**
@@ -67,9 +75,6 @@ class TraceEngineResult {
     }
 
     const result = await TraceEngineResult.runTraceEngine(traceEvents);
-    if (!result) {
-      throw new Error('null trace engine result');
-    }
     return result;
   }
 }

package/core/computed/unused-css.d.ts

@@ -5,6 +5,7 @@ export type StyleSheetInfo = LH.Artifacts.CSSStyleSheetInfo & {
 };
 declare const UnusedCSSComputed: typeof UnusedCSS & {
     request: (dependencies: {
+        Stylesheets: LH.Artifacts['Stylesheets'];
         CSSUsage: LH.Artifacts['CSSUsage'];
         devtoolsLog: import("../index.js").DevtoolsLog;
     }, context: import("../../types/utility-types.js").default.ImmutableObject<{
@@ -50,11 +51,12 @@ declare class UnusedCSS {
      */
     static mapSheetToResult(stylesheetInfo: StyleSheetInfo): LH.Audit.ByteEfficiencyItem;
     /**
-     * @param {{CSSUsage: LH.Artifacts['CSSUsage'], devtoolsLog: LH.DevtoolsLog}} data
+     * @param {{Stylesheets: LH.Artifacts['Stylesheets'], CSSUsage: LH.Artifacts['CSSUsage'], devtoolsLog: LH.DevtoolsLog}} data
      * @param {LH.Artifacts.ComputedContext} context
      * @return {Promise<LH.Audit.ByteEfficiencyItem[]>}
     */
     static compute_(data: {
+        Stylesheets: LH.Artifacts['Stylesheets'];
         CSSUsage: LH.Artifacts['CSSUsage'];
         devtoolsLog: import("../index.js").DevtoolsLog;
     }, context: LH.Artifacts.ComputedContext): Promise<LH.Audit.ByteEfficiencyItem[]>;

package/core/computed/unused-css.js

@@ -134,15 +134,15 @@ class UnusedCSS {
   }
 
   /**
-   * @param {{CSSUsage: LH.Artifacts['CSSUsage'], devtoolsLog: LH.DevtoolsLog}} data
+   * @param {{Stylesheets: LH.Artifacts['Stylesheets'], CSSUsage: LH.Artifacts['CSSUsage'], devtoolsLog: LH.DevtoolsLog}} data
    * @param {LH.Artifacts.ComputedContext} context
    * @return {Promise<LH.Audit.ByteEfficiencyItem[]>}
   */
   static async compute_(data, context) {
-    const {CSSUsage, devtoolsLog} = data;
+    const {CSSUsage, Stylesheets, devtoolsLog} = data;
     const networkRecords = await NetworkRecords.request(devtoolsLog, context);
-    const indexedSheets = UnusedCSS.indexStylesheetsById(CSSUsage.stylesheets, networkRecords);
-    UnusedCSS.indexUsedRules(CSSUsage.rules, indexedSheets);
+    const indexedSheets = UnusedCSS.indexStylesheetsById(Stylesheets, networkRecords);
+    UnusedCSS.indexUsedRules(CSSUsage, indexedSheets);
 
     const items = Object.keys(indexedSheets)
       .map(sheetId => UnusedCSS.mapSheetToResult(indexedSheets[sheetId]));
@@ -150,5 +150,6 @@ class UnusedCSS {
   }
 }
 
-const UnusedCSSComputed = makeComputedArtifact(UnusedCSS, ['CSSUsage', 'devtoolsLog']);
+const UnusedCSSComputed = makeComputedArtifact(UnusedCSS,
+  ['Stylesheets', 'CSSUsage', 'devtoolsLog']);
 export {UnusedCSSComputed as UnusedCSS};

package/core/config/config-helpers.js

@@ -11,7 +11,6 @@ import url from 'url';
 import isDeepEqual from 'lodash/isEqual.js';
 
 import * as constants from './constants.js';
-import {Budget} from './budget.js';
 import ConfigPlugin from './config-plugin.js';
 import {Runner} from '../runner.js';
 import * as i18n from '../lib/i18n/i18n.js';
@@ -347,9 +346,6 @@ function resolveSettings(settingsJson = {}, overrides = undefined) {
     true
   );
 
-  if (settingsWithFlags.budgets) {
-    settingsWithFlags.budgets = Budget.initializeBudget(settingsWithFlags.budgets);
-  }
   // Locale is special and comes only from flags/settings/lookupLocale.
   settingsWithFlags.locale = locale;
 

package/core/config/constants.js

@@ -118,7 +118,6 @@ const defaultSettings = {
 
   // the following settings have no defaults but we still want ensure that `key in settings`
   // in config will work in a typechecked way
-  budgets: null,
   locale: 'en-US', // actual default determined by Config using lib/i18n
   blockedUrlPatterns: null,
   additionalTraceCategories: null,

package/core/config/default-config.js

@@ -9,21 +9,12 @@
 import * as LH from '../../types/lh.js';
 import * as constants from './constants.js';
 import * as i18n from '../lib/i18n/i18n.js';
-import {metricsToAudits} from './metrics-to-audits.js';
 
 const UIStrings = {
   /** Title of the Performance category of audits. Equivalent to 'Web performance', this term is inclusive of all web page speed and loading optimization topics. Also used as a label of a score gauge; try to limit to 20 characters. */
   performanceCategoryTitle: 'Performance',
-  /** Title of the Budgets section of the Performance Category. 'Budgets' refers to a budget (like a financial budget), but applied to the amount of resources on a page, rather than money. */
-  budgetsGroupTitle: 'Budgets',
-  /** Description of the Budgets section of the Performance category. Within this section the budget results are displayed. */
-  budgetsGroupDescription: 'Performance budgets set standards for the performance of your site.',
   /** Title of the speed metrics section of the Performance category. Within this section are various speed metrics which quantify the pageload performance into values presented in seconds and milliseconds. */
   metricGroupTitle: 'Metrics',
-  /** Title of the opportunity section of the Performance category. Within this section are audits with imperative titles that suggest actions the user can take to improve the loading performance of their web page. 'Suggestion'/'Optimization'/'Recommendation' are reasonable synonyms for 'opportunity' in this case. */
-  loadOpportunitiesGroupTitle: 'Opportunities',
-  /** Description of the opportunity section of the Performance category. 'Suggestions' could also be 'recommendations'. Within this section are audits with imperative titles that suggest actions the user can take to improve the loading performance of their web page. */
-  loadOpportunitiesGroupDescription: 'These suggestions can help your page load faster. They don\'t [directly affect](https://developer.chrome.com/docs/lighthouse/performance/performance-scoring/) the Performance score.',
   /** Title of an opportunity sub-section of the Performance category. Within this section are audits with imperative titles that suggest actions the user can take to improve the time of the first initial render of the webpage. */
   firstPaintImprovementsGroupTitle: 'First Paint Improvements',
   /** Description of an opportunity sub-section of the Performance category. Within this section are audits with imperative titles that suggest actions the user can take to improve the time of the first initial render of the webpage. */
@@ -95,15 +86,6 @@ const UIStrings = {
   seoCrawlingGroupTitle: 'Crawling and Indexing',
   /** Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers. */
   seoCrawlingGroupDescription: 'To appear in search results, crawlers need access to your app.',
-  /** Title of the Progressive Web Application (PWA) category of audits. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. Also used as a label of a score gauge. */
-  pwaCategoryTitle: 'PWA',
-  /** Description of the Progressive Web Application (PWA) category. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
-  pwaCategoryDescription: 'These checks validate the aspects of a Progressive Web App. ' +
-  '[Learn what makes a good Progressive Web App](https://web.dev/articles/pwa-checklist).',
-  /** Description of the Progressive Web Application (PWA) manual checks category, containing a list of additional validators must be run by hand in order to check all PWA best practices. This is displayed at the top of a list of manually run audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc.. No character length limits. */
-  pwaCategoryManualDescription: 'These checks are required by the baseline ' +
-  '[PWA Checklist](https://web.dev/articles/pwa-checklist) but are ' +
-  'not automatically checked by Lighthouse. They do not affect your score but it\'s important that you verify them manually.',
   /** Title of the Best Practices category of audits. This is displayed at the top of a list of audits focused on topics related to following web development best practices and accepted guidelines. Also used as a label of a score gauge; try to limit to 20 characters. */
   bestPracticesCategoryTitle: 'Best Practices',
   /** Title of the Trust & Safety group of audits. This is displayed at the top of a list of audits focused on maintaining user trust and protecting security in web development. */
@@ -114,10 +96,6 @@ const UIStrings = {
   bestPracticesBrowserCompatGroupTitle: 'Browser Compatibility',
   /** Title of the General group of the Best Practices category. Within this section are the audits that don't belong to a specific group but are of general interest. */
   bestPracticesGeneralGroupTitle: 'General',
-  /** Title of the Installable section of the web app category. Within this section are audits that check if Chrome supports installing the web site as an app on their device. */
-  pwaInstallableGroupTitle: 'Installable',
-  /** Title of the "PWA Optimized" section of the web app category. Within this section are audits that check if the developer has taken advantage of features to make their web page more enjoyable and engaging for the user. */
-  pwaOptimizedGroupTitle: 'PWA Optimized',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
@@ -138,13 +116,10 @@ const defaultConfig = {
     {id: 'CSSUsage', gatherer: 'css-usage'},
     {id: 'Doctype', gatherer: 'dobetterweb/doctype'},
     {id: 'DOMStats', gatherer: 'dobetterweb/domstats'},
-    {id: 'EmbeddedContent', gatherer: 'seo/embedded-content'},
     {id: 'FontSize', gatherer: 'seo/font-size'},
     {id: 'Inputs', gatherer: 'inputs'},
-    {id: 'GlobalListeners', gatherer: 'global-listeners'},
     {id: 'IFrameElements', gatherer: 'iframe-elements'},
     {id: 'ImageElements', gatherer: 'image-elements'},
-    {id: 'InstallabilityErrors', gatherer: 'installability-errors'},
     {id: 'InspectorIssues', gatherer: 'inspector-issues'},
     {id: 'JsUsage', gatherer: 'js-usage'},
     {id: 'LinkElements', gatherer: 'link-elements'},
@@ -154,16 +129,12 @@ const defaultConfig = {
     {id: 'OptimizedImages', gatherer: 'dobetterweb/optimized-images'},
     {id: 'ResponseCompression', gatherer: 'dobetterweb/response-compression'},
     {id: 'RobotsTxt', gatherer: 'seo/robots-txt'},
-    {id: 'ServiceWorker', gatherer: 'service-worker'},
-    {id: 'ScriptElements', gatherer: 'script-elements'},
     {id: 'Scripts', gatherer: 'scripts'},
     {id: 'SourceMaps', gatherer: 'source-maps'},
     {id: 'Stacks', gatherer: 'stacks'},
-    {id: 'TagsBlockingFirstPaint', gatherer: 'dobetterweb/tags-blocking-first-paint'},
-    {id: 'TapTargets', gatherer: 'seo/tap-targets'},
+    {id: 'Stylesheets', gatherer: 'stylesheets'},
     {id: 'TraceElements', gatherer: 'trace-elements'},
     {id: 'ViewportDimensions', gatherer: 'viewport-dimensions'},
-    {id: 'WebAppManifest', gatherer: 'web-app-manifest'},
 
     // Artifact copies are renamed for compatibility with legacy artifacts.
     {id: 'devtoolsLogs', gatherer: 'devtools-log-compat'},
@@ -177,6 +148,7 @@ const defaultConfig = {
   ],
   audits: [
     'is-on-https',
+    'redirects-http',
     'viewport',
     'metrics/first-contentful-paint',
     'metrics/largest-contentful-paint',
@@ -194,19 +166,12 @@ const defaultConfig = {
     'user-timings',
     'critical-request-chains',
     'redirects',
-    'installable-manifest',
-    'splash-screen',
-    'themed-omnibox',
-    'maskable-icon',
-    'content-width',
     'image-aspect-ratio',
     'image-size-responsive',
-    'preload-fonts',
     'deprecations',
     'third-party-cookies',
     'mainthread-work-breakdown',
     'bootup-time',
-    'uses-rel-preload',
     'uses-rel-preconnect',
     'font-display',
     'diagnostics',
@@ -215,36 +180,32 @@ const defaultConfig = {
     'network-server-latency',
     'main-thread-tasks',
     'metrics',
-    'performance-budget',
-    'timing-budget',
     'resource-summary',
     'third-party-summary',
     'third-party-facades',
     'largest-contentful-paint-element',
     'lcp-lazy-loaded',
-    'layout-shift-elements',
     'layout-shifts',
     'long-tasks',
-    'no-unload-listeners',
     'non-composited-animations',
     'unsized-images',
     'valid-source-maps',
     'prioritize-lcp-image',
     'csp-xss',
     'script-treemap-data',
-    'manual/pwa-cross-browser',
-    'manual/pwa-page-transitions',
-    'manual/pwa-each-page-has-url',
     'accessibility/accesskeys',
     'accessibility/aria-allowed-attr',
     'accessibility/aria-allowed-role',
     'accessibility/aria-command-name',
+    'accessibility/aria-conditional-attr',
+    'accessibility/aria-deprecated-role',
     'accessibility/aria-dialog-name',
     'accessibility/aria-hidden-body',
     'accessibility/aria-hidden-focus',
     'accessibility/aria-input-field-name',
     'accessibility/aria-meter-name',
     'accessibility/aria-progressbar-name',
+    'accessibility/aria-prohibited-attr',
     'accessibility/aria-required-attr',
     'accessibility/aria-required-children',
     'accessibility/aria-required-parent',
@@ -261,7 +222,6 @@ const defaultConfig = {
     'accessibility/definition-list',
     'accessibility/dlitem',
     'accessibility/document-title',
-    'accessibility/duplicate-id-active',
     'accessibility/duplicate-id-aria',
     'accessibility/empty-heading',
     'accessibility/form-field-multiple-labels',
@@ -340,9 +300,7 @@ const defaultConfig = {
     'seo/crawlable-anchors',
     'seo/is-crawlable',
     'seo/robots-txt',
-    'seo/tap-targets',
     'seo/hreflang',
-    'seo/plugins',
     'seo/canonical',
     'seo/manual/structured-data',
     'work-during-interaction',
@@ -352,24 +310,10 @@ const defaultConfig = {
     'metrics': {
       title: str_(UIStrings.metricGroupTitle),
     },
-    'load-opportunities': {
-      title: str_(UIStrings.loadOpportunitiesGroupTitle),
-      description: str_(UIStrings.loadOpportunitiesGroupDescription),
-    },
-    'budgets': {
-      title: str_(UIStrings.budgetsGroupTitle),
-      description: str_(UIStrings.budgetsGroupDescription),
-    },
     'diagnostics': {
       title: str_(UIStrings.diagnosticsGroupTitle),
       description: str_(UIStrings.diagnosticsGroupDescription),
     },
-    'pwa-installable': {
-      title: str_(UIStrings.pwaInstallableGroupTitle),
-    },
-    'pwa-optimized': {
-      title: str_(UIStrings.pwaOptimizedGroupTitle),
-    },
     'a11y-best-practices': {
       title: str_(UIStrings.a11yBestPracticesGroupTitle),
       description: str_(UIStrings.a11yBestPracticesGroupDescription),
@@ -434,64 +378,58 @@ const defaultConfig = {
       title: str_(UIStrings.performanceCategoryTitle),
       supportedModes: ['navigation', 'timespan', 'snapshot'],
       auditRefs: [
-        {id: 'first-contentful-paint', weight: 10, group: 'metrics', acronym: 'FCP', relevantAudits: metricsToAudits.fcpRelevantAudits},
-        {id: 'largest-contentful-paint', weight: 25, group: 'metrics', acronym: 'LCP', relevantAudits: metricsToAudits.lcpRelevantAudits},
-        {id: 'total-blocking-time', weight: 30, group: 'metrics', acronym: 'TBT', relevantAudits: metricsToAudits.tbtRelevantAudits},
-        {id: 'cumulative-layout-shift', weight: 25, group: 'metrics', acronym: 'CLS', relevantAudits: metricsToAudits.clsRelevantAudits},
+        {id: 'first-contentful-paint', weight: 10, group: 'metrics', acronym: 'FCP'},
+        {id: 'largest-contentful-paint', weight: 25, group: 'metrics', acronym: 'LCP'},
+        {id: 'total-blocking-time', weight: 30, group: 'metrics', acronym: 'TBT'},
+        {id: 'cumulative-layout-shift', weight: 25, group: 'metrics', acronym: 'CLS'},
         {id: 'speed-index', weight: 10, group: 'metrics', acronym: 'SI'},
-        {id: 'interaction-to-next-paint', weight: 0, group: 'metrics', acronym: 'INP', relevantAudits: metricsToAudits.inpRelevantAudits},
+        {id: 'interaction-to-next-paint', weight: 0, group: 'metrics', acronym: 'INP'},
 
         // These are our "invisible" metrics. Not displayed, but still in the LHR.
         {id: 'interactive', weight: 0, group: 'hidden', acronym: 'TTI'},
         {id: 'max-potential-fid', weight: 0, group: 'hidden'},
         {id: 'first-meaningful-paint', weight: 0, acronym: 'FMP', group: 'hidden'},
 
-        // These audits will be put in "load-opportunities" or "diagnostics" based on their details type.
-        {id: 'render-blocking-resources', weight: 0},
-        {id: 'uses-responsive-images', weight: 0},
-        {id: 'offscreen-images', weight: 0},
-        {id: 'unminified-css', weight: 0},
-        {id: 'unminified-javascript', weight: 0},
-        {id: 'unused-css-rules', weight: 0},
-        {id: 'unused-javascript', weight: 0},
-        {id: 'uses-optimized-images', weight: 0},
-        {id: 'modern-image-formats', weight: 0},
-        {id: 'uses-text-compression', weight: 0},
-        {id: 'uses-rel-preconnect', weight: 0},
-        {id: 'server-response-time', weight: 0},
-        {id: 'redirects', weight: 0},
-        {id: 'uses-rel-preload', weight: 0},
-        {id: 'uses-http2', weight: 0},
-        {id: 'efficient-animated-content', weight: 0},
-        {id: 'duplicated-javascript', weight: 0},
-        {id: 'legacy-javascript', weight: 0},
-        {id: 'prioritize-lcp-image', weight: 0},
-        {id: 'total-byte-weight', weight: 0},
-        {id: 'uses-long-cache-ttl', weight: 0},
-        {id: 'dom-size', weight: 0},
-        {id: 'critical-request-chains', weight: 0},
-        {id: 'user-timings', weight: 0},
-        {id: 'bootup-time', weight: 0},
-        {id: 'mainthread-work-breakdown', weight: 0},
-        {id: 'font-display', weight: 0},
-        {id: 'third-party-summary', weight: 0},
-        {id: 'third-party-facades', weight: 0},
-        {id: 'largest-contentful-paint-element', weight: 0},
-        {id: 'lcp-lazy-loaded', weight: 0},
-        {id: 'layout-shifts', weight: 0},
-        {id: 'uses-passive-event-listeners', weight: 0},
-        {id: 'no-document-write', weight: 0},
-        {id: 'long-tasks', weight: 0},
-        {id: 'non-composited-animations', weight: 0},
-        {id: 'unsized-images', weight: 0},
-        {id: 'viewport', weight: 0},
-        {id: 'uses-responsive-images-snapshot', weight: 0},
-        {id: 'work-during-interaction', weight: 0},
-        {id: 'bf-cache', weight: 0},
-
-        // Budget audits.
-        {id: 'performance-budget', weight: 0, group: 'budgets'},
-        {id: 'timing-budget', weight: 0, group: 'budgets'},
+        {id: 'render-blocking-resources', weight: 0, group: 'diagnostics'},
+        {id: 'uses-responsive-images', weight: 0, group: 'diagnostics'},
+        {id: 'offscreen-images', weight: 0, group: 'diagnostics'},
+        {id: 'unminified-css', weight: 0, group: 'diagnostics'},
+        {id: 'unminified-javascript', weight: 0, group: 'diagnostics'},
+        {id: 'unused-css-rules', weight: 0, group: 'diagnostics'},
+        {id: 'unused-javascript', weight: 0, group: 'diagnostics'},
+        {id: 'uses-optimized-images', weight: 0, group: 'diagnostics'},
+        {id: 'modern-image-formats', weight: 0, group: 'diagnostics'},
+        {id: 'uses-text-compression', weight: 0, group: 'diagnostics'},
+        {id: 'uses-rel-preconnect', weight: 0, group: 'diagnostics'},
+        {id: 'server-response-time', weight: 0, group: 'diagnostics'},
+        {id: 'redirects', weight: 0, group: 'diagnostics'},
+        {id: 'uses-http2', weight: 0, group: 'diagnostics'},
+        {id: 'efficient-animated-content', weight: 0, group: 'diagnostics'},
+        {id: 'duplicated-javascript', weight: 0, group: 'diagnostics'},
+        {id: 'legacy-javascript', weight: 0, group: 'diagnostics'},
+        {id: 'prioritize-lcp-image', weight: 0, group: 'diagnostics'},
+        {id: 'total-byte-weight', weight: 0, group: 'diagnostics'},
+        {id: 'uses-long-cache-ttl', weight: 0, group: 'diagnostics'},
+        {id: 'dom-size', weight: 0, group: 'diagnostics'},
+        {id: 'critical-request-chains', weight: 0, group: 'diagnostics'},
+        {id: 'user-timings', weight: 0, group: 'diagnostics'},
+        {id: 'bootup-time', weight: 0, group: 'diagnostics'},
+        {id: 'mainthread-work-breakdown', weight: 0, group: 'diagnostics'},
+        {id: 'font-display', weight: 0, group: 'diagnostics'},
+        {id: 'third-party-summary', weight: 0, group: 'diagnostics'},
+        {id: 'third-party-facades', weight: 0, group: 'diagnostics'},
+        {id: 'largest-contentful-paint-element', weight: 0, group: 'diagnostics'},
+        {id: 'lcp-lazy-loaded', weight: 0, group: 'diagnostics'},
+        {id: 'layout-shifts', weight: 0, group: 'diagnostics'},
+        {id: 'uses-passive-event-listeners', weight: 0, group: 'diagnostics'},
+        {id: 'no-document-write', weight: 0, group: 'diagnostics'},
+        {id: 'long-tasks', weight: 0, group: 'diagnostics'},
+        {id: 'non-composited-animations', weight: 0, group: 'diagnostics'},
+        {id: 'unsized-images', weight: 0, group: 'diagnostics'},
+        {id: 'viewport', weight: 0, group: 'diagnostics'},
+        {id: 'uses-responsive-images-snapshot', weight: 0, group: 'diagnostics'},
+        {id: 'work-during-interaction', weight: 0, group: 'diagnostics'},
+        {id: 'bf-cache', weight: 0, group: 'diagnostics'},
 
         // Audits past this point contain useful data but are not displayed with other audits.
         {id: 'network-requests', weight: 0, group: 'hidden'},
@@ -504,7 +442,6 @@ const defaultConfig = {
         {id: 'final-screenshot', weight: 0, group: 'hidden'},
         {id: 'script-treemap-data', weight: 0, group: 'hidden'},
         {id: 'resource-summary', weight: 0, group: 'hidden'},
-        {id: 'layout-shift-elements', weight: 0, group: 'hidden'},
       ],
     },
     'accessibility': {
@@ -521,12 +458,15 @@ const defaultConfig = {
         {id: 'aria-allowed-attr', weight: 10, group: 'a11y-aria'},
         {id: 'aria-allowed-role', weight: 1, group: 'a11y-aria'},
         {id: 'aria-command-name', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-conditional-attr', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-deprecated-role', weight: 1, group: 'a11y-aria'},
         {id: 'aria-dialog-name', weight: 7, group: 'a11y-aria'},
         {id: 'aria-hidden-body', weight: 10, group: 'a11y-aria'},
         {id: 'aria-hidden-focus', weight: 7, group: 'a11y-aria'},
         {id: 'aria-input-field-name', weight: 7, group: 'a11y-aria'},
         {id: 'aria-meter-name', weight: 7, group: 'a11y-aria'},
         {id: 'aria-progressbar-name', weight: 7, group: 'a11y-aria'},
+        {id: 'aria-prohibited-attr', weight: 7, group: 'a11y-aria'},
         {id: 'aria-required-attr', weight: 10, group: 'a11y-aria'},
         {id: 'aria-required-children', weight: 10, group: 'a11y-aria'},
         {id: 'aria-required-parent', weight: 10, group: 'a11y-aria'},
@@ -543,7 +483,6 @@ const defaultConfig = {
         {id: 'definition-list', weight: 7, group: 'a11y-tables-lists'},
         {id: 'dlitem', weight: 7, group: 'a11y-tables-lists'},
         {id: 'document-title', weight: 7, group: 'a11y-names-labels'},
-        {id: 'duplicate-id-active', weight: 7, group: 'a11y-navigation'},
         {id: 'duplicate-id-aria', weight: 10, group: 'a11y-aria'},
         {id: 'form-field-multiple-labels', weight: 3, group: 'a11y-names-labels'},
         {id: 'frame-title', weight: 7, group: 'a11y-names-labels'},
@@ -567,6 +506,7 @@ const defaultConfig = {
         {id: 'skip-link', weight: 3, group: 'a11y-names-labels'},
         {id: 'tabindex', weight: 7, group: 'a11y-navigation'},
         {id: 'table-duplicate-name', weight: 1, group: 'a11y-tables-lists'},
+        {id: 'target-size', weight: 7, group: 'a11y-best-practices'},
         {id: 'td-headers-attr', weight: 7, group: 'a11y-tables-lists'},
         {id: 'th-has-data-cells', weight: 7, group: 'a11y-tables-lists'},
         {id: 'valid-lang', weight: 7, group: 'a11y-language'},
@@ -586,7 +526,6 @@ const defaultConfig = {
         {id: 'empty-heading', weight: 0, group: 'hidden'},
         {id: 'identical-links-same-purpose', weight: 0, group: 'hidden'},
         {id: 'landmark-one-main', weight: 0, group: 'hidden'},
-        {id: 'target-size', weight: 0, group: 'hidden'},
         {id: 'label-content-name-mismatch', weight: 0, group: 'hidden'},
         {id: 'table-fake-caption', weight: 0, group: 'hidden'},
         {id: 'td-has-header', weight: 0, group: 'hidden'},
@@ -598,6 +537,7 @@ const defaultConfig = {
       auditRefs: [
         // Trust & Safety
         {id: 'is-on-https', weight: 5, group: 'best-practices-trust-safety'},
+        {id: 'redirects-http', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'geolocation-on-start', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'notification-on-start', weight: 1, group: 'best-practices-trust-safety'},
         {id: 'csp-xss', weight: 0, group: 'best-practices-trust-safety'},
@@ -605,12 +545,12 @@ const defaultConfig = {
         {id: 'paste-preventing-inputs', weight: 3, group: 'best-practices-ux'},
         {id: 'image-aspect-ratio', weight: 1, group: 'best-practices-ux'},
         {id: 'image-size-responsive', weight: 1, group: 'best-practices-ux'},
-        {id: 'preload-fonts', weight: 1, group: 'best-practices-ux'},
+        {id: 'viewport', weight: 1, group: 'best-practices-ux'},
+        {id: 'font-size', weight: 1, group: 'best-practices-ux'},
         // Browser Compatibility
         {id: 'doctype', weight: 1, group: 'best-practices-browser-compat'},
         {id: 'charset', weight: 1, group: 'best-practices-browser-compat'},
         // General Group
-        {id: 'no-unload-listeners', weight: 1, group: 'best-practices-general'},
         {id: 'js-libraries', weight: 0, group: 'best-practices-general'},
         {id: 'deprecations', weight: 5, group: 'best-practices-general'},
         {id: 'third-party-cookies', weight: 5, group: 'best-practices-general'},
@@ -625,44 +565,25 @@ const defaultConfig = {
       manualDescription: str_(UIStrings.seoCategoryManualDescription),
       supportedModes: ['navigation', 'snapshot'],
       auditRefs: [
-        {id: 'viewport', weight: 1, group: 'seo-mobile'},
+        // Should be at least 31% of the score, such that this audit failing
+        // results in the SEO category failing.
+        // Solve for w:
+        //    w / (w + T) >= 0.31
+        // where T is the sum of all the other weights.
+        {id: 'is-crawlable', weight: 93 / 23, group: 'seo-crawl'},
         {id: 'document-title', weight: 1, group: 'seo-content'},
         {id: 'meta-description', weight: 1, group: 'seo-content'},
         {id: 'http-status-code', weight: 1, group: 'seo-crawl'},
         {id: 'link-text', weight: 1, group: 'seo-content'},
         {id: 'crawlable-anchors', weight: 1, group: 'seo-crawl'},
-        {id: 'is-crawlable', weight: 1, group: 'seo-crawl'},
         {id: 'robots-txt', weight: 1, group: 'seo-crawl'},
         {id: 'image-alt', weight: 1, group: 'seo-content'},
         {id: 'hreflang', weight: 1, group: 'seo-content'},
         {id: 'canonical', weight: 1, group: 'seo-content'},
-        {id: 'font-size', weight: 1, group: 'seo-mobile'},
-        {id: 'plugins', weight: 1, group: 'seo-content'},
-        {id: 'tap-targets', weight: 1, group: 'seo-mobile'},
         // Manual audits
         {id: 'structured-data', weight: 0},
       ],
     },
-    'pwa': {
-      title: str_(UIStrings.pwaCategoryTitle),
-      description: str_(UIStrings.pwaCategoryDescription),
-      manualDescription: str_(UIStrings.pwaCategoryManualDescription),
-      supportedModes: ['navigation'],
-      auditRefs: [
-        // Installable
-        {id: 'installable-manifest', weight: 2, group: 'pwa-installable'},
-        // PWA Optimized
-        {id: 'splash-screen', weight: 1, group: 'pwa-optimized'},
-        {id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
-        {id: 'content-width', weight: 1, group: 'pwa-optimized'},
-        {id: 'viewport', weight: 2, group: 'pwa-optimized'},
-        {id: 'maskable-icon', weight: 1, group: 'pwa-optimized'},
-        // Manual audits
-        {id: 'pwa-cross-browser', weight: 0},
-        {id: 'pwa-page-transitions', weight: 0},
-        {id: 'pwa-each-page-has-url', weight: 0},
-      ],
-    },
   },
 };
 

package/core/config/experimental-config.js

@@ -14,13 +14,24 @@ const config = {
   extends: 'lighthouse:default',
   audits: [
     'autocomplete',
+    // Preload advice is on hold until https://github.com/GoogleChrome/lighthouse/issues/11960
+    'preload-fonts',
+    'uses-rel-preload',
   ],
   categories: {
+    // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
+    // config is awkward - easier to omit the property here. Will defer to default config.
+    'performance': {
+      auditRefs: [
+        {id: 'uses-rel-preload', weight: 0, group: 'diagnostics'},
+      ],
+    },
     // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
     // config is awkward - easier to omit the property here. Will defer to default config.
     'best-practices': {
       auditRefs: [
         {id: 'autocomplete', weight: 0, group: 'best-practices-ux'},
+        {id: 'preload-fonts', weight: 0, group: 'best-practices-ux'},
       ],
     },
   },

package/core/config/filters.js

@@ -13,7 +13,6 @@ const baseArtifactKeySource = {
   fetchTime: '',
   LighthouseRunWarnings: '',
   BenchmarkIndex: '',
-  BenchmarkIndexes: '',
   settings: '',
   Timing: '',
   URL: '',

package/core/gather/driver/navigation.js

@@ -122,7 +122,10 @@ async function gotoURL(driver, requestor, options) {
     throw new Error('Cannot wait for FCP without waiting for page load');
   }
 
-  const waitConditions = await Promise.all(waitConditionPromises);
+  const waitConditions = await Promise.race([
+    driver.fatalRejection.promise,
+    Promise.all(waitConditionPromises),
+  ]);
   const timedOut = waitConditions.some(condition => condition.timedOut);
   const navigationUrls = await networkMonitor.getNavigationUrls();
 

package/core/gather/driver/prepare.js

@@ -45,7 +45,7 @@ async function enableAsyncStacks(session) {
   await enable();
 
   return async () => {
-    await session.sendCommand('Debugger.disable');
+    await session.sendCommandAndIgnore('Debugger.disable');
     session.off('Debugger.paused', onDebuggerPaused);
     session.off('Page.frameNavigated', onFrameNavigated);
   };

package/core/gather/driver/target-manager.js

@@ -180,7 +180,7 @@ class TargetManager extends ProtocolEventEmitter {
       throw err;
     } finally {
       // Resume the target if it was paused, but if it's unnecessary, we don't care about the error.
-      await newSession.sendCommand('Runtime.runIfWaitingForDebugger').catch(() => {});
+      await newSession.sendCommandAndIgnore('Runtime.runIfWaitingForDebugger');
     }
   }
 
@@ -266,8 +266,9 @@ class TargetManager extends ProtocolEventEmitter {
       cdpSession.off('sessionattached', this._onSessionAttached);
     }
 
-    await this._rootCdpSession.send('Page.disable');
-    await this._rootCdpSession.send('Runtime.disable');
+    // Ignore failures on these in case the tab has crashed.
+    await this._rootCdpSession.send('Page.disable').catch(_ => {});
+    await this._rootCdpSession.send('Runtime.disable').catch(_ => {});
 
     this._enabled = false;
     this._targetIdToTargets = new Map();