lighthouse 11.7.0-dev.20240414 → 11.7.0-dev.20240416

package/cli/test/smokehouse/config/exclusions.js

@@ -26,6 +26,8 @@ const exclusions = {
     'metrics-tricky-tti', 'metrics-tricky-tti-late-fcp', 'screenshot',
     // Disabled because of differences that need further investigation
     'byte-efficiency', 'byte-gzip', 'perf-preload',
+    // Disabled because a renderer crash also breaks devtools frontend
+    'crash',
   ],
 };
 

package/cli/test/smokehouse/core-tests.js

@@ -7,6 +7,7 @@
 import a11y from './test-definitions/a11y.js';
 import byteEfficiency from './test-definitions/byte-efficiency.js';
 import byteGzip from './test-definitions/byte-gzip.js';
+import crash from './test-definitions/crash.js';
 import cspAllowAll from './test-definitions/csp-allow-all.js';
 import cspBlockAll from './test-definitions/csp-block-all.js';
 import dbw from './test-definitions/dobetterweb.js';
@@ -65,6 +66,7 @@ const smokeTests = [
   a11y,
   byteEfficiency,
   byteGzip,
+  crash,
   cspAllowAll,
   cspBlockAll,
   dbw,

package/core/audits/seo/link-text.js

@@ -84,6 +84,18 @@ const BLOCKLIST = new Set([
   'மேலும் தரவுகளுக்கு',
   'தயவுசெய்து இங்கே அழுத்தவும்',
   'இங்கே கிளிக் செய்யவும்',
+  // Persian
+  'اطلاعات بیشتر',
+  'اطلاعات',
+  'این',
+  'اینجا بزنید',
+  'اینجا کلیک کنید',
+  'اینجا',
+  'برو',
+  'بیشتر بخوانید',
+  'بیشتر بدانید',
+  'بیشتر',
+  'شروع',
 ]);
 
 const UIStrings = {

package/core/computed/page-dependency-graph.js

@@ -9,7 +9,6 @@ import {PageDependencyGraph as LanternPageDependencyGraph} from '../lib/lantern/
 import {NetworkRequest} from '../lib/network-request.js';
 import {ProcessedTrace} from './processed-trace.js';
 import {NetworkRecords} from './network-records.js';
-import {DocumentUrls} from './document-urls.js';
 
 /** @typedef {import('../lib/lantern/base-node.js').Node<LH.Artifacts.NetworkRequest>} Node */
 
@@ -20,16 +19,12 @@ class PageDependencyGraph {
    * @return {Promise<Node>}
    */
   static async compute_(data, context) {
-    const {trace, devtoolsLog} = data;
+    const {trace, devtoolsLog, URL} = data;
     const [processedTrace, networkRecords] = await Promise.all([
       ProcessedTrace.request(trace, context),
       NetworkRecords.request(devtoolsLog, context),
     ]);
 
-    // COMPAT: Backport for pre-10.0 clients that don't pass the URL artifact here (e.g. pubads).
-    // Calculates the URL artifact from the processed trace and DT log.
-    const URL = data.URL || await DocumentUrls.request(data, context);
-
     const mainThreadEvents = processedTrace.mainThreadEvents;
     const lanternRequests = networkRecords.map(NetworkRequest.asLanternNetworkRequest);
     return LanternPageDependencyGraph.createGraph(mainThreadEvents, lanternRequests, URL);

package/core/gather/driver/navigation.js

@@ -122,7 +122,10 @@ async function gotoURL(driver, requestor, options) {
     throw new Error('Cannot wait for FCP without waiting for page load');
   }
 
-  const waitConditions = await Promise.all(waitConditionPromises);
+  const waitConditions = await Promise.race([
+    driver.fatalRejection.promise,
+    Promise.all(waitConditionPromises),
+  ]);
   const timedOut = waitConditions.some(condition => condition.timedOut);
   const navigationUrls = await networkMonitor.getNavigationUrls();
 

package/core/gather/driver/prepare.js

@@ -45,7 +45,7 @@ async function enableAsyncStacks(session) {
   await enable();
 
   return async () => {
-    await session.sendCommand('Debugger.disable');
+    await session.sendCommandAndIgnore('Debugger.disable');
     session.off('Debugger.paused', onDebuggerPaused);
     session.off('Page.frameNavigated', onFrameNavigated);
   };

package/core/gather/driver/target-manager.js

@@ -266,8 +266,9 @@ class TargetManager extends ProtocolEventEmitter {
       cdpSession.off('sessionattached', this._onSessionAttached);
     }
 
-    await this._rootCdpSession.send('Page.disable');
-    await this._rootCdpSession.send('Runtime.disable');
+    // Ignore failures on these in case the tab has crashed.
+    await this._rootCdpSession.send('Page.disable').catch(_ => {});
+    await this._rootCdpSession.send('Runtime.disable').catch(_ => {});
 
     this._enabled = false;
     this._targetIdToTargets = new Map();

package/core/gather/driver.d.ts

@@ -14,6 +14,10 @@ export class Driver implements LH.Gatherer.Driver {
     /** @type {Fetcher|undefined} */
     _fetcher: Fetcher | undefined;
     defaultSession: import("../../types/gatherer.js").default.ProtocolSession;
+    fatalRejection: {
+        promise: Promise<never>;
+        rej: (_: Error) => void;
+    };
     /** @return {LH.Gatherer.Driver['executionContext']} */
     get executionContext(): ExecutionContext;
     get fetcher(): any;
@@ -23,6 +27,14 @@ export class Driver implements LH.Gatherer.Driver {
     url(): Promise<string>;
     /** @return {Promise<void>} */
     connect(): Promise<void>;
+    /**
+     * If the target crashes, we can't continue gathering.
+     *
+     * FWIW, if the target unexpectedly detaches (eg the user closed the tab), pptr will
+     * catch that and reject into our this._cdpSession.send, which we'll alrady handle appropriately
+     * @return {void}
+     */
+    listenForCrashes(): void;
     /** @return {Promise<void>} */
     disconnect(): Promise<void>;
 }

package/core/gather/driver.js

@@ -8,6 +8,7 @@ import log from 'lighthouse-logger';
 
 import {ExecutionContext} from './driver/execution-context.js';
 import {TargetManager} from './driver/target-manager.js';
+import {LighthouseError} from '../lib/lh-error.js';
 import {Fetcher} from './fetcher.js';
 import {NetworkMonitor} from './driver/network-monitor.js';
 
@@ -47,6 +48,12 @@ class Driver {
     this._fetcher = undefined;
 
     this.defaultSession = throwingSession;
+
+    // Poor man's Promise.withResolvers()
+    /** @param {Error} _ */
+    let rej = _ => {};
+    const promise = /** @type {Promise<never>} */ (new Promise((_, theRej) => rej = theRej));
+    this.fatalRejection = {promise, rej};
   }
 
   /** @return {LH.Gatherer.Driver['executionContext']} */
@@ -86,11 +93,30 @@ class Driver {
     this._networkMonitor = new NetworkMonitor(this._targetManager);
     await this._networkMonitor.enable();
     this.defaultSession = this._targetManager.rootSession();
+    this.listenForCrashes();
     this._executionContext = new ExecutionContext(this.defaultSession);
     this._fetcher = new Fetcher(this.defaultSession);
     log.timeEnd(status);
   }
 
+  /**
+   * If the target crashes, we can't continue gathering.
+   *
+   * FWIW, if the target unexpectedly detaches (eg the user closed the tab), pptr will
+   * catch that and reject into our this._cdpSession.send, which we'll alrady handle appropriately
+   * @return {void}
+   */
+  listenForCrashes() {
+    this.defaultSession.on('Inspector.targetCrashed', async _ => {
+      log.error('Driver', 'Inspector.targetCrashed');
+      // Manually detach so no more CDP traffic is attempted.
+      // Don't await, else our rejection will be a 'Target closed' protocol error on cross-talk CDP calls.
+      void this.defaultSession.dispose();
+      this.fatalRejection.rej(new LighthouseError(LighthouseError.errors.TARGET_CRASHED));
+    });
+  }
+
+
   /** @return {Promise<void>} */
   async disconnect() {
     if (this.defaultSession === throwingSession) return;

package/core/gather/navigation-runner.js

@@ -92,7 +92,9 @@ async function _navigate(navigationContext) {
     return {requestedUrl, mainDocumentUrl, navigationError: undefined};
   } catch (err) {
     if (!(err instanceof LighthouseError)) throw err;
-    if (err.code !== 'NO_FCP' && err.code !== 'PAGE_HUNG') throw err;
+    if (err.code !== 'NO_FCP' && err.code !== 'PAGE_HUNG' && err.code !== 'TARGET_CRASHED') {
+      throw err;
+    }
     if (typeof requestor !== 'string') throw err;
 
     // TODO: Make the urls optional here so we don't need to throw an error with a callback requestor.

package/core/gather/session.js

@@ -100,6 +100,7 @@ class ProtocolSession extends CrdpEventEmitter {
     /** @type {NodeJS.Timer|undefined} */
     let timeout;
     const timeoutPromise = new Promise((resolve, reject) => {
+      // Unexpected setTimeout invocation to preserve the error stack. https://github.com/GoogleChrome/lighthouse/issues/13332
       // eslint-disable-next-line max-len
       timeout = setTimeout(reject, timeoutMs, new LighthouseError(LighthouseError.errors.PROTOCOL_TIMEOUT, {
         protocolMethod: method,
@@ -139,7 +140,7 @@ class ProtocolSession extends CrdpEventEmitter {
   async dispose() {
     // @ts-expect-error Puppeteer expects the handler params to be type `unknown`
     this._cdpSession.off('*', this._handleProtocolEvent);
-    await this._cdpSession.detach();
+    await this._cdpSession.detach().catch(e => log.verbose('session', 'detach failed', e.message));
   }
 }
 

package/core/lib/emulation.js

@@ -128,7 +128,7 @@ function enableNetworkThrottling(session, throttlingSettings) {
  * @return {Promise<void>}
  */
 function clearNetworkThrottling(session) {
-  return session.sendCommand('Network.emulateNetworkConditions', NO_THROTTLING_METRICS);
+  return session.sendCommandAndIgnore('Network.emulateNetworkConditions', NO_THROTTLING_METRICS);
 }
 
 /**
@@ -146,7 +146,7 @@ function enableCPUThrottling(session, throttlingSettings) {
  * @return {Promise<void>}
  */
 function clearCPUThrottling(session) {
-  return session.sendCommand('Emulation.setCPUThrottlingRate', NO_CPU_THROTTLE_METRICS);
+  return session.sendCommandAndIgnore('Emulation.setCPUThrottlingRate', NO_CPU_THROTTLE_METRICS);
 }
 
 export {

package/core/lib/lantern/metrics/speed-index.js

@@ -7,8 +7,8 @@
 import * as Lantern from '../types/lantern.js';
 import {Metric} from '../metric.js';
 import {BaseNode} from '../base-node.js';
-// TODO(15841): move this default config value into lib/lantern
-import {throttling as defaultThrottling} from '../../../config/constants.js';
+
+const mobileSlow4GRtt = 150;
 
 /** @typedef {import('../base-node.js').Node} Node */
 
@@ -44,7 +44,7 @@ class SpeedIndex extends Metric {
     //      lantern test data set. See core/scripts/test-lantern.sh for more detail.
     // While the coefficients haven't been analyzed at the interpolated points, it's our current best effort.
     const defaultCoefficients = this.COEFFICIENTS;
-    const defaultRttExcess = defaultThrottling.mobileSlow4G.rttMs - 30;
+    const defaultRttExcess = mobileSlow4GRtt - 30;
     const multiplier = Math.max((rttMs - 30) / defaultRttExcess, 0);
 
     return {

package/core/lib/lantern/simulator/network-analyzer.js

@@ -140,15 +140,6 @@ class NetworkAnalyzer {
     const {timing, connectionReused, record} = info;
     if (connectionReused) return;
 
-    // In LR, network records are missing connection timing, but we've smuggled it in via headers.
-    if (global.isLightrider && record.lrStatistics) {
-      if (record.protocol.startsWith('h3')) {
-        return record.lrStatistics.TCPMs;
-      } else {
-        return [record.lrStatistics.TCPMs / 2, record.lrStatistics.TCPMs / 2];
-      }
-    }
-
     const {connectStart, sslStart, sslEnd, connectEnd} = timing;
     if (connectEnd >= 0 && connectStart >= 0 && record.protocol.startsWith('h3')) {
       // These values are equal to sslStart and sslEnd for h3.
@@ -256,9 +247,7 @@ class NetworkAnalyzer {
    */
   static _estimateResponseTimeByOrigin(records, rttByOrigin) {
     return NetworkAnalyzer._estimateValueByOrigin(records, ({record, timing}) => {
-      // Lightrider does not have timings for sendEnd, but we do have this timing which should be
-      // close to the response time.
-      if (global.isLightrider && record.lrStatistics) return record.lrStatistics.requestMs;
+      if (record.serverResponseTime !== undefined) return record.serverResponseTime;
 
       if (!Number.isFinite(timing.receiveHeadersEnd) || timing.receiveHeadersEnd < 0) return;
       if (!Number.isFinite(timing.sendEnd) || timing.sendEnd < 0) return;

package/core/lib/lantern/types/lantern.d.ts

@@ -67,9 +67,6 @@ export class NetworkRequest<T = any> {
     resourceSize: number;
     fromDiskCache: boolean;
     fromMemoryCache: boolean;
-    // TODO(15841): remove from lantern.
-    /** Extra timing information available only when run in Lightrider. */
-    lrStatistics: LightriderStatistics | undefined;
     finished: boolean;
     statusCode: number;
     /** The network request that this one redirected to */
@@ -80,6 +77,11 @@ export class NetworkRequest<T = any> {
     /** The chain of network requests that redirected to this one */
     redirects: NetworkRequest[] | undefined;
     timing: LH.Crdp.Network.ResourceTiming | undefined;
+    /**
+     * Optional value for how long the server took to respond to this request.
+     * When not provided, the server response time is derived from the timing object.
+     */
+    serverResponseTime: number | undefined;
     resourceType: LH.Crdp.Network.ResourceType | undefined;
     mimeType: string;
     priority: LH.Crdp.Network.ResourcePriority;

package/core/lib/lh-error.d.ts

@@ -105,6 +105,7 @@ export namespace UIStrings {
     const missingRequiredArtifact: string;
     const erroredRequiredArtifact: string;
     const oldChromeDoesNotSupportFeature: string;
+    const targetCrashed: string;
 }
 declare namespace ERRORS {
     namespace NO_SPEEDLINE_FRAMES {
@@ -340,6 +341,14 @@ declare namespace ERRORS {
         import message_30 = UIStrings.erroredRequiredArtifact;
         export { message_30 as message };
     }
+    namespace TARGET_CRASHED {
+        const code_31: string;
+        export { code_31 as code };
+        import message_31 = UIStrings.targetCrashed;
+        export { message_31 as message };
+        const lhrRuntimeError_22: boolean;
+        export { lhrRuntimeError_22 as lhrRuntimeError };
+    }
 }
 export {};
 //# sourceMappingURL=lh-error.d.ts.map

package/core/lib/lh-error.js

@@ -91,6 +91,9 @@ const UIStrings = {
    * @example {Largest Contentful Paint} featureName
    * */
   oldChromeDoesNotSupportFeature: 'This version of Chrome is too old to support \'{featureName}\'. Use a newer version to see full results.',
+
+  /** Error message explaining that the browser tab that Lighthouse is inspecting has crashed. */
+  targetCrashed: 'Browser tab has unexpectedly crashed.',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
@@ -423,6 +426,13 @@ const ERRORS = {
     message: UIStrings.erroredRequiredArtifact,
   },
 
+  /** The page has crashed and will no longer respond to 99% of CDP commmands. */
+  TARGET_CRASHED: {
+    code: 'TARGET_CRASHED',
+    message: UIStrings.targetCrashed,
+    lhrRuntimeError: true,
+  },
+
   // Hey! When adding a new error type, update lighthouse-result.proto too.
   // Only necessary for runtime errors, which come from artifacts or pageLoadErrors.
 };

package/core/lib/navigation-error.js

@@ -150,6 +150,9 @@ function getPageLoadError(navigationError, context) {
   let finalRecord;
   if (mainRecord) {
     finalRecord = NetworkAnalyzer.resolveRedirects(mainRecord);
+  } else {
+    // We have no network requests to process, use the navError
+    return navigationError;
   }
 
   if (finalRecord?.mimeType === XHTML_MIME_TYPE) {

package/core/lib/network-request.d.ts

@@ -247,6 +247,7 @@ export class NetworkRequest {
      * is passed in via X-Headers similar to 'X-TotalFetchedSize'.
      */
     _updateTimingsForLightrider(): void;
+    serverResponseTime: number | undefined;
 }
 export namespace NetworkRequest {
     export { HEADER_TCP };

package/core/lib/network-request.js

@@ -536,6 +536,7 @@ class NetworkRequest {
       requestMs: requestMs,
       responseMs: responseMs,
     };
+    this.serverResponseTime = responseMs;
   }
 
   /**
@@ -574,8 +575,35 @@ class NetworkRequest {
    * @return {Lantern.NetworkRequest<NetworkRequest>}
    */
   static asLanternNetworkRequest(record) {
+    // In LR, network records are missing connection timing, but we've smuggled it in via headers.
+    let timing = record.timing;
+    let serverResponseTime;
+    if (global.isLightrider && record.lrStatistics) {
+      if (record.protocol.startsWith('h3')) {
+        // @ts-expect-error We don't need all the properties set.
+        timing = {
+          connectStart: 0,
+          connectEnd: record.lrStatistics.TCPMs,
+        };
+      } else {
+        // @ts-expect-error We don't need all the properties set.
+        timing = {
+          connectStart: 0,
+          sslStart: record.lrStatistics.TCPMs / 2,
+          connectEnd: record.lrStatistics.TCPMs,
+          sslEnd: record.lrStatistics.TCPMs,
+        };
+
+        // Lightrider does not have timings for sendEnd, but we do have this timing which should be
+        // close to the response time.
+        serverResponseTime = record.lrStatistics.requestMs;
+      }
+    }
+
     return {
       ...record,
+      timing,
+      serverResponseTime,
       record,
     };
   }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "11.7.0-dev.20240414",
+  "version": "11.7.0-dev.20240416",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -165,7 +165,7 @@
     "pako": "^2.0.3",
     "preact": "^10.7.2",
     "pretty-json-stringify": "^0.0.2",
-    "puppeteer": "^22.5.0",
+    "puppeteer": "^22.6.5",
     "resolve": "^1.22.1",
     "rollup": "^2.52.7",
     "rollup-plugin-polyfill-node": "^0.12.0",
@@ -199,7 +199,7 @@
     "open": "^8.4.0",
     "parse-cache-control": "1.0.1",
     "ps-list": "^8.0.0",
-    "puppeteer-core": "^22.5.0",
+    "puppeteer-core": "^22.6.5",
     "robots-parser": "^3.0.1",
     "semver": "^5.3.0",
     "speedline-core": "^1.4.3",

package/shared/localization/locales/en-US.json

@@ -2471,6 +2471,9 @@
   "core/lib/lh-error.js | requestContentTimeout": {
     "message": "Fetching resource content has exceeded the allotted time"
   },
+  "core/lib/lh-error.js | targetCrashed": {
+    "message": "Browser tab has unexpectedly crashed."
+  },
   "core/lib/lh-error.js | urlInvalid": {
     "message": "The URL you have provided appears to be invalid."
   },

package/shared/localization/locales/en-XL.json

@@ -2471,6 +2471,9 @@
   "core/lib/lh-error.js | requestContentTimeout": {
     "message": "F̂ét̂ćĥín̂ǵ r̂éŝóûŕĉé ĉón̂t́êńt̂ h́âś êx́ĉéêd́êd́ t̂h́ê ál̂ĺôt́t̂éd̂ t́îḿê"
   },
+  "core/lib/lh-error.js | targetCrashed": {
+    "message": "B̂ŕôẃŝér̂ t́âb́ ĥáŝ ún̂éx̂ṕêćt̂éd̂ĺŷ ćr̂áŝh́êd́."
+  },
   "core/lib/lh-error.js | urlInvalid": {
     "message": "T̂h́ê ÚR̂Ĺ ŷóû h́âv́ê ṕr̂óv̂íd̂éd̂ áp̂ṕêár̂ś t̂ó b̂é îńv̂ál̂íd̂."
   },

package/types/gatherer.d.ts

@@ -49,6 +49,8 @@ declare module Gatherer {
       off(event: 'protocolevent', callback: (payload: Protocol.RawEventMessage) => void): void
     };
     networkMonitor: NetworkMonitor;
+    listenForCrashes: (() => void);
+    fatalRejection: {promise: Promise<never>, rej: (reason: Error) => void}
   }
 
   interface Context<TDependencies extends DependencyKey = DefaultDependenciesKey> {