lighthouse 11.7.0-dev.20240325 → 11.7.0-dev.20240327

package/core/audits/accessibility/table-duplicate-name.js

@@ -20,7 +20,7 @@ const UIStrings = {
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'The summary attribute should describe the table structure, while `<caption>` ' +
       'should have the onscreen title. Accurate table mark-up helps users of screen readers. ' +
-      '[Learn more about summary and caption](https://dequeuniversity.com/rules/axe/4.8/table-duplicate-name).',
+      '[Learn more about summary and caption](https://dequeuniversity.com/rules/axe/4.9/table-duplicate-name).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/table-fake-caption.js

@@ -23,7 +23,7 @@ const UIStrings = {
   description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
       'that tables use the actual caption element instead of cells with the `[colspan]` ' +
       'attribute may improve the experience for screen reader users. ' +
-      '[Learn more about captions](https://dequeuniversity.com/rules/axe/4.8/table-fake-caption).',
+      '[Learn more about captions](https://dequeuniversity.com/rules/axe/4.9/table-fake-caption).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/target-size.js

@@ -20,7 +20,7 @@ const UIStrings = {
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'Touch targets with sufficient size and spacing help users who may have ' +
       'difficulty targeting small controls to activate the targets. ' +
-      '[Learn more about touch targets](https://dequeuniversity.com/rules/axe/4.8/target-size).',
+      '[Learn more about touch targets](https://dequeuniversity.com/rules/axe/4.9/target-size).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/td-has-header.js

@@ -21,7 +21,7 @@ const UIStrings = {
   description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
       'that `<td>` elements in a large table (3 or more cells in width and height) have an ' +
       'associated table header may improve the experience for screen reader users. ' +
-      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.8/td-has-header).',
+      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.9/td-has-header).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/td-headers-attr.js

@@ -24,7 +24,7 @@ const UIStrings = {
   description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
       '`<td>` cells using the `[headers]` attribute only refer to other cells in the same ' +
       'table may improve the experience for screen reader users. ' +
-      '[Learn more about the `headers` attribute](https://dequeuniversity.com/rules/axe/4.8/td-headers-attr).',
+      '[Learn more about the `headers` attribute](https://dequeuniversity.com/rules/axe/4.9/td-headers-attr).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/th-has-data-cells.js

@@ -23,7 +23,7 @@ const UIStrings = {
   description: 'Screen readers have features to make navigating tables easier. Ensuring ' +
       'table headers always refer to some set of cells may improve the experience for screen ' +
       'reader users. ' +
-      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.8/th-has-data-cells).',
+      '[Learn more about table headers](https://dequeuniversity.com/rules/axe/4.9/th-has-data-cells).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/valid-lang.js

@@ -20,7 +20,7 @@ const UIStrings = {
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'Specifying a valid [BCP 47 language](https://www.w3.org/International/questions/qa-choosing-language-tags#question) ' +
       'on elements helps ensure that text is pronounced correctly by a screen reader. ' +
-      '[Learn how to use the `lang` attribute](https://dequeuniversity.com/rules/axe/4.8/valid-lang).',
+      '[Learn how to use the `lang` attribute](https://dequeuniversity.com/rules/axe/4.9/valid-lang).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/accessibility/video-caption.js

@@ -21,7 +21,7 @@ const UIStrings = {
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
   description: 'When a video provides a caption it is easier for deaf and hearing impaired ' +
       'users to access its information. ' +
-      '[Learn more about video captions](https://dequeuniversity.com/rules/axe/4.8/video-caption).',
+      '[Learn more about video captions](https://dequeuniversity.com/rules/axe/4.9/video-caption).',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/work-during-interaction.d.ts

@@ -32,7 +32,7 @@ declare class WorkDuringInteraction extends Audit {
             startTs: number;
             endTs: number;
         };
-        processingTime: {
+        processingDuration: {
             startTs: number;
             endTs: number;
         };
@@ -72,7 +72,7 @@ export namespace UIStrings {
     const failureTitle: string;
     const description: string;
     const inputDelay: string;
-    const processingTime: string;
+    const processingDuration: string;
     const presentationDelay: string;
     const displayValue: string;
     const eventTarget: string;

package/core/audits/work-during-interaction.js

@@ -30,7 +30,7 @@ const UIStrings = {
   /** Label for a column in a data table; entries will be information on the time that the browser is delayed before responding to user input. Ideally fits within a ~40 character limit. */
   inputDelay: 'Input delay',
   /** Label for a column in a data table; entries will be information on the time taken by code processing user input that delays a response to the user. Ideally fits within a ~40 character limit. */
-  processingTime: 'Processing time',
+  processingDuration: 'Processing duration',
   /** Label for a column in a data table; entries will be information on the time that the browser is delayed before presenting a response to user input on screen. Ideally fits within a ~40 character limit. */
   presentationDelay: 'Presentation delay',
   /**
@@ -115,7 +115,7 @@ class WorkDuringInteraction extends Audit {
     const endTs = startTs + interactionData.duration * 1000;
     return {
       inputDelay: {startTs, endTs: processingStartTs},
-      processingTime: {startTs: processingStartTs, endTs: processingEndTs},
+      processingDuration: {startTs: processingStartTs, endTs: processingEndTs},
       presentationDelay: {startTs: processingEndTs, endTs},
     };
   }

package/core/computed/metrics/lantern-metric.js

@@ -19,9 +19,7 @@ class LanternMetric extends Metric {
    * @return {Promise<LH.Artifacts.LanternMetric>}
    */
   static async computeMetricWithGraphs(data, context, extras) {
-    // TODO: remove this fallback when lighthouse-pub-ads plugin can update.
-    const gatherContext = data.gatherContext || {gatherMode: 'navigation'};
-    if (gatherContext.gatherMode !== 'navigation') {
+    if (data.gatherContext.gatherMode !== 'navigation') {
       throw new Error(`Lantern metrics can only be computed on navigations`);
     }
 

package/core/computed/metrics/metric.js

@@ -61,9 +61,7 @@ class Metric {
    * @return {Promise<LH.Artifacts.LanternMetric|LH.Artifacts.Metric>}
    */
   static async compute_(data, context) {
-    // TODO: remove this fallback when lighthouse-pub-ads plugin can update.
-    const gatherContext = data.gatherContext || {gatherMode: 'navigation'};
-    const {trace, devtoolsLog, settings} = data;
+    const {trace, devtoolsLog, settings, gatherContext} = data;
     if (!trace || !devtoolsLog || !settings) {
       throw new Error('Did not provide necessary metric computation data');
     }

package/core/config/default-config.js

@@ -9,7 +9,6 @@
 import * as LH from '../../types/lh.js';
 import * as constants from './constants.js';
 import * as i18n from '../lib/i18n/i18n.js';
-import {metricsToAudits} from './metrics-to-audits.js';
 
 const UIStrings = {
   /** Title of the Performance category of audits. Equivalent to 'Web performance', this term is inclusive of all web page speed and loading optimization topics. Also used as a label of a score gauge; try to limit to 20 characters. */
@@ -141,7 +140,6 @@ const defaultConfig = {
     {id: 'EmbeddedContent', gatherer: 'seo/embedded-content'},
     {id: 'FontSize', gatherer: 'seo/font-size'},
     {id: 'Inputs', gatherer: 'inputs'},
-    {id: 'GlobalListeners', gatherer: 'global-listeners'},
     {id: 'IFrameElements', gatherer: 'iframe-elements'},
     {id: 'ImageElements', gatherer: 'image-elements'},
     {id: 'InstallabilityErrors', gatherer: 'installability-errors'},
@@ -222,7 +220,6 @@ const defaultConfig = {
     'layout-shift-elements',
     'layout-shifts',
     'long-tasks',
-    'no-unload-listeners',
     'non-composited-animations',
     'unsized-images',
     'valid-source-maps',
@@ -431,12 +428,12 @@ const defaultConfig = {
       title: str_(UIStrings.performanceCategoryTitle),
       supportedModes: ['navigation', 'timespan', 'snapshot'],
       auditRefs: [
-        {id: 'first-contentful-paint', weight: 10, group: 'metrics', acronym: 'FCP', relevantAudits: metricsToAudits.fcpRelevantAudits},
-        {id: 'largest-contentful-paint', weight: 25, group: 'metrics', acronym: 'LCP', relevantAudits: metricsToAudits.lcpRelevantAudits},
-        {id: 'total-blocking-time', weight: 30, group: 'metrics', acronym: 'TBT', relevantAudits: metricsToAudits.tbtRelevantAudits},
-        {id: 'cumulative-layout-shift', weight: 25, group: 'metrics', acronym: 'CLS', relevantAudits: metricsToAudits.clsRelevantAudits},
+        {id: 'first-contentful-paint', weight: 10, group: 'metrics', acronym: 'FCP'},
+        {id: 'largest-contentful-paint', weight: 25, group: 'metrics', acronym: 'LCP'},
+        {id: 'total-blocking-time', weight: 30, group: 'metrics', acronym: 'TBT'},
+        {id: 'cumulative-layout-shift', weight: 25, group: 'metrics', acronym: 'CLS'},
         {id: 'speed-index', weight: 10, group: 'metrics', acronym: 'SI'},
-        {id: 'interaction-to-next-paint', weight: 0, group: 'metrics', acronym: 'INP', relevantAudits: metricsToAudits.inpRelevantAudits},
+        {id: 'interaction-to-next-paint', weight: 0, group: 'metrics', acronym: 'INP'},
 
         // These are our "invisible" metrics. Not displayed, but still in the LHR.
         {id: 'interactive', weight: 0, group: 'hidden', acronym: 'TTI'},
@@ -605,7 +602,6 @@ const defaultConfig = {
         {id: 'doctype', weight: 1, group: 'best-practices-browser-compat'},
         {id: 'charset', weight: 1, group: 'best-practices-browser-compat'},
         // General Group
-        {id: 'no-unload-listeners', weight: 1, group: 'best-practices-general'},
         {id: 'js-libraries', weight: 0, group: 'best-practices-general'},
         {id: 'deprecations', weight: 5, group: 'best-practices-general'},
         {id: 'third-party-cookies', weight: 5, group: 'best-practices-general'},

package/core/lib/lighthouse-compatibility.js

@@ -125,6 +125,39 @@ function upgradeLhrForCompatibility(lhr) {
     }
   }
 
+  if (majorVersion < 12 && perfCategory) {
+    /** @type {Map<string, string[]>} */
+    const metricRelevanceMap = new Map();
+
+    for (const auditRef of perfCategory.auditRefs) {
+      /** @type {string[]|undefined} */
+      // @ts-expect-error Removed in v12
+      const relevantAudits = auditRef.relevantAudits;
+      if (!relevantAudits || !auditRef.acronym) continue;
+
+      for (const auditId of relevantAudits) {
+        const acronyms = metricRelevanceMap.get(auditId) || [];
+        acronyms.push(auditRef.acronym);
+        metricRelevanceMap.set(auditId, acronyms);
+      }
+    }
+
+    for (const [auditId, acronyms] of metricRelevanceMap) {
+      if (!acronyms.length) continue;
+
+      const audit = lhr.audits[auditId];
+      if (!audit) continue;
+
+      // Old versions can still define metric savings, let's not mess with it.
+      if (audit.metricSavings) continue;
+
+      audit.metricSavings = {};
+      for (const acronym of acronyms) {
+        audit.metricSavings[acronym] = 0;
+      }
+    }
+  }
+
   // Add some minimal stuff so older reports still work.
   if (!lhr.environment) {
     lhr.environment = {