npm - lighthouse - Versions diffs - 11.3.0-dev.20231126 → 11.3.0-dev.20231127 - Mend

lighthouse 11.3.0-dev.20231126 → 11.3.0-dev.20231127

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (6) hide show

package/core/audits/accessibility/aria-allowed-role.js +1 -1
package/core/audits/third-party-summary.d.ts +20 -2
package/core/audits/third-party-summary.js +3 -48
package/package.json +1 -1
package/shared/localization/locales/en-US.json +1 -1
package/shared/localization/locales/en-XL.json +1 -1

package/core/audits/accessibility/aria-allowed-role.js CHANGED Viewed

@@ -22,7 +22,7 @@ const UIStrings = {
       'the web page. If the `role` values are misspelled, not existing ARIA `role` values, or ' +
       'abstract roles, then the purpose of the element will not be communicated to users of ' +
       'assistive technologies. ' +
-      '[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles).',
+      '[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role).',
 };
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

package/core/audits/third-party-summary.d.ts CHANGED Viewed

@@ -25,6 +25,25 @@ export type SummaryMaps = {
      */
     urls: Map<LH.Artifacts.Entity, string[]>;
 };
+/**
+ * @typedef Summary
+ * @property {number} mainThreadTime
+ * @property {number} transferSize
+ * @property {number} blockingTime
+ * @property {number} tbtImpact
+ */
+/**
+ * @typedef URLSummary
+ * @property {number} transferSize
+ * @property {number} blockingTime
+ * @property {number} tbtImpact
+ * @property {string | LH.IcuMessage} url
+ */
+/** @typedef SummaryMaps
+ * @property {Map<LH.Artifacts.Entity, Summary>} byEntity Map of impact summaries for each entity.
+ * @property {Map<string, Summary>} byURL Map of impact summaries for each URL.
+ * @property {Map<LH.Artifacts.Entity, string[]>} urls Map of URLs under each entity.
+ */
 declare class ThirdPartySummary extends Audit {
     /**
      *
@@ -38,10 +57,9 @@ declare class ThirdPartySummary extends Audit {
     /**
      * @param {LH.Artifacts.Entity} entity
      * @param {SummaryMaps} summaries
-     * @param {Summary} stats
      * @return {Array<URLSummary>}
      */
-    static makeSubItems(entity: LH.Artifacts.Entity, summaries: SummaryMaps, stats: Summary): Array<URLSummary>;
+    static makeSubItems(entity: LH.Artifacts.Entity, summaries: SummaryMaps): Array<URLSummary>;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/third-party-summary.js CHANGED Viewed

@@ -55,15 +55,6 @@ const PASS_THRESHOLD_IN_MS = 250;
  * @property {Map<LH.Artifacts.Entity, string[]>} urls Map of URLs under each entity.
  */
-/**
- * Don't bother showing resources smaller than 4KiB since they're likely to be pixels, which isn't
- * too actionable.
- */
-const MIN_TRANSFER_SIZE_FOR_SUBITEMS = 4096;
-/** Show at most 5 sub items in the resource breakdown. */
-const MAX_SUBITEMS = 5;
 class ThirdPartySummary extends Audit {
   /**
    * @return {LH.Audit.Meta}
@@ -146,51 +137,15 @@ class ThirdPartySummary extends Audit {
   /**
    * @param {LH.Artifacts.Entity} entity
    * @param {SummaryMaps} summaries
-   * @param {Summary} stats
    * @return {Array<URLSummary>}
    */
-  static makeSubItems(entity, summaries, stats) {
+  static makeSubItems(entity, summaries) {
     const entityURLs = summaries.urls.get(entity) || [];
-    let items = entityURLs
+    const items = entityURLs
       .map(url => /** @type {URLSummary} */ ({url, ...summaries.byURL.get(url)}))
-      // Filter out any cases where byURL was missing entries.
-      .filter((stat) => stat.transferSize > 0)
       // Sort by blocking time first, then transfer size to break ties.
       .sort((a, b) => (b.blockingTime - a.blockingTime) || (b.transferSize - a.transferSize));
-    const subitemSummary = {transferSize: 0, blockingTime: 0, tbtImpact: 0};
-    const minTransferSize = Math.max(MIN_TRANSFER_SIZE_FOR_SUBITEMS, stats.transferSize / 20);
-    const maxSubItems = Math.min(MAX_SUBITEMS, items.length);
-    let numSubItems = 0;
-    while (numSubItems < maxSubItems) {
-      const nextSubItem = items[numSubItems];
-      if (nextSubItem.blockingTime === 0 && nextSubItem.transferSize < minTransferSize) {
-        // Don't include the resource in the sub-item breakdown because it didn't have a big
-        // enough impact on its own.
-        break;
-      }
-      numSubItems++;
-      subitemSummary.transferSize += nextSubItem.transferSize;
-      subitemSummary.blockingTime += nextSubItem.blockingTime;
-      subitemSummary.tbtImpact += nextSubItem.tbtImpact;
-    }
-    if (!subitemSummary.blockingTime && !subitemSummary.transferSize) {
-      // Don't bother breaking down if there are no large resources.
-      return [];
-    }
-    // Only show the top N entries for brevity. If there is more than one remaining entry
-    // we'll replace the tail entries with single remainder entry.
-    items = items.slice(0, numSubItems);
-    const remainder = {
-      url: str_(i18n.UIStrings.otherResourcesLabel),
-      transferSize: stats.transferSize - subitemSummary.transferSize,
-      blockingTime: stats.blockingTime - subitemSummary.blockingTime,
-      tbtImpact: stats.tbtImpact - subitemSummary.tbtImpact,
-    };
-    if (remainder.transferSize > minTransferSize) {
-      items.push(remainder);
-    }
     return items;
   }
@@ -231,7 +186,7 @@ class ThirdPartySummary extends Audit {
           entity: entity.name,
           subItems: {
             type: /** @type {const} */ ('subitems'),
-            items: ThirdPartySummary.makeSubItems(entity, summaries, stats),
+            items: ThirdPartySummary.makeSubItems(entity, summaries),
           },
         };
       })

package/package.json CHANGED Viewed

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "11.3.0-dev.20231126",
+  "version": "11.3.0-dev.20231127",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {

package/shared/localization/locales/en-US.json CHANGED Viewed

@@ -18,7 +18,7 @@
     "message": "`[aria-*]` attributes match their roles"
   },
   "core/audits/accessibility/aria-allowed-role.js | description": {
-    "message": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles)."
+    "message": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role)."
   },
   "core/audits/accessibility/aria-allowed-role.js | failureTitle": {
     "message": "Values assigned to `role=\"\"` are not valid ARIA roles."

package/shared/localization/locales/en-XL.json CHANGED Viewed

@@ -18,7 +18,7 @@
     "message": "`[aria-*]` ât́t̂ŕîb́ût́êś m̂át̂ćĥ t́ĥéîŕ r̂ól̂éŝ"
   },
   "core/audits/accessibility/aria-allowed-role.js | description": {
-    "message": "ÂŔÎÁ `role`ŝ én̂áb̂ĺê áŝśîśt̂ív̂é t̂éĉh́n̂ól̂óĝíêś t̂ó k̂ńôẃ t̂h́ê ŕôĺê óf̂ éâćĥ él̂ém̂én̂t́ ôń t̂h́ê ẃêb́ p̂áĝé. Îf́ t̂h́ê `role` v́âĺûéŝ ár̂é m̂íŝśp̂él̂ĺêd́, n̂ót̂ éx̂íŝt́îńĝ ÁR̂ÍÂ `role` v́âĺûéŝ, ór̂ áb̂śt̂ŕâćt̂ ŕôĺêś, t̂h́êń t̂h́ê ṕûŕp̂óŝé ôf́ t̂h́ê él̂ém̂én̂t́ ŵíl̂ĺ n̂ót̂ b́ê ćôḿm̂ún̂íĉát̂éd̂ t́ô úŝér̂ś ôf́ âśŝíŝt́îv́ê t́êćĥńôĺôǵîéŝ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ ÁR̂ÍÂ ŕôĺêś](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-roles)."
+    "message": "ÂŔÎÁ `role`ŝ én̂áb̂ĺê áŝśîśt̂ív̂é t̂éĉh́n̂ól̂óĝíêś t̂ó k̂ńôẃ t̂h́ê ŕôĺê óf̂ éâćĥ él̂ém̂én̂t́ ôń t̂h́ê ẃêb́ p̂áĝé. Îf́ t̂h́ê `role` v́âĺûéŝ ár̂é m̂íŝśp̂él̂ĺêd́, n̂ót̂ éx̂íŝt́îńĝ ÁR̂ÍÂ `role` v́âĺûéŝ, ór̂ áb̂śt̂ŕâćt̂ ŕôĺêś, t̂h́êń t̂h́ê ṕûŕp̂óŝé ôf́ t̂h́ê él̂ém̂én̂t́ ŵíl̂ĺ n̂ót̂ b́ê ćôḿm̂ún̂íĉát̂éd̂ t́ô úŝér̂ś ôf́ âśŝíŝt́îv́ê t́êćĥńôĺôǵîéŝ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ ÁR̂ÍÂ ŕôĺêś](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-role)."
   },
   "core/audits/accessibility/aria-allowed-role.js | failureTitle": {
     "message": "V̂ál̂úêś âśŝíĝńêd́ t̂ó `role=\"\"` âŕê ńôt́ v̂ál̂íd̂ ÁR̂ÍÂ ŕôĺêś."