lighthouse 11.2.0-dev.20231017 → 11.2.0-dev.20231018

package/core/lib/navigation-error.d.ts

@@ -15,12 +15,11 @@ export function getInterstitialError(mainRecord: LH.Artifacts.NetworkRequest | u
  * Returns an error if the page load should be considered failed, e.g. from a
  * main document request failure, a security issue, etc.
  * @param {LH.LighthouseError|undefined} navigationError
- * @param {{url: string, loadFailureMode: LH.Config.SharedPassNavigationJson['loadFailureMode'], networkRecords: Array<LH.Artifacts.NetworkRequest>, warnings: Array<string | LH.IcuMessage>}} context
+ * @param {{url: string, networkRecords: Array<LH.Artifacts.NetworkRequest>, warnings: Array<string | LH.IcuMessage>}} context
  * @return {LH.LighthouseError|undefined}
  */
 export function getPageLoadError(navigationError: LH.LighthouseError | undefined, context: {
     url: string;
-    loadFailureMode: LH.Config.SharedPassNavigationJson['loadFailureMode'];
     networkRecords: Array<LH.Artifacts.NetworkRequest>;
     warnings: Array<string | LH.IcuMessage>;
 }): LH.LighthouseError | undefined;

package/core/lib/navigation-error.js

@@ -113,11 +113,11 @@ function getNonHtmlError(finalRecord) {
  * Returns an error if the page load should be considered failed, e.g. from a
  * main document request failure, a security issue, etc.
  * @param {LH.LighthouseError|undefined} navigationError
- * @param {{url: string, loadFailureMode: LH.Config.SharedPassNavigationJson['loadFailureMode'], networkRecords: Array<LH.Artifacts.NetworkRequest>, warnings: Array<string | LH.IcuMessage>}} context
+ * @param {{url: string, networkRecords: Array<LH.Artifacts.NetworkRequest>, warnings: Array<string | LH.IcuMessage>}} context
  * @return {LH.LighthouseError|undefined}
  */
 function getPageLoadError(navigationError, context) {
-  const {url, loadFailureMode, networkRecords} = context;
+  const {url, networkRecords} = context;
   /** @type {LH.Artifacts.NetworkRequest|undefined} */
   let mainRecord = NetworkAnalyzer.findResourceForUrl(networkRecords, url);
 
@@ -148,10 +148,6 @@ function getPageLoadError(navigationError, context) {
   const interstitialError = getInterstitialError(mainRecord, networkRecords);
   const nonHtmlError = getNonHtmlError(finalRecord);
 
-  // Check to see if we need to ignore the page load failure.
-  // e.g. When the driver is offline, the load will fail without page offline support.
-  if (loadFailureMode === 'ignore') return;
-
   // We want to special-case the interstitial beyond FAILED_DOCUMENT_REQUEST. See https://github.com/GoogleChrome/lighthouse/pull/8865#issuecomment-497507618
   if (interstitialError) return interstitialError;
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "11.2.0-dev.20231017",
+  "version": "11.2.0-dev.20231018",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {

package/types/config.d.ts

@@ -34,45 +34,11 @@ declare module Config {
   interface ResolvedConfig {
     settings: Settings;
     artifacts: AnyArtifactDefn[] | null;
-    navigations: NavigationDefn[] | null;
     audits: AuditDefn[] | null;
     categories: Record<string, Category> | null;
     groups: Record<string, Group> | null;
   }
 
-  interface SharedPassNavigationJson {
-    /**
-     * Controls the behavior when the navigation fails to complete (due to server error, no FCP, etc).
-     * Fatal means Lighthouse will exit immediately and return a runtimeError / non-zero exit code.
-     * Warn means a toplevel warning will appear in the report, but the run will complete with success.
-     * Ignore means a failure is expected and no action should be taken.
-     */
-    loadFailureMode?: 'fatal'|'warn'|'ignore';
-    /** The number of milliseconds to wait after FCP until the page should be considered loaded. */
-    pauseAfterFcpMs?: number;
-    /** The number of milliseconds to wait after the load event until the page should be considered loaded. */
-    pauseAfterLoadMs?: number;
-    /** The number of milliseconds to wait between high priority network requests or 3 simulataneous requests before the page should be considered loaded. */
-    networkQuietThresholdMs?: number;
-    /** The number of milliseconds to wait between long tasks until the page should be considered loaded. */
-    cpuQuietThresholdMs?: number;
-    /** Substring patterns of network resources to block during this navigation, '*' wildcards supported though unnecessary as prefix or suffix (due to substring matching). */
-    blockedUrlPatterns?: string[];
-    /** The URL to use for the "blank" neutral page in between navigations. Defaults to `about:blank`. */
-    blankPage?: string;
-  }
-
-  interface NavigationJson extends SharedPassNavigationJson {
-    /** The identifier for the navigation. Config extension will deduplicate navigations with the same id. */
-    id: string;
-    /** Whether throttling settings should be skipped for the pass. */
-    disableThrottling?: boolean;
-    /** Whether storage clearing (service workers, cache storage) should be skipped for the pass. A run-wide setting of `true` takes precedence over this value. */
-    disableStorageReset?: boolean;
-    /** The array of artifacts to collect during the navigation. */
-    artifacts?: Array<string>;
-  }
-
   interface ArtifactJson {
     id: string;
     gatherer: GathererJson;
@@ -121,10 +87,6 @@ declare module Config {
 
   type Settings = ConfigSettings;
 
-  interface NavigationDefn extends Omit<Required<NavigationJson>, 'artifacts'> {
-    artifacts: AnyArtifactDefn[];
-  }
-
   interface ArtifactDefn<TDependencies extends Gatherer.DependencyKey = Gatherer.DependencyKey> {
     id: string;
     gatherer: GathererDefn<TDependencies>;

package/types/internal/smokehouse.d.ts

@@ -56,14 +56,19 @@ declare global {
       {runnerName?: string} & ((url: string, config?: Config, runnerOptions?: {isDebug?: boolean}) => Promise<{lhr: LHResult, artifacts: Artifacts, log: string}>);
 
     export interface SmokehouseOptions {
-      /** If true, performs extra logging from the test runs. */
-      isDebug?: boolean;
+      /** Options to pass to the specific Lighthouse runner. */
+      testRunnerOptions?: {
+        /** If true, performs extra logging from the test runs. */
+        isDebug?: boolean;
+        /** Launch Chrome in the new headless mode (`--headless=new`), rather than the typical desktop headful mode. */
+        headless?: boolean;
+      };
       /** Manually set the number of jobs to run at once. `1` runs all tests serially. */
-      jobs?: number;
+      jobs: number;
       /** The number of times to retry failing tests before accepting. Defaults to 0. */
-      retries?: number;
+      retries: number;
       /** A function that runs Lighthouse with the given options. Defaults to running Lighthouse via the CLI. */
-      lighthouseRunner?: LighthouseRunner;
+      lighthouseRunner: LighthouseRunner;
       /** A function that gets a list of URLs requested to the server since the last fetch. */
       takeNetworkRequestUrls?: () => string[];
       /** A function run once before all smoke tests. */