lighthouse 11.1.0-dev.20230913 → 11.1.0-dev.20230914

package/core/lib/asset-saver.d.ts

@@ -1,6 +1,6 @@
 export type PreparedAssets = {
-    traceData: LH.Trace;
-    devtoolsLog: import("../index.js").DevtoolsLog;
+    traceData?: import("../index.js").Trace | undefined;
+    devtoolsLog?: import("../index.js").DevtoolsLog | undefined;
 };
 /**
  * Save artifacts object mostly to single file located at basePath/artifacts.json.
@@ -34,8 +34,8 @@ export function saveFlowArtifacts(flowArtifacts: LH.UserFlow.FlowArtifacts, base
 export function saveLhr(lhr: LH.Result, basePath: string): void;
 /**
  * @typedef {object} PreparedAssets
- * @property {LH.Trace} traceData
- * @property {LH.DevtoolsLog} devtoolsLog
+ * @property {LH.Trace} [traceData]
+ * @property {LH.DevtoolsLog} [devtoolsLog]
  */
 /**
  * Load artifacts object from files located within basePath

package/core/lib/asset-saver.js

@@ -29,8 +29,8 @@ const stepDirectoryRegex = /^step(\d+)$/;
 
 /**
  * @typedef {object} PreparedAssets
- * @property {LH.Trace} traceData
- * @property {LH.DevtoolsLog} devtoolsLog
+ * @property {LH.Trace} [traceData]
+ * @property {LH.DevtoolsLog} [devtoolsLog]
  */
 
 
@@ -420,14 +420,18 @@ async function saveLanternDebugTraces(pathWithBasename) {
  */
 async function saveAssets(artifacts, audits, pathWithBasename) {
   const allAssets = await prepareAssets(artifacts, audits);
-  const saveAll = allAssets.map(async (passAssets, index) => {
-    const devtoolsLogFilename = `${pathWithBasename}-${index}${devtoolsLogSuffix}`;
-    fs.writeFileSync(devtoolsLogFilename, JSON.stringify(passAssets.devtoolsLog, null, 2));
-    log.log('saveAssets', 'devtools log saved to disk: ' + devtoolsLogFilename);
-
-    const traceFilename = `${pathWithBasename}-${index}${traceSuffix}`;
-    await saveTrace(passAssets.traceData, traceFilename);
-    log.log('saveAssets', 'trace file streamed to disk: ' + traceFilename);
+  const saveAll = allAssets.map(async (assets, index) => {
+    if (assets.devtoolsLog) {
+      const devtoolsLogFilename = `${pathWithBasename}-${index}${devtoolsLogSuffix}`;
+      await saveDevtoolsLog(assets.devtoolsLog, devtoolsLogFilename);
+      log.log('saveAssets', 'devtools log saved to disk: ' + devtoolsLogFilename);
+    }
+
+    if (assets.traceData) {
+      const traceFilename = `${pathWithBasename}-${index}${traceSuffix}`;
+      await saveTrace(assets.traceData, traceFilename);
+      log.log('saveAssets', 'trace file streamed to disk: ' + traceFilename);
+    }
   });
 
   await Promise.all(saveAll);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "11.1.0-dev.20230913",
+  "version": "11.1.0-dev.20230914",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -166,7 +166,7 @@
     "pako": "^2.0.3",
     "preact": "^10.7.2",
     "pretty-json-stringify": "^0.0.2",
-    "puppeteer": "^21.1.1",
+    "puppeteer": "21.1.1",
     "resolve": "^1.22.1",
     "rollup": "^2.52.7",
     "rollup-plugin-polyfill-node": "^0.12.0",
@@ -199,7 +199,7 @@
     "open": "^8.4.0",
     "parse-cache-control": "1.0.1",
     "ps-list": "^8.0.0",
-    "puppeteer-core": "^21.1.1",
+    "puppeteer-core": "21.1.1",
     "robots-parser": "^3.0.1",
     "semver": "^5.3.0",
     "speedline-core": "^1.4.3",