lighthouse 10.4.0-dev.20230717 → 10.4.0-dev.20230718

package/core/gather/driver/execution-context.d.ts

@@ -11,6 +11,15 @@ export class ExecutionContext {
      * @return {string}
      */
     static serializeArguments(args: unknown[]): string;
+    /**
+     * Serializes an array of functions or strings.
+     *
+     * Also makes sure that an esbuild-bundled version of Lighthouse will
+     * continue to create working code to be executed within the browser.
+     * @param {Array<Function|string>=} deps
+     * @return {string}
+     */
+    static serializeDeps(deps?: Array<Function | string> | undefined): string;
     /** @param {LH.Gatherer.ProtocolSession} session */
     constructor(session: LH.Gatherer.ProtocolSession);
     _session: LH.Gatherer.ProtocolSession;
@@ -47,15 +56,6 @@ export class ExecutionContext {
      * @return {Promise<*>}
      */
     _evaluateInContext(expression: string, contextId: number | undefined): Promise<any>;
-    /**
-     * Serializes an array of functions or strings.
-     *
-     * Also makes sure that an esbuild-bundled version of Lighthouse will
-     * continue to create working code to be executed within the browser.
-     * @param {Array<Function|string>=} deps
-     * @return {string}
-     */
-    _serializeDeps(deps?: Array<Function | string> | undefined): string;
     /**
      * Note: Prefer `evaluate` instead.
      * Evaluate an expression in the context of the current page. If useIsolation is true, the expression

package/core/gather/driver/execution-context.js

@@ -155,28 +155,6 @@ class ExecutionContext {
     }
   }
 
-  /**
-   * Serializes an array of functions or strings.
-   *
-   * Also makes sure that an esbuild-bundled version of Lighthouse will
-   * continue to create working code to be executed within the browser.
-   * @param {Array<Function|string>=} deps
-   * @return {string}
-   */
-  _serializeDeps(deps) {
-    deps = [pageFunctions.esbuildFunctionNameStubString, ...deps || []];
-    return deps.map(dep => {
-      if (typeof dep === 'function') {
-        // esbuild will change the actual function name (ie. function actualName() {})
-        // always, despite minification settings, but preserve the real name in `actualName.name`
-        // (see esbuildFunctionNameStubString).
-        return `const ${dep.name} = ${dep}`;
-      } else {
-        return dep;
-      }
-    }).join('\n');
-  }
-
   /**
    * Note: Prefer `evaluate` instead.
    * Evaluate an expression in the context of the current page. If useIsolation is true, the expression
@@ -219,7 +197,7 @@ class ExecutionContext {
    */
   evaluate(mainFn, options) {
     const argsSerialized = ExecutionContext.serializeArguments(options.args);
-    const depsSerialized = this._serializeDeps(options.deps);
+    const depsSerialized = ExecutionContext.serializeDeps(options.deps);
 
     const expression = `(() => {
       ${depsSerialized}
@@ -239,7 +217,7 @@ class ExecutionContext {
    */
   async evaluateOnNewDocument(mainFn, options) {
     const argsSerialized = ExecutionContext.serializeArguments(options.args);
-    const depsSerialized = this._serializeDeps(options.deps);
+    const depsSerialized = ExecutionContext.serializeDeps(options.deps);
 
     const expression = `(() => {
       ${ExecutionContext._cachedNativesPreamble};
@@ -289,6 +267,28 @@ class ExecutionContext {
   static serializeArguments(args) {
     return args.map(arg => arg === undefined ? 'undefined' : JSON.stringify(arg)).join(',');
   }
+
+  /**
+   * Serializes an array of functions or strings.
+   *
+   * Also makes sure that an esbuild-bundled version of Lighthouse will
+   * continue to create working code to be executed within the browser.
+   * @param {Array<Function|string>=} deps
+   * @return {string}
+   */
+  static serializeDeps(deps) {
+    deps = [pageFunctions.esbuildFunctionNameStubString, ...deps || []];
+    return deps.map(dep => {
+      if (typeof dep === 'function') {
+        // esbuild will change the actual function name (ie. function actualName() {})
+        // always, despite minification settings, but preserve the real name in `actualName.name`
+        // (see esbuildFunctionNameStubString).
+        return `const ${dep.name} = ${dep}`;
+      } else {
+        return dep;
+      }
+    }).join('\n');
+  }
 }
 
 export {ExecutionContext};

package/core/lib/page-functions.js

@@ -514,12 +514,11 @@ function truncate(string, characterLimit) {
 }
 
 // This is to support bundled lighthouse.
-// esbuild calls every function with a builtin `__name`, whose purpose is to store the
-// real name of the function so that esbuild can rename it to avoid collisions. There is no way to
-// disable this renaming, even if esbuild minification (and thus function name mangling) is disabled.
-// Anywhere we inject dynamically generated code at runtime for the browser to process,
-// we must manually include this function (because esbuild only does so once at the top scope
-// of the bundle, which is irrelevant for code executed in the browser).
+// esbuild calls every function with a builtin `__name` (since we set keepNames: true),
+// whose purpose is to store the real name of the function so that esbuild can rename it to avoid
+// collisions. Anywhere we inject dynamically generated code at runtime for the browser to process,
+// we must manually include this function (because esbuild only does so once at the top scope of
+// the bundle, which is irrelevant for code executed in the browser).
 const esbuildFunctionNameStubString = 'var __name=(fn)=>fn;';
 
 /** @type {string} */

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "10.4.0-dev.20230717",
+  "version": "10.4.0-dev.20230718",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {

package/tsconfig.json

@@ -30,6 +30,7 @@
     "shared/localization/locales/en-US.json",
   ],
   "exclude": [
+    "build/test/*test-case*.js",
     "core/test/audits/**/*.js",
     "core/test/fixtures/**/*.js",
     "core/test/computed/**/*.js",