lighthouse 10.3.0-dev.20230619 → 10.3.0-dev.20230621

package/core/audits/accessibility/aria-dialog-name.d.ts

@@ -0,0 +1,10 @@
+export default AriaDialogName;
+declare class AriaDialogName extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=aria-dialog-name.d.ts.map

package/core/audits/accessibility/aria-dialog-name.js

@@ -0,0 +1,45 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+/**
+ * @fileoverview Ensures every ARIA dialog element has a discernable, accessible name.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accessibility audit that evaluates if ARIA dialog elements have an accessible name. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Elements with `role="dialog"` or `role="alertdialog"` have accessible names.',
+  /** Title of an accessibility audit that evaluates if ARIA dialog elements do not have accessible names. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Elements with `role="dialog"` or `role="alertdialog"` do not have accessible ' +
+      'names.',
+  /** Description of a Lighthouse audit that tells the user *why* they should have accessible names for ARIA dialog elements. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'ARIA dialog elements without accessible names may prevent screen readers users ' +
+      'from discerning the purpose of these elements. ' +
+      '[Learn how to make ARIA dialog elements more accessible](https://dequeuniversity.com/rules/axe/4.7/aria-dialog-name).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class AriaDialogName extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'aria-dialog-name',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default AriaDialogName;
+export {UIStrings};

package/core/audits/accessibility/aria-text.d.ts

@@ -0,0 +1,10 @@
+export default AriaText;
+declare class AriaText extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=aria-text.d.ts.map

package/core/audits/accessibility/aria-text.js

@@ -0,0 +1,44 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+/**
+ * @fileoverview Ensures all elements with `role=text` have no focusable descendents.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if elements with `role=text` have no focusable descendents. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Elements with the `role=text` attribute do not have focusable descendents.',
+  /** Title of an accesibility audit that evaluates if elements with `role=text` have focusable descendents. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  failureTitle: 'Elements with the `role=text` attribute do have focusable descendents.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Adding `role=text` around a text node split by markup enables VoiceOver to treat ' +
+      'it as one phrase, but the element\'s focusable descendents will not be announced. ' +
+      '[Learn more about the `role=text` attribute](https://dequeuniversity.com/rules/axe/4.7/aria-text).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class AriaText extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'aria-text',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default AriaText;
+export {UIStrings};

package/core/audits/accessibility/link-in-text-block.d.ts

@@ -0,0 +1,10 @@
+export default LinkInTextBlock;
+declare class LinkInTextBlock extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=link-in-text-block.d.ts.map

package/core/audits/accessibility/link-in-text-block.js

@@ -0,0 +1,44 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+/**
+ * @fileoverview Ensures that links can be distinguished without relying on color.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if all link elements can be distinguished without relying on color. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Links are distinguishable without relying on color.',
+  /** Title of an accesibility audit that evaluates if all link elements can be distinguished without relying on color. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Links rely on color to be distinguishable.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Low-contrast text is difficult or impossible for many users to read. Link text ' +
+      'that is discernible improves the experience for users with low vision. ' +
+      '[Learn how to make links distinguishable](https://dequeuniversity.com/rules/axe/4.7/link-in-text-block).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class LinkInTextBlock extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'link-in-text-block',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default LinkInTextBlock;
+export {UIStrings};

package/core/audits/accessibility/select-name.d.ts

@@ -0,0 +1,10 @@
+export default SelectName;
+declare class SelectName extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=select-name.d.ts.map

package/core/audits/accessibility/select-name.js

@@ -0,0 +1,44 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+/**
+ * @fileoverview Ensures select elements have programmatically associated label elements.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accesibility audit that evaluates if all select elements have programmatically associated label elements. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Select elements have associated label elements.',
+  /** Title of an accesibility audit that evaluates if all select elements have programmatically associated label elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Select elements do not have associated label elements.',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Form elements without effective labels can create frustrating experiences ' +
+      'for screen reader users. ' +
+      '[Learn more about the `select` element](https://dequeuniversity.com/rules/axe/4.7/select-name).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class SelectName extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'select-name',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default SelectName;
+export {UIStrings};

package/core/config/default-config.js

@@ -236,6 +236,7 @@ const defaultConfig = {
     'accessibility/accesskeys',
     'accessibility/aria-allowed-attr',
     'accessibility/aria-command-name',
+    'accessibility/aria-dialog-name',
     'accessibility/aria-hidden-body',
     'accessibility/aria-hidden-focus',
     'accessibility/aria-input-field-name',
@@ -245,6 +246,7 @@ const defaultConfig = {
     'accessibility/aria-required-children',
     'accessibility/aria-required-parent',
     'accessibility/aria-roles',
+    'accessibility/aria-text',
     'accessibility/aria-toggle-field-name',
     'accessibility/aria-tooltip-name',
     'accessibility/aria-treeitem-name',
@@ -269,11 +271,13 @@ const defaultConfig = {
     'accessibility/input-image-alt',
     'accessibility/label',
     'accessibility/link-name',
+    'accessibility/link-in-text-block',
     'accessibility/list',
     'accessibility/listitem',
     'accessibility/meta-refresh',
     'accessibility/meta-viewport',
     'accessibility/object-alt',
+    'accessibility/select-name',
     'accessibility/tabindex',
     'accessibility/table-fake-caption',
     'accessibility/td-has-header',
@@ -504,6 +508,7 @@ const defaultConfig = {
         {id: 'accesskeys', weight: 3, group: 'a11y-navigation'},
         {id: 'aria-allowed-attr', weight: 10, group: 'a11y-aria'},
         {id: 'aria-command-name', weight: 3, group: 'a11y-aria'},
+        {id: 'aria-dialog-name', weight: 3, group: 'a11y-aria'},
         {id: 'aria-hidden-body', weight: 10, group: 'a11y-aria'},
         {id: 'aria-hidden-focus', weight: 3, group: 'a11y-aria'},
         {id: 'aria-input-field-name', weight: 3, group: 'a11y-aria'},
@@ -513,6 +518,7 @@ const defaultConfig = {
         {id: 'aria-required-children', weight: 10, group: 'a11y-aria'},
         {id: 'aria-required-parent', weight: 10, group: 'a11y-aria'},
         {id: 'aria-roles', weight: 10, group: 'a11y-aria'},
+        {id: 'aria-text', weight: 3, group: 'a11y-aria'},
         {id: 'aria-toggle-field-name', weight: 3, group: 'a11y-aria'},
         {id: 'aria-tooltip-name', weight: 3, group: 'a11y-aria'},
         {id: 'aria-treeitem-name', weight: 3, group: 'a11y-aria'},
@@ -536,12 +542,14 @@ const defaultConfig = {
         {id: 'input-button-name', weight: 10, group: 'a11y-names-labels'},
         {id: 'input-image-alt', weight: 10, group: 'a11y-names-labels'},
         {id: 'label', weight: 10, group: 'a11y-names-labels'},
+        {id: 'link-in-text-block', weight: 3, group: 'a11y-color-contrast'},
         {id: 'link-name', weight: 3, group: 'a11y-names-labels'},
         {id: 'list', weight: 3, group: 'a11y-tables-lists'},
         {id: 'listitem', weight: 3, group: 'a11y-tables-lists'},
         {id: 'meta-refresh', weight: 10, group: 'a11y-best-practices'},
         {id: 'meta-viewport', weight: 10, group: 'a11y-best-practices'},
         {id: 'object-alt', weight: 3, group: 'a11y-names-labels'},
+        {id: 'select-name', weight: 3, group: 'a11y-names-labels'},
         {id: 'tabindex', weight: 3, group: 'a11y-navigation'},
         {id: 'table-fake-caption', weight: 3, group: 'a11y-tables-lists'},
         {id: 'td-has-header', weight: 10, group: 'a11y-tables-lists'},

package/core/gather/gatherers/accessibility.js

@@ -41,8 +41,10 @@ async function runA11yChecks() {
       // Consider http://go/prcpg for expert review of the aXe rules.
       'accesskeys': {enabled: true},
       'area-alt': {enabled: false},
+      'aria-dialog-name': {enabled: true},
       'aria-roledescription': {enabled: false},
       'aria-treeitem-name': {enabled: true},
+      'aria-text': {enabled: true},
       'audio-caption': {enabled: false},
       'blink': {enabled: false},
       'duplicate-id': {enabled: false},
@@ -52,7 +54,7 @@ async function runA11yChecks() {
       'html-xml-lang-mismatch': {enabled: true},
       'identical-links-same-purpose': {enabled: false},
       'input-button-name': {enabled: true},
-      'link-in-text-block': {enabled: false},
+      'link-in-text-block': {enabled: true},
       'marquee': {enabled: false},
       'meta-viewport': {enabled: true},
       // https://github.com/dequelabs/axe-core/issues/2958
@@ -60,7 +62,7 @@ async function runA11yChecks() {
       'no-autoplay-audio': {enabled: false},
       'role-img-alt': {enabled: false},
       'scrollable-region-focusable': {enabled: false},
-      'select-name': {enabled: false},
+      'select-name': {enabled: true},
       'server-side-image-map': {enabled: false},
       'svg-img-alt': {enabled: false},
       'tabindex': {enabled: true},