lighthouse 10.2.0-dev.20230516 → 10.2.0-dev.20230518

package/core/audits/seo/is-crawlable.d.ts

@@ -6,7 +6,6 @@ declare class IsCrawlable extends Audit {
     static handleMetaElement(metaElement: LH.Artifacts.MetaElement): {
         source: {
             snippet: string;
-            /** @type {Array<string|undefined>} */
             type: "node";
             lhId?: string | undefined;
             path?: string | undefined;

package/core/audits/server-response-time.js

@@ -76,10 +76,6 @@ class ServerResponseTime extends Audit {
       [{url: mainResource.url, responseTime}],
       {overallSavingsMs}
     );
-    details.metricSavings = {
-      FCP: overallSavingsMs,
-      LCP: overallSavingsMs,
-    };
 
     return {
       numericValue: responseTime,
@@ -87,6 +83,10 @@ class ServerResponseTime extends Audit {
       score: Number(passed),
       displayValue,
       details,
+      metricSavings: {
+        FCP: overallSavingsMs,
+        LCP: overallSavingsMs,
+      },
     };
   }
 }

package/core/lib/dependency-graph/simulator/network-analyzer.d.ts

@@ -58,13 +58,17 @@ export class NetworkAnalyzer {
         connectionReused?: boolean | undefined;
     }) => number | number[] | undefined): Map<string, number[]>;
     /**
-     * Estimates the observed RTT to each origin based on how long the TCP handshake took.
+     * Estimates the observed RTT to each origin based on how long the connection setup.
+     * For h1 and h2, this could includes two estimates - one for the TCP handshake, another for
+     * SSL negotiation.
+     * For h3, we get only one estimate since QUIC establishes a secure connection in a
+     * single handshake.
      * This is the most accurate and preferred method of measurement when the data is available.
      *
      * @param {LH.Artifacts.NetworkRequest[]} records
      * @return {Map<string, number[]>}
      */
-    static _estimateRTTByOriginViaTCPTiming(records: LH.Artifacts.NetworkRequest[]): Map<string, number[]>;
+    static _estimateRTTByOriginViaConnectionTiming(records: LH.Artifacts.NetworkRequest[]): Map<string, number[]>;
     /**
      * Estimates the observed RTT to each origin based on how long a download took on a fresh connection.
      * NOTE: this will tend to overestimate the actual RTT quite significantly as the download can be

package/core/lib/dependency-graph/simulator/network-analyzer.js

@@ -114,19 +114,25 @@ class NetworkAnalyzer {
   }
 
   /**
-   * Estimates the observed RTT to each origin based on how long the TCP handshake took.
+   * Estimates the observed RTT to each origin based on how long the connection setup.
+   * For h1 and h2, this could includes two estimates - one for the TCP handshake, another for
+   * SSL negotiation.
+   * For h3, we get only one estimate since QUIC establishes a secure connection in a
+   * single handshake.
    * This is the most accurate and preferred method of measurement when the data is available.
    *
    * @param {LH.Artifacts.NetworkRequest[]} records
    * @return {Map<string, number[]>}
    */
-  static _estimateRTTByOriginViaTCPTiming(records) {
-    return NetworkAnalyzer._estimateValueByOrigin(records, ({timing, connectionReused}) => {
+  static _estimateRTTByOriginViaConnectionTiming(records) {
+    return NetworkAnalyzer._estimateValueByOrigin(records, ({timing, connectionReused, record}) => {
       if (connectionReused) return;
 
-      // If the request was SSL we get two estimates, one for the SSL negotiation and another for the
-      // regular handshake. SSL can also be more than 1 RT but assume False Start was used.
-      if (timing.sslStart > 0 && timing.sslEnd > 0) {
+      if (timing.connectEnd > 0 && timing.connectStart > 0 && record.protocol.startsWith('h3')) {
+        // These values are equal to sslStart and sslEnd for h3.
+        return timing.connectEnd - timing.connectStart;
+      } else if (timing.sslStart > 0 && timing.sslEnd > 0) {
+        // SSL can also be more than 1 RT but assume False Start was used.
         return [timing.connectEnd - timing.sslStart, timing.sslStart - timing.connectStart];
       } else if (timing.connectStart > 0 && timing.connectEnd > 0) {
         return timing.connectEnd - timing.connectStart;
@@ -318,7 +324,7 @@ class NetworkAnalyzer {
       useHeadersEndEstimates = true,
     } = options || {};
 
-    let estimatesByOrigin = NetworkAnalyzer._estimateRTTByOriginViaTCPTiming(records);
+    let estimatesByOrigin = NetworkAnalyzer._estimateRTTByOriginViaConnectionTiming(records);
     if (!estimatesByOrigin.size || forceCoarseEstimates) {
       estimatesByOrigin = new Map();
       const estimatesViaDownload = NetworkAnalyzer._estimateRTTByOriginViaDownloadTiming(records);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "10.2.0-dev.20230516",
+  "version": "10.2.0-dev.20230518",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -187,7 +187,7 @@
   },
   "dependencies": {
     "@sentry/node": "^6.17.4",
-    "axe-core": "4.7.0",
+    "axe-core": "4.7.1",
     "chrome-launcher": "^0.15.2",
     "configstore": "^5.0.1",
     "csp_evaluator": "1.1.1",

package/readme.md

@@ -399,6 +399,7 @@ Other awesome open source projects that use Lighthouse.
 * **[site-audit-seo](https://github.com/viasite/site-audit-seo)** - CLI tool for SEO site audit, crawl site, lighthouse each page. Output to console and tables in csv, xlsx, json, web or Google Drive.
 * **[webpack-lighthouse-plugin](https://github.com/addyosmani/webpack-lighthouse-plugin)** - Run Lighthouse from a Webpack build.
 * **[cypress-audit](https://github.com/mfrachet/cypress-audit)** - Run Lighthouse and Pa11y audits directly in your E2E test suites.
+* **[laravel-lighthouse](https://github.com/adityadees/laravel-lighthouse)** - Google Lighthouse wrapper for laravel framework to run Google Lighthouse CLI with custom option and can automatically save result in your server directory.
 
 ## FAQ
 

package/types/audit.d.ts

@@ -18,6 +18,7 @@ declare module Audit {
   export type Result = AuditResult.Result;
   export type ScoreDisplayMode = AuditResult.ScoreDisplayMode;
   export type ScoreDisplayModes = AuditResult.ScoreDisplayModes;
+  export type MetricSavings = AuditResult.MetricSavings;
 
   type Context = Util.Immutable<{
     /** audit options */
@@ -81,6 +82,8 @@ declare module Audit {
     details?: AuditDetails;
     /** If an audit encounters unusual execution circumstances, strings can be put in this optional array to add top-level warnings to the LHR. */
     runWarnings?: Array<IcuMessage>;
+    /** [EXPERIMENTAL] Estimates of how much this audit affects various performance metrics. Values will be in the unit of the respective metrics. */
+    metricSavings?: MetricSavings;
   }
 
   /** The Audit.Product type for audits that do not return a `numericValue`. */

package/types/lhr/audit-details.d.ts

@@ -15,8 +15,6 @@ interface BaseDetails {
   overallSavingsBytes?: number;
   /** Additional information, usually used for including debug or meta information in the LHR */
   debugData?: Details.DebugData;
-  /** Estimates of how much this audit affects various performance metrics. Values will be in the unit of the respective metrics. */
-  metricSavings?: Details.MetricSavings;
 }
 
 type Details =
@@ -306,13 +304,6 @@ declare module Details {
     granularity?: number,
   }
 
-  interface MetricSavings {
-    LCP?: number;
-    FCP?: number;
-    CLS?: number;
-    TBT?: number;
-    INP?: number;
-  }
 }
 
 export default Details;

package/types/lhr/audit-result.d.ts

@@ -24,6 +24,14 @@ interface ScoreDisplayModes {
 
 type ScoreDisplayMode = ScoreDisplayModes[keyof ScoreDisplayModes];
 
+interface MetricSavings {
+  LCP?: number;
+  FCP?: number;
+  CLS?: number;
+  TBT?: number;
+  INP?: number;
+}
+
 /** Audit result returned in Lighthouse report. All audits offer a description and score of 0-1. */
 export interface Result {
   displayValue?: string;
@@ -50,8 +58,6 @@ export interface Result {
   id: string;
   /** A more detailed description that describes why the audit is important and links to Lighthouse documentation on the audit; markdown links supported. */
   description: string;
-  /** Estimates of how much this audit affects various performance metrics. Values will be in the unit of the respective metrics. */
-  metricSavings?: AuditDetails.MetricSavings;
   /** A numeric value that has a meaning specific to the audit, e.g. the number of nodes in the DOM or the timestamp of a specific load event. More information can be found in the audit details, if present. */
   numericValue?: number;
   /** The unit of `numericValue`, used when the consumer wishes to convert numericValue to a display string. */