lighthouse 10.1.0 → 10.1.1

package/core/audits/installable-manifest.d.ts

@@ -109,6 +109,7 @@ export const UIStrings: {
     /** Message logged when the web app has been uninstalled o desktop, signalling that the install banner state is being reset. */
     'pipeline-restarted': string;
     /**
+     * TODO: This error was removed in M114, we can remove this message when it hits stable.
      * @description Error message explaining that the URL of the manifest uses a scheme that is not supported on Android.
      * @example {data:} scheme
      */

package/core/audits/installable-manifest.js

@@ -44,6 +44,7 @@ const UIStrings = {
   'manifest-display-not-supported': `Manifest 'display' property must be one of 'standalone', 'fullscreen', or 'minimal-ui'`,
   /** Error message explaining that the manifest could not be fetched, might be empty, or could not be parsed. */
   'manifest-empty': `Manifest could not be fetched, is empty, or could not be parsed`,
+  // TODO: This error was removed in M114, we can remove this message when it hits stable.
   /** Error message explaining that no matching service worker was detected,
    * and provides a suggestion to reload the page or check whether the scope of the service worker
    * for the current page encloses the scope and start URL from the manifest. */
@@ -97,6 +98,7 @@ const UIStrings = {
   /** Message logged when the web app has been uninstalled o desktop, signalling that the install banner state is being reset. */
   'pipeline-restarted': 'PWA has been uninstalled and installability checks resetting.',
   /**
+   * TODO: This error was removed in M114, we can remove this message when it hits stable.
    * @description Error message explaining that the URL of the manifest uses a scheme that is not supported on Android.
    * @example {data:} scheme
    */

package/core/gather/gatherers/image-elements.js

@@ -84,6 +84,7 @@ function getHTMLImages(allElements) {
       isPicture,
       loading: element.loading,
       isInShadowDOM: element.getRootNode() instanceof ShadowRoot,
+      fetchPriority: element.fetchPriority,
       // @ts-expect-error - getNodeDetails put into scope via stringification
       node: getNodeDetails(element),
     };

package/core/gather/gatherers/inspector-issues.js

@@ -61,6 +61,7 @@ class InspectorIssues extends FRGatherer {
     const artifact = {
       attributionReportingIssue: [],
       blockedByResponseIssue: [],
+      bounceTrackingIssue: [],
       clientHintIssue: [],
       contentSecurityPolicyIssue: [],
       corsIssue: [],

package/core/gather/gatherers/link-elements.d.ts

@@ -35,5 +35,8 @@ declare class LinkElements extends FRGatherer {
      */
     getArtifact(context: LH.Gatherer.FRTransitionalContext<'DevtoolsLog'>): Promise<LH.Artifacts['LinkElements']>;
 }
+export namespace UIStrings {
+    const headerParseWarning: string;
+}
 import FRGatherer from "../base-gatherer.js";
 //# sourceMappingURL=link-elements.d.ts.map

package/core/gather/gatherers/link-elements.js

@@ -10,6 +10,8 @@ import FRGatherer from '../base-gatherer.js';
 import {pageFunctions} from '../../lib/page-functions.js';
 import DevtoolsLog from './devtools-log.js';
 import {MainResource} from '../../computed/main-resource.js';
+import {Util} from '../../../shared/util.js';
+import * as i18n from '../../lib/i18n/i18n.js';
 
 /* globals HTMLLinkElement getNodeDetails */
 
@@ -19,6 +21,17 @@ import {MainResource} from '../../computed/main-resource.js';
  * headers of the main resource.
  */
 
+const UIStrings = {
+  /**
+   * @description Warning message explaining that there was an error parsing a link header in an HTTP response. `error` will be an english string with more details on the error. `header` will be the value of the header that caused the error. `link` is a type of HTTP header and should not be translated.
+   * @example {Expected attribute delimiter at offset 94} error
+   * @example {<https://assets.calendly.com/assets/booking/css/booking-d0ac32b1.css>; rel=preload; as=style; nopush} error
+   */
+  headerParseWarning: 'Error parsing `link` header ({error}): `{header}`',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
 /**
  *
  * @param {string} url
@@ -70,6 +83,7 @@ function getLinkElementsInDOM() {
       crossOrigin: link.crossOrigin,
       hrefRaw,
       source,
+      fetchPriority: link.fetchPriority,
       // @ts-expect-error - put into scope via stringification
       node: getNodeDetails(link),
     });
@@ -125,7 +139,21 @@ class LinkElements extends FRGatherer {
     for (const header of mainDocument.responseHeaders) {
       if (header.name.toLowerCase() !== 'link') continue;
 
-      for (const link of LinkHeader.parse(header.value).refs) {
+      /** @type {LinkHeader.Reference[]} */
+      let parsedRefs = [];
+
+      try {
+        parsedRefs = LinkHeader.parse(header.value).refs;
+      } catch (err) {
+        const truncatedHeader = Util.truncate(header.value, 100);
+        const warning = str_(UIStrings.headerParseWarning, {
+          error: err.message,
+          header: truncatedHeader,
+        });
+        context.baseArtifacts.LighthouseRunWarnings.push(warning);
+      }
+
+      for (const link of parsedRefs) {
         linkElements.push({
           rel: link.rel || '',
           href: normalizeUrlOrNull(link.uri, context.baseArtifacts.URL.finalDisplayedUrl),
@@ -134,6 +162,7 @@ class LinkElements extends FRGatherer {
           as: link.as || '',
           crossOrigin: getCrossoriginFromHeader(link.crossorigin),
           source: 'headers',
+          fetchPriority: link.fetchpriority,
           node: null,
         });
       }
@@ -179,3 +208,4 @@ class LinkElements extends FRGatherer {
 }
 
 export default LinkElements;
+export {UIStrings};

package/core/lib/deprecations-strings.d.ts

@@ -3,12 +3,12 @@
  */
 declare function getDescription(issueDetails: LH.Crdp.Audits.DeprecationIssueDetails): {
     file: string;
-    substitutions: Map<string, import("../index.js").IcuMessage>;
+    substitutions: Map<string, import("../index.js").IcuMessage | undefined>;
     links: {
         link: string;
         linkTitle: import("../index.js").IcuMessage;
     }[];
-    message: import("../index.js").IcuMessage;
+    message: import("../index.js").IcuMessage | undefined;
 };
 export namespace UIStrings {
     const feature: string;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "10.1.0",
+  "version": "10.1.1",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -142,7 +142,6 @@
     "cpy": "^8.1.2",
     "cross-env": "^7.0.2",
     "csv-validator": "^0.0.3",
-    "devtools-protocol": "0.0.1081726",
     "es-main": "^1.0.2",
     "eslint": "^8.4.1",
     "eslint-config-google": "^0.14.0",
@@ -191,8 +190,9 @@
     "chrome-launcher": "^0.15.1",
     "configstore": "^5.0.1",
     "csp_evaluator": "1.1.1",
+    "devtools-protocol": "0.0.1130274",
     "enquirer": "^2.3.6",
-    "http-link-header": "^1.1.0",
+    "http-link-header": "^1.1.1",
     "intl-messageformat": "^4.4.0",
     "jpeg-js": "^0.4.4",
     "js-library-detector": "^6.6.0",
@@ -214,8 +214,8 @@
     "yargs-parser": "^21.0.0"
   },
   "resolutions": {
-    "puppeteer/**/devtools-protocol": "0.0.1081726",
-    "puppeteer-core/**/devtools-protocol": "0.0.1081726"
+    "puppeteer/**/devtools-protocol": "0.0.1130274",
+    "puppeteer-core/**/devtools-protocol": "0.0.1130274"
   },
   "repository": "GoogleChrome/lighthouse",
   "keywords": [

package/shared/localization/locales/en-US.json

@@ -1715,6 +1715,9 @@
   "core/gather/driver/storage.js | warningOriginDataTimeout": {
     "message": "Clearing the origin data timed out. Try auditing this page again and file a bug if the issue persists."
   },
+  "core/gather/gatherers/link-elements.js | headerParseWarning": {
+    "message": "Error parsing `link` header ({error}): `{header}`"
+  },
   "core/lib/bf-cache-strings.js | appBanner": {
     "message": "Pages that requested an AppBanner are not currently eligible for back/forward cache."
   },

package/shared/localization/locales/en-XL.json

@@ -1715,6 +1715,9 @@
   "core/gather/driver/storage.js | warningOriginDataTimeout": {
     "message": "Ĉĺêár̂ín̂ǵ t̂h́ê ór̂íĝín̂ d́ât́â t́îḿêd́ ôút̂. T́r̂ý âúd̂ít̂ín̂ǵ t̂h́îś p̂áĝé âǵâín̂ án̂d́ f̂íl̂é â b́ûǵ îf́ t̂h́ê íŝśûé p̂ér̂śîśt̂ś."
   },
+  "core/gather/gatherers/link-elements.js | headerParseWarning": {
+    "message": "Êŕr̂ór̂ ṕâŕŝín̂ǵ `link` ĥéâd́êŕ ({error}): `{header}`"
+  },
   "core/lib/bf-cache-strings.js | appBanner": {
     "message": "P̂áĝéŝ t́ĥát̂ ŕêq́ûéŝt́êd́ âń Âṕp̂B́âńn̂ér̂ ár̂é n̂ót̂ ćûŕr̂én̂t́l̂ý êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê."
   },

package/third-party/chromium-synchronization/inspector-issueAdded-types-test.js

@@ -34,6 +34,7 @@ describe('issueAdded types', () => {
 Array [
   "attributionReportingIssueDetails",
   "blockedByResponseIssueDetails",
+  "bounceTrackingIssueDetails",
   "clientHintIssueDetails",
   "contentSecurityPolicyIssueDetails",
   "cookieIssueDetails",

package/third-party/chromium-synchronization/installability-errors-test.js

@@ -57,7 +57,6 @@ Array [
   "no-icon-available",
   "no-id-specified",
   "no-manifest",
-  "no-matching-service-worker",
   "no-url-for-service-worker",
   "not-from-secure-origin",
   "not-offline-capable",
@@ -65,7 +64,6 @@ Array [
   "platform-not-supported-on-android",
   "prefer-related-applications",
   "prefer-related-applications-only-beta-stable",
-  "scheme-not-supported-for-webapk",
   "start-url-not-valid",
   "url-not-supported-for-webapk",
   "warn-not-offline-capable",

package/types/artifacts.d.ts

@@ -308,6 +308,8 @@ declare module Artifacts {
     /** Where the link was found, either in the DOM or in the headers of the main document */
     source: 'head'|'body'|'headers'
     node: NodeDetails | null
+    /** The fetch priority hint for preload links. */
+    fetchPriority?: string;
   }
 
   interface Script extends Omit<Crdp.Debugger.ScriptParsedEvent, 'url'|'embedderName'> {
@@ -534,6 +536,8 @@ declare module Artifacts {
     node: NodeDetails;
     /** The loading attribute of the image. */
     loading?: string;
+    /** The fetch priority hint for HTMLImageElements. */
+    fetchPriority?: string;
   }
 
   interface OptimizedImage {
@@ -599,6 +603,7 @@ declare module Artifacts {
   interface InspectorIssues {
     attributionReportingIssue: Crdp.Audits.AttributionReportingIssueDetails[];
     blockedByResponseIssue: Crdp.Audits.BlockedByResponseIssueDetails[];
+    bounceTrackingIssue: Crdp.Audits.BounceTrackingIssueDetails[];
     clientHintIssue: Crdp.Audits.ClientHintIssueDetails[];
     contentSecurityPolicyIssue: Crdp.Audits.ContentSecurityPolicyIssueDetails[];
     corsIssue: Crdp.Audits.CorsIssueDetails[];

package/types/internal/node.d.ts

@@ -35,9 +35,22 @@ declare global {
 
     /** Injected into the page when the `--debug` flag is used. */
     continueLighthouseRun(): void;
+  }
 
-    // Not defined in tsc yet: https://github.com/microsoft/TypeScript/issues/40807
-    requestIdleCallback(callback: (deadline: {didTimeout: boolean, timeRemaining: () => DOMHighResTimeStamp}) => void, options?: {timeout: number}): number;
+  // `fetchPriority` not defined in tsc as of 4.9.4.
+  interface HTMLImageElement {
+    /**
+     * Sets the priority for fetches initiated by the element.
+     * @see https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-fetchpriority
+     */
+    fetchPriority: string;
+  }
+  interface HTMLLinkElement {
+    /**
+     * Sets the priority for fetches initiated by the element.
+     * @see https://html.spec.whatwg.org/multipage/semantics.html#dom-link-fetchpriority
+     */
+    fetchPriority: string;
   }
 }