lighthouse 10.1.0-dev.20230327 → 10.1.0-dev.20230329

package/core/gather/gatherers/link-elements.d.ts

@@ -35,5 +35,8 @@ declare class LinkElements extends FRGatherer {
      */
     getArtifact(context: LH.Gatherer.FRTransitionalContext<'DevtoolsLog'>): Promise<LH.Artifacts['LinkElements']>;
 }
+export namespace UIStrings {
+    const headerParseWarning: string;
+}
 import FRGatherer from "../base-gatherer.js";
 //# sourceMappingURL=link-elements.d.ts.map

package/core/gather/gatherers/link-elements.js

@@ -10,6 +10,8 @@ import FRGatherer from '../base-gatherer.js';
 import {pageFunctions} from '../../lib/page-functions.js';
 import DevtoolsLog from './devtools-log.js';
 import {MainResource} from '../../computed/main-resource.js';
+import {Util} from '../../../shared/util.js';
+import * as i18n from '../../lib/i18n/i18n.js';
 
 /* globals HTMLLinkElement getNodeDetails */
 
@@ -19,6 +21,17 @@ import {MainResource} from '../../computed/main-resource.js';
  * headers of the main resource.
  */
 
+const UIStrings = {
+  /**
+   * @description Warning message explaining that there was an error parsing a link header in an HTTP response. `error` will be an english string with more details on the error. `header` will be the value of the header that caused the error. `link` is a type of HTTP header and should not be translated.
+   * @example {Expected attribute delimiter at offset 94} error
+   * @example {<https://assets.calendly.com/assets/booking/css/booking-d0ac32b1.css>; rel=preload; as=style; nopush} error
+   */
+  headerParseWarning: 'Error parsing `link` header ({error}): `{header}`',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
 /**
  *
  * @param {string} url
@@ -126,7 +139,21 @@ class LinkElements extends FRGatherer {
     for (const header of mainDocument.responseHeaders) {
       if (header.name.toLowerCase() !== 'link') continue;
 
-      for (const link of LinkHeader.parse(header.value).refs) {
+      /** @type {LinkHeader.Reference[]} */
+      let parsedRefs = [];
+
+      try {
+        parsedRefs = LinkHeader.parse(header.value).refs;
+      } catch (err) {
+        const truncatedHeader = Util.truncate(header.value, 100);
+        const warning = str_(UIStrings.headerParseWarning, {
+          error: err.message,
+          header: truncatedHeader,
+        });
+        context.baseArtifacts.LighthouseRunWarnings.push(warning);
+      }
+
+      for (const link of parsedRefs) {
         linkElements.push({
           rel: link.rel || '',
           href: normalizeUrlOrNull(link.uri, context.baseArtifacts.URL.finalDisplayedUrl),
@@ -181,3 +208,4 @@ class LinkElements extends FRGatherer {
 }
 
 export default LinkElements;
+export {UIStrings};

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "10.1.0-dev.20230327",
+  "version": "10.1.0-dev.20230329",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {

package/shared/localization/locales/en-US.json

@@ -1715,6 +1715,9 @@
   "core/gather/driver/storage.js | warningOriginDataTimeout": {
     "message": "Clearing the origin data timed out. Try auditing this page again and file a bug if the issue persists."
   },
+  "core/gather/gatherers/link-elements.js | headerParseWarning": {
+    "message": "Error parsing `link` header ({error}): `{header}`"
+  },
   "core/lib/bf-cache-strings.js | appBanner": {
     "message": "Pages that requested an AppBanner are not currently eligible for back/forward cache."
   },

package/shared/localization/locales/en-XL.json

@@ -1715,6 +1715,9 @@
   "core/gather/driver/storage.js | warningOriginDataTimeout": {
     "message": "Ĉĺêár̂ín̂ǵ t̂h́ê ór̂íĝín̂ d́ât́â t́îḿêd́ ôút̂. T́r̂ý âúd̂ít̂ín̂ǵ t̂h́îś p̂áĝé âǵâín̂ án̂d́ f̂íl̂é â b́ûǵ îf́ t̂h́ê íŝśûé p̂ér̂śîśt̂ś."
   },
+  "core/gather/gatherers/link-elements.js | headerParseWarning": {
+    "message": "Êŕr̂ór̂ ṕâŕŝín̂ǵ `link` ĥéâd́êŕ ({error}): `{header}`"
+  },
   "core/lib/bf-cache-strings.js | appBanner": {
     "message": "P̂áĝéŝ t́ĥát̂ ŕêq́ûéŝt́êd́ âń Âṕp̂B́âńn̂ér̂ ár̂é n̂ót̂ ćûŕr̂én̂t́l̂ý êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê."
   },