lighthouse 10.0.0 → 10.0.1

package/report/test/renderer/details-renderer-test.js

@@ -1,882 +0,0 @@
-/**
- * @license Copyright 2017 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-
-import assert from 'assert/strict';
-
-import jsdom from 'jsdom';
-
-import {DOM} from '../../renderer/dom.js';
-import {I18nFormatter} from '../../renderer/i18n-formatter.js';
-import {DetailsRenderer} from '../../renderer/details-renderer.js';
-import {Globals} from '../../renderer/report-globals.js';
-
-describe('DetailsRenderer', () => {
-  let renderer;
-
-  function createRenderer(options) {
-    const {document} = new jsdom.JSDOM().window;
-    const dom = new DOM(document);
-    renderer = new DetailsRenderer(dom, options);
-  }
-
-  before(() => {
-    Globals.apply({
-      providedStrings: {},
-      i18n: new I18nFormatter('en'),
-      reportJson: null,
-    });
-    createRenderer();
-  });
-
-  after(() => {
-    Globals.i18n = undefined;
-  });
-
-  describe('render', () => {
-    it('renders filmstrips', () => {
-      const el = renderer.render({
-        type: 'filmstrip',
-        items: [
-          {timing: 1020, data: 'data:image/jpeg;base64,foobar'},
-          {timing: 3030, data: 'data:image/jpeg;base64,foobaz'},
-        ],
-      });
-
-      assert.ok(el.localName === 'div');
-      assert.ok(el.classList.contains('lh-filmstrip'));
-
-      const frames = [...el.querySelectorAll('.lh-filmstrip__frame')];
-      assert.equal(frames.length, 2);
-
-      const thumbnails = [...el.querySelectorAll('.lh-filmstrip__thumbnail')];
-      assert.equal(thumbnails.length, 2);
-      assert.equal(thumbnails[0].src, 'data:image/jpeg;base64,foobar');
-      assert.ok(thumbnails[0].alt, 'did not set alt text');
-    });
-
-    it('renders tables', () => {
-      const el = renderer.render({
-        type: 'table',
-        headings: [
-          {text: 'First', key: 'a', valueType: 'text'},
-          {text: 'Second', key: 'b', valueType: 'text'},
-          {text: 'Preview', key: 'c', valueType: 'thumbnail'},
-        ],
-        items: [
-          {
-            a: 'value A.1',
-            b: 'value A.2',
-            c: 'http://example.com/image.jpg',
-          },
-          {
-            a: 'value B.1',
-            b: 'value B.2',
-            c: 'unknown',
-          },
-        ],
-      });
-
-      assert.equal(el.localName, 'table', 'did not render table');
-      assert.ok(el.querySelector('img'), 'did not render recursive items');
-      assert.equal(el.querySelectorAll('th').length, 3, 'did not render header items');
-      assert.equal(el.querySelectorAll('td').length, 6, 'did not render table cells');
-      assert.equal(el.querySelectorAll('.lh-table-column--text').length, 6, '--text not set');
-      assert.equal(el.querySelectorAll('.lh-table-column--thumbnail').length, 3,
-          '--thumbnail not set');
-    });
-
-    it('renders with default granularity', () => {
-      const el = renderer.render({
-        type: 'table',
-        headings: [
-          {text: '', key: 'bytes', valueType: 'bytes'},
-          {text: '', key: 'numeric', valueType: 'numeric'},
-          {text: '', key: 'ms', valueType: 'ms'},
-          // Verify that 0 is ignored.
-          {text: '', key: 'ms', valueType: 'ms', granularity: 0},
-        ],
-        items: [
-          {
-            bytes: 1234.567,
-            numeric: 1234.567,
-            ms: 1234.567,
-          },
-        ],
-      });
-
-      assert.equal(el.querySelectorAll('td').length, 4, 'did not render table cells');
-      assert.equal(el.querySelectorAll('td')[0].textContent, '1.2\xa0KiB');
-      assert.equal(el.querySelectorAll('td')[1].textContent, '1,234.6');
-      assert.equal(el.querySelectorAll('td')[2].textContent, '1,230\xa0ms');
-      assert.equal(el.querySelectorAll('td')[3].textContent, '1,230\xa0ms');
-    });
-
-    it('renders with custom granularity', () => {
-      const el = renderer.render({
-        type: 'table',
-        headings: [
-          {text: '', key: 'bytes', valueType: 'bytes', granularity: 0.01},
-          {text: '', key: 'numeric', valueType: 'numeric', granularity: 100},
-          {text: '', key: 'ms', valueType: 'ms', granularity: 1},
-        ],
-        items: [
-          {
-            bytes: 1234.567,
-            numeric: 1234.567,
-            ms: 1234.567,
-          },
-        ],
-      });
-
-      assert.equal(el.querySelectorAll('td').length, 3, 'did not render table cells');
-      assert.equal(el.querySelectorAll('td')[0].textContent, '1.21\xa0KiB');
-      assert.equal(el.querySelectorAll('td')[1].textContent, '1,200');
-      assert.equal(el.querySelectorAll('td')[2].textContent, '1,235\xa0ms');
-    });
-
-    it('renders critical request chains', () => {
-      const details = {
-        type: 'criticalrequestchain',
-        longestChain: {
-          duration: 2,
-          length: 1,
-          transferSize: 221,
-        },
-        chains: {
-          F3B687683512E0F003DD41EB23E2091A: {
-            request: {
-              url: 'https://example.com',
-              startTime: 0,
-              endTime: 2,
-              responseReceivedTime: 1,
-              transferSize: 221,
-            },
-            children: {},
-          },
-        },
-      };
-
-      const crcEl = renderer.render(details);
-      assert.ok(crcEl.classList.contains('lh-crc-container'));
-      assert.strictEqual(crcEl.querySelectorAll('.lh-crc-node').length, 1);
-    });
-
-    it('renders opportunity details as a table', () => {
-      const details = {
-        type: 'opportunity',
-        headings: [
-          {key: 'url', valueType: 'url', label: 'URL'},
-          {key: 'totalBytes', valueType: 'bytes', label: 'Size (KiB)'},
-          {key: 'wastedBytes', valueType: 'bytes', label: 'Potential Savings (KiB)'},
-        ],
-        items: [{
-          url: 'https://example.com',
-          totalBytes: 71654,
-          wastedBytes: 30470,
-          wastedPercent: 42,
-        }],
-        overallSavingsMs: 150,
-        overallSavingsBytes: 30470,
-      };
-
-      const oppEl = renderer.render(details);
-      assert.equal(oppEl.localName, 'table');
-      assert.ok(oppEl.querySelector('.lh-text__url').title === 'https://example.com', 'did not render recursive items');
-      assert.equal(oppEl.querySelectorAll('th').length, 3, 'did not render header items');
-      assert.equal(oppEl.querySelectorAll('td').length, 3, 'did not render table cells');
-      assert.equal(oppEl.querySelectorAll('.lh-table-column--url').length, 2, 'url column not set');
-      assert.equal(oppEl.querySelectorAll('.lh-table-column--bytes').length, 4, 'bytes not set');
-    });
-
-    it('renders lists', () => {
-      const table = {
-        type: 'table',
-        headings: [{text: '', key: 'numeric', valueType: 'numeric'}],
-        items: [{numeric: 1234.567}],
-      };
-
-      const el = renderer.render({
-        type: 'list',
-        items: [table, table],
-      });
-
-      assert.equal(el.localName, 'div');
-      assert.ok(el.classList.contains('lh-list'), 'has list class');
-      assert.ok(el.children.length, 2, 'renders all items');
-      for (const child of el.children) {
-        assert.ok(child.classList.contains('lh-table'));
-        assert.equal(child.textContent, '1,234.6');
-      }
-    });
-
-    it('does not render internal-only screenshot details', () => {
-      const details = {
-        type: 'screenshot',
-        timestamp: 185600000,
-        data: 'data:image/jpeg;base64,/9j/4AAQSkZJRYP/2Q==',
-      };
-
-      const screenshotEl = renderer.render(details);
-      assert.strictEqual(screenshotEl, null);
-    });
-
-    it('does not render internal-only diagnostic details', () => {
-      const details = {
-        type: 'debugdata',
-        items: [{
-          failures: ['No manifest was fetched'],
-          isParseFailure: true,
-          parseFailureReason: 'No manifest was fetched',
-        }],
-      };
-
-      const diagnosticEl = renderer.render(details);
-      assert.strictEqual(diagnosticEl, null);
-    });
-
-    describe('unknown types', () => {
-      // console.error is set to a no-op, to avoid distracting log spam in the test output.
-      let consoleError;
-      beforeEach(() => {
-        consoleError = console.error;
-        console.error = () => {};
-      });
-      afterEach(() => {
-        console.error = consoleError;
-      });
-
-      it('renders an unknown details type', () => {
-        // Disallowed by type system, but test that we get an error message out just in case.
-        const details = {
-          type: 'imaginary',
-          items: 5,
-        };
-
-        const el = renderer.render(details);
-        const summaryEl = el.querySelector('summary');
-        expect(summaryEl.textContent)
-          .toContain('We don\'t know how to render audit details of type `imaginary`');
-        assert.strictEqual(el.lastChild.textContent, JSON.stringify(details, null, 2));
-      });
-    });
-  });
-
-  describe('Table rendering', () => {
-    it('renders text values', () => {
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'text', label: 'Heading'}],
-        items: [{content: 'My text content'}],
-      };
-
-      const el = renderer.render(details);
-      const textEls = el.querySelectorAll('.lh-text');
-      assert.strictEqual(textEls[0].textContent, 'Heading');
-      assert.strictEqual(textEls[1].textContent, 'My text content');
-    });
-
-    it('renders not much if items are empty', () => {
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'text', label: 'Heading'}],
-        items: [],
-      };
-
-      const el = renderer.render(details);
-      assert.strictEqual(el.outerHTML, '<span></span>');
-    });
-
-    it('renders an empty cell if item is missing a property', () => {
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'text', label: 'Heading'}],
-        items: [
-          {},
-          {content: undefined},
-          {content: 'a thing'},
-        ],
-      };
-
-      const el = renderer.render(details);
-      const itemEls = el.querySelectorAll('td');
-      assert.strictEqual(itemEls.length, 3);
-
-      // missing prop
-      assert.ok(itemEls[0].classList.contains('lh-table-column--empty'));
-      assert.strictEqual(itemEls[0].innerHTML, '');
-
-      // undefined prop
-      assert.ok(itemEls[1].classList.contains('lh-table-column--empty'));
-      assert.strictEqual(itemEls[1].innerHTML, '');
-
-      // defined prop
-      assert.ok(itemEls[2].classList.contains('lh-table-column--text'));
-      assert.strictEqual(itemEls[2].textContent, 'a thing');
-    });
-
-    it('renders code values from a string', () => {
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'code', label: 'Heading'}],
-        items: [{content: 'code snippet'}],
-      };
-
-      const el = renderer.render(details);
-      const codeEl = el.querySelector('.lh-code');
-      assert.ok(codeEl.localName === 'pre');
-      assert.equal(codeEl.textContent, 'code snippet');
-    });
-
-    it('renders code values from a code details object', () => {
-      const code = {
-        type: 'code',
-        value: 'code object',
-      };
-
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'code', label: 'Heading'}],
-        items: [{content: code}],
-      };
-
-      const el = renderer.render(details);
-      const codeEl = el.querySelector('.lh-code');
-      assert.ok(codeEl.localName === 'pre');
-      assert.equal(codeEl.textContent, 'code object');
-    });
-
-    it('renders thumbnail values', () => {
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'thumbnail', label: 'Heading'}],
-        items: [{content: 'http://example.com/my-image.jpg'}],
-      };
-
-      const el = renderer.render(details);
-      const thumbnailEl = el.querySelector('img');
-      assert.ok(thumbnailEl.classList.contains('lh-thumbnail'));
-      assert.strictEqual(thumbnailEl.src, 'http://example.com/my-image.jpg');
-      assert.strictEqual(thumbnailEl.title, 'http://example.com/my-image.jpg');
-      assert.strictEqual(thumbnailEl.alt, '');
-    });
-
-    it('renders link values', () => {
-      const linkText = 'Example Site';
-      const linkUrl = 'https://example.com/';
-      const link = {
-        type: 'link',
-        text: linkText,
-        url: linkUrl,
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'link', label: 'Heading'}],
-        items: [{content: link}],
-      };
-
-      const el = renderer.render(details);
-      const anchorEl = el.querySelector('a');
-      assert.equal(anchorEl.textContent, linkText);
-      assert.equal(anchorEl.href, linkUrl);
-      assert.equal(anchorEl.rel, 'noopener');
-      assert.equal(anchorEl.target, '_blank');
-    });
-
-    it('renders link value as text if URL is not allowed', () => {
-      const linkText = 'Evil Link';
-      const linkUrl = 'javascript:alert(5)';
-      const link = {
-        type: 'link',
-        text: linkText,
-        url: linkUrl,
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'link', label: 'Heading'}],
-        items: [{content: link}],
-      };
-
-      const el = renderer.render(details);
-      const linkEl = el.querySelector('td.lh-table-column--link > .lh-text');
-      assert.equal(linkEl.localName, 'div');
-      assert.equal(linkEl.textContent, linkText);
-    });
-
-    it('renders link value as text if URL is invalid', () => {
-      const linkText = 'Invalid Link';
-      const linkUrl = 'link nonsense';
-      const link = {
-        type: 'link',
-        text: linkText,
-        url: linkUrl,
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'link', label: 'Heading'}],
-        items: [{content: link}],
-      };
-
-      const el = renderer.render(details);
-      const linkEl = el.querySelector('td.lh-table-column--link > .lh-text');
-      assert.equal(linkEl.localName, 'div');
-      assert.equal(linkEl.textContent, linkText);
-    });
-
-    describe('renders node values', () => {
-      it('renders', () => {
-        const node = {
-          type: 'node',
-          path: '3,HTML,1,BODY,5,DIV,0,H2',
-          selector: 'h2',
-          snippet: '<h2>Do better web tester page</h2>',
-        };
-        const details = {
-          type: 'table',
-          headings: [{key: 'content', valueType: 'node', label: 'Heading'}],
-          items: [{content: node}],
-        };
-
-        const el = renderer.render(details);
-        const nodeEl = el.querySelector('.lh-node');
-        assert.strictEqual(nodeEl.localName, 'span');
-        assert.equal(nodeEl.textContent, node.snippet);
-        assert.equal(nodeEl.title, node.selector);
-        assert.equal(nodeEl.getAttribute('data-path'), node.path);
-        assert.equal(nodeEl.getAttribute('data-selector'), node.selector);
-        assert.equal(nodeEl.getAttribute('data-snippet'), node.snippet);
-      });
-
-      it('renders screenshot using FullPageScreenshot rect data', () => {
-        createRenderer({
-          fullPageScreenshot: {
-            screenshot: {
-              data: '',
-              width: 1000,
-              height: 1000,
-            },
-            nodes: {
-              'page-0-0': {left: 1, right: 101, top: 1, bottom: 101, width: 100, height: 100},
-            },
-          },
-        });
-
-        const node = {
-          type: 'node',
-          lhId: 'page-0-0',
-          boundingRect: {left: 0, right: 100, top: 0, bottom: 100, width: 100, height: 100},
-        };
-        const details = {
-          type: 'table',
-          headings: [{key: 'content', valueType: 'node', label: 'Heading'}],
-          items: [{content: node}],
-        };
-
-        const el = renderer.render(details);
-        const nodeEl = el.querySelector('.lh-node');
-        const screenshotEl = nodeEl.querySelector('.lh-element-screenshot');
-        assert.equal(screenshotEl.dataset['rectLeft'], '1');
-        assert.equal(screenshotEl.dataset['rectTop'], '1');
-      });
-
-      it('does not render screenshot if rect missing in FullPageScreenshot', () => {
-        createRenderer({
-          fullPageScreenshot: {
-            screenshot: {
-              data: '',
-              width: 1000,
-              height: 1000,
-            },
-            nodes: {
-              'ignore-me': {left: 1, right: 101, top: 1, bottom: 101, width: 100, height: 100},
-            },
-          },
-        });
-
-        const node = {
-          type: 'node',
-          lhId: 'page-0-0',
-          boundingRect: {left: 0, right: 100, top: 0, bottom: 100, width: 100, height: 100},
-        };
-        const details = {
-          type: 'table',
-          headings: [{key: 'content', valueType: 'node', label: 'Heading'}],
-          items: [{content: node}],
-        };
-
-        const el = renderer.render(details);
-        const nodeEl = el.querySelector('.lh-node');
-        const screenshotEl = nodeEl.querySelector('.lh-element-screenshot');
-        expect(screenshotEl).toBeNull();
-      });
-    });
-
-    it('renders source-location values', () => {
-      const sourceLocation = {
-        type: 'source-location',
-        url: 'https://www.example.com/script.js',
-        urlProvider: 'network',
-        line: 10,
-        column: 5,
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'source-location', label: 'Heading'}],
-        items: [{content: sourceLocation}],
-      };
-
-      const el = renderer.render(details);
-      const sourceLocationEl = el.querySelector('.lh-source-location');
-      const anchorEl = sourceLocationEl.querySelector('a');
-      assert.strictEqual(sourceLocationEl.localName, 'div');
-      assert.equal(anchorEl.href, 'https://www.example.com/script.js');
-      assert.equal(sourceLocationEl.textContent, '/script.js:11:5(www.example.com)');
-      assert.equal(sourceLocationEl.getAttribute('data-source-url'), sourceLocation.url);
-      assert.equal(sourceLocationEl.getAttribute('data-source-line'), `${sourceLocation.line}`);
-      assert.equal(sourceLocationEl.getAttribute('data-source-column'), `${sourceLocation.column}`);
-    });
-
-    it('renders source-location values using source map data', () => {
-      const sourceLocation = {
-        type: 'source-location',
-        url: 'https://www.example.com/script.js',
-        urlProvider: 'network',
-        line: 10,
-        column: 5,
-        original: {
-          file: 'main.js',
-          line: 100,
-          column: 10,
-        },
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'source-location', label: 'Heading'}],
-        items: [{content: sourceLocation}],
-      };
-
-      const el = renderer.render(details);
-      const sourceLocationEl = el.querySelector('.lh-source-location.lh-link');
-      assert.strictEqual(sourceLocationEl.localName, 'a');
-      assert.equal(sourceLocationEl.href, 'https://www.example.com/script.js');
-      assert.equal(sourceLocationEl.textContent, 'main.js:101:10');
-      assert.equal(sourceLocationEl.title, 'maps to generated location https://www.example.com/script.js:11:5');
-      // DevTools should still use the generated location.
-      assert.equal(sourceLocationEl.getAttribute('data-source-url'), sourceLocation.url);
-      assert.equal(sourceLocationEl.getAttribute('data-source-line'), `${sourceLocation.line}`);
-      assert.equal(sourceLocationEl.getAttribute('data-source-column'), `${sourceLocation.column}`);
-    });
-
-    it('renders source-location with lh-link class for relative url', () => {
-      const sourceLocation = {
-        type: 'source-location',
-        url: '/root-relative-url/script.js',
-        urlProvider: 'network',
-        line: 0,
-        column: 0,
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'source-location', label: 'Heading'}],
-        items: [{content: sourceLocation}],
-      };
-
-      const el = renderer.render(details);
-      const sourceLocationEl = el.querySelector('.lh-source-location');
-      const anchorEl = sourceLocationEl.querySelector('.lh-link');
-      assert.ok(anchorEl);
-      assert.strictEqual(sourceLocationEl.localName, 'div');
-      assert.equal(sourceLocationEl.textContent, '/root-relative-url/script.js:1:0');
-      assert.equal(sourceLocationEl.getAttribute('data-source-url'), sourceLocation.url);
-      assert.equal(sourceLocationEl.getAttribute('data-source-line'), `${sourceLocation.line}`);
-      assert.equal(sourceLocationEl.getAttribute('data-source-column'), `${sourceLocation.column}`);
-    });
-
-    it('renders source-location with lh-link class for invalid urls', () => {
-      const sourceLocation = {
-        type: 'source-location',
-        url: 'thisisclearlynotavalidurl',
-        urlProvider: 'network',
-        line: 0,
-        column: 0,
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'source-location', label: 'Heading'}],
-        items: [{content: sourceLocation}],
-      };
-
-      const el = renderer.render(details);
-      const sourceLocationEl = el.querySelector('.lh-source-location');
-      const anchorEl = sourceLocationEl.querySelector('.lh-link');
-      assert.ok(anchorEl);
-      assert.strictEqual(sourceLocationEl.localName, 'div');
-      assert.equal(sourceLocationEl.textContent, 'thisisclearlynotavalidurl:1:0');
-      assert.equal(sourceLocationEl.getAttribute('data-source-url'), sourceLocation.url);
-      assert.equal(sourceLocationEl.getAttribute('data-source-line'), `${sourceLocation.line}`);
-      assert.equal(sourceLocationEl.getAttribute('data-source-column'), `${sourceLocation.column}`);
-    });
-
-    it('renders source-location values that aren\'t network resources', () => {
-      const sourceLocation = {
-        type: 'source-location',
-        url: 'https://www.example.com/script.js',
-        urlProvider: 'comment',
-        line: 0,
-        column: 0,
-      };
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'source-location', label: 'Heading'}],
-        items: [{content: sourceLocation}],
-      };
-
-      const el = renderer.render(details);
-      const sourceLocationEl = el.querySelector('.lh-source-location');
-      const anchorEl = sourceLocationEl.querySelector('a');
-      assert.ok(!anchorEl);
-      assert.strictEqual(sourceLocationEl.localName, 'div');
-      assert.equal(sourceLocationEl.textContent, 'https://www.example.com/script.js:1:0 (from sourceURL)');
-      assert.equal(sourceLocationEl.getAttribute('data-source-url'), sourceLocation.url);
-      assert.equal(sourceLocationEl.getAttribute('data-source-line'), `${sourceLocation.line}`);
-      assert.equal(sourceLocationEl.getAttribute('data-source-column'), `${sourceLocation.column}`);
-    });
-
-    it('renders text URL values from a string', () => {
-      const urlText = 'https://example.com/';
-      const displayUrlText = 'https://example.com';
-
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'url', label: 'Heading'}],
-        items: [{content: urlText}],
-      };
-
-      const el = renderer.render(details);
-      const urlEl = el.querySelector('td.lh-table-column--url > .lh-text__url');
-
-      assert.equal(urlEl.localName, 'div');
-      assert.equal(urlEl.title, urlText);
-      assert.equal(urlEl.dataset.url, urlText);
-      assert.equal(urlEl.firstChild.nodeName, 'A');
-      assert.equal(urlEl.firstChild.href, urlText);
-      assert.equal(urlEl.firstChild.rel, 'noopener');
-      assert.equal(urlEl.firstChild.target, '_blank');
-      assert.equal(urlEl.textContent, displayUrlText);
-    });
-
-    it('renders text URL values from a url details object', () => {
-      const urlText = 'https://example.com/';
-      const displayUrlText = 'https://example.com';
-      const url = {
-        type: 'url',
-        value: urlText,
-      };
-
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'url', label: 'Heading'}],
-        items: [{content: url}],
-        overallSavingsMs: 100,
-      };
-
-      const el = renderer.render(details);
-      const urlEl = el.querySelector('td.lh-table-column--url > .lh-text__url');
-
-      assert.equal(urlEl.localName, 'div');
-      assert.equal(urlEl.title, urlText);
-      assert.equal(urlEl.dataset.url, urlText);
-      assert.equal(urlEl.firstChild.nodeName, 'A');
-      assert.equal(urlEl.textContent, displayUrlText);
-    });
-
-    it('renders text URL values as code if not an allowed URL', () => {
-      const urlText = 'invalid-url://example.com/';
-
-      const details = {
-        type: 'table',
-        headings: [{key: 'content', valueType: 'url', label: 'Heading'}],
-        items: [{content: urlText}],
-      };
-
-      const el = renderer.render(details);
-      const codeItemEl = el.querySelector('td.lh-table-column--url');
-      assert.strictEqual(codeItemEl.innerHTML, '<pre class="lh-code">invalid-url://example.com/</pre>');
-    });
-
-    describe('unknown types', () => {
-      let consoleError;
-      beforeEach(() => {
-        consoleError = console.error;
-        console.error = () => {};
-      });
-      afterEach(() => {
-        console.error = consoleError;
-      });
-
-      it('renders an unknown heading valueType', () => {
-        // Disallowed by type system, but test that we get an error message out just in case.
-        const details = {
-          type: 'table',
-          headings: [{key: 'content', valueType: 'notRealValueType', label: 'Heading'}],
-          items: [{content: 'some string'}],
-        };
-
-        const el = renderer.render(details);
-        const unknownEl = el.querySelector('td.lh-table-column--notRealValueType .lh-unknown');
-        const summaryEl = unknownEl.querySelector('summary');
-        expect(summaryEl.textContent)
-          .toContain('We don\'t know how to render audit details of type `notRealValueType`');
-        assert.strictEqual(unknownEl.lastChild.textContent, '"some string"');
-      });
-
-      it('renders an unknown item object type', () => {
-        // Disallowed by type system, but test that we get an error message out just in case.
-        const item = {
-          type: 'imaginaryItem',
-          items: 'alllll the items',
-        };
-
-        const details = {
-          type: 'table',
-          headings: [{key: 'content', valueType: 'url', label: 'Heading'}],
-          items: [{content: item}],
-        };
-
-        const el = renderer.render(details);
-        const unknownEl = el.querySelector('td.lh-table-column--url .lh-unknown');
-        const summaryEl = unknownEl.querySelector('summary');
-        expect(summaryEl.textContent)
-          .toContain('We don\'t know how to render audit details of type `imaginaryItem`');
-        assert.strictEqual(unknownEl.lastChild.textContent, JSON.stringify(item, null, 2));
-      });
-    });
-
-    it('uses the item\'s type over the heading type', () => {
-      const details = {
-        type: 'table',
-        // valueType is overriden by code object
-        headings: [{key: 'content', valueType: 'url', label: 'Heading'}],
-        items: [
-          {content: {type: 'code', value: 'https://codeobject.com'}},
-          {content: 'https://example.com'},
-        ],
-      };
-
-      const el = renderer.render(details);
-      const itemElements = el.querySelectorAll('td.lh-table-column--url');
-
-      // First item's value uses its own type.
-      const codeEl = itemElements[0].firstChild;
-      assert.equal(codeEl.localName, 'pre');
-      assert.ok(codeEl.classList.contains('lh-code'));
-      assert.equal(codeEl.textContent, 'https://codeobject.com');
-
-      // Second item uses the heading's specified type for the column.
-      const urlEl = itemElements[1].firstChild;
-      assert.equal(urlEl.localName, 'div');
-      assert.ok(urlEl.classList.contains('lh-text__url'));
-      assert.equal(urlEl.title, 'https://example.com');
-      assert.equal(urlEl.textContent, 'https://example.com');
-    });
-
-    describe('subitems', () => {
-      function makeSubitems(items) {
-        return {
-          type: 'subitems',
-          items,
-        };
-      }
-
-      it('renders', () => {
-        const details = {
-          type: 'table',
-          headings: [
-            {key: 'url', valueType: 'url', subItemsHeading: {key: 'source', valueType: 'code'}},
-          ],
-          items: [
-            {
-              url: 'https://www.example.com',
-              subItems: makeSubitems([
-                {source: 'a'},
-                {source: 'b'},
-                {source: 'c'},
-              ]),
-            },
-          ],
-        };
-
-        const el = renderer.render(details);
-
-        const rowEls = el.querySelectorAll('tbody tr');
-        let rowEl;
-        let columnEl;
-
-        // First row contains a 'url' item type.
-        rowEl = rowEls[0];
-        columnEl = rowEl.querySelector('td.lh-table-column--url');
-        const codeEl = columnEl.firstChild;
-        assert.equal(codeEl.localName, 'div');
-        assert.ok(codeEl.classList.contains('lh-text__url'));
-        assert.equal(codeEl.textContent, 'https://www.example.com');
-
-        // The subItems contain a 'code' item type.
-        for (let i = 0; i < details.items[0].subItems.items; i++) {
-          const source = details.items[0].subItems.items[i].source;
-          rowEl = rowEls[i + 1];
-          columnEl = rowEl.querySelector('td.lh-table-column--code');
-          assert.ok(rowEl.classList.contains('lh-sub-item-row'));
-          assert.ok(columnEl.firstChild.classList.contains('lh-code'));
-          assert.equal(rowEl.textContent, source);
-        }
-      });
-
-      it('renders, uses heading properties as fallback', () => {
-        const details = {
-          type: 'table',
-          headings: [{key: 'url', valueType: 'url', subItemsHeading: {key: 'source'}}],
-          items: [
-            {
-              url: 'https://www.example.com',
-              subItems: makeSubitems([
-                {source: 'https://www.a.com'},
-                {source: {type: 'code', value: 'https://www.b.com'}},
-                {source: 'https://www.c.com'},
-              ]),
-            },
-          ],
-        };
-
-        const el = renderer.render(details);
-        const rowEls = el.querySelectorAll('tbody tr');
-        let rowEl;
-        let columnEl;
-
-        // First row contains a 'url' item type.
-        rowEl = rowEls[0];
-        columnEl = rowEl.querySelector('td.lh-table-column--url');
-        const codeEl = columnEl.firstChild;
-        assert.equal(codeEl.localName, 'div');
-        assert.ok(codeEl.classList.contains('lh-text__url'));
-        assert.equal(codeEl.textContent, 'https://www.example.com');
-
-        // The sub-rows contain a 'url' item type, except for the second one, which is 'code'.
-        for (let i = 0; i < details.items[0].subItems.items.length; i++) {
-          const source = details.items[0].subItems.items[i].source;
-          rowEl = rowEls[i + 1];
-          assert.ok(rowEl.classList.contains('lh-sub-item-row'));
-          columnEl = rowEl.querySelector('td');
-          if (typeof source === 'string') {
-            assert.ok(columnEl.firstChild.classList.contains('lh-text__url'));
-            assert.equal(rowEl.textContent, source);
-          } else {
-            assert.ok(columnEl.firstChild.classList.contains('lh-code'));
-            assert.equal(columnEl.textContent, source.value);
-          }
-        }
-      });
-    });
-  });
-});