lighthouse 10.0.0-dev.20230213 → 10.0.1

package/core/audits/dobetterweb/doctype.d.ts

@@ -2,9 +2,10 @@ export default Doctype;
 declare class Doctype extends Audit {
     /**
      * @param {LH.Artifacts} artifacts
-     * @return {LH.Audit.Product}
+     * @param {LH.Audit.Context} context
+     * @return {Promise<LH.Audit.Product>}
      */
-    static audit(artifacts: LH.Artifacts): LH.Audit.Product;
+    static audit(artifacts: LH.Artifacts, context: LH.Audit.Context): Promise<LH.Audit.Product>;
 }
 export namespace UIStrings {
     const title: string;

package/core/audits/dobetterweb/doctype.js

@@ -6,6 +6,7 @@
 
 import {Audit} from '../audit.js';
 import * as i18n from '../../lib/i18n/i18n.js';
+import {ProcessedTrace} from '../../computed/processed-trace.js';
 
 const UIStrings = {
   /** Title of a Lighthouse audit that provides detail on the doctype of a page. This descriptive title is shown to users when the pages's doctype is set to HTML. */
@@ -43,15 +44,16 @@ class Doctype extends Audit {
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
       requiredArtifacts: ['Doctype'],
-      __internalOptionalArtifacts: ['InspectorIssues'],
+      __internalOptionalArtifacts: ['InspectorIssues', 'traces'],
     };
   }
 
   /**
    * @param {LH.Artifacts} artifacts
-   * @return {LH.Audit.Product}
+   * @param {LH.Audit.Context} context
+   * @return {Promise<LH.Audit.Product>}
    */
-  static audit(artifacts) {
+  static async audit(artifacts, context) {
     if (!artifacts.Doctype) {
       return {
         score: 0,
@@ -64,7 +66,16 @@ class Doctype extends Audit {
     const doctypePublicId = artifacts.Doctype.publicId;
     const doctypeSystemId = artifacts.Doctype.systemId;
     const compatMode = artifacts.Doctype.documentCompatMode;
-    const quirksModeIssues = artifacts.InspectorIssues?.quirksModeIssue || [];
+
+    /** @type {LH.Crdp.Audits.QuirksModeIssueDetails[]} */
+    let quirksModeIssues = [];
+    if (artifacts.traces && artifacts.InspectorIssues) {
+      const trace = artifacts.traces[Audit.DEFAULT_PASS];
+      const processedTrace = await ProcessedTrace.request(trace, context);
+      const mainFrameId = processedTrace.mainFrameInfo.frameId;
+      quirksModeIssues =
+        artifacts.InspectorIssues.quirksModeIssue.filter(issue => issue.frameId === mainFrameId);
+    }
 
     // Can only determine limited quirks mode with some helps from the protocol via
     // inspector issues. But cannot get inspector issues in snapshot mode, so in that

package/core/audits/dobetterweb/paste-preventing-inputs.js

@@ -13,8 +13,8 @@ const UIStrings = {
   /** Title of a Lighthouse audit that provides detail on the ability to paste into input fields. This descriptive title is shown to users when the page does not allow pasting of content into input fields. */
   failureTitle: 'Prevents users from pasting into input fields',
   /** Description of a Lighthouse audit that tells the user why they should allow pasting of content into input fields. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
-  description: 'Preventing input pasting is a UX anti-pattern, ' +
-      'and undermines good security policy. ' +
+  description: 'Preventing input pasting is a bad practice for the UX, ' +
+      'and weakens security by blocking password managers.' +
       '[Learn more about user-friendly input fields](https://developer.chrome.com/docs/lighthouse/best-practices/paste-preventing-inputs/).',
 };
 

package/core/gather/driver/network-monitor.js

@@ -95,9 +95,7 @@ class NetworkMonitor extends NetworkMonitorEventEmitter {
     const frameNavigations = this._frameNavigations;
     if (!frameNavigations.length) return {};
 
-    const frameTreeResponse = await this._session.sendCommand('Page.getFrameTree');
-    const mainFrameId = frameTreeResponse.frameTree.frame.id;
-    const mainFrameNavigations = frameNavigations.filter(frame => frame.id === mainFrameId);
+    const mainFrameNavigations = frameNavigations.filter(frame => !frame.parentId);
     if (!mainFrameNavigations.length) log.warn('NetworkMonitor', 'No detected navigations');
 
     // The requested URL is the initiator request for the first frame navigation.

package/core/gather/gatherers/bf-cache-failures.js

@@ -8,7 +8,7 @@ import FRGatherer from '../base-gatherer.js';
 import {waitForFrameNavigated, waitForLoadEvent} from '../driver/wait-for-condition.js';
 import DevtoolsLog from './devtools-log.js';
 
-const FAILURE_EVENT_TIMEOUT = 100;
+const AFTER_RETURN_TIMEOUT = 100;
 const TEMP_PAGE_PAUSE_TIMEOUT = 100;
 
 class BFCacheFailures extends FRGatherer {
@@ -122,14 +122,13 @@ class BFCacheFailures extends FRGatherer {
 
     // The bfcache failure event is not necessarily emitted by this point.
     // If we are expecting a bfcache failure event but haven't seen one, we should wait for it.
-    if (frameNavigatedEvent.type !== 'BackForwardCacheRestore' && !bfCacheEvent) {
-      await new Promise(resolve => setTimeout(resolve, FAILURE_EVENT_TIMEOUT));
+    // This timeout also allows the environment to "settle" before gathering enters it's cleanup phase.
+    await new Promise(resolve => setTimeout(resolve, AFTER_RETURN_TIMEOUT));
 
-      // If we still can't get the failure reasons after the timeout we should fail loudly,
-      // otherwise this gatherer will return no failures when there should be failures.
-      if (!bfCacheEvent) {
-        throw new Error('bfcache failed but the failure reasons were not emitted in time');
-      }
+    // If we still can't get the failure reasons after the timeout we should fail loudly,
+    // otherwise this gatherer will return no failures when there should be failures.
+    if (frameNavigatedEvent.type !== 'BackForwardCacheRestore' && !bfCacheEvent) {
+      throw new Error('bfcache failed but the failure reasons were not emitted in time');
     }
 
     session.off('Page.backForwardCacheNotUsed', onBfCacheNotUsed);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "10.0.0-dev.20230213",
+  "version": "10.0.1",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {

package/shared/localization/locales/en-US.json

@@ -765,7 +765,7 @@
     "message": "Avoids requesting the notification permission on page load"
   },
   "core/audits/dobetterweb/paste-preventing-inputs.js | description": {
-    "message": "Preventing input pasting is a UX anti-pattern, and undermines good security policy. [Learn more about user-friendly input fields](https://developer.chrome.com/docs/lighthouse/best-practices/paste-preventing-inputs/)."
+    "message": "Preventing input pasting is a bad practice for the UX, and weakens security by blocking password managers.[Learn more about user-friendly input fields](https://developer.chrome.com/docs/lighthouse/best-practices/paste-preventing-inputs/)."
   },
   "core/audits/dobetterweb/paste-preventing-inputs.js | failureTitle": {
     "message": "Prevents users from pasting into input fields"

package/shared/localization/locales/en-XL.json

@@ -765,7 +765,7 @@
     "message": "Âv́ôíd̂ś r̂éq̂úêśt̂ín̂ǵ t̂h́ê ńôt́îf́îćât́îón̂ ṕêŕm̂íŝśîón̂ ón̂ ṕâǵê ĺôád̂"
   },
   "core/audits/dobetterweb/paste-preventing-inputs.js | description": {
-    "message": "P̂ŕêv́êńt̂ín̂ǵ îńp̂út̂ ṕâśt̂ín̂ǵ îś â ÚX̂ án̂t́î-ṕât́t̂ér̂ń, âńd̂ ún̂d́êŕm̂ín̂éŝ ǵôód̂ śêćûŕît́ŷ ṕôĺîćŷ. [Ĺêár̂ń m̂ór̂é âb́ôút̂ úŝér̂-f́r̂íêńd̂ĺŷ ín̂ṕût́ f̂íêĺd̂ś](https://developer.chrome.com/docs/lighthouse/best-practices/paste-preventing-inputs/)."
+    "message": "P̂ŕêv́êńt̂ín̂ǵ îńp̂út̂ ṕâśt̂ín̂ǵ îś â b́âd́ p̂ŕâćt̂íĉé f̂ór̂ t́ĥé ÛX́, âńd̂ ẃêák̂én̂ś ŝéĉúr̂ít̂ý b̂ý b̂ĺôćk̂ín̂ǵ p̂áŝśŵór̂d́ m̂án̂áĝér̂ś.[L̂éâŕn̂ ḿôŕê áb̂óût́ ûśêŕ-f̂ŕîén̂d́l̂ý îńp̂út̂ f́îél̂d́ŝ](https://developer.chrome.com/docs/lighthouse/best-practices/paste-preventing-inputs/)."
   },
   "core/audits/dobetterweb/paste-preventing-inputs.js | failureTitle": {
     "message": "P̂ŕêv́êńt̂ś ûśêŕŝ f́r̂óm̂ ṕâśt̂ín̂ǵ îńt̂ó îńp̂út̂ f́îél̂d́ŝ"

package/.codecov.yml

@@ -1,22 +0,0 @@
-# validate this file:
-#   curl --data-binary @.codecov.yml https://codecov.io/validate
-
-comment: off
-
-# partial line support
-parsers:
-  javascript:
-    enable_partials: yes
-
-# docs:
-#   https://codecov.readme.io/v4.3.6/docs/commit-status
-#   https://gist.github.com/stevepeak/53bee7b2c326b24a9b4a
-coverage:
-  status:
-    project:
-      default:
-        threshold: 1%
-        if_not_found: success  # no commit found? still set a success
-    patch:
-      default:
-        if_not_found: success

package/.cz-config.js

@@ -1,24 +0,0 @@
-/**
- * @license Copyright 2017 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-'use strict';
-
-module.exports = {
-  allowBreakingChanges: ['core'],
-  allowCustomScopes: true,
-  scopes: [],
-  types: [
-    {value: 'new_audit',  name: 'new_audit: A new audit'},
-    {value: 'core',       name: 'core:      Driver, gather, (non-new) audits, LHR JSON, etc'},
-    {value: 'tests',      name: 'tests:     Tests, smokehouse, etc'},
-    {value: 'i18n',       name: 'i18n:      Internationalization'},
-    {value: 'docs',       name: 'docs:      Documentation'},
-    {value: 'deps',       name: 'deps:      Dependency bumps only'},
-    {value: 'report',     name: 'report:    Report, UI, renderers'},
-    {value: 'cli',        name: 'cli:       CLI stuff'},
-    {value: 'clients',    name: 'clients:   Extension, DevTools, or LR stuff'},
-    {value: 'misc',       name: 'misc:      Something else entirely'}
-  ]
-};

package/.gitattributes

@@ -1,5 +0,0 @@
-*.js eol=lf
-**/locales/*.json linguist-generated=true
-build/** linguist-generated=false
-report/assets/styles.css linguist-generated=false
-report/renderer/components.js linguist-generated=true

package/.mailmap

@@ -1,6 +0,0 @@
-Brendan Kenny <bckenny@gmail.com> Brendan Kenny <bckenny@google.com>
-Connor Clark <cjamcl@gmail.com> cjamcl <cjamcl@google.com>
-Connor Clark <cjamcl@gmail.com> Connor Clark <cjamcl@google.com>
-Patrick Hulce <patrick.hulce@gmail.com> Patrick Hulce <phulce@google.com>
-Paul Irish <paul.irish@gmail.com> Paul Irish <paulirish@google.com>
-Paul Lewis <github@aerotwist.com> Paul Lewis <gravatar@aerotwist.com>

package/CODE_OF_CONDUCT.md

@@ -1,93 +0,0 @@
-# Code of Conduct
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as
-contributors and maintainers pledge to making participation in our project and
-our community a harassment-free experience for everyone, regardless of age, body
-size, disability, ethnicity, gender identity and expression, level of
-experience, education, socio-economic status, nationality, personal appearance,
-race, religion, or sexual identity and orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment
-include:
-
-*   Using welcoming and inclusive language
-*   Being respectful of differing viewpoints and experiences
-*   Gracefully accepting constructive criticism
-*   Focusing on what is best for the community
-*   Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-*   The use of sexualized language or imagery and unwelcome sexual attention or
-    advances
-*   Trolling, insulting/derogatory comments, and personal or political attacks
-*   Public or private harassment
-*   Publishing others' private information, such as a physical or electronic
-    address, without explicit permission
-*   Other conduct which could reasonably be considered inappropriate in a
-    professional setting
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or reject
-comments, commits, code, wiki edits, issues, and other contributions that are
-not aligned to this Code of Conduct, or to ban temporarily or permanently any
-contributor for other behaviors that they deem inappropriate, threatening,
-offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community. Examples of
-representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an appointed
-representative at an online or offline event. Representation of a project may be
-further defined and clarified by project maintainers.
-
-This Code of Conduct also applies outside the project spaces when the Project
-Steward has a reasonable belief that an individual's behavior may have a
-negative impact on the project or its community.
-
-## Conflict Resolution
-
-We do not believe that all conflict is bad; healthy debate and disagreement
-often yield positive results. However, it is never okay to be disrespectful or
-to engage in behavior that violates the project’s code of conduct.
-
-If you see someone violating the code of conduct, you are encouraged to address
-the behavior directly with those involved. Many issues can be resolved quickly
-and easily, and this gives people more control over the outcome of their
-dispute. If you are unable to resolve the matter for any reason, or if the
-behavior is threatening or harassing, report it. We are dedicated to providing
-an environment where participants feel welcome and safe.
-
-Reports should be directed to *Brendan Kenny (bckenny@google.com)*, the
-Project Steward(s) for *Lighthouse*. It is the Project Steward’s duty to
-receive and address reported violations of the code of conduct. They will then
-work with a committee consisting of representatives from the Open Source
-Programs Office and the Google Open Source Strategy team. If for any reason you
-are uncomfortable reaching out to the Project Steward, please email
-opensource@google.com.
-
-We will investigate every complaint, but you may not receive a direct response.
-We will use our discretion in determining when and how to follow up on reported
-incidents, which may range from not taking action to permanent expulsion from
-the project and project-sponsored spaces. We will notify the accused of the
-report and provide them an opportunity to discuss it before any action is taken.
-The identity of the reporter will be omitted from the details of the report
-supplied to the accused. In potentially harmful situations, such as ongoing
-harassment or threats to anyone's safety, we may take action without notice.
-
-## Attribution
-
-This Code of Conduct is adapted from the Contributor Covenant, version 1.4,
-available at
-https://www.contributor-covenant.org/version/1/4/code-of-conduct.html

package/eslint-local-rules.cjs

@@ -1,106 +0,0 @@
-/**
- * @license Copyright 2019 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-'use strict';
-
-/**
- * @fileoverview A collection of eslint rules written specifically for
- * Lighthouse. These are included by the eslint-plugin-local-rules plugin.
- */
-
-const path = require('path');
-
-/** @typedef {import('eslint').Rule.RuleModule} RuleModule */
-
-/**
- * Use `require.resolve()` to resolve the location of `path` from a location of
- * `baseDir` and return it. Returns null if unable to resolve a path.
- * @param {string} path
- * @param {string} baseDir
- * @return {string|null}
- */
-function requireResolveOrNull(path, baseDir) {
-  try {
-    return require.resolve(path, {
-      paths: [baseDir],
-    });
-  } catch (err) {
-    return null;
-  }
-}
-
-/**
- * An eslint rule ensuring that any require() of a local path (aka not a core
- * module or a module dependency) includes a file extension (.js' or '.json').
- * @type {RuleModule}
- */
-const requireFileExtension = {
-  meta: {
-    docs: {
-      description: 'disallow require() without a file extension',
-      category: 'Best Practices',
-      recommended: false,
-    },
-    schema: [],
-    fixable: 'code',
-  },
-
-  create(context) {
-    return {
-      CallExpression(node) {
-        // Only look at instances of `require(moduleName: string)`.
-        if (node.type !== 'CallExpression') return;
-        if (node.callee.type !== 'Identifier' || node.callee.name !== 'require') return;
-        if (!node.arguments.length) return;
-        const arg0 = node.arguments[0];
-        if (arg0.type !== 'Literal' || typeof arg0.value !== 'string') return;
-
-        const requiredPath = arg0.value;
-
-        // If it's not a local file, we don't care.
-        if (!requiredPath.startsWith('.')) return;
-
-        // Check that `requiredPath` is resolvable from the source file.
-        const contextDirname = path.dirname(context.getFilename());
-        const resolvedRequiredPath = requireResolveOrNull(requiredPath, contextDirname);
-        if (!resolvedRequiredPath) {
-          return context.report({
-            node: node,
-            message: `Cannot resolve module '${requiredPath}'.`,
-          });
-        }
-
-        // If it has a file extension, it's good to go.
-        if (requiredPath.endsWith('.js')) return;
-        if (requiredPath.endsWith('.json')) return;
-
-        context.report({
-          node: node,
-          message: 'Local require path must have a file extension.',
-          fix(fixer) {
-            // Find the correct file extension/filename ending of the requiredPath.
-            let fixedPath = path.relative(contextDirname, resolvedRequiredPath);
-            if (!fixedPath.startsWith('.')) fixedPath = `./${fixedPath}`;
-
-            // Usually `fixedPath.startsWith(requiredPath)` and this will just add
-            // a suffix to the existing path, but sometimes humans write confusing
-            // paths, e.g. './core/lib/../lib/lh-error.js'. To cover both
-            // cases, double check that the paths resolve to the same file.
-            const resolvedFixedPath = requireResolveOrNull(fixedPath, contextDirname);
-
-            // If somehow they don't point to the same file, don't try to fix.
-            if (resolvedFixedPath !== resolvedRequiredPath) return null;
-
-            return fixer.replaceText(arg0, `'${fixedPath}'`);
-          },
-        });
-      },
-    };
-  },
-};
-
-module.exports = {
-  'require-file-extension': requireFileExtension,
-};

package/flow-report/test/app-test.d.ts

@@ -1,7 +0,0 @@
-/**
- * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-export {};
-//# sourceMappingURL=app-test.d.ts.map

package/flow-report/test/app-test.tsx

@@ -1,52 +0,0 @@
-/**
- * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-
-import {act, render} from '@testing-library/preact';
-
-import {App} from '../src/app';
-import {flowResult} from './sample-flow';
-
-it('renders a standalone report with summary', async () => {
-  const root = render(<App flowResult={flowResult}/>);
-
-  expect(root.getByTestId('Summary')).toBeTruthy();
-});
-
-it('renders the navigation step', async () => {
-  global.location.hash = '#index=0';
-  const root = render(<App flowResult={flowResult}/>);
-
-  expect(root.getByTestId('Report')).toBeTruthy();
-});
-
-it('renders the timespan step', async () => {
-  global.location.hash = '#index=1';
-  const root = render(<App flowResult={flowResult}/>);
-
-  expect(root.getByTestId('Report')).toBeTruthy();
-});
-
-it('renders the snapshot step', async () => {
-  global.location.hash = '#index=2';
-  const root = render(<App flowResult={flowResult}/>);
-
-  expect(root.getByTestId('Report')).toBeTruthy();
-});
-
-it('toggles collapsed mode when hamburger button clicked', async () => {
-  const root = render(<App flowResult={flowResult}/>);
-
-  const app = root.getByTestId('App');
-  const hamburgerButton = root.getByLabelText('Button that opens and closes the sidebar');
-
-  expect(app.classList).not.toContain('App--collapsed');
-
-  await act(() => {
-    hamburgerButton.click();
-  });
-
-  expect(app.classList).toContain('App--collapsed');
-});

package/flow-report/test/common-test.d.ts

@@ -1,7 +0,0 @@
-/**
- * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-export {};
-//# sourceMappingURL=common-test.d.ts.map

package/flow-report/test/common-test.tsx

@@ -1,103 +0,0 @@
-/**
- * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-
-import jestMock from 'jest-mock';
-import {act, render} from '@testing-library/preact';
-
-import {timers} from '../../core/test/test-env/fake-timers.js';
-import {FlowStepThumbnail} from '../src/common';
-
-let lhr: LH.Result;
-
-describe('FlowStepThumbnail', () => {
-  before(() => timers.useFakeTimers());
-  after(() => timers.dispose());
-
-  beforeEach(() => {
-    global.console.warn = jestMock.fn();
-
-    lhr = {
-      gatherMode: 'navigation',
-      configSettings: {screenEmulation: {width: 400, height: 600}},
-      audits: {
-        'screenshot-thumbnails': {
-          details: {
-            type: 'filmstrip',
-            items: [
-              {data: 'frame1'},
-              {data: 'frame2'},
-            ],
-          },
-        },
-      },
-      fullPageScreenshot: {
-        screenshot: {data: 'FPS', width: 400, height: 600},
-        nodes: {},
-      },
-    } as any;
-  });
-
-  it('renders a thumbnail', () => {
-    const root = render(<FlowStepThumbnail lhr={lhr} width={200} height={200} />);
-
-    const thumbnail = root.getByAltText(/Screenshot/);
-    expect(thumbnail.style.width).toEqual('200px');
-    expect(thumbnail.style.height).toEqual('200px');
-  });
-
-  it('renders nothing without dimensions', () => {
-    const root = render(<FlowStepThumbnail lhr={lhr} />);
-
-    expect(() => root.getByAltText(/Screenshot/)).toThrow();
-    expect(global.console.warn).toHaveBeenCalled();
-  });
-
-  it('interpolates height', () => {
-    const root = render(<FlowStepThumbnail lhr={lhr} width={200} />);
-
-    const thumbnail = root.getByAltText(/Screenshot/);
-    expect(thumbnail.style.width).toEqual('200px');
-    expect(thumbnail.style.height).toEqual('300px');
-  });
-
-  it('interpolates width', () => {
-    const root = render(<FlowStepThumbnail lhr={lhr} height={150} />);
-
-    const thumbnail = root.getByAltText(/Screenshot/);
-    expect(thumbnail.style.width).toEqual('100px');
-    expect(thumbnail.style.height).toEqual('150px');
-  });
-
-  it('uses last filmstrip thumbnail', () => {
-    const root = render(<FlowStepThumbnail lhr={lhr} height={150} />);
-
-    const thumbnail = root.getByAltText(/Screenshot/) as HTMLImageElement;
-    expect(thumbnail.src).toContain('frame2');
-  });
-
-  it('uses full page screenshot if filmstrip unavailable', () => {
-    delete lhr.audits['screenshot-thumbnails'];
-    const root = render(<FlowStepThumbnail lhr={lhr} height={150} />);
-
-    const thumbnail = root.getByAltText(/Screenshot/) as HTMLImageElement;
-    expect(thumbnail.src).toContain('FPS');
-  });
-
-  it('renders animated thumbnail for timespan', async () => {
-    lhr.gatherMode = 'timespan';
-    const root = render(<FlowStepThumbnail lhr={lhr} height={150} />);
-
-    const thumbnail = root.getByAltText(/Animated/) as HTMLImageElement;
-    expect(thumbnail.style.width).toEqual('100px');
-    expect(thumbnail.style.height).toEqual('150px');
-
-    expect(thumbnail.src).toContain('frame1');
-    await act(() => {
-      timers.advanceTimersByTime(501);
-    });
-    expect(thumbnail.src).toContain('frame2');
-  });
-});

package/flow-report/test/flow-report-pptr-test.d.ts

@@ -1,7 +0,0 @@
-/**
- * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-export {};
-//# sourceMappingURL=flow-report-pptr-test.d.ts.map

package/flow-report/test/flow-report-pptr-test.ts

@@ -1,59 +0,0 @@
-/**
- * @license Copyright 2021 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-
-import puppeteer, {Browser, Page} from 'puppeteer';
-
-import {ReportGenerator} from '../../report/generator/report-generator.js';
-import {swapFlowLocale} from '../../shared/localization/swap-flow-locale.js';
-import {flowResult} from './sample-flow';
-
-describe('Lighthouse Flow Report', () => {
-  console.log('\n✨ Be sure to have recently run this: yarn build-report');
-
-  let browser: Browser;
-  let page: Page;
-  const pageErrors: Error[] = [];
-
-  before(async () => {
-    browser = await puppeteer.launch({
-      headless: true,
-    });
-    page = await browser.newPage();
-    page.on('pageerror', pageError => pageErrors.push(pageError));
-  });
-
-  after(async () => {
-    if (pageErrors.length > 0) console.error(pageErrors);
-
-    await browser.close();
-  });
-
-  describe('Renders the flow report', () => {
-    before(async () => {
-      const html = ReportGenerator.generateFlowReportHtml(flowResult);
-      await page.setContent(html);
-    });
-
-    it('should load with no errors', async () => {
-      expect(pageErrors).toHaveLength(0);
-    });
-  });
-
-  describe('Renders the flow report (i18n)', () => {
-    before(async () => {
-      const html = ReportGenerator.generateFlowReportHtml(swapFlowLocale(flowResult, 'es'));
-      await page.setContent(html);
-    });
-
-    it('should load with no errors', async () => {
-      expect(pageErrors).toHaveLength(0);
-      const el = await page.$('.SummarySectionHeader__content');
-      if (!el) throw new Error();
-      const text = await el.evaluate(el => el.textContent);
-      expect(text).toEqual('Todos los informes');
-    });
-  });
-}).timeout(35_000);