librats 0.7.1 → 0.8.0

package/native-src/src/io_poller.h

@@ -0,0 +1,138 @@
+#pragma once
+
+/**
+ * @file io_poller.h
+ * @brief Platform-optimal I/O multiplexing abstraction
+ * 
+ * Provides a unified interface over platform-specific I/O multiplexers:
+ * - Linux:       epoll   (O(1) per event, scales to millions of fds)
+ * - macOS/BSD:   kqueue  (O(1) per event, scales to millions of fds)
+ * - Windows:     IOCP    (true async completion ports, O(1) per event)
+ * 
+ * Usage:
+ *   auto poller = IOPoller::create();
+ *   poller->add(fd, PollIn);
+ *   
+ *   PollResult results[64];
+ *   int n = poller->wait(results, 64, 100);  // 100ms timeout
+ *   for (int i = 0; i < n; i++) {
+ *       if (results[i].events & PollIn) handle_read(results[i].fd);
+ *       if (results[i].events & PollOut) handle_write(results[i].fd);
+ *   }
+ */
+
+#include "socket.h"
+
+#include <memory>
+#include <cstdint>
+
+namespace librats {
+
+//=============================================================================
+// Poll Event Flags
+//=============================================================================
+
+/**
+ * @brief I/O event flags for polling
+ */
+enum PollFlags : uint32_t {
+    PollNone = 0,
+    PollIn   = 1 << 0,  ///< Socket is readable (data available or connection accepted)
+    PollOut  = 1 << 1,  ///< Socket is writable (can send or connect completed)
+    PollErr  = 1 << 2,  ///< Error condition on socket
+    PollHup  = 1 << 3,  ///< Hang up / peer disconnected
+};
+
+inline uint32_t operator|(PollFlags a, PollFlags b) {
+    return static_cast<uint32_t>(a) | static_cast<uint32_t>(b);
+}
+
+//=============================================================================
+// Poll Result
+//=============================================================================
+
+/**
+ * @brief Result entry from a poll wait
+ */
+struct PollResult {
+    socket_t fd;        ///< The socket that has events
+    uint32_t events;    ///< Bitmask of PollFlags that occurred
+};
+
+//=============================================================================
+// IOPoller Abstract Interface
+//=============================================================================
+
+/**
+ * @brief Abstract I/O multiplexer
+ * 
+ * Thread-safety:
+ * - add/modify/remove: Safe to call from any thread (epoll_ctl is thread-safe,
+ *   kqueue changes are atomic, WSAPoll rebuilds on wait).
+ * - wait: Should be called from a single I/O thread.
+ * - add/modify/remove can be called concurrently with wait().
+ */
+class IOPoller {
+public:
+    virtual ~IOPoller() = default;
+    
+    /**
+     * @brief Create the platform-optimal poller instance
+     * 
+     * Returns:
+     * - EpollPoller on Linux
+     * - KqueuePoller on macOS/FreeBSD
+     * - IocpPoller on Windows (I/O Completion Ports)
+     */
+    static std::unique_ptr<IOPoller> create();
+    
+    /**
+     * @brief Add a socket to the poll set
+     * 
+     * @param fd Socket to monitor
+     * @param events Bitmask of PollFlags to watch for
+     * @return true on success
+     */
+    virtual bool add(socket_t fd, uint32_t events) = 0;
+    
+    /**
+     * @brief Modify the event mask for a monitored socket
+     * 
+     * @param fd Socket already in the poll set
+     * @param events New bitmask of PollFlags
+     * @return true on success
+     */
+    virtual bool modify(socket_t fd, uint32_t events) = 0;
+    
+    /**
+     * @brief Remove a socket from the poll set
+     * 
+     * @param fd Socket to remove
+     * @return true on success (false if fd was not registered)
+     */
+    virtual bool remove(socket_t fd) = 0;
+    
+    /**
+     * @brief Wait for I/O events
+     * 
+     * Blocks until events occur or timeout expires.
+     * 
+     * @param results Array to fill with ready socket events
+     * @param max_results Maximum entries in results array
+     * @param timeout_ms Timeout in milliseconds (-1 = block forever, 0 = non-blocking)
+     * @return Number of ready descriptors (0 on timeout, -1 on error)
+     */
+    virtual int wait(PollResult* results, int max_results, int timeout_ms) = 0;
+    
+    /**
+     * @brief Get the backend name (for logging/diagnostics)
+     */
+    virtual const char* name() const = 0;
+    
+    // Non-copyable
+    IOPoller() = default;
+    IOPoller(const IOPoller&) = delete;
+    IOPoller& operator=(const IOPoller&) = delete;
+};
+
+} // namespace librats

package/native-src/src/krpc.cpp

@@ -60,7 +60,7 @@ KrpcMessage KrpcProtocol::create_get_peers_query(const std::string& transaction_
     return message;
 }
 
-KrpcMessage KrpcProtocol::create_announce_peer_query(const std::string& transaction_id, const NodeId& sender_id, const InfoHash& info_hash, uint16_t port, const std::string& token) {
+KrpcMessage KrpcProtocol::create_announce_peer_query(const std::string& transaction_id, const NodeId& sender_id, const InfoHash& info_hash, uint16_t port, const std::string& token, bool implied_port) {
     KrpcMessage message;
     message.type = KrpcMessageType::Query;
     message.transaction_id = transaction_id;
@@ -68,6 +68,7 @@ KrpcMessage KrpcProtocol::create_announce_peer_query(const std::string& transact
     message.sender_id = sender_id;
     message.info_hash = info_hash;
     message.port = port;
+    message.implied_port = implied_port;
     message.token = token;
     return message;
 }
@@ -176,6 +177,9 @@ BencodeValue KrpcProtocol::encode_query(const KrpcMessage& message) {
             args["info_hash"] = BencodeValue(node_id_to_string(message.info_hash));
             args["port"] = BencodeValue(static_cast<int64_t>(message.port));
             args["token"] = BencodeValue(message.token);
+            if (message.implied_port) {
+                args["implied_port"] = BencodeValue(static_cast<int64_t>(1));
+            }
             break;
     }
     
@@ -316,6 +320,9 @@ std::unique_ptr<KrpcMessage> KrpcProtocol::decode_query(const BencodeValue& data
             if (args.has_key("token")) {
                 message->token = args["token"].as_string();
             }
+            if (args.has_key("implied_port")) {
+                message->implied_port = (args["implied_port"].as_integer() != 0);
+            }
             break;
     }
     

package/native-src/src/krpc.h

@@ -68,6 +68,7 @@ struct KrpcMessage {
     NodeId target_id;
     InfoHash info_hash;
     uint16_t port;
+    bool implied_port;  // BEP 5: if true, use UDP source port instead of 'port' field
     std::string token;
     
     // For responses
@@ -79,7 +80,7 @@ struct KrpcMessage {
     KrpcErrorCode error_code;
     std::string error_message;
     
-    KrpcMessage() : type(KrpcMessageType::Query), query_type(KrpcQueryType::Ping), sender_id(), target_id(), info_hash(), port(0), response_id(), error_code(KrpcErrorCode::GenericError) {}
+    KrpcMessage() : type(KrpcMessageType::Query), query_type(KrpcQueryType::Ping), sender_id(), target_id(), info_hash(), port(0), implied_port(false), response_id(), error_code(KrpcErrorCode::GenericError) {}
 };
 
 /**
@@ -96,7 +97,7 @@ public:
     static KrpcMessage create_ping_query(const std::string& transaction_id, const NodeId& sender_id);
     static KrpcMessage create_find_node_query(const std::string& transaction_id, const NodeId& sender_id, const NodeId& target_id);
     static KrpcMessage create_get_peers_query(const std::string& transaction_id, const NodeId& sender_id, const InfoHash& info_hash);
-    static KrpcMessage create_announce_peer_query(const std::string& transaction_id, const NodeId& sender_id, const InfoHash& info_hash, uint16_t port, const std::string& token);
+    static KrpcMessage create_announce_peer_query(const std::string& transaction_id, const NodeId& sender_id, const InfoHash& info_hash, uint16_t port, const std::string& token, bool implied_port = false);
     
     static KrpcMessage create_ping_response(const std::string& transaction_id, const NodeId& response_id);
     static KrpcMessage create_find_node_response(const std::string& transaction_id, const NodeId& response_id, const std::vector<KrpcNode>& nodes);