libnpmexec 2.0.0 → 3.0.2

package/lib/cache-install-dir.js

@@ -3,8 +3,9 @@ const crypto = require('crypto')
 const { resolve } = require('path')
 
 const cacheInstallDir = ({ npxCache, packages }) => {
-  if (!npxCache)
+  if (!npxCache) {
     throw new Error('Must provide a valid npxCache path')
+  }
 
   // only packages not found in ${prefix}/node_modules
   return resolve(npxCache, getHash(packages))

package/lib/file-exists.js

@@ -13,11 +13,13 @@ const localFileExists = async (dir, binName, root = '/') => {
   for (const path of walkUp(resolve(dir))) {
     const binDir = resolve(path, 'node_modules', '.bin')
 
-    if (await fileExists(resolve(binDir, binName)))
+    if (await fileExists(resolve(binDir, binName))) {
       return binDir
+    }
 
-    if (path.toLowerCase() === root)
+    if (path.toLowerCase() === root) {
       return false
+    }
   }
 
   return false

package/lib/get-bin-from-manifest.js

@@ -3,13 +3,15 @@ const getBinFromManifest = (mani) => {
   // otherwise if there's 1 bin or all bin value is the same (alias), use
   // that, otherwise fail
   const bin = mani.bin || {}
-  if (new Set(Object.values(bin)).size === 1)
+  if (new Set(Object.values(bin)).size === 1) {
     return Object.keys(bin)[0]
+  }
 
   // XXX probably a util to parse this better?
   const name = mani.name.replace(/^@[^/]+\//, '')
-  if (bin[name])
+  if (bin[name]) {
     return name
+  }
 
   // XXX need better error message
   throw Object.assign(new Error('could not determine executable to run'), {

package/lib/index.js

@@ -59,8 +59,9 @@ const exec = async (opts) => {
   })
 
   // nothing to maybe install, skip the arborist dance
-  if (!call && !args.length && !packages.length)
+  if (!call && !args.length && !packages.length) {
     return await _run()
+  }
 
   const needPackageCommandSwap = args.length && !packages.length
   // if there's an argument and no package has been explicitly asked for
@@ -79,8 +80,9 @@ const exec = async (opts) => {
       binExists = true
     }
 
-    if (binExists)
+    if (binExists) {
       return await _run()
+    }
 
     packages.push(args[0])
   }
@@ -109,8 +111,9 @@ const exec = async (opts) => {
     })
   }))
 
-  if (needPackageCommandSwap)
+  if (needPackageCommandSwap) {
     args[0] = getBinFromManifest(manis[0])
+  }
 
   // figure out whether we need to install stuff, or if local is fine
   const localArb = new Arborist({
@@ -150,8 +153,9 @@ const exec = async (opts) => {
     if (add.length) {
       if (!yes) {
         // set -n to always say no
-        if (yes === false)
+        if (yes === false) {
           throw new Error('canceled')
+        }
 
         if (noTTY() || ciDetect()) {
           log.warn('exec', `The following package${
@@ -165,9 +169,13 @@ const exec = async (opts) => {
           const prompt = `Need to install the following packages:\n${
           addList
         }Ok to proceed? `
+          if (typeof log.clearProgress === 'function') {
+            log.clearProgress()
+          }
           const confirm = await read({ prompt, default: 'y' })
-          if (confirm.trim().toLowerCase().charAt(0) !== 'y')
+          if (confirm.trim().toLowerCase().charAt(0) !== 'y') {
             throw new Error('canceled')
+          }
         }
       }
       await arb.reify({

package/lib/manifest-missing.js

@@ -3,12 +3,14 @@ const manifestMissing = ({ tree, manifest }) => {
   // true means we need to install it
   const child = tree.children.get(manifest.name)
   // if no child, we have to load it
-  if (!child)
+  if (!child) {
     return true
+  }
 
   // if no version/tag specified, allow whatever's there
-  if (manifest._from === `${manifest.name}@`)
+  if (manifest._from === `${manifest.name}@`) {
     return false
+  }
 
   // otherwise the version has to match what we WOULD get
   return child.version !== manifest.version

package/lib/run-script.js

@@ -41,16 +41,18 @@ const run = async ({
     },
   }
 
-  if (log && log.disableProgress)
+  if (log && log.disableProgress) {
     log.disableProgress()
+  }
 
   try {
     if (script === scriptShell) {
       const isTTY = !noTTY()
 
       if (isTTY) {
-        if (ciDetect())
+        if (ciDetect()) {
           return log.warn('exec', 'Interactive mode disabled in CI environment')
+        }
 
         locationMsg = locationMsg || ` at location:\n${colorize.dim(runPath)}`
 
@@ -78,8 +80,9 @@ const run = async ({
       stdio: 'inherit',
     })
   } finally {
-    if (log && log.enableProgress)
+    if (log && log.enableProgress) {
       log.enableProgress()
+    }
   }
 }
 

package/package.json

@@ -1,12 +1,13 @@
 {
   "name": "libnpmexec",
-  "version": "2.0.0",
+  "version": "3.0.2",
   "files": [
+    "bin",
     "lib"
   ],
   "main": "lib/index.js",
   "engines": {
-    "node": ">=10"
+    "node": "^12.13.0 || ^14.15.0 || >=16"
   },
   "description": "npm exec (npx) programmatic API",
   "repository": "https://github.com/npm/libnpmexec",
@@ -28,37 +29,39 @@
   ],
   "license": "ISC",
   "scripts": {
-    "lint": "eslint lib/*.js",
-    "pretest": "npm run lint",
-    "test": "tap test/*.js",
-    "snap": "tap test/*.js",
+    "lint": "eslint '**/*.js'",
+    "posttest": "npm run lint",
+    "test": "tap",
+    "snap": "tap",
     "preversion": "npm test",
     "postversion": "npm publish",
-    "prepublishOnly": "git push origin --follow-tags"
+    "prepublishOnly": "git push origin --follow-tags",
+    "postlint": "npm-template-check",
+    "lintfix": "npm run lint -- --fix"
   },
   "tap": {
-    "check-coverage": true
+    "color": true,
+    "check-coverage": true,
+    "files": "test/*.js"
   },
   "devDependencies": {
     "bin-links": "^2.2.1",
-    "eslint": "^7.24.0",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^5.1.0",
-    "eslint-plugin-standard": "^5.0.0",
     "tap": "^15.0.6"
   },
   "dependencies": {
-    "@npmcli/arborist": "^2.3.0",
+    "@npmcli/arborist": "^4.0.0",
     "@npmcli/ci-detect": "^1.3.0",
-    "@npmcli/run-script": "^1.8.4",
+    "@npmcli/run-script": "^2.0.0",
     "chalk": "^4.1.0",
     "mkdirp-infer-owner": "^2.0.0",
     "npm-package-arg": "^8.1.2",
-    "pacote": "^11.3.1",
+    "pacote": "^12.0.0",
     "proc-log": "^1.0.0",
     "read": "^1.0.7",
     "read-package-json-fast": "^2.0.2",
     "walk-up-path": "^1.0.0"
+  },
+  "templateOSS": {
+    "version": "2.4.1"
   }
 }