lib-fints 1.4.1 → 1.4.3

package/README.md

@@ -1,4 +1,4 @@
-[![Node.js CI with pnpm](https://github.com/robocode13/lib-fints/actions/workflows/build-test.yml/badge.svg?branch=main)](https://github.com/robocode13/lib-fints/actions/workflows/build-test.yml)
+[![Node.js CI with pnpm](https://github.com/robocode13/lib-fints/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/robocode13/lib-fints/actions/workflows/ci.yml)
 
 # Lib-FinTS
 

package/dist/camtParser.js

@@ -75,7 +75,9 @@ export class CamtParser {
         }
         // Look for any object with BkToCstmrAcctRpt property
         for (const key in document) {
-            if (document[key] && document[key].BkToCstmrAcctRpt) {
+            if (document[key] &&
+                typeof document[key] === 'object' &&
+                document[key]?.BkToCstmrAcctRpt) {
                 return document[key];
             }
         }
@@ -130,12 +132,16 @@ export class CamtParser {
             }
             // Parse transactions
             const transactions = this.parseTransactions(report, reportNumber);
+            // At this point we should have both balances, otherwise throw an error
+            if (!openingBalance || !closingBalance) {
+                throw new CamtParsingError(`Unable to determine required balances for CAMT report ${reportNumber}`);
+            }
             return {
                 account,
                 number,
                 transactionReference,
-                openingBalance: openingBalance,
-                closingBalance: closingBalance,
+                openingBalance,
+                closingBalance,
                 availableBalance: balances.availableBalance,
                 transactions,
             };
@@ -151,7 +157,7 @@ export class CamtParser {
         const pathParts = path.split('.');
         let current = obj;
         for (const part of pathParts) {
-            if (current && typeof current === 'object' && current[part] !== undefined) {
+            if (current && typeof current === 'object' && current !== null && part in current) {
                 current = current[part];
             }
             else {
@@ -161,7 +167,10 @@ export class CamtParser {
         if (typeof current === 'string' || typeof current === 'number') {
             return String(current);
         }
-        if (current && typeof current === 'object' && current['#text'] !== undefined) {
+        if (Array.isArray(current)) {
+            return String(current.join(''));
+        }
+        if (current && typeof current === 'object' && current !== null && '#text' in current) {
             return String(current['#text']);
         }
         return undefined;
@@ -180,7 +189,10 @@ export class CamtParser {
             for (const balanceObj of balanceArray) {
                 const typeCode = this.getValueFromPath(balanceObj, 'Tp.CdOrPrtry.Cd');
                 // Extract amount and currency
-                const currency = balanceObj.Amt?.['@Ccy'] || 'EUR';
+                let currency = 'EUR';
+                if (balanceObj.Amt && typeof balanceObj.Amt === 'object' && '@Ccy' in balanceObj.Amt) {
+                    currency = balanceObj.Amt['@Ccy'] || 'EUR';
+                }
                 const value = parseFloat(this.getValueFromPath(balanceObj, 'Amt') || '0');
                 const creditDebitInd = this.getValueFromPath(balanceObj, 'CdtDbtInd');
                 const finalValue = creditDebitInd === 'DBIT' ? -value : value;
@@ -237,7 +249,7 @@ export class CamtParser {
         const entryArray = Array.isArray(entries) ? entries : [entries];
         for (let i = 0; i < entryArray.length; i++) {
             try {
-                const transaction = this.parseTransaction(entryArray[i], reportNumber, i + 1);
+                const transaction = this.parseTransaction(entryArray[i]);
                 if (transaction) {
                     transactions.push(transaction);
                 }
@@ -248,7 +260,7 @@ export class CamtParser {
         }
         return transactions;
     }
-    parseTransaction(entry, reportNumber, transactionNumber) {
+    parseTransaction(entry) {
         try {
             // Extract amount and credit/debit indicator
             const amountValue = parseFloat(this.getValueFromPath(entry, 'Amt') || '0');
@@ -381,7 +393,7 @@ export class CamtParser {
     parseDate(dateStr) {
         // Parse ISO date format (YYYY-MM-DD)
         if (dateStr.length === 10 && dateStr.includes('-')) {
-            return new Date(dateStr + 'T12:00:00'); // Set time to noon to avoid timezone issues
+            return new Date(`${dateStr}T12:00:00`); // Set time to noon to avoid timezone issues
         }
         // Parse CAMT date format (YYYYMMDD)
         if (dateStr.length === 8) {

package/dist/client.js

@@ -1,16 +1,16 @@
+import { FinTSConfig } from './config.js';
 import { Dialog } from './dialog.js';
-import { StatementInteractionMT940 } from './interactions/statementInteractionMT940.js';
+import { BalanceInteraction, } from './interactions/balanceInteraction.js';
+import { CreditCardStatementInteraction } from './interactions/creditcardStatementInteraction.js';
+import { PortfolioInteraction, } from './interactions/portfolioInteraction.js';
 import { StatementInteractionCAMT } from './interactions/statementInteractionCAMT.js';
-import { BalanceInteraction } from './interactions/balanceInteraction.js';
-import { PortfolioInteraction } from './interactions/portfolioInteraction.js';
-import { FinTSConfig } from './config.js';
-import { HKSAL } from './segments/HKSAL.js';
-import { HKKAZ } from './segments/HKKAZ.js';
-import { HKCAZ } from './segments/HKCAZ.js';
-import { HKWPD } from './segments/HKWPD.js';
+import { StatementInteractionMT940 } from './interactions/statementInteractionMT940.js';
 import { DKKKU } from './segments/DKKKU.js';
-import { CreditCardStatementInteraction } from './interactions/creditcardStatementInteraction.js';
+import { HKCAZ } from './segments/HKCAZ.js';
 import { HKIDN } from './segments/HKIDN.js';
+import { HKKAZ } from './segments/HKKAZ.js';
+import { HKSAL } from './segments/HKSAL.js';
+import { HKWPD } from './segments/HKWPD.js';
 /**
  * A client to communicate with a bank over the FinTS protocol
  */
@@ -36,8 +36,7 @@ export class FinTSClient {
      * @returns the selected TAN method
      */
     selectTanMethod(tanMethodId) {
-        this.config.selectTanMethod(tanMethodId);
-        return this.config.selectedTanMethod;
+        return this.config.selectTanMethod(tanMethodId);
     }
     /**
      * Selects a TAN media by its name
@@ -105,7 +104,7 @@ export class FinTSClient {
         }
         else {
             // Check if either CAMT or MT940 is supported by the bank
-            return this.config.isTransactionSupported(HKCAZ.Id) || this.config.isTransactionSupported(HKKAZ.Id);
+            return (this.config.isTransactionSupported(HKCAZ.Id) || this.config.isTransactionSupported(HKKAZ.Id));
         }
     }
     /**
@@ -163,12 +162,12 @@ export class FinTSClient {
         return (await this.startCustomerOrderInteraction(new PortfolioInteraction(accountNumber, currency, priceQuality, maxEntries)));
     }
     /**
-       * Continues the portfolio fetching when a TAN is required
-       * @param tanReference The TAN reference provided in the first call's response
-  
-       * @param tan The TAN entered by the user, can be omitted if a decoupled TAN method is used
-       * @returns a portfolio response containing holdings and total value
-       */
+     * Continues the portfolio fetching when a TAN is required
+     * @param tanReference The TAN reference provided in the first call's response
+
+     * @param tan The TAN entered by the user, can be omitted if a decoupled TAN method is used
+     * @returns a portfolio response containing holdings and total value
+     */
     async getPortfolioWithTan(tanReference, tan) {
         return (await this.continueCustomerInteractionWithTan([HKWPD.Id], tanReference, tan));
     }
@@ -211,7 +210,13 @@ export class FinTSClient {
             return response;
         }
         else {
-            return [...responses.values()].at(-1);
+            const lastResponse = [...responses.values()].at(-1);
+            if (lastResponse) {
+                return lastResponse;
+            }
+            else {
+                throw new Error(`No response received for customer interaction with segment ID '${interaction.segId}'`);
+            }
         }
     }
     async continueCustomerInteractionWithTan(segIds, tanReference, tan) {
@@ -225,6 +230,12 @@ export class FinTSClient {
                 return response;
             }
         }
-        return [...responses.values()].at(-1);
+        const lastResponse = [...responses.values()].at(-1);
+        if (lastResponse) {
+            return lastResponse;
+        }
+        else {
+            throw new Error(`No response received for customer interaction with segment IDs '${segIds.join(', ')}'`);
+        }
     }
 }

package/dist/config.js

@@ -89,19 +89,19 @@ export class FinTSConfig {
      * The FinTS URL of the bank
      */
     get bankingUrl() {
-        return this.bankingInformation.bpd?.url ?? this.url;
+        return this.bankingInformation.bpd?.url ?? this.url ?? '';
     }
     /**
      * The country code of the bank
      */
     get countryCode() {
-        return this.bankingInformation.bpd?.countryCode ?? this.country;
+        return this.bankingInformation.bpd?.countryCode ?? this.country ?? 280;
     }
     /**
      * The bank ID (BLZ)
      */
     get bankId() {
-        return this.bankingInformation.bpd?.bankId ?? this.bankIdentification;
+        return this.bankingInformation.bpd?.bankId ?? this.bankIdentification ?? '';
     }
     /**
      * A list of all available TAN methods for the user
@@ -114,10 +114,12 @@ export class FinTSConfig {
      * @param tanMethodId The ID of the TAN method to select, corresponding to an ID in availableTanMethods
      */
     selectTanMethod(tanMethodId) {
-        if (!this.availableTanMethods.find((method) => method.id === tanMethodId)) {
+        const tanMethod = this.availableTanMethods.find((method) => method.id === tanMethodId);
+        if (!tanMethod) {
             throw new Error(`TAN Method '${tanMethodId}' is not supported`);
         }
         this.tanMethodId = tanMethodId;
+        return tanMethod;
     }
     /**
      * Selects a TAN media by its name for the user
@@ -143,7 +145,8 @@ export class FinTSConfig {
      * @param transId The transaction ID
      */
     isTransactionSupported(transId) {
-        return this.bankingInformation.bpd?.allowedTransactions.find((t) => t.transId === transId) !== undefined;
+        return (this.bankingInformation.bpd?.allowedTransactions.find((t) => t.transId === transId) !==
+            undefined);
     }
     /**
      * Checks if a transaction is supported for a specific account
@@ -163,7 +166,8 @@ export class FinTSConfig {
         if (!definition) {
             throw new Error(`segment definition for ${transId} not registered`);
         }
-        const allowedVersions = this.bankingInformation.bpd?.allowedTransactions.find((t) => t.transId === transId)?.versions ?? [];
+        const allowedVersions = this.bankingInformation.bpd?.allowedTransactions.find((t) => t.transId === transId)
+            ?.versions ?? [];
         const maxSupportedversion = allowedVersions.sort().findLast((version) => version <= definition.version) ?? undefined;
         return maxSupportedversion;
     }

package/dist/dataElements/AlphaNumeric.js

@@ -1,5 +1,5 @@
-import { DataElement } from './DataElement.js';
 import { finTsDecode, finTsEncode } from '../format.js';
+import { DataElement } from './DataElement.js';
 export class AlphaNumeric extends DataElement {
     maxLength;
     constructor(name, minCount = 0, maxCount = 1, maxLength, minVersion, maxVersion) {

package/dist/dataElements/DataElement.js

@@ -21,7 +21,8 @@ export class DataElement {
         return this.isInVersion(version) ? 1 : 0;
     }
     isInVersion(version) {
-        return (!this.minVersion || version >= this.minVersion) && (!this.maxVersion || version <= this.maxVersion);
+        return ((!this.minVersion || version >= this.minVersion) &&
+            (!this.maxVersion || version <= this.maxVersion));
     }
     toString(value) {
         if (value !== undefined && value !== null && value !== '') {

package/dist/dataElements/Digits.js

@@ -18,6 +18,6 @@ export class Digits extends DataElement {
         return value.toString().padStart(this.digits, '0');
     }
     decode(text) {
-        return Number.parseInt(text);
+        return Number.parseInt(text, 10);
     }
 }

package/dist/dataElements/Float.js

@@ -13,7 +13,7 @@ export class Float extends DataElement {
             throw Error(`the Float value '${this.name}' must not exceed its maximum length`);
         }
         const text = value.toString().replace('.', ',');
-        return text.indexOf(',') >= 0 ? text : text + ',';
+        return text.indexOf(',') >= 0 ? text : `${text},`;
     }
     decode(text) {
         return Number.parseFloat(text.replace(',', '.'));

package/dist/dataElements/Numeric.js

@@ -18,9 +18,9 @@ export class Numeric extends DataElement {
         return value.toString();
     }
     decode(text) {
-        return Number.parseInt(text);
+        return Number.parseInt(text, 10);
     }
     static decode(text) {
-        return Number.parseInt(text);
+        return Number.parseInt(text, 10);
     }
 }

package/dist/dataElements/Text.js

@@ -1,5 +1,5 @@
-import { DataElement } from './DataElement.js';
 import { finTsDecode, finTsEncode } from '../format.js';
+import { DataElement } from './DataElement.js';
 export class Text extends DataElement {
     maxLength;
     constructor(name, minCount = 0, maxCount = 1, maxLength, minVersion, maxVersion) {

package/dist/dataGroups/Account.js

@@ -1,6 +1,6 @@
-import { DataGroup } from './DataGroup.js';
 import { Identification } from '../dataElements/Identification.js';
 import { BankIdentification } from './BankIdentification.js';
+import { DataGroup } from './DataGroup.js';
 export class AccountGroup extends DataGroup {
     constructor(name, minCount = 0, maxCount = 1, minVersion, maxVersion) {
         super(name, [

package/dist/dataGroups/Balance.js

@@ -1,6 +1,6 @@
-import { Time } from '../dataElements/Time.js';
-import { Dat } from '../dataElements/Dat.js';
 import { AlphaNumeric } from '../dataElements/AlphaNumeric.js';
+import { Dat } from '../dataElements/Dat.js';
+import { Time } from '../dataElements/Time.js';
 import { DataGroup } from './DataGroup.js';
 import { MoneyGroup } from './Money.js';
 export class BalanceGroup extends DataGroup {

package/dist/dataGroups/BankIdentification.js

@@ -1,6 +1,6 @@
 import { AlphaNumeric } from '../dataElements/AlphaNumeric.js';
-import { DataGroup } from './DataGroup.js';
 import { Country } from '../dataElements/Country.js';
+import { DataGroup } from './DataGroup.js';
 export class BankIdentification extends DataGroup {
     constructor(name, minCount = 0, maxCount = 1, minVersion, maxVersion) {
         super(name, [new Country('country', 1, 1), new AlphaNumeric('bankId', 1, 1, 30)], minCount, maxCount, minVersion, maxVersion);

package/dist/dataGroups/DataGroup.js

@@ -21,7 +21,10 @@ export class DataGroup extends DataElement {
             throw new Error('version is required for encoding an element group');
         }
         const isSingleArray = this.elements.length === 1 && this.elements[0].maxCount > 1;
-        return encodeElements(isSingleArray ? [values] : values, this.elements, ':', version, [...context, this.name]);
+        return encodeElements(isSingleArray ? [values] : values, this.elements, ':', version, [
+            ...context,
+            this.name,
+        ]);
     }
     decode(text, version) {
         if (!text.replaceAll(':', '')) {
@@ -36,18 +39,22 @@ export class DataGroup extends DataElement {
         if (!values) {
             return '';
         }
-        let texts = this.elements.map((element) => {
+        const texts = this.elements.map((element) => {
             if (element.maxCount > 1) {
-                if (this.elements.length === 1) {
+                if (this.elements.length === 1 && Array.isArray(values)) {
                     return values.map((value) => element.toString(value)).join('; ');
                 }
-                else {
-                    return values[element.name]?.map((value) => element.toString(value)).join('; ') ?? '';
+                else if (!Array.isArray(values)) {
+                    const currentValue = values[element.name];
+                    return Array.isArray(currentValue)
+                        ? currentValue.map((value) => element.toString(value)).join('; ')
+                        : element.toString(currentValue);
                 }
             }
-            else {
+            else if (!Array.isArray(values)) {
                 return element.toString(values[element.name]);
             }
+            return element.toString(undefined);
         });
         return `[${texts.filter((text) => !!text).join(', ')}]`;
     }

package/dist/dataGroups/InternationalAccount.js

@@ -1,7 +1,7 @@
 import { AlphaNumeric } from '../dataElements/AlphaNumeric.js';
-import { DataGroup } from './DataGroup.js';
 import { Identification } from '../dataElements/Identification.js';
 import { BankIdentification } from './BankIdentification.js';
+import { DataGroup } from './DataGroup.js';
 export class InternationalAccountGroup extends DataGroup {
     constructor(name, minCount = 0, maxCount = 1, minVersion, maxVersion) {
         super(name, [

package/dist/dataGroups/Money.js

@@ -1,6 +1,6 @@
-import { DataGroup } from './DataGroup.js';
 import { Amount } from '../dataElements/Amount.js';
 import { Currency } from '../dataElements/Currency.js';
+import { DataGroup } from './DataGroup.js';
 export class MoneyGroup extends DataGroup {
     constructor(name, minCount = 0, maxCount = 1, minVersion, maxVersion) {
         super(name, [new Amount('value', 1, 1), new Currency('currency', 1, 1)], minCount, maxCount, minVersion, maxVersion);

package/dist/dataGroups/RefMessage.js

@@ -1,6 +1,6 @@
+import { Identification } from '../dataElements/Identification.js';
 import { Numeric } from '../dataElements/Numeric.js';
 import { DataGroup } from './DataGroup.js';
-import { Identification } from '../dataElements/Identification.js';
 export class RefMessageGroup extends DataGroup {
     constructor(name, minCount = 0, maxCount = 1, minVersion, maxVersion) {
         super(name, [new Identification('dialogId', 1, 1), new Numeric('msgNr', 1, 1, 4)], minCount, maxCount, minVersion, maxVersion);

package/dist/dataGroups/SepaAccount.js

@@ -1,8 +1,8 @@
 import { AlphaNumeric } from '../dataElements/AlphaNumeric.js';
-import { DataGroup } from './DataGroup.js';
 import { Identification } from '../dataElements/Identification.js';
-import { BankIdentification } from './BankIdentification.js';
 import { YesNo } from '../dataElements/YesNo.js';
+import { BankIdentification } from './BankIdentification.js';
+import { DataGroup } from './DataGroup.js';
 export class SepaAccountGroup extends DataGroup {
     constructor(name, minCount = 0, maxCount = 1, minVersion, maxVersion) {
         super(name, [

package/dist/dataGroups/SepaAccountParameters.js

@@ -1,6 +1,6 @@
-import { YesNo } from '../dataElements/YesNo.js';
-import { Numeric } from '../dataElements/Numeric.js';
 import { AlphaNumeric } from '../dataElements/AlphaNumeric.js';
+import { Numeric } from '../dataElements/Numeric.js';
+import { YesNo } from '../dataElements/YesNo.js';
 import { DataGroup } from './DataGroup.js';
 export class SepaAccountParametersGroup extends DataGroup {
     constructor(name, minCount = 1, maxCount = 1, minVersion, maxVersion) {

package/dist/dataGroups/TimeStamp.js

@@ -1,5 +1,5 @@
-import { Time } from '../dataElements/Time.js';
 import { Dat } from '../dataElements/Dat.js';
+import { Time } from '../dataElements/Time.js';
 import { DataGroup } from './DataGroup.js';
 export class TimeStampGroup extends DataGroup {
     constructor(name, minCount = 0, maxCount = 1, minVersion, maxVersion) {

package/dist/decoder.js

@@ -10,7 +10,9 @@ export function decodeElements(text, elements, separator, version, context) {
         if (element.isInVersion(version)) {
             let textValue;
             if (separator === ':') {
-                textValue = textValues.slice(valueIndex, valueIndex + element.maxValueCount(version)).join(':');
+                textValue = textValues
+                    .slice(valueIndex, valueIndex + element.maxValueCount(version))
+                    .join(':');
                 valueIndex += element.maxValueCount(version);
             }
             else {
@@ -27,13 +29,14 @@ export function decodeElements(text, elements, separator, version, context) {
             else {
                 value = element.decode(textValue, version);
             }
-            if (isResultArray) {
+            if (Array.isArray(result)) {
                 if (element.maxCount > 1) {
                     if (elements.length === 1) {
                         result = [...result, value];
                     }
                     else {
-                        result[elementIndex] = result[elementIndex] ? [...result[elementIndex], value] : [value];
+                        const currentValue = result[elementIndex];
+                        result[elementIndex] = Array.isArray(currentValue) ? [...currentValue, value] : [value];
                     }
                 }
                 else {
@@ -42,7 +45,8 @@ export function decodeElements(text, elements, separator, version, context) {
             }
             else {
                 if (element.maxCount > 1) {
-                    result[element.name] = result[element.name] ? [...result[element.name], value] : [value];
+                    const currentValue = result[element.name];
+                    result[element.name] = Array.isArray(currentValue) ? [...currentValue, value] : [value];
                 }
                 else {
                     result[element.name] = value;
@@ -51,7 +55,9 @@ export function decodeElements(text, elements, separator, version, context) {
         }
         elementCount++;
         if (valueIndex >= textValues.length) {
-            if (elements.slice(elementIndex + 1).some((element) => element.isInVersion(version) && element.minCount > 0)) {
+            if (elements
+                .slice(elementIndex + 1)
+                .some((element) => element.isInVersion(version) && element.minCount > 0)) {
                 throw new Error(`Not all mandatory values are present in '${context}', expected a value for element '${elements[elementIndex + 1].name}'`);
             }
             else {
@@ -72,7 +78,7 @@ export function splitBySeparator(text, separator) {
         const char = text[index];
         if (char === '@' && !isEscaped(text, index)) {
             const next = text.indexOf('@', index + 1);
-            const size = Number.parseInt(text.slice(index + 1, next));
+            const size = Number.parseInt(text.slice(index + 1, next), 10);
             if (size) {
                 index = next + size;
             }

package/dist/dialog.js

@@ -1,14 +1,14 @@
 import { TanMediaRequirement, TanProcess } from './codes.js';
 import { HttpClient } from './httpClient.js';
+import { CustomerOrderInteraction, } from './interactions/customerInteraction.js';
+import { EndDialogInteraction } from './interactions/endDialogInteraction.js';
+import { InitDialogInteraction } from './interactions/initDialogInteraction.js';
 import { CustomerMessage, CustomerOrderMessage } from './message.js';
-import { HKIDN } from './segments/HKIDN.js';
+import { PARTED } from './partedSegment.js';
+import { decode } from './segment.js';
+import { HKEND } from './segments/HKEND.js';
 import { HKTAN } from './segments/HKTAN.js';
 import { HNHBK } from './segments/HNHBK.js';
-import { decode } from './segment.js';
-import { PARTED } from './partedSegment.js';
-import { CustomerOrderInteraction } from './interactions/customerInteraction.js';
-import { InitDialogInteraction } from './interactions/initDialogInteraction.js';
-import { EndDialogInteraction } from './interactions/endDialogInteraction.js';
 export class Dialog {
     config;
     dialogId = '0';
@@ -125,22 +125,24 @@ export class Dialog {
             ? new CustomerOrderMessage(this.currentInteraction.segId, this.currentInteraction.responseSegId, this.dialogId, this.lastMessageNumber)
             : new CustomerMessage(this.dialogId, this.lastMessageNumber);
         const tanMethod = this.config.selectedTanMethod;
-        let isScaSupported = tanMethod && tanMethod.version >= 6;
-        let isTanMethodNeeded = isScaSupported;
+        const isScaSupported = tanMethod && tanMethod.version >= 6;
+        let isTanMethodNeeded = isScaSupported && this.currentInteraction.segId !== HKEND.Id;
         if (isCustomerOrder) {
             const bankTransaction = this.config.bankingInformation.bpd?.allowedTransactions.find((t) => t.transId === this.currentInteraction.segId);
-            isTanMethodNeeded = isScaSupported && bankTransaction?.tanRequired;
+            isTanMethodNeeded = isTanMethodNeeded && bankTransaction?.tanRequired;
         }
         if (this.config.userId && this.config.pin) {
             message.sign(this.config.countryCode, this.config.bankId, this.config.userId, this.config.pin, this.config.bankingInformation.systemId, isScaSupported ? this.config.tanMethodId : undefined);
         }
         const segments = this.currentInteraction.getSegments(this.config);
-        segments.forEach((segment) => message.addSegment(segment));
+        segments.forEach((segment) => {
+            message.addSegment(segment);
+        });
         if (this.config.userId && this.config.pin && isTanMethodNeeded) {
             const hktan = {
-                header: { segId: HKTAN.Id, segNr: 0, version: tanMethod.version },
+                header: { segId: HKTAN.Id, segNr: 0, version: tanMethod?.version ?? 0 },
                 tanProcess: TanProcess.Process4,
-                segId: HKIDN.Id,
+                segId: this.currentInteraction.segId,
             };
             message.addSegment(hktan);
         }
@@ -150,16 +152,19 @@ export class Dialog {
         this.lastMessageNumber++;
         const message = new CustomerMessage(this.dialogId, this.lastMessageNumber);
         if (this.config.userId && this.config.pin) {
-            message.sign(this.config.countryCode, this.config.bankId, this.config.userId, this.config.pin, this.config.bankingInformation.systemId, this.config.tanMethodId, tan);
+            message.sign(this.config.countryCode, this.config.bankId, this.config.userId, this.config.pin, this.config.bankingInformation?.systemId, this.config.tanMethodId, tan);
         }
         if (this.config.userId && this.config.pin && this.config.tanMethodId) {
             const hktan = {
-                header: { segId: HKTAN.Id, segNr: 0, version: this.config.selectedTanMethod.version },
-                tanProcess: this.config.selectedTanMethod?.isDecoupled ? TanProcess.Status : TanProcess.Process2,
+                header: { segId: HKTAN.Id, segNr: 0, version: this.config.selectedTanMethod?.version ?? 0 },
+                tanProcess: this.config.selectedTanMethod?.isDecoupled
+                    ? TanProcess.Status
+                    : TanProcess.Process2,
                 segId: this.currentInteraction.segId,
                 orderRef: tanOrderReference,
                 nextTan: false,
-                tanMedia: this.config.selectedTanMethod.tanMediaRequirement >= TanMediaRequirement.Optional
+                tanMedia: (this.config.selectedTanMethod?.tanMediaRequirement ??
+                    TanMediaRequirement.NotAllowed >= TanMediaRequirement.Optional)
                     ? this.config.tanMediaName
                     : undefined,
             };
@@ -176,13 +181,22 @@ export class Dialog {
                 if (!segmentWithContinuation) {
                     throw new Error(`Response contains segment with further information, but corresponding segment could not be found or is not specified`);
                 }
-                segmentWithContinuation.continuationMark = answers.find((a) => a.code === 3040).params[0];
-                message.findSegment(HNHBK.Id).msgNr = ++this.lastMessageNumber;
+                const answer = answers.find((a) => a.code === 3040);
+                if (!answer || !answer.params || answer.params.length === 0) {
+                    throw new Error('Expected bank answer to contain continuation mark parameters (code 3040)');
+                }
+                segmentWithContinuation.continuationMark = answer.params[0];
+                const hnhbkSegment = message.findSegment(HNHBK.Id);
+                if (!hnhbkSegment) {
+                    throw new Error('HNHBK segment not found in message');
+                }
+                hnhbkSegment.msgNr = ++this.lastMessageNumber;
                 const nextResponseMessage = await this.httpClient.sendMessage(message);
                 const nextPartedSegment = nextResponseMessage.findSegment(PARTED.Id);
                 if (nextPartedSegment) {
                     nextPartedSegment.rawData =
-                        partedSegment.rawData + nextPartedSegment.rawData.slice(nextPartedSegment.rawData.indexOf('+') + 1);
+                        partedSegment.rawData +
+                            nextPartedSegment.rawData.slice(nextPartedSegment.rawData.indexOf('+') + 1);
                     partedSegment = nextPartedSegment;
                 }
                 responseMessage = nextResponseMessage;

package/dist/encoder.js

@@ -1,6 +1,8 @@
 export function encodeElements(values, elements, separator, version, context) {
     const isArray = Array.isArray(values);
-    if (!values || (isArray && values.length === 0) || (!isArray && Object.keys(values).length === 0)) {
+    if (!values ||
+        (isArray && values.length === 0) ||
+        (!isArray && Object.keys(values).length === 0)) {
         if (context.length >= 3) {
             return separator.repeat(elements.reduce((sum, element) => sum + element.maxValueCount(version), 0) - 1);
         }
@@ -9,7 +11,7 @@ export function encodeElements(values, elements, separator, version, context) {
     if (isArray && values.length !== elements.length) {
         throw new Error(`Values to encode don't match number of elements (${values.length} <> ${elements.length}) when encoding '${context.join('->')}'`);
     }
-    let textValues = [];
+    const textValues = [];
     let elementIndex = 0;
     while (elementIndex < elements.length) {
         const element = elements[elementIndex];
@@ -24,7 +26,12 @@ export function encodeElements(values, elements, separator, version, context) {
                 }
             }
             if (element.maxCount > 1) {
-                textValues.push(values[elementIndex]?.map((value) => element.encode(value, context, version)).join(separator));
+                const elementValue = values[elementIndex];
+                textValues.push(Array.isArray(elementValue)
+                    ? elementValue
+                        .map((value) => element.encode(value, context, version))
+                        .join(separator)
+                    : undefined);
             }
             else {
                 textValues.push(element.encode(values[elementIndex], context, version));
@@ -32,7 +39,12 @@ export function encodeElements(values, elements, separator, version, context) {
         }
         else {
             if (element.maxCount > 1) {
-                textValues.push(values[element.name]?.map((value) => element.encode(value, context, version)).join(separator));
+                const elementValue = values[element.name];
+                textValues.push(Array.isArray(elementValue)
+                    ? elementValue
+                        .map((value) => element.encode(value, context, version))
+                        .join(separator)
+                    : undefined);
             }
             else {
                 textValues.push(element.encode(values[element.name], context, version));