let-them-talk 3.2.3 → 3.3.1

package/CHANGELOG.md

@@ -0,0 +1,122 @@
+# Changelog
+
+## [3.0.0] - 2026-03-14
+
+### Added — Agent Profiles
+- New tool: `update_profile` (display_name, avatar, bio, role)
+- 12 built-in SVG robot avatar icons with hash-based defaults
+- Profiles auto-created on register, persist across restarts
+- Profile data shown in dashboard (avatars, role badges, profile popup)
+
+### Added — Agent Workspaces
+- 3 new tools: `workspace_write`, `workspace_read`, `workspace_list`
+- Per-agent key-value storage (50 keys max, 100KB per value)
+- Agents can read anyone's workspace, write only their own
+- Dashboard "Workspaces" tab with collapsible accordion UI
+
+### Added — Workflow Automation
+- 3 new tools: `create_workflow`, `advance_workflow`, `workflow_status`
+- Multi-step pipelines with auto-handoff to step assignees
+- Dashboard "Workflows" tab with horizontal pipeline visualization
+- Dashboard can advance/skip workflow steps
+
+### Added — Conversation Branching
+- 3 new tools: `fork_conversation`, `switch_branch`, `list_branches`
+- Fork at any message point with isolated branch history
+- All message tools branch-aware (backward compatible — main branch uses existing files)
+- Branch tabs in dashboard
+
+### Added — Plugin System
+- Dynamic tool loading from `plugins/*.js` files
+- Sandboxed execution with 30s timeout
+- CLI: `npx let-them-talk plugin add/list/remove/enable/disable`
+- Dashboard plugin cards with enable/disable toggles
+
+### Changed
+- MCP tools: 17 → 27 + dynamic plugins
+- Dashboard tabs: 2 → 4 (Messages, Tasks, Workspaces, Workflows)
+- Branch-aware history API (`?branch=` query param)
+- Version bump across all files (server, dashboard, CLI, package.json)
+
+## [2.5.0] - 2026-03-14
+
+### Added
+- Task management system: `create_task`, `update_task`, `list_tasks` tools
+- Kanban board in dashboard (Messages/Tasks toggle)
+- Agent stats panel (sent/received/avg response time per agent)
+- Shareable HTML export (/api/export endpoint)
+- Export dropdown (HTML + Markdown formats)
+- Conversation bookmarks (star messages, localStorage)
+- Sound notification toggle (Web Audio API)
+- Typing indicator for processing agents
+- Connection quality display (SSE latency)
+- Date separators between message groups
+- Message grouping for consecutive same-sender messages
+- Project auto-discover (scan nearby folders)
+- Copy-to-clipboard prompts in onboarding
+- Dynamic tab title with message count
+- Dashboard footer with version
+
+### Security
+- Path traversal fix in `share_file` (restricted to project dir)
+- Path traversal fix in `?project=` param (validate against registered projects)
+- 1MB message size limit on send/broadcast/handoff
+- 1MB request body limit on dashboard POST endpoints
+- XSS fix in HTML export (escape agent names)
+- CORS restricted to localhost only (was wildcard)
+- Dashboard binds to 127.0.0.1 only (was 0.0.0.0)
+- Registration guard on `reset` tool
+- Removed absolute file paths from share_file responses
+
+## [2.3.0] - 2026-03-14
+
+### Added
+- `handoff` tool for structured work delegation
+- `share_file` tool for sending file contents between agents
+- `broadcast` tool for messaging all agents at once
+- `get_summary` tool for conversation recaps
+- Server-Sent Events for real-time dashboard updates
+- `fs.watch()` on data directory with debounced SSE push
+- Graceful SSE fallback to polling
+- Handoff message rendering (purple banner)
+- File share message rendering (file icon + size)
+
+## [2.1.0] - 2026-03-14
+
+### Added
+- Multi-agent support (any name, not just A/B)
+- `list_agents` tool with alive/dead status
+- `listen` tool (blocks indefinitely, never times out)
+- Conversation threading (`reply_to` + auto `thread_id`)
+- Message acknowledgments (`ack_message` tool)
+- Heartbeat system (10s interval, `last_activity` tracking)
+- Agent status: active/sleeping/dead with idle time
+- Listening status tracking (`listening_since`)
+- Auto-compact messages.jsonl when >500 lines
+- Auto-archive conversations before reset
+- Context hints when conversation exceeds 50 messages
+- Dead recipient warnings in `send_message`
+- Message sequence numbers for ordering
+- `pending_count` and `agents_online` in delivery responses
+- 4 agent templates: pair, team, review, debate
+- CLI: `npx let-them-talk templates` command
+- CLI: `--template` flag for guided setup
+- Multi-CLI support: Claude Code, Gemini CLI, Codex CLI
+- `AGENT_BRIDGE_DATA_DIR` env var in MCP config
+
+### Fixed
+- Heartbeat timer `.unref()` to prevent zombie processes
+- Process exit cleanup (deregister agent on exit)
+- Re-registration cleanup (old name removed)
+- Stale byte offset recovery on file truncation
+
+## [2.0.0] - 2026-03-14
+
+### Added
+- Initial release
+- MCP server with stdio transport
+- 6 tools: register, send_message, wait_for_reply, check_messages, get_history, reset
+- Web dashboard with real-time monitoring
+- Message injection from dashboard
+- Dark theme UI with markdown rendering
+- `.mcp.json` project-level configuration

package/README.md

@@ -2,6 +2,7 @@
 
 [![npm version](https://img.shields.io/npm/v/let-them-talk.svg)](https://www.npmjs.com/package/let-them-talk)
 [![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://opensource.org/licenses/MIT)
+[![Discord](https://img.shields.io/discord/1482478651000885359?color=5865F2&label=Discord&logo=discord&logoColor=white)](https://discord.gg/6Y9YgkFNJP)
 
 **MCP server + web dashboard that lets AI CLI agents talk to each other.**
 
@@ -154,6 +155,22 @@ npx let-them-talk plugin disable <name>   # Disable a plugin
 npx let-them-talk help                    # Show help
 ```
 
+## Updating
+
+```bash
+# If using npx (recommended) — clear cache to get latest version
+npx clear-npx-cache
+npx let-them-talk init    # Re-run to update MCP config paths
+
+# If installed globally
+npm update -g let-them-talk
+
+# Check your version
+npx let-them-talk help    # Shows version in header
+```
+
+After updating, restart your CLI terminals to pick up the new MCP server.
+
 ## Plugins
 
 Extend Let Them Talk with custom tools. Plugins are `.js` files in the `.agent-bridge/plugins/` directory.

package/SECURITY.md

@@ -0,0 +1,58 @@
+# Security Policy
+
+## Supported Versions
+
+| Version | Supported          |
+| ------- | ------------------ |
+| 3.x.x   | Yes               |
+| 2.x.x   | No                |
+| < 2.0   | No                |
+
+## Reporting a Vulnerability
+
+If you discover a security vulnerability in Let Them Talk, please report it responsibly.
+
+**Do NOT open a public GitHub issue for security vulnerabilities.**
+
+Instead, please email **security@dos-technology.com** or use [GitHub's private vulnerability reporting](https://github.com/Dekelelz/let-them-talk/security/advisories/new).
+
+### What to include
+
+- Description of the vulnerability
+- Steps to reproduce
+- Potential impact
+- Suggested fix (if any)
+
+### Response timeline
+
+- **Acknowledgment**: Within 48 hours
+- **Initial assessment**: Within 1 week
+- **Fix release**: As soon as possible, typically within 2 weeks
+
+## Security Model
+
+Let Them Talk is a **local message broker** — it passes text messages between CLI terminals via shared files on your local machine.
+
+### What it does NOT do
+
+- Does not give agents filesystem access (they already have it via their CLI)
+- Does not expose anything to the internet (dashboard binds to `127.0.0.1` only)
+- Does not store or transmit API keys
+- Does not run any cloud services
+- Does not execute remote code
+
+### Built-in protections
+
+- **CORS restriction** — dashboard only accepts requests from localhost
+- **XSS prevention** — all user inputs are escaped before rendering
+- **Path traversal protection** — agents cannot read files outside the project directory
+- **Symlink protection** — follows symlinks and validates the real path
+- **Origin enforcement** — POST/DELETE requests require valid localhost origin
+- **SSE connection limits** — prevents connection exhaustion
+- **Input validation** — agent names, branch names, and file paths are validated
+- **Message size limits** — 1MB max per message
+- **Plugin sandboxing** — plugins run with a 30-second timeout
+
+### LAN mode
+
+When using `--lan` mode, the dashboard is exposed to your local network only. It is never accessible from the internet.

package/cli.js

@@ -8,7 +8,7 @@ const command = process.argv[2];
 
 function printUsage() {
   console.log(`
-  Let Them Talk — Agent Bridge v3.2.0
+  Let Them Talk — Agent Bridge v3.3.0
   MCP message broker for inter-agent communication
   Supports: Claude Code, Gemini CLI, Codex CLI
 
@@ -331,24 +331,33 @@ function pluginCmd() {
       const absPath = path.resolve(filePath);
       if (!fs.existsSync(absPath)) { console.error('  File not found: ' + absPath); process.exit(1); }
 
-      // Validate plugin exports
+      // Validate plugin structure without executing it (no require — prevents RCE on install)
       try {
-        const plugin = require(absPath);
-        if (!plugin.name || !plugin.handler) { console.error('  Plugin must export name, description, and handler'); process.exit(1); }
+        const src = fs.readFileSync(absPath, 'utf8');
+        if (!src.includes('module.exports') || !src.includes('name') || !src.includes('handler')) {
+          console.error('  Plugin must export name, description, and handler (module.exports = { name, handler })');
+          process.exit(1);
+        }
+
+        // Extract plugin name from source using regex (no eval)
+        const nameMatch = src.match(/name\s*:\s*['"]([^'"]+)['"]/);
+        const descMatch = src.match(/description\s*:\s*['"]([^'"]+)['"]/);
+        const pluginName = nameMatch ? nameMatch[1] : path.basename(absPath, '.js');
+        const pluginDesc = descMatch ? descMatch[1] : '';
 
         if (!fs.existsSync(pluginsDir)) fs.mkdirSync(pluginsDir, { recursive: true });
         const destFile = path.join(pluginsDir, path.basename(absPath));
         fs.copyFileSync(absPath, destFile);
 
         const reg = getRegistry();
-        if (!reg.find(p => p.name === plugin.name)) {
-          reg.push({ name: plugin.name, description: plugin.description || '', file: path.basename(absPath), enabled: true, added_at: new Date().toISOString() });
+        if (!reg.find(p => p.name === pluginName)) {
+          reg.push({ name: pluginName, description: pluginDesc, file: path.basename(absPath), enabled: true, added_at: new Date().toISOString() });
           saveRegistry(reg);
         }
-        console.log('  Plugin "' + plugin.name + '" installed successfully.');
-        console.log('  Restart CLI to load the new tool.');
+        console.log('  Plugin "' + pluginName + '" installed successfully.');
+        console.log('  Restart CLI to load the new tool (runs sandboxed).');
       } catch (e) {
-        console.error('  Failed to load plugin: ' + e.message);
+        console.error('  Failed to install plugin: ' + e.message);
         process.exit(1);
       }
       break;
@@ -362,8 +371,11 @@ function pluginCmd() {
       const newReg = reg.filter(p => p.name !== name);
       saveRegistry(newReg);
       if (plugin.file) {
-        const pluginFile = path.join(pluginsDir, plugin.file);
-        if (fs.existsSync(pluginFile)) fs.unlinkSync(pluginFile);
+        const pluginFile = path.resolve(pluginsDir, plugin.file);
+        // Prevent path traversal — only delete files inside pluginsDir
+        if (pluginFile.startsWith(path.resolve(pluginsDir) + path.sep) && fs.existsSync(pluginFile)) {
+          fs.unlinkSync(pluginFile);
+        }
       }
       console.log('  Plugin "' + name + '" removed.');
       break;

package/dashboard.html

@@ -2471,7 +2471,7 @@
   </div>
 </div>
 <div class="app-footer">
-  <span>Let Them Talk v3.2.0</span>
+  <span>Let Them Talk v3.3.0</span>
 </div>
 <div class="profile-popup" id="profile-popup" onclick="event.stopPropagation()">
   <div class="profile-popup-header">

package/dashboard.js

@@ -690,8 +690,18 @@ const server = http.createServer(async (req, res) => {
     return;
   }
 
-  // CSRF protection: validate origin on mutating requests
+  // CSRF + DNS rebinding protection: validate Host and Origin on mutating requests
   if (req.method === 'POST' || req.method === 'DELETE') {
+    // Check Host header to block DNS rebinding attacks
+    const host = (req.headers.host || '').replace(/:\d+$/, '');
+    const validHosts = ['localhost', '127.0.0.1'];
+    if (LAN_MODE && getLanIP()) validHosts.push(getLanIP());
+    if (!validHosts.includes(host)) {
+      res.writeHead(403, { 'Content-Type': 'application/json' });
+      res.end(JSON.stringify({ error: 'Forbidden: invalid host' }));
+      return;
+    }
+    // Check Origin header to block cross-site requests
     const origin = req.headers.origin || '';
     const referer = req.headers.referer || '';
     const source = origin || referer;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "let-them-talk",
-  "version": "3.2.3",
+  "version": "3.3.1",
   "description": "MCP message broker + web dashboard for inter-agent communication. Let AI CLI agents talk to each other.",
   "main": "server.js",
   "bin": {
@@ -22,7 +22,9 @@
     "cli.js",
     "templates/",
     "logo.png",
-    "LICENSE"
+    "LICENSE",
+    "SECURITY.md",
+    "CHANGELOG.md"
   ],
   "keywords": [
     "mcp",

package/server.js

@@ -23,11 +23,27 @@ const PLUGINS_DIR = path.join(DATA_DIR, 'plugins');
 
 // In-memory state for this process
 let registeredName = null;
+let registeredToken = null; // auth token for re-registration
 let lastReadOffset = 0; // byte offset into messages.jsonl for efficient polling
 let heartbeatInterval = null; // heartbeat timer reference
 let messageSeq = 0; // monotonic sequence counter for message ordering
 let currentBranch = 'main'; // which branch this agent is on
 
+// Rate limiting — prevent broadcast storms and message flooding
+const rateLimitWindow = 60000; // 1 minute window
+const rateLimitMax = 30; // max 30 messages per minute per agent
+let rateLimitMessages = []; // timestamps of recent messages
+
+function checkRateLimit() {
+  const now = Date.now();
+  rateLimitMessages = rateLimitMessages.filter(t => now - t < rateLimitWindow);
+  if (rateLimitMessages.length >= rateLimitMax) {
+    return { error: `Rate limit exceeded: max ${rateLimitMax} messages per minute. Wait before sending more.` };
+  }
+  rateLimitMessages.push(now);
+  return null;
+}
+
 // --- Helpers ---
 
 function ensureDataDir() {
@@ -112,7 +128,13 @@ function validateContentSize(content) {
 }
 
 function generateId() {
-  return Date.now().toString(36) + Math.random().toString(36).slice(2, 8);
+  try { return Date.now().toString(36) + require('crypto').randomBytes(6).toString('hex'); }
+  catch { return Date.now().toString(36) + Math.random().toString(36).slice(2, 8); }
+}
+
+function generateToken() {
+  try { return require('crypto').randomBytes(16).toString('hex'); }
+  catch { return Math.random().toString(36).slice(2) + Math.random().toString(36).slice(2); }
 }
 
 function sleep(ms) {
@@ -230,9 +252,11 @@ function autoCompact() {
       return false;
     });
 
-    // Rewrite messages.jsonl with only active messages
+    // Rewrite messages.jsonl atomically — write to temp file then rename
     const newContent = active.map(m => JSON.stringify(m)).join('\n') + (active.length ? '\n' : '');
-    fs.writeFileSync(msgFile, newContent);
+    const tmpFile = msgFile + '.tmp';
+    fs.writeFileSync(tmpFile, newContent);
+    fs.renameSync(tmpFile, msgFile);
     lastReadOffset = Buffer.byteLength(newContent, 'utf8');
 
     // Trim consumed ID files — keep only IDs still in active messages
@@ -366,7 +390,15 @@ function toolRegister(name, provider = null) {
 
   const agents = getAgents();
   if (agents[name] && agents[name].pid !== process.pid && isPidAlive(agents[name].pid)) {
-    return { error: `Agent "${name}" is already registered by a live process (PID ${agents[name].pid})` };
+    return { error: `Agent "${name}" is already registered by a live process. Choose a different name.` };
+  }
+
+  // If name was previously registered by a dead process, verify token to prevent impersonation
+  if (agents[name] && agents[name].token && !isPidAlive(agents[name].pid)) {
+    // Dead agent — only allow re-registration from the same process (same token)
+    if (registeredToken && registeredToken !== agents[name].token) {
+      return { error: `Agent "${name}" was previously registered by another process. Choose a different name.` };
+    }
   }
 
   // Clean up old registration if re-registering with a different name
@@ -375,9 +407,11 @@ function toolRegister(name, provider = null) {
   }
 
   const now = new Date().toISOString();
-  agents[name] = { pid: process.pid, timestamp: now, last_activity: now, provider: provider || 'unknown', branch: currentBranch };
+  const token = (agents[name] && agents[name].token) || generateToken();
+  agents[name] = { pid: process.pid, timestamp: now, last_activity: now, provider: provider || 'unknown', branch: currentBranch, token };
   saveAgents(agents);
   registeredName = name;
+  registeredToken = token;
 
   // Auto-create profile if not exists
   const profiles = getProfiles();
@@ -459,6 +493,9 @@ function toolSendMessage(content, to = null, reply_to = null) {
     return { error: 'You must call register() first' };
   }
 
+  const rateErr = checkRateLimit();
+  if (rateErr) return rateErr;
+
   const agents = getAgents();
   const otherAgents = Object.keys(agents).filter(n => n !== registeredName);
 
@@ -531,6 +568,9 @@ function toolBroadcast(content) {
     return { error: 'You must call register() first' };
   }
 
+  const rateErr = checkRateLimit();
+  if (rateErr) return rateErr;
+
   const sizeErr = validateContentSize(content);
   if (sizeErr) return sizeErr;
 
@@ -1909,13 +1949,16 @@ function loadPlugins() {
   const enabledNames = new Set(registry.filter(p => p.enabled !== false).map(p => p.name));
 
   try {
+    const vm = require('vm');
     const files = fs.readdirSync(PLUGINS_DIR).filter(f => f.endsWith('.js'));
     for (const file of files) {
       try {
         const pluginPath = path.join(PLUGINS_DIR, file);
-        // Clear require cache so plugins can be reloaded
-        delete require.cache[require.resolve(pluginPath)];
-        const plugin = require(pluginPath);
+        const code = fs.readFileSync(pluginPath, 'utf8');
+        // Run plugin in a sandboxed VM context — no require, no process, no child_process
+        const sandbox = { module: { exports: {} }, exports: {}, console: { log: () => {}, error: () => {}, warn: () => {} } };
+        vm.runInNewContext(code, sandbox, { filename: file, timeout: 5000 });
+        const plugin = sandbox.module.exports;
         if (!plugin.name || !plugin.description || !plugin.handler) {
           console.error(`Plugin ${file}: missing name, description, or handler`);
           continue;
@@ -1927,7 +1970,7 @@ function loadPlugins() {
           inputSchema: plugin.inputSchema || { type: 'object', properties: {} },
           handler: plugin.handler,
         });
-        console.error(`Plugin loaded: ${plugin.name}`);
+        console.error(`Plugin loaded: ${plugin.name} (sandboxed)`);
       } catch (e) {
         console.error(`Plugin ${file} failed to load: ${e.message}`);
       }
@@ -1941,17 +1984,18 @@ function executePlugin(pluginName, args) {
 
   const context = {
     registeredName,
-    dataDir: DATA_DIR,
     sendMessage: (to, content) => toolSendMessage(content, to),
     getAgents: () => toolListAgents().agents,
     getHistory: (limit) => toolGetHistory(limit),
     readFile: (filePath) => {
       const resolved = path.resolve(filePath);
       const allowedRoot = path.resolve(process.cwd());
-      if (!resolved.startsWith(allowedRoot + path.sep) && resolved !== allowedRoot) {
+      let realPath;
+      try { realPath = fs.realpathSync(resolved); } catch { throw new Error('File not found'); }
+      if (!realPath.startsWith(allowedRoot + path.sep) && realPath !== allowedRoot) {
         throw new Error('File path must be within the project directory');
       }
-      return fs.readFileSync(resolved, 'utf8');
+      return fs.readFileSync(realPath, 'utf8');
     },
   };
 
@@ -1977,7 +2021,7 @@ async function main() {
   loadPlugins();
   const transport = new StdioServerTransport();
   await server.connect(transport);
-  console.error('Agent Bridge MCP server v3.2.0 running (' + (27 + loadedPlugins.length) + ' tools)');
+  console.error('Agent Bridge MCP server v3.3.1 running (' + (27 + loadedPlugins.length) + ' tools)');
 }
 
 main().catch(console.error);