less 4.4.1 → 4.5.1

package/scripts/coverage-report.js

@@ -0,0 +1,158 @@
+#!/usr/bin/env node
+
+/**
+ * Generates a per-file coverage report table for src/ directories
+ */
+
+const fs = require('fs');
+const path = require('path');
+
+const coverageSummaryPath = path.join(__dirname, '..', 'coverage', 'coverage-summary.json');
+
+if (!fs.existsSync(coverageSummaryPath)) {
+    console.error('Coverage summary not found. Run pnpm test:coverage first.');
+    process.exit(1);
+}
+
+const coverage = JSON.parse(fs.readFileSync(coverageSummaryPath, 'utf8'));
+
+// Filter to only src/ files (less, less-node) and bin/ files
+// Note: src/less-browser/ is excluded because browser tests aren't included in coverage
+// Abstract base classes are excluded as they're meant to be overridden by implementations
+const abstractClasses = [
+    'abstract-file-manager',
+    'abstract-plugin-loader'
+];
+
+const srcFiles = Object.entries(coverage)
+    .filter(([filePath]) => {
+        const normalized = filePath.replace(/\\/g, '/');
+        // Exclude abstract classes
+        if (abstractClasses.some(abstract => normalized.includes(abstract))) {
+            return false;
+        }
+        return (normalized.includes('/src/less/') && !normalized.includes('/src/less-browser/')) || 
+               normalized.includes('/src/less-node/') ||
+               normalized.includes('/bin/');
+    })
+    .map(([filePath, data]) => {
+        // Extract relative path from absolute path
+        const normalized = filePath.replace(/\\/g, '/');
+        // Match src/ paths or bin/ paths
+        const match = normalized.match(/((?:src\/[^/]+\/[^/]+\/|bin\/).+)$/);
+        const relativePath = match ? match[1] : path.basename(filePath);
+        
+        return {
+            path: relativePath,
+            statements: data.statements,
+            branches: data.branches,
+            functions: data.functions,
+            lines: data.lines
+        };
+    })
+    .sort((a, b) => {
+        // Sort by directory first, then by coverage percentage
+        const pathCompare = a.path.localeCompare(b.path);
+        if (pathCompare !== 0) return pathCompare;
+        return a.statements.pct - b.statements.pct;
+    });
+
+if (srcFiles.length === 0) {
+    console.log('No src/ files found in coverage report.');
+    process.exit(0);
+}
+
+// Group by directory
+const grouped = {
+    'src/less/': [],
+    'src/less-node/': [],
+    'bin/': []
+};
+
+srcFiles.forEach(file => {
+    if (file.path.startsWith('src/less/')) {
+        grouped['src/less/'].push(file);
+    } else if (file.path.startsWith('src/less-node/')) {
+        grouped['src/less-node/'].push(file);
+    } else if (file.path.startsWith('bin/')) {
+        grouped['bin/'].push(file);
+    }
+});
+
+// Print table
+console.log('\n' + '='.repeat(100));
+console.log('Per-File Coverage Report (src/less/, src/less-node/, and bin/)');
+console.log('='.repeat(100));
+console.log('For line-by-line coverage details, open coverage/index.html in your browser.');
+console.log('='.repeat(100) + '\n');
+
+Object.entries(grouped).forEach(([dir, files]) => {
+    if (files.length === 0) return;
+    
+    console.log(`\n${dir.toUpperCase()}`);
+    console.log('-'.repeat(100));
+    console.log(
+        'File'.padEnd(50) + 
+        'Statements'.padStart(12) + 
+        'Branches'.padStart(12) + 
+        'Functions'.padStart(12) + 
+        'Lines'.padStart(12)
+    );
+    console.log('-'.repeat(100));
+    
+    files.forEach(file => {
+        const filename = file.path.replace(dir, '');
+        const truncated = filename.length > 48 ? '...' + filename.slice(-45) : filename;
+        
+        console.log(
+            truncated.padEnd(50) +
+            `${file.statements.pct.toFixed(1)}%`.padStart(12) +
+            `${file.branches.pct.toFixed(1)}%`.padStart(12) +
+            `${file.functions.pct.toFixed(1)}%`.padStart(12) +
+            `${file.lines.pct.toFixed(1)}%`.padStart(12)
+        );
+    });
+    
+    // Summary for this directory
+    const totals = files.reduce((acc, file) => {
+        acc.statements.total += file.statements.total;
+        acc.statements.covered += file.statements.covered;
+        acc.branches.total += file.branches.total;
+        acc.branches.covered += file.branches.covered;
+        acc.functions.total += file.functions.total;
+        acc.functions.covered += file.functions.covered;
+        acc.lines.total += file.lines.total;
+        acc.lines.covered += file.lines.covered;
+        return acc;
+    }, {
+        statements: { total: 0, covered: 0 },
+        branches: { total: 0, covered: 0 },
+        functions: { total: 0, covered: 0 },
+        lines: { total: 0, covered: 0 }
+    });
+    
+    const stmtPct = totals.statements.total > 0 
+        ? (totals.statements.covered / totals.statements.total * 100).toFixed(1)
+        : '0.0';
+    const branchPct = totals.branches.total > 0
+        ? (totals.branches.covered / totals.branches.total * 100).toFixed(1)
+        : '0.0';
+    const funcPct = totals.functions.total > 0
+        ? (totals.functions.covered / totals.functions.total * 100).toFixed(1)
+        : '0.0';
+    const linePct = totals.lines.total > 0
+        ? (totals.lines.covered / totals.lines.total * 100).toFixed(1)
+        : '0.0';
+    
+    console.log('-'.repeat(100));
+    console.log(
+        'TOTAL'.padEnd(50) +
+        `${stmtPct}%`.padStart(12) +
+        `${branchPct}%`.padStart(12) +
+        `${funcPct}%`.padStart(12) +
+        `${linePct}%`.padStart(12)
+    );
+});
+
+console.log('\n' + '='.repeat(100) + '\n');
+

package/scripts/postinstall.js

@@ -0,0 +1,61 @@
+#!/usr/bin/env node
+
+/**
+ * Post-install script for Less.js package
+ * 
+ * This script installs Playwright browsers only when:
+ * 1. This is a development environment (not when installed as a dependency)
+ * 2. We're in a monorepo context (parent package.json exists)
+ * 3. Not running in CI or other automated environments
+ */
+
+const fs = require('fs');
+const path = require('path');
+const { execSync } = require('child_process');
+
+// Check if we're in a development environment
+function isDevelopmentEnvironment() {
+    // Skip if this is a global install or user config
+    if (process.env.npm_config_user_config || process.env.npm_config_global) {
+        return false;
+    }
+    
+    // Skip in CI environments
+    if (process.env.CI || process.env.GITHUB_ACTIONS || process.env.TRAVIS) {
+        return false;
+    }
+    
+    // Check if we're in a monorepo (parent package.json exists)
+    const parentPackageJson = path.join(__dirname, '../../../package.json');
+    if (!fs.existsSync(parentPackageJson)) {
+        return false;
+    }
+    
+    // Check if this is the root of the monorepo
+    const currentPackageJson = path.join(__dirname, '../package.json');
+    if (!fs.existsSync(currentPackageJson)) {
+        return false;
+    }
+    
+    return true;
+}
+
+// Install Playwright browsers
+function installPlaywrightBrowsers() {
+    try {
+        console.log('🎭 Installing Playwright browsers for development...');
+        execSync('pnpm exec playwright install', { 
+            stdio: 'inherit',
+            cwd: path.join(__dirname, '..')
+        });
+        console.log('✅ Playwright browsers installed successfully');
+    } catch (error) {
+        console.warn('⚠️  Failed to install Playwright browsers:', error.message);
+        console.warn('   You can install them manually with: pnpm exec playwright install');
+    }
+}
+
+// Main execution
+if (isDevelopmentEnvironment()) {
+    installPlaywrightBrowsers();
+}

package/test/browser/common.js

@@ -99,6 +99,18 @@ testSheet = function (sheet) {
                             window.navigator.userAgent.indexOf('Trident/') >= 0) {
                             text = ieFormat(text);
                         }
+                        
+                        // Normalize URLs: convert absolute URLs back to relative for comparison
+                        // The browser resolves relative URLs when reading from DOM, but we want to compare against the original relative URLs
+                        lessOutput = lessOutput.replace(/url\("http:\/\/localhost:8081\/packages\/less\/node_modules\/@less\/test-data\/tests-unit\/([^"]+)"\)/g, 'url("$1")');
+                        // Also normalize directory-prefixed relative URLs (e.g., "at-rules/myfont.woff2" -> "myfont.woff2")
+                        // This happens because the browser resolves URLs relative to the HTML document location
+                        lessOutput = lessOutput.replace(/url\("([a-z-]+\/)([^"]+)"\)/g, 'url("$2")');
+                        // Also normalize @import statements that get resolved to absolute URLs
+                        lessOutput = lessOutput.replace(/@import "http:\/\/localhost:8081\/packages\/less\/node_modules\/@less\/test-data\/tests-unit\/([^"]+)"(.*);/g, '@import "$1"$2;');
+                        // Also normalize @import with directory prefix (e.g., "at-rules-keyword-comments/test.css" -> "test.css")
+                        lessOutput = lessOutput.replace(/@import "([a-z-]+\/)([^"]+)"(.*);/g, '@import "$2"$3;');
+                        
                         expect(lessOutput).to.equal(text);
                         done();
                     })
@@ -164,12 +176,21 @@ testErrorSheet = function (sheet) {
                 .replace(/\nStack Trace\n[\s\S]*/i, '')
                 .replace(/\n$/, '')
                 .trim();
+            actualErrorMsg = actualErrorMsg
+                .replace(/ in [\w\-]+\.less( on line \d+, column \d+)?:?$/, '')  // Remove filename and optional line/column from end of error message
+                .replace(/\{path\}/g, '')
+                .replace(/\{pathrel\}/g, '')
+                .replace(/\{pathhref\}/g, 'http://localhost:8081/packages/less/node_modules/@less/test-data/tests-error/eval/')
+                .replace(/\{404status\}/g, ' (404)')
+                .replace(/\{node\}[\s\S]*\{\/node\}/g, '')
+                .replace(/\n$/, '')
+                .trim();
             errorFile
                 .then(function (errorTxt) {
                     errorTxt = errorTxt
                         .replace(/\{path\}/g, '')
                         .replace(/\{pathrel\}/g, '')
-                        .replace(/\{pathhref\}/g, 'http://localhost:8081/test/less/errors/')
+                        .replace(/\{pathhref\}/g, 'http://localhost:8081/packages/less/node_modules/@less/test-data/tests-error/eval/')
                         .replace(/\{404status\}/g, ' (404)')
                         .replace(/\{node\}[\s\S]*\{\/node\}/g, '')
                         .replace(/\n$/, '')

package/test/browser/generator/runner.config.js

@@ -4,21 +4,25 @@ var { forceCovertToBrowserPath } = require('./utils');
 
 /** Root of repo */
 var testFolder = forceCovertToBrowserPath(path.dirname(resolve.sync('@less/test-data')));
-var lessFolder = forceCovertToBrowserPath(path.join(testFolder, 'less'));
+var testsUnitFolder = forceCovertToBrowserPath(path.join(testFolder, 'tests-unit'));
+var testsConfigFolder = forceCovertToBrowserPath(path.join(testFolder, 'tests-config'));
 var localTests = forceCovertToBrowserPath(path.resolve(__dirname, '..'));
 
 module.exports = {
     main: {
     // src is used to build list of less files to compile
         src: [
-            `${lessFolder}/_main/*.less`,
-            `!${lessFolder}/_main/plugin-preeval.less`, // uses ES6 syntax
+            `${testsUnitFolder}/*/*.less`,
+            `!${testsUnitFolder}/plugin-preeval/plugin-preeval.less`, // uses ES6 syntax
             // Don't test NPM import, obviously
-            `!${lessFolder}/_main/plugin-module.less`,
-            `!${lessFolder}/_main/import-module.less`,
-            `!${lessFolder}/_main/javascript.less`,
-            `!${lessFolder}/_main/urls.less`,
-            `!${lessFolder}/_main/empty.less`
+            `!${testsUnitFolder}/plugin-module/plugin-module.less`,
+            `!${testsUnitFolder}/import/import-module.less`,
+            `!${testsUnitFolder}/javascript/javascript.less`,
+            `!${testsUnitFolder}/urls/urls.less`,
+            `!${testsUnitFolder}/empty/empty.less`,
+            `!${testsUnitFolder}/color-functions/operations.less`, // conflicts with operations/operations.less
+            // Exclude debug line numbers tests - these are Node.js only (dumpLineNumbers is deprecated)
+            `!${testsConfigFolder}/debug/**/*.less`
         ],
         options: {
             helpers: 'test/browser/runner-main-options.js',
@@ -26,16 +30,8 @@ module.exports = {
             outfile: 'tmp/browser/test-runner-main.html'
         }
     },
-    legacy: {
-        src: [`${lessFolder}/legacy/*.less`],
-        options: {
-            helpers: 'test/browser/runner-legacy-options.js',
-            specs: 'test/browser/runner-legacy-spec.js',
-            outfile: 'tmp/browser/test-runner-legacy.html'
-        }
-    },
     strictUnits: {
-        src: [`${lessFolder}/units/strict/*.less`],
+        src: [`${testsConfigFolder}/units/strict/*.less`],
         options: {
             helpers: 'test/browser/runner-strict-units-options.js',
             specs: 'test/browser/runner-strict-units-spec.js',
@@ -44,8 +40,8 @@ module.exports = {
     },
     errors: {
         src: [
-            `${lessFolder}/errors/*.less`,
-            `${testFolder}/errors/javascript-error.less`,
+            `${testFolder}/tests-error/eval/*.less`,
+            `${testFolder}/tests-error/parse/*.less`,
             `${localTests}/less/errors/*.less`
         ],
         options: {
@@ -56,7 +52,7 @@ module.exports = {
         }
     },
     noJsErrors: {
-        src: [`${lessFolder}/no-js-errors/*.less`],
+        src: [`${testsConfigFolder}/no-js-errors/*.less`],
         options: {
             helpers: 'test/browser/runner-no-js-errors-options.js',
             specs: 'test/browser/runner-no-js-errors-spec.js',
@@ -141,7 +137,7 @@ module.exports = {
         }
     },
     postProcessorPlugin: {
-        src: [`${lessFolder}/postProcessorPlugin/*.less`],
+        src: [`${testsConfigFolder}/postProcessorPlugin/*.less`],
         options: {
             helpers: [
                 'test/plugins/postprocess/index.js',
@@ -153,7 +149,7 @@ module.exports = {
         }
     },
     preProcessorPlugin: {
-        src: [`${lessFolder}/preProcessorPlugin/*.less`],
+        src: [`${testsConfigFolder}/preProcessorPlugin/*.less`],
         options: {
             helpers: [
                 'test/plugins/preprocess/index.js',
@@ -164,7 +160,7 @@ module.exports = {
         }
     },
     visitorPlugin: {
-        src: [`${lessFolder}/visitorPlugin/*.less`],
+        src: [`${testsConfigFolder}/visitorPlugin/*.less`],
         options: {
             helpers: [
                 'test/plugins/visitor/index.js',
@@ -175,7 +171,7 @@ module.exports = {
         }
     },
     filemanagerPlugin: {
-        src: [`${lessFolder}/filemanagerPlugin/*.less`],
+        src: [`${testsConfigFolder}/filemanagerPlugin/*.less`],
         options: {
             helpers: [
                 'test/plugins/filemanager/index.js',

package/test/browser/generator/template.js

@@ -25,9 +25,20 @@ module.exports = (stylesheets, helpers, spec, less) => {
     <!-- for each test, generate CSS/LESS link tags -->
     $${stylesheets.map(function(fullLessName) {
         var pathParts = fullLessName.split('/');
-        var fullCssName = fullLessName
-            .replace(/\/(browser|test-data)\/less\//g, '/$1/css/')
-            .replace(/less$/, 'css')
+        var fullCssName = fullLessName.replace(/less$/, 'css');
+        
+        // Check if the CSS file exists in the same directory as the LESS file
+        var fs = require('fs');
+        var cssExists = fs.existsSync(fullCssName);
+        
+        // If not, try the css/ directory for local browser tests
+        if (!cssExists && fullLessName.includes('/test/browser/less/')) {
+            var cssInCssDir = fullLessName.replace('/test/browser/less/', '/test/browser/css/').replace(/less$/, 'css');
+            if (fs.existsSync(cssInCssDir)) {
+                fullCssName = cssInCssDir;
+            }
+        }
+        
         var lessName = pathParts[pathParts.length - 1];
         var name = lessName.split('.')[0];
         return `

package/test/browser/runner-browser-options.js

@@ -6,7 +6,7 @@ var less = {
 };
 
 // test inline less in style tags by grabbing an assortment of less files and doing `@import`s
-var testFiles = ['charsets', 'colors', 'comments', 'css-3', 'strings', 'media', 'mixins'],
+var testFiles = ['charsets/charsets', 'color-functions/basic', 'comments/comments', 'css-3/css-3', 'strings/strings', 'media/media', 'mixins/mixins'],
     testSheets = [];
 
 // setup style tags with less and link tags pointing to expected css output
@@ -14,13 +14,13 @@ var testFiles = ['charsets', 'colors', 'comments', 'css-3', 'strings', 'media',
 /**
  * @todo - generate the node_modules path for this file and in templates
  */
-var lessFolder = '../../node_modules/@less/test-data/less'
-var cssFolder = '../../node_modules/@less/test-data/css'
+var lessFolder = '../../node_modules/@less/test-data/tests-unit'
+var cssFolder = '../../node_modules/@less/test-data/tests-unit'
 
 for (var i = 0; i < testFiles.length; i++) {
     var file = testFiles[i],
-        lessPath  = lessFolder + '/_main/' + file + '.less',
-        cssPath   = cssFolder + '/_main/' + file + '.css',
+        lessPath  = lessFolder + '/' + file + '.less',
+        cssPath   = cssFolder + '/' + file + '.css',
         lessStyle = document.createElement('style'),
         cssLink   = document.createElement('link'),
         lessText  = '@import "' + lessPath + '";';