less-openui5 0.11.6 → 0.11.7

package/CONTRIBUTING.md

@@ -1,6 +1,11 @@
 # Contributing to less-openui5
 
 In general the contributing guidelines of OpenUI5 also apply to this project. They can be found here:  
-https://github.com/SAP/openui5/blob/master/CONTRIBUTING.md
+https://github.com/SAP/openui5/blob/-/CONTRIBUTING.md
 
 Some parts might not be relevant for this project (e.g. the browser-specific requirements like jQuery, CSS and accessibility in the "Contribution Content Guidelines") and the contribution process is easier (pull requests will be merged directly on GitHub).
+
+# Contributing with AI-generated code
+As artificial intelligence evolves, AI-generated code is becoming valuable for many software projects, including open-source initiatives. While we recognize the potential benefits of incorporating AI-generated content into our open-source projects there are certain requirements that need to be reflected and adhered to when making contributions.
+
+Please see our [guideline for AI-generated code contributions to SAP Open Source Software Projects](https://github.com/SAP/.github/blob/main/CONTRIBUTING_USING_GENAI.md) for these requirements.

package/LICENSE.txt

@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright 2023 SAP SE or an SAP affiliate company.
+   Copyright [yyyy] [name of copyright owner]
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

package/README.md

@@ -1,7 +1,7 @@
 ![OpenUI5](http://openui5.org/images/OpenUI5_new_big_side.png)
 
 [![REUSE status](https://api.reuse.software/badge/github.com/SAP/less-openui5)](https://api.reuse.software/info/github.com/SAP/less-openui5)
-[![Build Status](http://img.shields.io/travis/SAP/less-openui5.svg?style=flat)](https://travis-ci.org/SAP/less-openui5)
+[![GitHub CI](https://github.com/SAP/less-openui5/actions/workflows/github-ci.yml/badge.svg)](https://github.com/SAP/less-openui5/actions/workflows/github-ci.yml)
 [![NPM Version](http://img.shields.io/npm/v/less-openui5.svg?style=flat)](https://www.npmjs.org/package/less-openui5)
 
 # less-openui5

package/lib/Compiler.js

@@ -1,6 +1,5 @@
 const path = require("path");
 const createParser = require("./less/parser");
-const clone = require("clone");
 
 // Plugins
 const ImportCollectorPlugin = require("./plugin/import-collector");
@@ -56,7 +55,7 @@ class Compiler {
 		};
 	}
 	async compile(config) {
-		const parserOptions = clone(this.options.parser);
+		const parserOptions = structuredClone(this.options.parser);
 		let rootpath;
 
 		if (config.path) {

package/lib/plugin/rtl.js

@@ -2,7 +2,7 @@
 
 const less = require("../thirdparty/less");
 const path = require("path");
-const url = require("url");
+const {isAbsoluteUrl} = require("./util");
 
 const cssSizePattern = /(-?[.0-9]+)([a-z]*)/;
 const percentagePattern = /^\s*(-?[.0-9]+)%\s*$/;
@@ -619,9 +619,8 @@ LessRtlPlugin.prototype = {
 		}
 		modifyOnce(node, "replaceUrl", (urlNode) => {
 			const imgPath = urlNode.value.value;
-			const parsedUrl = url.parse(imgPath);
-			if (parsedUrl.protocol || imgPath.startsWith("/")) {
-				// Ignore absolute urls
+			if (isAbsoluteUrl(imgPath)) {
+				// Ignore urls with a scheme (http:, data:, etc.) and server-absolute urls.
 				return;
 			}
 			const imgPathRTL = LessRtlPlugin.getRtlImgUrl(imgPath);

package/lib/plugin/url-collector.js

@@ -1,8 +1,8 @@
 "use strict";
 
 const path = require("path");
-const url = require("url");
 const less = require("../thirdparty/less");
+const {isAbsoluteUrl} = require("./util");
 
 const urlNodeNames = {
 	"background": true,
@@ -48,10 +48,8 @@ UrlCollectorPlugin.prototype = {
 		if (node.type === "Url") {
 			const relativeUrl = node.value.value;
 
-			const parsedUrl = url.parse(relativeUrl);
-			// Ignore urls with protocol (also includes data urls)
-			// Ignore server absolute urls
-			if (parsedUrl.protocol || relativeUrl.startsWith("/")) {
+			// Ignore urls with a scheme (http:, data:, etc.) and server-absolute urls.
+			if (isAbsoluteUrl(relativeUrl)) {
 				return;
 			}
 

package/lib/plugin/util.js

@@ -0,0 +1,20 @@
+"use strict";
+
+/**
+ * Checks whether a CSS url() value should be treated as absolute, i.e. must not be resolved
+ * relative to the current file. This covers urls carrying a scheme (http:, https:, data:, ...)
+ * as well as server-absolute urls starting with "/".
+ *
+ * URL.canParse only succeeds for absolute urls (those with a scheme), so relative urls return
+ * false.
+ *
+ * @param {string} value the url value as taken from the CSS url() node
+ * @returns {boolean} true if the url is absolute and should not be resolved relatively
+ */
+function isAbsoluteUrl(value) {
+	return URL.canParse(value) || value.startsWith("/");
+}
+
+module.exports = {
+	isAbsoluteUrl
+};

package/lib/plugin/variable-collector.js

@@ -39,6 +39,7 @@ VariableCollector.prototype = {
 				filename: node.currentFileInfo.filename,
 				rootFilename: node.currentFileInfo.rootFilename
 			};
+		// eslint-disable-next-line no-unused-vars
 		} catch (err) {
 			// Errors might occur within mixins.
 			// But as we only collect global variables, this doesn't matter...

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "less-openui5",
-	"version": "0.11.6",
+	"version": "0.11.7",
 	"description": "Build OpenUI5 themes with Less.js",
 	"author": {
 		"name": "SAP SE",
@@ -18,20 +18,20 @@
 	],
 	"main": "lib/index.js",
 	"engines": {
-		"node": ">= 10",
-		"npm": ">= 5"
+		"node": "^20.11.0 || >=22.0.0",
+		"npm": ">= 8"
 	},
 	"scripts": {
 		"lint": "eslint ./",
 		"unit": "mocha test/*.js test/lib/**",
 		"unit-debug": "mocha --inspect --inspect-brk test/*.js test/lib/**",
 		"coverage": "nyc npm run unit",
-		"test": "npm run lint && npm run coverage && npm run depcheck",
+		"test": "npm run lint && npm run coverage && npm run knip",
 		"preversion": "npm test",
 		"version": "git-chglog --next-tag v$npm_package_version -o CHANGELOG.md 0.7.0.. && git add CHANGELOG.md",
-		"postversion": "git push --follow-tags",
+		"prepublishOnly": "git push --follow-tags",
 		"release-note": "git-chglog -c .chglog/release-config.yml v$npm_package_version",
-		"depcheck": "depcheck --ignores clean-css,source-map"
+		"knip": "knip --config knip.config.js"
 	},
 	"files": [
 		"CONTRIBUTING.md",
@@ -49,7 +49,8 @@
 			"coverage/**",
 			"test/**",
 			".eslintrc.js",
-			"lib/thirdparty/**"
+			"lib/thirdparty/**",
+			"knip.config.js"
 		],
 		"check-coverage": true,
 		"statements": 95,
@@ -82,17 +83,19 @@
 		"url": "git@github.com:SAP/less-openui5.git"
 	},
 	"dependencies": {
-		"@adobe/css-tools": "^4.0.2",
-		"clone": "^2.1.2",
+		"@adobe/css-tools": "^4.5.0",
 		"mime": "^1.6.0"
 	},
 	"devDependencies": {
-		"depcheck": "^1.4.3",
-		"eslint": "^7.32.0",
+		"@eslint/js": "^9.15.0",
+		"eslint": "^9.39.5",
 		"eslint-config-google": "^0.14.0",
-		"graceful-fs": "^4.2.10",
-		"mocha": "^8.4.0",
-		"nyc": "^15.1.0",
-		"sinon": "^11.1.2"
+		"eslint-plugin-jsdoc": "61.5.0",
+		"globals": "^17.7.0",
+		"graceful-fs": "^4.2.11",
+		"knip": "^5.88.1",
+		"mocha": "^11.7.6",
+		"nyc": "^18.0.0",
+		"sinon": "^16.1.3"
 	}
 }

package/.reuse/dep5

@@ -1,33 +0,0 @@
-Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: less-openui5
-Upstream-Contact: SAP OpenUI5 <openui5@sap.com>
-Source: https://github.com/SAP/less-openui5
-Disclaimer: The code in this project may include calls to APIs (“API Calls”) of
- SAP or third-party products or services developed outside of this project
- (“External Products”).
- “APIs” means application programming interfaces, as well as their respective
- specifications and implementing code that allows software to communicate with
- other software.
- API Calls to External Products are not licensed under the open source license
- that governs this project. The use of such API Calls and related External
- Products are subject to applicable additional agreements with the relevant
- provider of the External Products. In no event shall the open source license
- that governs this project grant any rights in or to any External Products,or
- alter, expand or supersede any terms of the applicable additional agreements.
- If you have a valid license agreement with SAP for the use of a particular SAP
- External Product, then you may make use of any API Calls included in this
- project’s code for that SAP External Product, subject to the terms of such
- license agreement. If you do not have a valid license agreement for the use of
- a particular SAP External Product, then you may only make use of any API Calls
- in this project for that SAP External Product for your internal, non-productive
- and non-commercial test and evaluation of such API Calls. Nothing herein grants
- you any rights to use or access any SAP External Product, or provide any third
- parties the right to use of access any SAP External Product, through API Calls.
-
-Files: *
-Copyright: 2016-2023 SAP SE or an SAP affiliate company and less-openui5 contributors
-License: Apache-2.0
-
-Files: lib/thirdparty/less/*
-Copyright: Copyright (c) 2009-2014 Alexis Sellier & The Core Less Team
-License: Apache-2.0