lesgo 0.7.4 → 0.7.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lesgo",
-  "version": "0.7.4",
+  "version": "0.7.5",
   "description": "Core framework for lesgo node.js serverless framework.",
   "main": "./src/index.js",
   "author": "Sufiyan Rahmat",

package/src/middlewares/__tests__/errorHttpResponseMiddleware.spec.js

@@ -21,7 +21,7 @@ describe('MiddlewareGroup: test errorHandler middleware', () => {
     expect(dataBody).toHaveProperty('status', 'error');
     expect(dataBody).toHaveProperty('data', null);
     expect(dataBody).toHaveProperty('error');
-    expect(dataBody).toHaveProperty('error.code', 'UNKNOWN_ERROR');
+    expect(dataBody).toHaveProperty('error.code', 'UNHANDLED_ERROR');
     expect(dataBody).toHaveProperty(
       'error.message',
       'Error: Test validation error'
@@ -78,7 +78,7 @@ describe('MiddlewareGroup: test errorHandler middleware', () => {
 
     expect(data.statusCode).toBe(500);
 
-    expect(dataBody).toHaveProperty('error.code', 'UNKNOWN_ERROR');
+    expect(dataBody).toHaveProperty('error.code', 'UNHANDLED_ERROR');
     expect(dataBody).toHaveProperty('error.message', 'Test error message');
     expect(dataBody).toHaveProperty('error.details', '');
   });
@@ -126,7 +126,7 @@ describe('MiddlewareGroup: test errorHandler middleware', () => {
     expect(dataBody).toHaveProperty('status', 'error');
     expect(dataBody).toHaveProperty('data', null);
     expect(dataBody).toHaveProperty('error');
-    expect(dataBody).toHaveProperty('error.code', 'UNKNOWN_ERROR');
+    expect(dataBody).toHaveProperty('error.code', 'UNHANDLED_ERROR');
     expect(dataBody).toHaveProperty('error.message', '');
     expect(dataBody).toHaveProperty('error.details', '');
   });

package/src/middlewares/__tests__/normalizeHttpRequestMiddleware.spec.js

@@ -102,7 +102,6 @@ describe('MiddlewareGroup: test normalizeHttpRequestBeforeHandler', () => {
     };
 
     normalizeHttpRequestBeforeHandler(handler, () => {});
-    expect(handler.event.requestContext.requestId).toBe('requestId');
   });
 
   it('should return auth.sub if Authorization exists', () => {
@@ -119,6 +118,44 @@ describe('MiddlewareGroup: test normalizeHttpRequestBeforeHandler', () => {
     expect(handler.event.auth.sub).toBe('f2b5349d-f5e3-44f5-9c08-ae6b01e95434');
   });
 
+  it.each`
+    version  | tags
+    ${'1.0'} | ${{ path: '/v1/path', httpMethod: 'GET' }}
+    ${'2.0'} | ${{ path: '/v2/path', httpMethod: 'POST' }}
+    ${'3.0'} | ${{ path: '/v2/path', httpMethod: 'POST' }}
+  `(
+    'should identify path and httpMethod based on version',
+    ({ version, tags }) => {
+      const handler = {
+        event: {
+          version,
+          headers: {},
+          ...tags,
+          requestContext: {
+            http: {
+              ...tags,
+              method: tags.httpMethod,
+            },
+          },
+        },
+      };
+      normalizeHttpRequestBeforeHandler(handler, () => {});
+      expect(logger.meta.tags).toStrictEqual(tags);
+    }
+  );
+
+  it('should not set tags when using API Gateway v2 and requestContext is empty', () => {
+    const handler = {
+      event: {
+        version: '2.0',
+        headers: {},
+      },
+    };
+
+    normalizeHttpRequestBeforeHandler(handler, () => {});
+    expect(logger.meta.tags).toStrictEqual({});
+  });
+
   it('should not set meta on debug', () => {
     app.debug = true;
     const handler = {
@@ -133,6 +170,7 @@ describe('MiddlewareGroup: test normalizeHttpRequestBeforeHandler', () => {
         },
       },
     };
+
     normalizeHttpRequestBeforeHandler(handler, () => {});
     expect(logger.meta.auth).toBe(handler.event.auth);
     expect(logger.meta.queryStringParameters).toStrictEqual(

package/src/middlewares/errorHttpResponseMiddleware.js

@@ -1,6 +1,8 @@
 import logger from '../utils/logger';
 import isEmpty from '../utils/isEmpty';
 
+const FILE = 'Lesgo/middlewares/errorHttpResponseMiddleware';
+
 export const errorHttpResponseHandler = async opts => {
   const defaults = {
     response: '',
@@ -29,7 +31,7 @@ export const errorHttpResponseHandler = async opts => {
     status: 'error',
     data: null,
     error: {
-      code: options.error.code || 'UNKNOWN_ERROR',
+      code: options.error.code || 'UNHANDLED_ERROR',
       message: options.error.name
         ? `${options.error.name}: ${options.error.message}`
         : options.error.message || options.error,
@@ -40,18 +42,18 @@ export const errorHttpResponseHandler = async opts => {
 
   const statusCode = options.error.statusCode || options.statusCode;
 
-  /* istanbul ignore next */
-  if (statusCode === 500) {
-    // this is likely an unhandled exception, log it
-    logger.error(options.error);
+  if (!isEmpty(options.error)) {
+    logger.log(statusCode === 500 ? 'error' : 'warn', options.error);
   } else {
-    logger.warn(options.error);
+    logger.log(statusCode === 500 ? 'error' : 'warn', jsonBody.error.message, {
+      error: jsonBody.error,
+    });
   }
 
   try {
     if (!isEmpty(opts.db)) await opts.db.end();
   } catch (err) {
-    // do nothing
+    logger.error(`${FILE}::Failed to end db connection`, err);
   }
 
   return {

package/src/middlewares/normalizeHttpRequestMiddleware.js

@@ -53,14 +53,26 @@ export const normalizeHttpRequestBeforeHandler = (handler, next) => {
   // eslint-disable-next-line no-param-reassign
   handler.event.auth = auth;
 
+  const tags = {};
+  switch (handler.event.version) {
+    case '2.0': {
+      if (handler.event.requestContext && handler.event.requestContext.http) {
+        tags.path = handler.event.requestContext.http.path;
+        tags.httpMethod = handler.event.requestContext.http.method;
+      }
+      break;
+    }
+    default:
+      tags.path = handler.event.path;
+      tags.httpMethod = handler.event.httpMethod;
+      break;
+  }
+
   logger.addMeta({
     requestId: handler.event.requestContext
       ? handler.event.requestContext.requestId
       : null,
-    tags: {
-      path: handler.event.path,
-      httpMethod: handler.event.httpMethod,
-    },
+    tags,
   });
 
   if (app.debug) {