lemon-tls 0.3.0 → 0.4.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lemon-tls",
-  "version": "0.3.0",
-  "description": "Zero-dependency TLS 1.3/1.2 implementation for Node.js - full control over cryptographic keys, record layer, and handshake. Drop-in replacement for node:tls with advanced options impossible in OpenSSL.",
+  "version": "0.4.0",
+  "description": "TLS 1.3/1.2 implementation for Node.js - full control over cryptographic keys, record layer, and handshake. Drop-in replacement for node:tls with advanced options impossible in OpenSSL.",
   "main": "index.js",
   "type": "module",
   "types": "index.d.ts",

package/src/dtls_socket.js

@@ -44,6 +44,7 @@ function DTLSSocket(udpSocket, options) {
     cert: options.cert,
     key: options.key,
     rejectUnauthorized: options.rejectUnauthorized,
+    requestCert: options.requestCert,
     ca: options.ca,
     alpnProtocols: options.alpnProtocols,
     minVersion: options.minVersion,
@@ -159,6 +160,7 @@ function createDTLSServer(options, connectionListener) {
           remotePort: rinfo.port,
           cert: options.cert,
           key: options.key,
+          requestCert: options.requestCert,
           SNICallback: options.SNICallback,
           alpnProtocols: options.alpnProtocols,
           minVersion: options.minVersion,
@@ -239,6 +241,7 @@ function connectDTLS(options, callback) {
     remotePort: port,
     servername: options.servername || host,
     rejectUnauthorized: options.rejectUnauthorized,
+    requestCert: options.requestCert,
     ca: options.ca,
     alpnProtocols: options.alpnProtocols,
     minVersion: options.minVersion,

package/src/session/message.js

@@ -29,7 +29,7 @@ function normalize_hello(hello) {
       } else if (name === 'KEY_SHARE') {
         if (!('key_groups' in out)) out.key_groups = [];
         if (!('supported_groups' in out)) out.supported_groups = [];
-        for (let i2 in value) {
+        for (let i2 = 0; i2 < value.length; i2++) {
           if (out.supported_groups.indexOf(value[i2].group) < 0) {
             out.supported_groups.push(value[i2].group);
           }

package/src/tls_session.js

@@ -533,7 +533,7 @@ function TLSSession(options){
             }
 
             // Custom extensions (e.g. QUIC transport params 0x39)
-            for (let ci in context.local_extensions) {
+            for (let ci = 0; ci < context.local_extensions.length; ci++) {
               extensions.push(context.local_extensions[ci]);
             }
 
@@ -999,7 +999,7 @@ function TLSSession(options){
 
 
       if('add_local_key_groups' in options){
-        for(let i in options['add_local_key_groups']){
+        for(let i = 0; i < options['add_local_key_groups'].length; i++){
 
           let group=options['add_local_key_groups'][i].group;
           if(group in context.local_key_groups==false){
@@ -1029,7 +1029,7 @@ function TLSSession(options){
 
 
       if('add_remote_key_groups' in options){
-        for(let i in options['add_remote_key_groups']){
+        for(let i = 0; i < options['add_remote_key_groups'].length; i++){
 
           let group=options['add_remote_key_groups'][i].group;
           if(group in context.remote_key_groups==false){
@@ -1779,7 +1779,7 @@ function TLSSession(options){
           }
 
 
-          for(let i in context.local_extensions){
+          for(let i = 0; i < context.local_extensions.length; i++){
             extensions.push(context.local_extensions[i]);
           }
 
@@ -2105,6 +2105,41 @@ function TLSSession(options){
         }
       }
 
+      // TLS 1.2 / DTLS 1.2 server: send CertificateRequest if mutual auth was
+      // requested via { requestCert: true }. Per RFC 5246 §7.4.4 this message
+      // goes between ServerKeyExchange and ServerHelloDone. The TLS 1.3 path
+      // (line ~1805) sends CertificateRequest between EncryptedExtensions and
+      // Certificate and is handled separately — version branching matters
+      // because the wire formats differ (RFC 5246 §7.4.4 vs RFC 8446 §4.3.2).
+      //
+      // Without this block, a 1.2 server that sets requestCert never actually
+      // requests the client's certificate, the client never sends one (TLS
+      // clients only send a cert in response to CertificateRequest), and any
+      // application-layer fingerprint check on the server fails with "peer
+      // presented no certificate" — most notably breaking WebRTC, which
+      // mandates mutual authentication (RFC 8827 §6.5) and pins to DTLS 1.2.
+      if (context.isServer == true && context.requestCert == true &&
+          !context.certificateRequestSent &&
+          context.key_exchange_sent == true && !context.hello_done_sent &&
+          (context.selected_version === wire.TLS_VERSION.TLS1_2 ||
+           context.selected_version === wire.DTLS_VERSION.DTLS1_2)) {
+
+        let cr_body = wire.build_certificate_request({
+          version: wire.TLS_VERSION.TLS1_2,
+          // rsa_sign(1), ecdsa_sign(64) — accept both. WebRTC uses ECDSA,
+          // most other 1.2 deployments use RSA. The client picks whichever
+          // matches its certificate.
+          certificate_types: [1, 64],
+          signature_algorithms: context.local_supported_signature_algorithms || [],
+          certificate_authorities: [],  // empty: accept any CA
+        });
+        let cr_data = wire.build_message(wire.TLS_MESSAGE_TYPE.CERTIFICATE_REQUEST, cr_body);
+        pushTranscript(cr_data);
+        context.certificateRequestSent = true;
+        ev.emit('message', 0, context.message_sent_seq, 'certificate_request', cr_data);
+        context.message_sent_seq++;
+      }
+
       //server hello done - 1.2 only...
       if(context.isServer==true && (context.selected_version === wire.TLS_VERSION.TLS1_2 || context.selected_version === wire.DTLS_VERSION.DTLS1_2)){
         if(context.hello_done_sent==false && context.key_exchange_sent==true){
@@ -2730,7 +2765,7 @@ function TLSSession(options){
       }
 
       // Add custom extensions (e.g. QUIC transport params 0x39)
-      for (let i in context.local_extensions) {
+      for (let i = 0; i < context.local_extensions.length; i++) {
         extensions.push(context.local_extensions[i]);
       }