leerness 1.36.183 → 1.36.185

package/lib/pure-utils.js

@@ -1,12 +1,27 @@
 'use strict';
 
+// Model identifiers reach argv surfaces. Keep the shell-inert predicate in this
+// side-effect-free module so persisted schemas and runtime dispatch cannot drift.
+const SAFE_MODEL_IDENTIFIER_RE = /^[A-Za-z0-9][A-Za-z0-9._:/@+-]{0,199}$/;
+function isValidModelIdentifier(value) {
+  const raw = String(value == null ? '' : value);
+  const visible = stripDefaultIgnorables(raw, { nfkc: true, visibleIdentity: true })
+    .replace(/[\u0000-\u001f\u007f-\u009f\u2028\u2029]/g, '')
+    .trim();
+  return raw === visible && SAFE_MODEL_IDENTIFIER_RE.test(visible);
+}
+
 // 1.9.274 (UR-0025 1단계, GPT-5.5 리뷰): bin/harness.js 단일 대형 파일 모듈 분리 — 점진적·비파괴 시작.
 //   여기에는 harness 내부 상태/다른 함수에 의존하지 않는 "순수 함수"만 추출한다 (부작용 0, 단위 테스트 대상).
 //   harness.js 는 이 모듈을 require 해 동일 이름으로 사용한다. 동작 동일 — selftest 가 7종 모두 검증.
 
 // 보안: 환경변수 키가 시크릿(TOKEN/SECRET/PASSWORD/API_KEY/PRIVATE)인지 판별.
 function _isSecretKey(k) {
-  return /TOKEN|SECRET|PASSWORD|API_KEY|PRIVATE/i.test(k);
+  // Environment keys are identifiers, not display text. Classify their
+  // compatibility spelling so full-width and Default-Ignorable variants cannot
+  // pass an ASCII allow-list and reach a child process with their secret value.
+  const canonical = stripDefaultIgnorables(k, { nfkc: true, visibleIdentity: true });
+  return /TOKEN|SECRET|PASSWORD|API_KEY|PRIVATE/i.test(canonical);
 }
 
 // 표시용 자유 텍스트에서 시크릿 값을 가린다 — 키 이름은 남겨 맥락을 유지하고 **값만** 지운다.
@@ -263,13 +278,19 @@ function _tierRank(t) { const i = PERMISSION_TIERS.indexOf(String(t || '')); ret
 // 명령/capability → 요구 등급 (순수 매핑)
 function _requiredTier(cmd) {
   const c = String(cmd || '').toLowerCase();
+  // Lease operands are arbitrary file names. Classify the parsed command/action
+  // prefix before scanning generic keywords so a path such as
+  // `dir/release publish/report.js` cannot turn a read-only check into publish.
+  const leaseCommand = c.match(/^\s*(?:(?:npx(?:\s+(?:-y|--yes))?\s+)?leerness(?:@[^\s]+)?\s+)?lease\s+(list|check|acquire|release)(?:\s|$)/);
+  if (leaseCommand && (leaseCommand[1] === 'list' || leaseCommand[1] === 'check')) return 'read-only';
+  if (leaseCommand) return 'safe-write';
   if (/release\s+publish|npm\s+publish|\bpublish\b/.test(c)) return 'publish';
   if (/\bweb\b/.test(c)) return 'network';
   if (/git\s+push|sync-main/.test(c)) return 'git-write';
   if (/multi\s+--execute|dispatch\s+--write|--yolo|\bpc\b/.test(c)) return 'shell-write';
   if (/agents\s+(list|quota|bench)|--run-tests/.test(c)) return 'shell-read';
   if (/\binit\b|\badapter\b|update\s+--yes|\bmigrate\b/.test(c)) return 'project-write';
-  if (/state\s+(start|record|verify|handoff)|decision|lesson|plan\s+add|task\s+add|rule\s+add/.test(c)) return 'safe-write';
+  if (/state\s+(start|record|verify|handoff)|decision|lesson|plan\s+add|task\s+add|rule\s+add|lease\s+(acquire|release)/.test(c)) return 'safe-write';
   return 'read-only';
 }
 function _policyAllows(allowedTier, requiredTier) { return _tierRank(requiredTier) <= _tierRank(allowedTier); }
@@ -868,10 +889,15 @@ function _renderDecisionsMd(decisions) {
   // preamble 의 코드펜스(```)는 single-quote 문자열로 안전 처리 (template literal 충돌 회피)
   const preamble = '# Decisions\n\n## Template (예시 — 실제 결정은 아래 코드블록 밖에 추가)\n\n'
     + '```md\n### YYYY-MM-DD — Decision 제목\n- Decision:\n- Reason:\n- Alternatives:\n- Impact:\n```\n';
+  const field = (name, value) => {
+    const safe = _lineSafe(value || '');
+    return `- ${name}:${safe ? ' ' + safe : ''}`;
+  };
   const body = (decisions || []).map(d => {
     // 1.9.402 (UR-0108): 필드 개행 → 공백(MD projection '### '/'- field:' 라인 위조 블록 주입 차단). canonical JSON 은 raw 유지.
+    // 1.36.185: 빈 canonical 필드는 colon 뒤 공백을 만들지 않는다 — decision add 후 git diff --check 위반 차단.
     const head = d.date ? `${_lineSafe(d.date)} — ${_lineSafe(d.title)}` : _lineSafe(d.title);
-    return `\n### ${head}\n- Decision: ${_lineSafe(d.decision || '')}\n- Reason: ${_lineSafe(d.reason || '')}\n- Alternatives: ${_lineSafe(d.alternatives || '')}\n- Impact: ${_lineSafe(d.impact || '')}\n`;
+    return `\n### ${head}\n${field('Decision', d.decision)}\n${field('Reason', d.reason)}\n${field('Alternatives', d.alternatives)}\n${field('Impact', d.impact)}\n`;
   }).join('');
   return preamble + body;
 }
@@ -1886,6 +1912,7 @@ module.exports = { _decisionBlocksWithOffset, _blocksWithOffset, _lineOfOffset,
   _parseImplExports, _briefUnfilled, _planGoalUnfilled, _mdSectionBody, _draftAnchors, _replaceMdSection,
   _matchTool, _parsePackageJsonDeps, _parseRequirementsTxt, _buildGlossary, _renderGlossaryMd, GLOSSARY_START, GLOSSARY_END,
   _isSecretKey, redactSecrets, hasCredentialMarker, compareVer, parseHarnessVersion,
+  SAFE_MODEL_IDENTIFIER_RE, isValidModelIdentifier,
   _isPlaceholderSecret, _looksSecretLike,
   _mergeLines, _mergeEnvLines, _mergeReadmeSection, _managedMerge, _splitPreserved, PRESERVED_TAG, _detectOrphanGuards, _parseSkillsValue,
   _parseArchiveBlocks, _parseSkillCatalog, _renderTeamsMd, _composeTeamPlan, _teamHandoffReminders, _cadenceAssessment, _teamDeployGate, _renderWorkspaceReferenceGuide, _memorySurface, _renderPulseLine,
@@ -1949,7 +1976,7 @@ module.exports = { _decisionBlocksWithOffset, _blocksWithOffset, _lineOfOffset,
   // 1.9.399 (7번째 버그헌트 P1-A, UR-0104): markdown 테이블 셀 안전화(파이프/개행 injection 차단)
   _cellSafe, _cellUnescape,
   // 1.9.402 (7번째 버그헌트 P1-A 잔여, UR-0108): MD projection 라인 안전화(개행→공백)
-  _lineSafe, _milestoneSurface, _recentChangesSurface, _recentChangesAggregate,
+  _lineSafe, stripDefaultIgnorables, _milestoneSurface, _recentChangesSurface, _recentChangesAggregate,
   // 1.9.407 (8번째 버그헌트, UR-0111): --limit 안전 파싱(NaN/음수/0 → 기본값)
   _parseLimit,
   // 1.9.416 (9th 외부평가, UR-0122): add 류 제목 파싱(flag/경로 break) 단일 출처
@@ -2234,6 +2261,27 @@ function _cellUnescape(s) { return String(s == null ? '' : s).replace(/\\\|/g, '
 //   ESC/CSI·VT·FF·NEL도 제거해 진단 출력과 MD projection에서 가짜 줄뿐 아니라 화면 지우기/커서 이동도 차단한다.
 function _lineSafe(s) { return String(s == null ? '' : s).replace(/\r\n|[\u0000-\u001f\u007f-\u009f\u2028\u2029]/g, ' '); }
 
+// Security-sensitive comparisons must share one Unicode policy. A hand-maintained
+// list had diverged between routing and provenance and missed Shorthand Format
+// Controls (U+1BCA0..U+1BCAF). Prefer the Unicode binary property exposed by
+// supported Node runtimes, with a conservative fallback for older engines.
+let _defaultIgnorableRe;
+try { _defaultIgnorableRe = new RegExp('\\p{Default_Ignorable_Code_Point}', 'gu'); }
+catch {
+  _defaultIgnorableRe = /[\u00ad\u034f\u061c\u115f-\u1160\u17b4-\u17b5\u180b-\u180f\u200b-\u200f\u202a-\u202e\u2060-\u206f\u3164\ufe00-\ufe0f\ufeff\uffa0\u{1bca0}-\u{1bcaf}\u{1d173}-\u{1d17a}\u{e0000}-\u{e0fff}]/gu;
+}
+function stripDefaultIgnorables(value, options = {}) {
+  let text = String(value == null ? '' : value);
+  if (options.nfkc === true) {
+    try { text = text.normalize('NFKC'); } catch {}
+  }
+  text = text.replace(_defaultIgnorableRe, '');
+  // Braille blank is visible-space spoofing rather than a Unicode default
+  // ignorable. Identity/approval callers opt into removing it as well.
+  if (options.visibleIdentity === true) text = text.replace(/\u2800/g, '');
+  return text;
+}
+
 // Git-backed aggregate surfaces must not turn "could not measure" into a
 // believable zero. Handoff, health, and session-close share this projection.
 function _milestoneSurface(value) {