lee-spec-kit 0.9.5 → 0.9.6

package/dist/index.js

@@ -213,7 +213,7 @@ var koCli = {
   "init.choice.taskAgent.on": "\uC0AC\uC6A9 - \uAC01 Task \uAD6C\uD604\uC744 \uC704\uC784",
   "init.choice.taskAgent.off": "\uC0AC\uC6A9 \uC548 \uD568 - \uBA54\uC778 \uC5D0\uC774\uC804\uD2B8\uAC00 \uC9C1\uC811 \uAD6C\uD604",
   "init.prompt.reviews": "\uB3C5\uB9BD \uAC80\uC218 \uB2E8\uACC4\uB97C \uC120\uD0DD\uD558\uC138\uC694:",
-  "init.prompt.maxReviewRounds": "\uC0AC\uC6A9\uC790\uC5D0\uAC8C \uD310\uB2E8\uC744 \uC694\uCCAD\uD558\uAE30 \uC804 \uB9AC\uBDF0 \uC9C0\uC801 \uC790\uB3D9 \uBC18\uC601 \uCD5C\uB300 \uD69F\uC218:",
+  "init.prompt.maxReviewRounds": "\uC794\uC5EC \uC704\uD5D8\uC744 \uAE30\uB85D\uD558\uACE0 \uACC4\uC18D\uD558\uAE30 \uC804 \uB9AC\uBDF0 \uC9C0\uC801 \uC790\uB3D9 \uBC18\uC601 \uCD5C\uB300 \uD69F\uC218:",
   "init.choice.review.plan": "Plan",
   "init.choice.review.task": "Task",
   "init.choice.review.feature": "Feature",
@@ -527,7 +527,7 @@ var enCli = {
   "init.choice.taskAgent.on": "On - delegate each task implementation",
   "init.choice.taskAgent.off": "Off - implement tasks in the main agent",
   "init.prompt.reviews": "Select independent review gates:",
-  "init.prompt.maxReviewRounds": "Maximum automatic review finding remediation rounds before asking the user:",
+  "init.prompt.maxReviewRounds": "Maximum automatic finding remediation rounds before continuing with residual risks:",
   "init.choice.review.plan": "Plan",
   "init.choice.review.task": "Task",
   "init.choice.review.feature": "Feature",
@@ -1374,7 +1374,7 @@ Before taking the next workflow step:
 16. When \`workflow-stage --json\` returns \`nextAction.category === "task_review"\` with \`executor === "subagent"\`, delegate a fresh read-only review for the returned \`taskId\`, \`baseSha\`, \`targetSha\`, and \`targetTree\`; the main agent records the returned reviewRound and evidence and moves the task from \`REVIEW\` to \`DONE\` only after an approve decision
 17. When \`workflow-stage --json\` returns \`nextAction.category === "pre_pr_review"\` and \`nextAction.executor === "subagent"\`, delegate a fresh read-only Feature review using the returned \`model\`, \`reasoningEffort\`, \`onUnavailable\`, reviewRound, and review target metadata; do not select or require a named review skill
 18. Review subagents return findings without modifying code; the main agent remediates findings and records the actual reviewer metadata, reviewed scope, evidence, decision, and exact hash/SHA/tree target metadata
-19. workflow.agentReview.maxRounds counts automatic finding-remediation passes, not the initial review. When workflow-stage returns nextAction.category review_escalation, those passes have been exhausted; do not remediate or delegate another review, keep implementation blocked, and present the exact returned action options to the user. Another remediation pass requires increasing maxRounds first
+19. workflow.agentReview.maxRounds counts automatic finding-remediation passes, not the initial review. After those passes are exhausted, keep the latest changes_requested findings as residual risks and automatically complete that Plan/task/Feature review gate without asking the user for a review-approval token; blocked decisions never auto-complete
 20. For a local workflow, do not report completion directly after implementation approval; follow the exact returned \`local verify\` / \`local merge\` / \`local cleanup\` commands until \`workflow-stage\` proves verification, integration, and cleanup and returns \`done\`; review-fix and \`feature_remediation\` stages explicitly permit scoped fixes
 21. In a \`local-ff\` or \`local-squash\` workflow, keep implementation approval and local merge approval distinct when \`local_merge\` is required: the first accepts the implementation, and the second authorizes the configured integration strategy, post-merge checks, and local cleanup
 
@@ -2131,7 +2131,7 @@ function initCommand(program2) {
     "Review gates: comma-separated plan,task,feature | none"
   ).option(
     "--max-review-rounds <count>",
-    "Automatic review finding remediation rounds before user escalation (default: 1)"
+    "Automatic review finding remediation rounds before continuing with residual risks (default: 1)"
   ).option(
     "--completion-strategy <strategy>",
     "Local completion: local-ff | local-squash | none"
@@ -8518,6 +8518,9 @@ function resolveMaxReviewRounds(config) {
   const configured = config.workflow?.agentReview?.maxRounds;
   return typeof configured === "number" && Number.isInteger(configured) && configured > 0 ? configured : 1;
 }
+function reviewRemediationLimitReached(config, reviewRound, decisionOutcome) {
+  return decisionOutcome === "changes_requested" && (reviewRound || 1) > resolveMaxReviewRounds(config);
+}
 function parseWorkflowTaskLine(line, index = -1) {
   const canonical = parseTaskLine(line, index);
   if (canonical) {
@@ -9241,16 +9244,32 @@ function reviewEvidenceSatisfied(config, feature, scope, evidence) {
   });
 }
 function planReviewSatisfied(config, feature, review, target) {
-  return review.status === "done" && reviewEvidenceSatisfied(config, feature, "plan", review.evidence) && review.decisionOutcome === "approve" && review.reviewedSpecHash === target.specHash && review.reviewedPlanHash === target.planHash;
+  return review.status === "done" && reviewEvidenceSatisfied(config, feature, "plan", review.evidence) && (review.decisionOutcome === "approve" || reviewRemediationLimitReached(
+    config,
+    review.reviewRound,
+    review.decisionOutcome
+  )) && review.reviewedSpecHash === target.specHash && review.reviewedPlanHash === target.planHash;
 }
 function featureReviewSatisfied(config, feature, tasks, target) {
-  return !!target && tasks.prePrReviewStatus === "done" && reviewEvidenceSatisfied(config, feature, "feature", tasks.prePrEvidence) && !!tasks.prePrDecision && tasks.prePrDecisionOutcome === "approve" && tasks.prePrReviewedHead === target.targetSha && tasks.prePrReviewedTree === target.targetTree;
+  return !!target && tasks.prePrReviewStatus === "done" && reviewEvidenceSatisfied(config, feature, "feature", tasks.prePrEvidence) && !!tasks.prePrDecision && (tasks.prePrDecisionOutcome === "approve" || reviewRemediationLimitReached(
+    config,
+    tasks.prePrReviewRound,
+    tasks.prePrDecisionOutcome
+  )) && tasks.prePrReviewedHead === target.targetSha && tasks.prePrReviewedTree === target.targetTree;
 }
 function taskReviewEvidenceSatisfied(config, feature, task, target) {
-  return !!target && reviewEvidenceSatisfied(config, feature, "task", task.reviewEvidence) && task.reviewDecisionOutcome === "approve" && task.reviewedHead === target.targetSha && task.reviewedTree === target.targetTree;
+  return !!target && reviewEvidenceSatisfied(config, feature, "task", task.reviewEvidence) && (task.reviewDecisionOutcome === "approve" || reviewRemediationLimitReached(
+    config,
+    task.reviewRound,
+    task.reviewDecisionOutcome
+  )) && task.reviewedHead === target.targetSha && task.reviewedTree === target.targetTree;
 }
 function recordedTaskReviewSatisfied(config, feature, projectGitCwd, task, currentTargetSha) {
-  if (!currentTargetSha || !task.reviewedHead || !task.reviewedTree || task.reviewDecisionOutcome !== "approve" || !reviewEvidenceSatisfied(config, feature, "task", task.reviewEvidence)) {
+  if (!currentTargetSha || !task.reviewedHead || !task.reviewedTree || task.reviewDecisionOutcome !== "approve" && !reviewRemediationLimitReached(
+    config,
+    task.reviewRound,
+    task.reviewDecisionOutcome
+  ) || !reviewEvidenceSatisfied(config, feature, "task", task.reviewEvidence)) {
     return false;
   }
   const actualTree = runGitCapture(
@@ -9671,36 +9690,6 @@ function resolvePlanReviewPayload(config, feature, review, target) {
     docsDirectory: config.docsDir
   };
   if (review.decisionOutcome === "changes_requested") {
-    if (reviewRound > maxReviewRounds) {
-      return {
-        status: "ok",
-        reasonCode: "WORKFLOW_STAGE_RESOLVED",
-        docsDir: config.docsDir,
-        featureRef: buildFeatureRef(feature),
-        stage: "review_escalation",
-        nextAction: buildAction(
-          "review_escalation",
-          `Plan review requested more changes after ${maxReviewRounds} automatic remediation round(s) were used. Ask the user whether to revise again, request a different reviewer, accept the documented risk, change scope, or hold the Feature.`,
-          true,
-          null,
-          void 0,
-          { ...actionContext, reviewRound }
-        ),
-        approvalRequired: true,
-        implementationAllowed: false,
-        primaryActionLabel: "A",
-        actionOptions: [
-          buildStageOption(
-            "A",
-            "A",
-            "review_retry",
-            "Increase workflow.agentReview.maxRounds, then revise the Plan and run one more fresh review round."
-          ),
-          buildStageOption("B", "B", "hold", "Hold the Feature for user resolution.")
-        ],
-        blockedReasonCode: "PLAN_REVIEW_NOT_APPROVED"
-      };
-    }
     if (targetMatches) {
       return {
         status: "ok",
@@ -9801,6 +9790,11 @@ async function collectWorkflowStage(cwd, selector, component) {
     specContent || "",
     planContent || ""
   );
+  const planReviewAutoCompleted = planReview.status === "done" && reviewEvidenceSatisfied(config, feature, "plan", planReview.evidence) && reviewRemediationLimitReached(
+    config,
+    planReview.reviewRound,
+    planReview.decisionOutcome
+  ) && planReview.reviewedSpecHash === planReviewTarget.specHash && planReview.reviewedPlanHash === planReviewTarget.planHash;
   const enforcePlanReview = requirements.planReviewEnabled && (tasks.docStatus !== "approved" || planReview.hasMetadata);
   const issueDraft = parseWorkflowDraftMetadataExtended(issueContent || "");
   const prDraft = parseWorkflowDraftMetadataExtended(prContent || "");
@@ -9845,7 +9839,7 @@ async function collectWorkflowStage(cwd, selector, component) {
         planReviewTarget
       );
     }
-    const approvalRequired = isReviewStage ? resolveActionApprovalRequired(config, "plan_approve", true) : false;
+    const approvalRequired = isReviewStage && !planReviewAutoCompleted ? resolveActionApprovalRequired(config, "plan_approve", true) : false;
     const actionOptions = approvalRequired ? buildApprovalActionOptions({
       approveSummary: "Approve plan.md and continue to the tasks stage.",
       holdSummary: "Request plan changes before continuing."
@@ -9858,7 +9852,7 @@ async function collectWorkflowStage(cwd, selector, component) {
       stage: "plan",
       nextAction: buildAction(
         isReviewStage ? "plan_approve" : "plan_write",
-        isReviewStage ? approvalRequired ? "Get user approval and update plan.md status to Approved." : "Promote plan.md from Review to Approved and continue automatically." : "Write or refine plan.md until it is ready for approval.",
+        isReviewStage ? planReviewAutoCompleted ? "The Plan review remediation limit was reached. Preserve the remaining findings as residual risks, promote plan.md from Review to Approved, and continue automatically without asking the user for review approval." : approvalRequired ? "Get user approval and update plan.md status to Approved." : "Promote plan.md from Review to Approved and continue automatically." : "Write or refine plan.md until it is ready for approval.",
         approvalRequired
       ),
       approvalRequired,
@@ -10045,32 +10039,7 @@ async function collectWorkflowStage(cwd, selector, component) {
     };
     const evidenceMatchesTarget = reviewTask.reviewedHead === reviewTarget.targetSha && reviewTask.reviewedTree === reviewTarget.targetTree;
     if (reviewTask.reviewDecisionOutcome === "changes_requested") {
-      if (reviewContext.reviewRound > reviewContext.maxReviewRounds) {
-        return {
-          status: "ok",
-          reasonCode: "WORKFLOW_STAGE_RESOLVED",
-          docsDir: config.docsDir,
-          featureRef: buildFeatureRef(feature),
-          stage: "review_escalation",
-          nextAction: buildAction(
-            "review_escalation",
-            `Task review for ${reviewTask.taskId || reviewTask.title} requested more changes after ${reviewContext.maxReviewRounds} automatic remediation round(s) were used. Ask the user whether to authorize another remediation round or hold the Feature.`,
-            true,
-            null,
-            void 0,
-            reviewContext
-          ),
-          approvalRequired: true,
-          implementationAllowed: false,
-          primaryActionLabel: "A",
-          actionOptions: [
-            buildStageOption("A", "A", "review_retry", "Increase workflow.agentReview.maxRounds, then run one more task remediation and fresh review round."),
-            buildStageOption("B", "B", "hold", "Hold the Feature for user resolution.")
-          ],
-          blockedReasonCode: "TASK_REVIEW_NOT_APPROVED"
-        };
-      }
-      if (evidenceMatchesTarget) {
+      if (evidenceMatchesTarget && reviewContext.reviewRound <= reviewContext.maxReviewRounds) {
         return {
           status: "ok",
           reasonCode: "WORKFLOW_STAGE_RESOLVED",
@@ -10112,7 +10081,7 @@ async function collectWorkflowStage(cwd, selector, component) {
       };
     }
     if (taskReviewEvidenceSatisfied(config, feature, reviewTask, reviewTarget)) {
-      const completionSummary = reviewTask.status === "DONE" ? `The independent review approved ${reviewTask.taskId || reviewTask.title} at the current code tree. Commit the review evidence before continuing.` : `The independent review approved ${reviewTask.taskId || reviewTask.title} at the current code tree. Mark the task DONE and commit the review evidence before starting another task.`;
+      const completionSummary = reviewTask.reviewDecisionOutcome === "approve" ? reviewTask.status === "DONE" ? `The independent review approved ${reviewTask.taskId || reviewTask.title} at the current code tree. Commit the review evidence before continuing.` : `The independent review approved ${reviewTask.taskId || reviewTask.title} at the current code tree. Mark the task DONE and commit the review evidence before starting another task.` : reviewTask.status === "DONE" ? `The review remediation limit was reached for ${reviewTask.taskId || reviewTask.title}. Keep the remaining findings as residual risks and commit the review evidence before continuing automatically.` : `The review remediation limit was reached for ${reviewTask.taskId || reviewTask.title}. Keep the remaining findings as residual risks, mark the task DONE, and commit the review evidence before continuing automatically.`;
       return {
         status: "ok",
         reasonCode: "WORKFLOW_STAGE_RESOLVED",
@@ -10255,32 +10224,7 @@ async function collectWorkflowStage(cwd, selector, component) {
     } : null;
     const evidenceMatchesTarget = !!reviewTarget && tasks.prePrReviewedHead === reviewTarget.targetSha && tasks.prePrReviewedTree === reviewTarget.targetTree;
     if (reviewContext && tasks.prePrDecisionOutcome === "changes_requested") {
-      if (reviewContext.reviewRound > reviewContext.maxReviewRounds) {
-        return {
-          status: "ok",
-          reasonCode: "WORKFLOW_STAGE_RESOLVED",
-          docsDir: config.docsDir,
-          featureRef: buildFeatureRef(feature),
-          stage: "review_escalation",
-          nextAction: buildAction(
-            "review_escalation",
-            `Feature review requested more changes after ${reviewContext.maxReviewRounds} automatic remediation round(s) were used. Ask the user whether to authorize another remediation round, accept the documented risk, change scope, or hold the Feature.`,
-            true,
-            null,
-            void 0,
-            reviewContext
-          ),
-          approvalRequired: true,
-          implementationAllowed: false,
-          primaryActionLabel: "A",
-          actionOptions: [
-            buildStageOption("A", "A", "review_retry", "Increase workflow.agentReview.maxRounds, then run one more Feature remediation and fresh review round."),
-            buildStageOption("B", "B", "hold", "Hold the Feature for user resolution.")
-          ],
-          blockedReasonCode: "PRE_PR_REVIEW_NOT_APPROVED"
-        };
-      }
-      if (evidenceMatchesTarget) {
+      if (evidenceMatchesTarget && reviewContext.reviewRound <= reviewContext.maxReviewRounds) {
         return {
           status: "ok",
           reasonCode: "WORKFLOW_STAGE_RESOLVED",