lee-spec-kit 0.6.40 → 0.6.41

package/dist/index.js

@@ -5687,13 +5687,21 @@ function hasStructuredReviewSummary(value) {
   if (!value) return false;
   const trimmed = value.trim();
   if (!trimmed) return false;
-  return /^(?:summary|요약)\s*[:：]\s*\S.+$/i.test(trimmed);
+  const match = trimmed.match(/^(?:summary|요약)\s*[:：]\s*(.+)$/i);
+  if (!match) return false;
+  const payload = (match[1] || "").trim();
+  if (!payload) return false;
+  return !isReviewDraftPlaceholder(payload) && !isPlaceholderReviewEvidence(payload);
 }
 function hasStructuredReviewDecision(value) {
   if (!value) return false;
   const trimmed = value.trim();
   if (!trimmed) return false;
-  return /^(?:decision|결정)\s*[:：]\s*\S.+$/i.test(trimmed);
+  const match = trimmed.match(/^(?:decision|결정)\s*[:：]\s*(.+)$/i);
+  if (!match) return false;
+  const payload = (match[1] || "").trim();
+  if (!payload) return false;
+  return !isReviewDraftPlaceholder(payload) && !isPlaceholderReviewEvidence(payload);
 }
 function parsePrePrDecisionOutcome(value) {
   if (!value) return void 0;
@@ -13436,7 +13444,9 @@ function insertFieldInGithubIssueSection(content, key, value) {
 }
 function insertFieldInMetadataSection(content, key, value) {
   const lines = content.split("\n");
-  const headingIndex = lines.findIndex((line) => /^\s*##\s+Metadata\s*$/.test(line));
+  const headingIndex = lines.findIndex(
+    (line) => /^\s*##\s+(?:Metadata|메타데이터)\s*$/.test(line)
+  );
   if (headingIndex < 0) return { content, changed: false };
   let end = lines.length;
   for (let i = headingIndex + 1; i < lines.length; i++) {
@@ -15199,14 +15209,6 @@ function asNonEmptyString(value, fallback) {
   const trimmed = value.trim();
   return trimmed || fallback;
 }
-function asRequiredNonEmptyString(value, field) {
-  const normalized = asNonEmptyString(value, "");
-  if (normalized) return normalized;
-  throw createCliError(
-    "VALIDATION_FAILED",
-    `Evidence JSON ${field} is required.`
-  );
-}
 function asRequiredBoolean(value, field) {
   if (typeof value === "boolean") return value;
   throw createCliError(
@@ -15223,9 +15225,67 @@ function asRequiredNonNegativeInteger(value, field) {
     `Evidence JSON ${field} must be a non-negative integer.`
   );
 }
+function asRequiredTextLike(value, field) {
+  if (typeof value === "string") {
+    const trimmed = value.trim();
+    if (trimmed) return trimmed;
+  }
+  if (typeof value === "number" && Number.isFinite(value) && !Number.isNaN(value)) {
+    return String(value);
+  }
+  throw createCliError(
+    "VALIDATION_FAILED",
+    `Evidence JSON ${field} is required.`
+  );
+}
+function isPlaceholderReviewEvidence2(value) {
+  return /^(?:-|#)?\s*(?:tbd|todo|n\/a|na|none|pending|미정|없음|-)\s*$/i.test(
+    value.trim()
+  );
+}
+function isReviewDraftPlaceholder2(value) {
+  return /^(?:-|#)?\s*(?:tbd|todo|pending|fill(?:\s+in)?|template|example|미정|작성|기입|n\/a|na)\b/i.test(
+    value.trim()
+  );
+}
+function isExplicitNoResidualRiskEntry2(value) {
+  const trimmed = value.trim().toLowerCase();
+  return trimmed === "none" || trimmed === "no residual risk" || trimmed === "no residual risks" || trimmed === "no residual risks found" || trimmed === "no residual risks found in reviewed scope" || trimmed === "\uC794\uC5EC \uB9AC\uC2A4\uD06C \uC5C6\uC74C" || trimmed === "\uC794\uC5EC \uC704\uD5D8 \uC5C6\uC74C";
+}
+function asRequiredReviewField(value, field, options) {
+  const normalized = asRequiredTextLike(value, field);
+  const allowExplicitNone = !!options?.allowExplicitNone;
+  if (isReviewDraftPlaceholder2(normalized)) {
+    throw createCliError(
+      "VALIDATION_FAILED",
+      `Evidence JSON ${field} contains draft placeholder text.`
+    );
+  }
+  if (isPlaceholderReviewEvidence2(normalized) && !(allowExplicitNone && normalized.trim().toLowerCase() === "none")) {
+    throw createCliError(
+      "VALIDATION_FAILED",
+      `Evidence JSON ${field} contains placeholder evidence text.`
+    );
+  }
+  return normalized;
+}
 function normalizeCommandsExecuted(value) {
-  if (!Array.isArray(value)) return [];
-  return value.map((entry) => typeof entry === "string" ? entry.trim() : "").filter(Boolean);
+  if (value == null) return [];
+  if (!Array.isArray(value)) {
+    throw createCliError(
+      "VALIDATION_FAILED",
+      'Evidence JSON "commandsExecuted" must be an array when provided.'
+    );
+  }
+  return value.map((entry, index) => {
+    if (typeof entry !== "string" || !entry.trim()) {
+      throw createCliError(
+        "VALIDATION_FAILED",
+        `Evidence JSON commandsExecuted[${index}] must be a non-empty string.`
+      );
+    }
+    return entry.trim();
+  });
 }
 function normalizeGitPath3(value) {
   return value.trim().replace(/\\/g, "/").replace(/^\.\/+/, "").replace(/\/+$/, "");
@@ -15243,6 +15303,16 @@ function uniquePaths(values) {
   }
   return out;
 }
+function normalizeFileLine(value, field) {
+  const normalized = asRequiredTextLike(value, field);
+  if (!/^\d+(?:[-:]\d+)?$/.test(normalized)) {
+    throw createCliError(
+      "VALIDATION_FAILED",
+      `Evidence JSON ${field} must start with a numeric line reference (for example "88" or "88-96").`
+    );
+  }
+  return normalized;
+}
 function normalizeEvidenceFiles(value) {
   if (!Array.isArray(value)) {
     throw createCliError(
@@ -15265,22 +15335,61 @@ function normalizeEvidenceFiles(value) {
         `Evidence JSON files[${index}].path is required.`
       );
     }
-    const review = file.review || {};
+    const review = file.review && typeof file.review === "object" ? file.review : file;
     return {
       path: filePath,
       review: {
-        risk: asNonEmptyString(review.risk, "not specified"),
-        security: asNonEmptyString(review.security, "not specified"),
-        perf: asNonEmptyString(review.perf, "not specified"),
-        maintainability: asNonEmptyString(
+        risk: asRequiredTextLike(review.risk, `"files[${index}].risk"`),
+        security: asRequiredTextLike(
+          review.security,
+          `"files[${index}].security"`
+        ),
+        perf: asRequiredTextLike(
+          review.perf ?? review.performance,
+          `"files[${index}].perf"`
+        ),
+        maintainability: asRequiredTextLike(
           review.maintainability,
-          "not specified"
+          `"files[${index}].maintainability"`
         ),
-        fileLine: asNonEmptyString(review.fileLine, "-")
+        fileLine: normalizeFileLine(
+          review.fileLine,
+          `"files[${index}].fileLine"`
+        )
       }
     };
   });
 }
+function normalizeResidualRisks(value) {
+  if (typeof value === "string" && value.trim()) {
+    const normalized = asRequiredReviewField(
+      value,
+      '"residualRisks"',
+      { allowExplicitNone: true }
+    );
+    if (!isExplicitNoResidualRiskEntry2(normalized) && isPlaceholderReviewEvidence2(normalized)) {
+      throw createCliError(
+        "VALIDATION_FAILED",
+        'Evidence JSON "residualRisks" contains placeholder evidence text.'
+      );
+    }
+    return [normalized];
+  }
+  if (Array.isArray(value)) {
+    const entries = value.map(
+      (entry, index) => asRequiredReviewField(entry, `"residualRisks[${index}]"`, {
+        allowExplicitNone: true
+      })
+    ).filter(
+      (entry) => isExplicitNoResidualRiskEntry2(entry) || !isReviewDraftPlaceholder2(entry) && !isPlaceholderReviewEvidence2(entry)
+    );
+    if (entries.length > 0) return entries;
+  }
+  throw createCliError(
+    "VALIDATION_FAILED",
+    'Evidence JSON "residualRisks" must be a non-empty string or string array.'
+  );
+}
 var PrePrReviewValidator = class {
   constructor(ctx) {
     this.ctx = ctx;
@@ -15307,18 +15416,19 @@ var PrePrReviewValidator = class {
       );
     }
     const normalizedEvidence = {
-      summary: asRequiredNonEmptyString(evidence.summary, '"summary"'),
-      featureIntentSummary: asRequiredNonEmptyString(
+      summary: asRequiredReviewField(evidence.summary, '"summary"'),
+      featureIntentSummary: asRequiredReviewField(
         evidence.featureIntentSummary,
         '"featureIntentSummary"'
       ),
-      implementationFit: asRequiredNonEmptyString(
+      implementationFit: asRequiredReviewField(
         evidence.implementationFit,
         '"implementationFit"'
       ),
-      missingCases: asRequiredNonEmptyString(
+      missingCases: asRequiredReviewField(
         evidence.missingCases,
-        '"missingCases"'
+        '"missingCases"',
+        { allowExplicitNone: true }
       ),
       specAlignmentChecked: asRequiredBoolean(
         evidence.specAlignmentChecked,
@@ -15333,7 +15443,7 @@ var PrePrReviewValidator = class {
         '"blockingFindings"'
       ),
       files: normalizeEvidenceFiles(evidence.files),
-      residualRisks: asNonEmptyString(evidence.residualRisks, "Not specified"),
+      residualRisks: normalizeResidualRisks(evidence.residualRisks),
       commandsExecuted: normalizeCommandsExecuted(evidence.commandsExecuted)
     };
     if (normalizedEvidence.blockingFindings > normalizedEvidence.findingCount) {
@@ -15515,7 +15625,7 @@ var DEFAULT_EVIDENCE_FOR_ANY_MODE = {
   findingCount: 0,
   blockingFindings: 0,
   files: [],
-  residualRisks: "Not specified",
+  residualRisks: ["none"],
   commandsExecuted: []
 };
 function escapeRegExp4(value) {
@@ -15602,7 +15712,7 @@ ${normalizedCommands.map((c) => `  - \`${c}\``).join("\n")}
 
 ` : "";
   let filesSection = "";
-  if (input.evidence.files.length === 0) {
+  if (input.evidence.findingCount === 0 || input.evidence.files.length === 0) {
     filesSection = "  - 0 findings";
   } else {
     filesSection = input.evidence.files.map((f) => {
@@ -15613,6 +15723,7 @@ ${normalizedCommands.map((c) => `  - \`${c}\``).join("\n")}
     - Maintainability: ${f.review.maintainability}`;
     }).join("\n");
   }
+  const residualRisksSection = input.evidence.residualRisks.length > 0 ? input.evidence.residualRisks.map((entry) => `  - ${entry}`).join("\n") : "  - none";
   const mainScopeFiles = input.scope.mainChangedFiles.length > 0 ? input.scope.mainChangedFiles.map((entry) => `    - ${entry}`).join("\n") : "    - (none)";
   const worktreeScopeFiles = input.scope.worktreeChangedFiles.length > 0 ? input.scope.worktreeChangedFiles.map((entry) => `    - ${entry}`).join("\n") : "    - (none)";
   return `## Pre-PR Review Log (${input.date})
@@ -15631,7 +15742,7 @@ ${normalizedCommands.map((c) => `  - \`${c}\``).join("\n")}
 ${commandsRun}
 
 - **Residual Risks**:
-  - ${input.evidence.residualRisks}
+${residualRisksSection}
 
 - **Review Scope**:
   - **Main Base Ref**: ${input.scope.baseRef}