leaflet-rotate 0.4.0 → 0.5.1

package/src/map/handler/TouchRotate.js

@@ -1,7 +1,10 @@
 /**
- * Rotates the map on two-finger (touch devices).
+ * Enables two-finger rotation through the shared touch-gesture handler.
  * 
  * @typedef L.Map.TouchRotate
+ * @property {boolean} [touchRotate=false] Enable two-finger map rotation.
+ * 
+ * @since leaflet-rotate (v0.1.0)
  */
 
 L.Map.mergeOptions({
@@ -10,6 +13,8 @@ L.Map.mergeOptions({
      * Whether the map can be rotated with a two-finger rotation gesture
      * 
      * @type {Boolean}
+     * 
+     * @since leaflet-rotate (v0.1.0)
      */
     touchRotate: false,
 
@@ -17,11 +22,21 @@ L.Map.mergeOptions({
 
 L.Map.TouchRotate = L.Handler.extend({
 
+    /**
+     * Enable rotation handling in the map's shared touch gesture handler.
+     * 
+     * @since leaflet-rotate (v0.1.0)
+     */
     addHooks() {
         this._map.touchGestures.enable();
         this._map.touchGestures.rotate = true;
     },
 
+    /**
+     * Disable rotation handling without affecting pinch zoom.
+     * 
+     * @since leaflet-rotate (v0.1.0)
+     */
     removeHooks() {
         this._map.touchGestures.rotate = false;
     },
@@ -32,5 +47,7 @@ L.Map.TouchRotate = L.Handler.extend({
  * Add Touch Rotate handler (disabled unless `touchGestures` is set).
  * 
  * @property {L.Map.TouchGestures} touchGestures
+ * 
+ * @since leaflet-rotate (v0.1.0)
  */
 L.Map.addInitHook('addHandler', 'touchRotate', L.Map.TouchRotate);

package/src/map/handler/TouchZoom.js

@@ -1,9 +1,13 @@
 /**
- * Adds pinch zoom rotation on mobile browsers
+ * Adds pinch zoom support through the shared touch-gesture handler.
  * 
  * @see https://github.com/Leaflet/Leaflet/blob/v1.9.3/src/map/handler/Map.TouchZoom.js
  * 
  * @external L.Map.TouchZoom
+ * @property {boolean|string} [touchZoom=L.Browser.touch] Enable pinch zoom; `'center'` zooms around the view center.
+ * @property {boolean} [bounceAtZoomLimits=false] Allow pinch zoom to exceed zoom limits before settling.
+ * 
+ * @since leaflet-rotate (v0.1.0)
  */
 
 L.Map.mergeOptions({
@@ -16,6 +20,8 @@ L.Map.mergeOptions({
      * for touch-capable web browsers.
      * 
      * @type {(Boolean|String)}
+     * 
+     * @since leaflet-rotate (v0.1.0)
      */
     touchZoom: L.Browser.touch,
 
@@ -27,6 +33,8 @@ L.Map.mergeOptions({
      * when pinch-zooming.
      * 
      * @type {Boolean}
+     * 
+     * @since leaflet-rotate (v0.1.0)
      */
     bounceAtZoomLimits: false,
 
@@ -34,12 +42,22 @@ L.Map.mergeOptions({
 
 L.Map.TouchZoom = L.Handler.extend({
 
+    /**
+     * Enable pinch zoom handling and mark the shared touch handler as active.
+     * 
+     * @since leaflet-rotate (v0.1.0)
+     */
     addHooks() {
         this._map._container.classList.add('leaflet-touch-zoom');
         this._map.touchGestures.enable();
         this._map.touchGestures.zoom = true;
     },
 
+    /**
+     * Disable pinch zoom handling while preserving touch rotation state.
+     * 
+     * @since leaflet-rotate (v0.1.0)
+     */
     removeHooks() {
         this._map._container.classList.remove('leaflet-touch-zoom');
         this._map.touchGestures.zoom = false;
@@ -51,5 +69,7 @@ L.Map.TouchZoom = L.Handler.extend({
  * Add Touch Zoom handler (disabled unless `L.Browser.touch` is set).
  * 
  * @property {L.Map.TouchGestures} touchGestures
+ * 
+ * @since leaflet-rotate (v0.1.0)
  */
 L.Map.addInitHook('addHandler', 'touchZoom', L.Map.TouchZoom);

package/test/features/example.feature

@@ -13,13 +13,17 @@ Feature: Rotating a Leaflet map
     Then the default rotate control visibility follows the bearing
 
   @issue-13
-  Scenario: Dragging the rotate control changes the map bearing
+  Scenario: Dragging the rotate control changes the map bearing and pitch
     When I drag the rotate control
-    Then the map bearing follows the control drag
+    Then the map bearing and pitch follow the control drag
+
+  Scenario: Clicking the rotate control resets bearing and pitch
+    When I click the rotate control on a rotated and pitched map
+    Then the map animates back to north and zero pitch
 
   @issue-44
-  Scenario: The compass control requests device-orientation permission
-    When I activate compass mode on a permission-based device
+  Scenario: Enabling compass bearing requests device-orientation permission
+    When I enable compass bearing on a permission-based device
     Then device-orientation permission is requested
 
   @issue-7

package/test/features/gestures.feature

@@ -7,6 +7,10 @@ Feature: Rotating a Leaflet map
     When I move a two-finger pinch gesture
     Then the zoom transition ends before the gesture ends
 
+  Scenario: Two fingers dragged vertically change the pitch, pinching does not
+    When I drag two fingers vertically and then pinch with touch pitch enabled
+    Then only the vertical two-finger drag changes the pitch
+
   @issue-43
   Scenario: Vector paths follow a rotated two-finger gesture
     When I rotate and zoom two fingers over a vector path

package/test/features/rotation.feature

@@ -21,6 +21,36 @@ Feature: Rotating a Leaflet map
     When I animate the bearing to 90 degrees
     Then the bearing reaches 90 degrees gradually
 
+  @issue-72
+  Scenario: Pitch projects and reverses map coordinates
+    When I set the map pitch to 45 degrees
+    Then map coordinates stay consistent with the pitched view
+
+  @issue-72
+  Scenario: Ctrl-drag changes pitch and bearing without panning
+    When I change pitch and bearing with Ctrl-drag
+    Then pitch and bearing change without moving the map pane
+
+  @issue-72
+  Scenario: Pitched vector layers stay aligned while panning
+    When I drag the pitched map
+    Then vector layers stay aligned with their map coordinates
+
+  @issue-72
+  Scenario: Vector layers stay aligned after off-center zoom and rotation
+    When I zoom off-center then rotate the map
+    Then vector layers stay aligned with their map coordinates
+
+  @issue-72
+  Scenario: Ctrl-drag after panning keeps the map center stable
+    When I pan the map then Ctrl-drag
+    Then the map center stays stable during Ctrl-drag
+
+  @issue-72
+  Scenario: Ctrl-drag cancels a pending wheel zoom
+    When I Ctrl-drag while a wheel zoom is pending
+    Then the pending wheel zoom does not move the map
+
   @issue-25
   Scenario: Fit bounds zoom is stable
     When I fit the same bounds twice
@@ -34,3 +64,33 @@ Feature: Rotating a Leaflet map
   @issue-34
   Scenario: Draggable marker listeners are not duplicated
     Then the draggable marker has one drag listener and one drag-end listener
+
+  @issue-73
+  Scenario: Vector layers do not jump when zooming from a low level
+    When I animate a zoom from a low level on a rotated map
+    Then vector layers do not jump at the end of the zoom animation
+
+  @issue-73
+  Scenario: Wheel zoom keeps the cursor point on a pitched map
+    When I zoom around an off-center point on a pitched map
+    Then the point under the cursor stays in place
+
+  @issue-73
+  Scenario: Right-drag rotates around the map center
+    When I right-drag horizontally below the map center
+    Then the map rotates counterclockwise without opening the context menu
+
+  @issue-73
+  Scenario: Right-button press suppresses the context menu before movement
+    When a context menu event fires immediately on right-button press
+    Then the early context menu is suppressed
+
+  @issue-73
+  Scenario: High pitch keeps tile loading bounded
+    When I look at a high zoom map with a high pitch
+    Then tile loading stays bounded and covers the visible map
+
+  @issue-73
+  Scenario: Tiles stay aligned after panning and changing pitch
+    When I pan, zoom and change the pitch of a rotated map
+    Then the map is centered and the tiles stay aligned with the map coordinates