ldap-authentication 4.2.1 → 4.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ldap-authentication",
-  "version": "4.2.1",
+  "version": "4.4.0",
   "description": "A simple async nodejs library for LDAP user authentication",
   "main": "index.js",
   "types": "./index.d.ts",
@@ -17,7 +17,8 @@
     "node": ">=22.0.0"
   },
   "scripts": {
-    "test": "node test/jasmine.js"
+    "test": "node test/jasmine.js",
+    "test:local": "bash scripts/test-local.sh"
   },
   "repository": {
     "type": "git",

package/scripts/test-local.sh

@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+# One-shot local integration test: start the seeded LDAP test container
+# (docker-compose.yml), wait until it accepts an admin bind, run `npm test`,
+# then stop the container again.
+set -uo pipefail
+cd "$(dirname "$0")/.."
+
+cleanup() {
+  docker compose -f docker-compose.yml down
+}
+trap cleanup EXIT
+
+docker compose -f docker-compose.yml up -d
+
+for i in $(seq 1 30); do
+  if node -e "
+const ldapts = require('ldapts')
+const c = new ldapts.Client({ url: 'ldap://localhost:1389', connectTimeout: 2000 })
+c.bind('cn=read-only-admin,dc=example,dc=com', 'password')
+  .then(() => { c.unbind(); process.exit(0) })
+  .catch(() => process.exit(1))
+"
+  then
+    break
+  fi
+  if [ "$i" -eq 30 ]; then
+    echo 'LDAP server did not become ready in time' >&2
+    exit 1
+  fi
+  sleep 2
+done
+
+INGITHUB=true npm test

package/test/authentication-result.spec.js

@@ -1,15 +1,15 @@
 const {
   authenticateResult,
+  LdapAuthenticationError,
   AuthenticationResult,
   AUTH_RESULT_SUCCESS,
   AUTH_RESULT_FAILURE,
   AUTH_RESULT_FAILURE_IDENTITY_NOT_FOUND,
   AUTH_RESULT_FAILURE_IDENTITY_AMBIGUOUS,
   AUTH_RESULT_FAILURE_CREDENTIAL_INVALID,
-  AUTH_RESULT_FAILURE_UNCATEGORIZED
+  AUTH_RESULT_FAILURE_UNCATEGORIZED,
 } = require('../index.js')
-
-const url = process.env.INGITHUB ? 'ldap://localhost:1389' : 'ldap://ldap:1389'
+const { url, adminDn, adminPassword, userSearchBase } = require('./config')
 
 describe('ldap-authentication test return AuthenticationResult', () => {
   it('Use an admin user to check if user exists', async () => {
@@ -17,10 +17,10 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       verifyUserExists: true,
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -36,10 +36,10 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       verifyUserExists: true,
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
       attributes: ['uid', 'sn'],
@@ -58,10 +58,10 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -77,10 +77,10 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
       attributes: ['uid', 'sn'],
@@ -101,7 +101,7 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       },
       userDn: 'cn=einstein,ou=users,dc=example,dc=com',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'einstein',
     }
@@ -119,7 +119,7 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       },
       userDn: 'cn=einstein,ou=users,dc=example,dc=com',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'einstein',
       attributes: ['uid', 'sn'],
@@ -151,13 +151,13 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
-      groupsSearchBase: 'dc=example,dc=com',
+      groupsSearchBase: userSearchBase,
       groupClass: 'groupOfNames',
       groupMemberAttribute: 'member',
       groupMemberUserAttribute: 'dn',
@@ -177,10 +177,10 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       },
       userDn: 'cn=gauss,ou=users,dc=example,dc=com',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
-      groupsSearchBase: 'dc=example,dc=com',
+      groupsSearchBase: userSearchBase,
       groupClass: 'groupOfNames',
       groupMemberAttribute: 'member',
       groupMemberUserAttribute: 'dn',
@@ -204,10 +204,10 @@ describe('ldap-authentication test return AuthenticationResult', () => {
       },
       userDn: 'cn=gauss,ou=users,dc=example,dc=com',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
-      groupsSearchBase: 'dc=example,dc=com',
+      groupsSearchBase: userSearchBase,
       groupClass: 'groupOfUniqueNames',
     }
 
@@ -228,7 +228,7 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       adminDn: 'cn=not-exist,dc=example,dc=com',
       adminPassword: 'password',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -242,10 +242,10 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
+      adminDn: adminDn,
       adminPassword: 'wrongpassword',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -259,10 +259,10 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'wrong',
     }
@@ -276,10 +276,10 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       ldapOpts: {
         url: url,
       },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       userPassword: 'wrongpassword',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -295,7 +295,7 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       },
       userDn: 'cn=not-exist,dc=example,dc=com',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -311,7 +311,7 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       },
       userDn: 'cn=gauss,dc=example,dc=com',
       userPassword: 'wrongpassword',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -341,7 +341,7 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       userDn: 'cn=einstein,ou=users,dc=example,dc=com',
       userPassword: 'password',
       usernameAttribute: 'wrongattribute',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       username: 'einstein',
     }
 
@@ -358,7 +358,7 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       userDn: 'uid=einstein,dc=example,dc=com',
       userPassword: 'password',
       usernameAttribute: 'cn',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       username: 'einstein',
     }
 
@@ -375,7 +375,7 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       userDn: 'uid=einstein,dc=example,dc=com',
       userPassword: 'password',
       usernameAttribute: 'cn',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       username: 'einstein',
       starttls: true,
     }
@@ -391,10 +391,10 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
       },
       userDn: 'cn=gauss,ou=users,dc=example,dc=com',
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
-      groupsSearchBase: 'dc=example,dc=com',
+      groupsSearchBase: userSearchBase,
       groupClass: 'groupOfNames',
       groupMemberAttribute: 'member',
       groupMemberUserAttribute: 'dnWRONG',
@@ -405,6 +405,47 @@ describe('ldap-authentication negative test returns AuthenticationResult', () =>
     expect(result.user).toBeTruthy()
     expect(result.user.groups.length).toBeLessThan(1)
   })
+  it('A username containing LDAP filter metacharacters must not change the filter', async () => {
+    // The filter below would match every user (`(uid=*)`) if the username
+    // were interpolated without escaping; escaping turns it into a literal
+    // search that matches nobody
+    let options = {
+      ldapOpts: {
+        url: url,
+      },
+      adminDn: adminDn,
+      adminPassword: adminPassword,
+      userPassword: 'password',
+      userSearchBase: userSearchBase,
+      usernameFilter: '(uid={{username}})',
+      username: 'gauss)(uid=*)',
+    }
+
+    let result = await authenticateResult(options)
+    expect(result).toBeInstanceOf(AuthenticationResult)
+    expect(result.code).toEqual(AUTH_RESULT_FAILURE_IDENTITY_NOT_FOUND)
+  })
+  it('Missing required options should throw LdapAuthenticationError', async () => {
+    let e = null
+    try {
+      await authenticateResult({
+        ldapOpts: {
+          url: url,
+        },
+        verifyUserExists: true,
+        adminDn: adminDn,
+        userSearchBase: userSearchBase,
+        usernameAttribute: 'uid',
+        username: 'gauss',
+      })
+    } catch (error) {
+      e = error
+    }
+
+    expect(e).toBeTruthy()
+    expect(e).toBeInstanceOf(LdapAuthenticationError)
+    expect(e.message).toContain('adminPassword')
+  })
 })
 
 describe('AuthenticationResult', () => {

package/test/binary.spec.js

@@ -1,22 +1,23 @@
-const { Change } = require('ldapts')
-const { authenticate, LdapAuthenticationError } = require('../index.js')
+const fs = require('fs')
+const path = require('path')
+const { Change, Attribute } = require('ldapts')
+const { authenticate } = require('../index.js')
 const ldapts = require('ldapts')
-const { Attribute } = require('ldapts')
+const { url, adminDn, adminPassword, userSearchBase } = require('./config')
 
-const url = process.env.INGITHUB ? 'ldap://localhost:1389' : 'ldap://ldap:1389'
+const jpegPhotoBase64 = fs
+  .readFileSync(path.join(__dirname, 'fixtures', 'jpeg-photo.b64'), 'utf8')
+  .trim()
 
 describe('ldap-authentication binary attributes test', () => {
-  const jpegPhotoBase64 =
-    '/9j/4AAQSkZJRgABAQEASABIAAD/2wBDACgcHiMeGSgjISMtKygwPGRBPDc3PHtYXUlkkYCZlo+AjIqgtObDoKrarYqMyP/L2u71////m8H////6/+b9//j/2wBDASstLTw1PHZBQXb4pYyl+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj/wAARCACBAGQDAREAAhEBAxEB/8QAGQAAAwEBAQAAAAAAAAAAAAAAAAECAwQF/8QALRAAAgEDAwMCBQQDAAAAAAAAAAECAxEhBBIxMkFRInEFE2GBsRU0QlJikaH/xAAXAQEBAQEAAAAAAAAAAAAAAAAAAQID/8QAGxEBAQEAAwEBAAAAAAAAAAAAAAERAhIhMUH/2gAMAwEAAhEDEQA/APMIAAKAgChp2AdwAAACBlAQUkmu5RkAAACuAAADsAZQDWQKRA7AL7gAEFCbAQDAYAAXAdwBYAogAAAAgokBgADAEr8Ab09JWqZcdq8yJpjb9Pa5qr/ROy4l6Ga6ZxfvgdoYiemqw6o49yoyAAACCiQKa4AAN9PpnWy3aP5Jbiya9ClRhBJRjby/Ji1qRqRQBMkuwMZSk2trdiys2PPqR2zaNspAAIKE0A+yA201H51TPSuSW4smvTilFJJWSOdbi0RTZQghPgK56nNwzXLXtvx4NxhiUAEABQ0nJpJcgejpkoR2rtyznWo3uRpE5S4i8hfRCrPKm0wLlUUUrgZSruXTD/oROZPISuat1s3GGRQgIKADp0kFNy8pYM2rJrshBQ4M1qNErojTOdFyjZTcfqhKWaqFPObuyAdeKlBfRhcZrT01JzXdWsXWc/U7XF5IVlqWm1waYczKhXKIKEB0aOW2uvDwZvxZ9ejbBlq+CLsZaWrMAckvSgpSW6DQVNKW6ObXRUTVd5BmuKp1M05s2USBmaABpS60Qeg41rqUXeMcszjW61auroliyi7sZaFk1YKirVnSVopyXkqajTNtSv3YouXU/oWM8nHLLZWENFCsBiaAB1aCj86tnpjlko9javBlUVY29SWO4VizNaiVBJcu/m5FJwvyFTGmqct+Como3Juz5EZrnZplLKhWAw5NDZxisW47gen8NpqOncsepmarrIBZwwOWunSf+L4ZmxqVnvI1puoU1nObs347BLS7FZLZ8x27sIwqQcJuMuUaRAGdKN5X8ZKHJu+Qrq02venpbNilnGbDB3UNXHUJ7dqmv4szfA46luVnTbf0ZNFyqUpxcKnpv2kUclWiqT9LvF8O5mtRNnZO+ChSTccAOzsGShVhSlullrhFHPObnNyfLKiAHQW2lKfngqxk3dgSyhwm4TUk3dPDIPV0OrhWltmlGr2fkxYrqrUVVg0+ez8GdHPGhLa0/uaRMFeW1K9wrd6e7vJ2XhFRjKnGqtlNtPyyTB5MrqV28nRFxnf3JgogSqp0FBKzRVZlAEKKyFCbjO6eUQexotaq6UKjtUXf+xz5ccWOmas91u2RKVjHZSlaTe210yoipqHNbY3UfyTVEI7nbyUc+r0vLiuFc1Kjz7WNItSxkmCShAAAgCeXewURbTusNBHs6LWRrpQqO1T8nOzGmtamnG1unK9gM4UknfgqNYxSzZsBuTtiOL2ZKPJ1lFU6zt0yymblRhYonuQD4KEAAOXIUkEa6f8AcQ90Sq92r2+5zioXWvY0jQqJkRXn/EeiHuywcS4NI//Z'
-
   const baseOptions = {
     ldapOpts: {
       url: url,
     },
-    adminDn: 'cn=read-only-admin,dc=example,dc=com',
-    adminPassword: 'password',
+    adminDn: adminDn,
+    adminPassword: adminPassword,
     verifyUserExists: true,
-    userSearchBase: 'dc=example,dc=com',
+    userSearchBase: userSearchBase,
     usernameAttribute: 'uid',
   }
 

package/test/config.js

@@ -0,0 +1,9 @@
+// Shared settings for the integration specs: the LDAP URL (switched to
+// localhost:1389 when INGITHUB is set, i.e. outside the docker network) and
+// the seeded admin account (see docker/ldap/10-ldap-test-data.ldif).
+module.exports = {
+  url: process.env.INGITHUB ? 'ldap://localhost:1389' : 'ldap://ldap:1389',
+  adminDn: 'cn=read-only-admin,dc=example,dc=com',
+  adminPassword: 'password',
+  userSearchBase: 'dc=example,dc=com',
+}

package/test/fetch-users.spec.js

@@ -1,25 +1,25 @@
 const { fetchUsers, LdapAuthenticationError } = require('../index.js')
+const { url, adminDn, adminPassword, userSearchBase } = require('./config')
 
-const url = process.env.INGITHUB ? 'ldap://localhost:1389' : 'ldap://ldap:1389'
+const baseOptions = {
+  ldapOpts: {
+    url: url,
+  },
+  adminDn: adminDn,
+  adminPassword: adminPassword,
+  userSearchBase: userSearchBase,
+}
 
 describe('ldap-authentication fetchUsers test', () => {
-  const baseOptions = {
-    ldapOpts: {
-      url: url,
-    },
-    adminDn: 'cn=read-only-admin,dc=example,dc=com',
-    adminPassword: 'password',
-    userSearchBase: 'dc=example,dc=com',
-  }
-
   it('Should return all users with the default filter', async () => {
     let users = await fetchUsers(baseOptions)
 
     expect(Array.isArray(users)).toBe(true)
-    expect(users.length).toBe(2)
+    expect(users.length).toBe(3)
     let uids = users.map((user) => user.uid)
     expect(uids).toContain('gauss')
     expect(uids).toContain('einstein')
+    expect(uids).toContain('doe')
     for (let user of users) {
       expect(user.dn).toBeTruthy()
     }
@@ -31,7 +31,7 @@ describe('ldap-authentication fetchUsers test', () => {
       attributes: ['uid', 'sn'],
     })
 
-    expect(users.length).toBe(2)
+    expect(users.length).toBe(3)
     let gauss = users.find((user) => user.uid === 'gauss')
     expect(gauss).toBeTruthy()
     expect(gauss.sn).toEqual('Bar1')
@@ -55,7 +55,7 @@ describe('ldap-authentication fetchUsers test', () => {
       userFilter: '(objectClass=*)',
     })
 
-    expect(users.length).toBeGreaterThan(2)
+    expect(users.length).toBeGreaterThan(3)
     let dns = users.map((user) => user.dn)
     expect(dns).toContain('cn=gauss,ou=users,dc=example,dc=com')
     expect(dns).toContain('cn=科学A部,ou=groups,dc=example,dc=com')
@@ -72,15 +72,6 @@ describe('ldap-authentication fetchUsers test', () => {
 })
 
 describe('ldap-authentication fetchUsers negative test', () => {
-  const baseOptions = {
-    ldapOpts: {
-      url: url,
-    },
-    adminDn: 'cn=read-only-admin,dc=example,dc=com',
-    adminPassword: 'password',
-    userSearchBase: 'dc=example,dc=com',
-  }
-
   it('wrong admin password should throw LdapAuthenticationError', async () => {
     let options = {
       ...baseOptions,
@@ -115,22 +106,22 @@ describe('ldap-authentication fetchUsers negative test', () => {
     expect(e).toBeInstanceOf(LdapAuthenticationError)
   })
 
-  it('missing userSearchBase should throw', async () => {
-    let options = {
-      ldapOpts: {
-        url: url,
-      },
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
-    }
-
+  it('missing required options should throw LdapAuthenticationError listing all of them', async () => {
     let e = null
     try {
-      await fetchUsers(options)
+      await fetchUsers({
+        ldapOpts: {
+          url: url,
+        },
+        adminDn: adminDn,
+      })
     } catch (error) {
       e = error
     }
 
     expect(e).toBeTruthy()
+    expect(e).toBeInstanceOf(LdapAuthenticationError)
+    expect(e.message).toContain('adminPassword')
+    expect(e.message).toContain('userSearchBase')
   })
 })

package/test/fixtures/jpeg-photo.b64

@@ -0,0 +1 @@
+/9j/4AAQSkZJRgABAQEASABIAAD/2wBDACgcHiMeGSgjISMtKygwPGRBPDc3PHtYXUlkkYCZlo+AjIqgtObDoKrarYqMyP/L2u71////m8H////6/+b9//j/2wBDASstLTw1PHZBQXb4pYyl+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pj/wAARCACBAGQDAREAAhEBAxEB/8QAGQAAAwEBAQAAAAAAAAAAAAAAAAECAwQF/8QALRAAAgEDAwMCBQQDAAAAAAAAAAECAxEhBBIxMkFRInEFE2GBsRU0QlJikaH/xAAXAQEBAQEAAAAAAAAAAAAAAAAAAQID/8QAGxEBAQEAAwEBAAAAAAAAAAAAAAERAhIhMUH/2gAMAwEAAhEDEQA/APMIAAKAgChp2AdwAAACBlAQUkmu5RkAAACuAAADsAZQDWQKRA7AL7gAEFCbAQDAYAAXAdwBYAogAAAAgokBgADAEr8Ab09JWqZcdq8yJpjb9Pa5qr/ROy4l6Ga6ZxfvgdoYiemqw6o49yoyAAACCiQKa4AAN9PpnWy3aP5Jbiya9ClRhBJRjby/Ji1qRqRQBMkuwMZSk2trdiys2PPqR2zaNspAAIKE0A+yA201H51TPSuSW4smvTilFJJWSOdbi0RTZQghPgK56nNwzXLXtvx4NxhiUAEABQ0nJpJcgejpkoR2rtyznWo3uRpE5S4i8hfRCrPKm0wLlUUUrgZSruXTD/oROZPISuat1s3GGRQgIKADp0kFNy8pYM2rJrshBQ4M1qNErojTOdFyjZTcfqhKWaqFPObuyAdeKlBfRhcZrT01JzXdWsXWc/U7XF5IVlqWm1waYczKhXKIKEB0aOW2uvDwZvxZ9ejbBlq+CLsZaWrMAckvSgpSW6DQVNKW6ObXRUTVd5BmuKp1M05s2USBmaABpS60Qeg41rqUXeMcszjW61auroliyi7sZaFk1YKirVnSVopyXkqajTNtSv3YouXU/oWM8nHLLZWENFCsBiaAB1aCj86tnpjlko9javBlUVY29SWO4VizNaiVBJcu/m5FJwvyFTGmqct+Como3Juz5EZrnZplLKhWAw5NDZxisW47gen8NpqOncsepmarrIBZwwOWunSf+L4ZmxqVnvI1puoU1nObs347BLS7FZLZ8x27sIwqQcJuMuUaRAGdKN5X8ZKHJu+Qrq02venpbNilnGbDB3UNXHUJ7dqmv4szfA46luVnTbf0ZNFyqUpxcKnpv2kUclWiqT9LvF8O5mtRNnZO+ChSTccAOzsGShVhSlullrhFHPObnNyfLKiAHQW2lKfngqxk3dgSyhwm4TUk3dPDIPV0OrhWltmlGr2fkxYrqrUVVg0+ez8GdHPGhLa0/uaRMFeW1K9wrd6e7vJ2XhFRjKnGqtlNtPyyTB5MrqV28nRFxnf3JgogSqp0FBKzRVZlAEKKyFCbjO6eUQexotaq6UKjtUXf+xz5ccWOmas91u2RKVjHZSlaTe210yoipqHNbY3UfyTVEI7nbyUc+r0vLiuFc1Kjz7WNItSxkmCShAAAgCeXewURbTusNBHs6LWRrpQqO1T8nOzGmtamnG1unK9gM4UknfgqNYxSzZsBuTtiOL2ZKPJ1lFU6zt0yymblRhYonuQD4KEAAOXIUkEa6f8AcQ90Sq92r2+5zioXWvY0jQqJkRXn/EeiHuywcS4NI//Z

package/test/starttls.spec.js

@@ -1,6 +1,5 @@
 const { authenticate, LdapAuthenticationError } = require('../index.js')
-
-const url = process.env.INGITHUB ? 'ldap://localhost:1389' : 'ldap://ldap:1389'
+const { url, adminDn, adminPassword, userSearchBase } = require('./config')
 
 describe('ldap-authentication StartTLS and TLS options test', () => {
   it('Plain LDAP with tlsOptions in ldapOpts should work (ldap:// protocol)', async () => {
@@ -38,10 +37,10 @@ describe('ldap-authentication StartTLS and TLS options test', () => {
         },
       },
       starttls: true,
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
       userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }
@@ -73,9 +72,10 @@ describe('ldap-authentication StartTLS and TLS options test', () => {
         },
       },
       starttls: true,
-      userDn: 'cn=einstein,ou=users,dc=example,dc=com',
-      userPassword: 'password',
-      userSearchBase: 'dc=example,dc=com',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
+      verifyUserExists: true,
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'einstein',
     }
@@ -103,10 +103,10 @@ describe('ldap-authentication StartTLS and TLS options test', () => {
         },
       },
       starttls: true,
-      adminDn: 'cn=read-only-admin,dc=example,dc=com',
-      adminPassword: 'password',
-      verifyUserExists: true,
-      userSearchBase: 'dc=example,dc=com',
+      adminDn: adminDn,
+      adminPassword: adminPassword,
+      userPassword: 'password',
+      userSearchBase: userSearchBase,
       usernameAttribute: 'uid',
       username: 'gauss',
     }