lazycodex-ai 5.0.0-beta.9 → 5.0.0

package/packages/omo-codex/plugin/components/ulw-loop/dist/plan-io.js

@@ -1,35 +1,88 @@
-import { createReadStream } from "node:fs";
-import { appendFile, mkdir, readFile, rename, writeFile } from "node:fs/promises";
-import { createInterface } from "node:readline";
+import { AsyncLocalStorage } from "node:async_hooks";
+import { readdirSync } from "node:fs";
 import { aggregateCodexObjectiveForScope } from "./goal-status.js";
-import { repoRelative, ulwLoopDir, ulwLoopGoalsPath, ulwLoopLedgerPath, ulwLoopRelativeDir, } from "./paths.js";
-import { iso, ULW_LOOP_DIR, ULW_LOOP_GOALS, ULW_LOOP_LEDGER, UlwLoopError } from "./types.js";
+import { readLedger as reconcileLedger } from "./ledger.js";
+import { repoRelative, ulwLoopDir, ulwLoopGoalsPath, ulwLoopRelativeDir, ulwLoopStateLockPath, } from "./paths.js";
+import { commit, materialize, materializeSync } from "./plan-commit.js";
+import { readOptional, reconcilePlan } from "./plan-log.js";
+import { planMissingError } from "./plan-missing-recovery.js";
+import { withStateLock } from "./state-lock.js";
+import { iso, ULW_LOOP_DIR, ULW_LOOP_GOALS, ULW_LOOP_LEDGER, UlwLoopError, } from "./types.js";
+export function readLedger(repoRoot, scope) {
+    const lockPath = ulwLoopStateLockPath(repoRoot, scope);
+    if (heldLocks.getStore()?.has(lockPath)) {
+        assertStateLockOwned(lockPath);
+        materializeSync(ulwLoopDir(repoRoot, scope));
+    }
+    return reconcileLedger(repoRoot, scope);
+}
+export { planExists } from "./plan-log.js";
 const LEGACY_OBJECTIVE_PREFIX = `Complete all ulw-loop stories in ${ULW_LOOP_DIR}/${ULW_LOOP_GOALS}: `;
 const LEGACY_OBJECTIVE = `Complete all ulw-loop stories listed in ${ULW_LOOP_DIR}/${ULW_LOOP_GOALS}. Use ${ULW_LOOP_DIR}/${ULW_LOOP_LEDGER} as the durable audit trail.`;
 const locks = new Map();
-function hasCode(error, code) {
-    return error instanceof Error && "code" in error && error.code === code;
+const heldLocks = new AsyncLocalStorage();
+const lockOptions = new AsyncLocalStorage();
+export function withMutationLockOptions(options, fn) {
+    return lockOptions.run(options, fn);
 }
-function isLegacyEnumeratedAggregateObjective(objective) {
-    return objective === LEGACY_OBJECTIVE || Boolean(objective?.startsWith(LEGACY_OBJECTIVE_PREFIX));
+function tokenAt(lockPath) {
+    const raw = readOptional(lockPath);
+    if (raw === undefined)
+        return undefined;
+    try {
+        const record = JSON.parse(raw);
+        return typeof record === "object" && record !== null && "token" in record && typeof record.token === "string"
+            ? record.token
+            : undefined;
+    }
+    catch (error) {
+        if (error instanceof SyntaxError)
+            return undefined;
+        throw error;
+    }
 }
-function isSteeringKind(value) {
-    return (value === "steering_accepted" ||
-        value === "steering_rejected" ||
-        value === "criteria_revised" ||
-        value === "batch_updated");
+export function assertStateLockOwned(lockPath) {
+    const context = heldLocks.getStore()?.get(lockPath);
+    if (context === undefined)
+        return;
+    if (tokenAt(lockPath) !== context.token)
+        throw new UlwLoopError("The ulw-loop mutation lock changed owners.", "ULW_LOOP_LOCK_LOST");
+}
+export function migrationEntries(plan) {
+    for (const context of heldLocks.getStore()?.values() ?? []) {
+        const entries = context.migrations.get(plan.goalsPath);
+        if (entries !== undefined) {
+            context.migrations.delete(plan.goalsPath);
+            return entries;
+        }
+    }
+    return [];
 }
-export async function withUlwLoopMutationLock(repoRoot, scopeOrFn, maybeFn) {
+export async function withUlwLoopMutationLock(repoRoot, scopeOrFn, maybeFn, options = {}) {
     const scope = typeof scopeOrFn === "function" ? undefined : scopeOrFn;
     const fn = typeof scopeOrFn === "function" ? scopeOrFn : maybeFn;
     if (fn === undefined)
         throw new UlwLoopError("Missing ulw-loop mutation body.", "ULW_LOOP_LOCK_BODY_MISSING");
     const lockKey = `${repoRoot}\0${ulwLoopRelativeDir(scope)}`;
+    const lockPath = ulwLoopStateLockPath(repoRoot, scope);
+    const locked = () => withStateLock(lockPath, async (token) => {
+        return heldLocks.run(new Map([...(heldLocks.getStore() ?? []), [lockPath, { token, migrations: new Map() }]]), async () => {
+            for (let attempt = 0;; attempt += 1) {
+                try {
+                    return await fn();
+                }
+                catch (error) {
+                    if (!(error instanceof UlwLoopError) || error.code !== "ULW_LOOP_PUBLISH_CONFLICT")
+                        throw error;
+                    assertStateLockOwned(lockPath);
+                    if (attempt !== 0)
+                        throw error;
+                }
+            }
+        });
+    }, { ...lockOptions.getStore(), ...options });
     const prior = locks.get(lockKey) ?? Promise.resolve(undefined);
-    const run = prior.then(fn, fn);
-    // The stored gate resolves to undefined so the map never retains fn's result
-    // (plans/audits), and it removes itself once no newer waiter replaced it —
-    // otherwise a long-lived host leaks one entry per (repo, scope) forever.
+    const run = prior.then(locked, locked);
     const gate = run.then(() => undefined, () => undefined);
     locks.set(lockKey, gate);
     void gate.then(() => {
@@ -38,106 +91,74 @@ export async function withUlwLoopMutationLock(repoRoot, scopeOrFn, maybeFn) {
     });
     return run;
 }
-export async function readUlwLoopPlan(repoRoot, scope) {
+export function readUlwLoopPlanSync(repoRoot, scope) {
     const path = ulwLoopGoalsPath(repoRoot, scope);
-    let raw;
-    try {
-        raw = await readFile(path, "utf8");
-    }
-    catch (error) {
-        if (!hasCode(error, "ENOENT"))
-            throw error;
-        throw new UlwLoopError(`No ulw-loop plan found at ${repoRelative(path, repoRoot)}. Run \`omo-agent-toolkit ulw-loop create-goals ...\` first.`, "ULW_LOOP_PLAN_MISSING", { cause: error });
-    }
-    const parsed = JSON.parse(raw);
-    if (parsed.version !== 1 || !Array.isArray(parsed.goals)) {
+    const parsed = reconcilePlan(ulwLoopDir(repoRoot, scope));
+    if (parsed === undefined)
+        throw planMissingError(repoRelative(path, repoRoot), listUlwLoopSessionIds(repoRoot));
+    if (parsed.version !== 1 || !Array.isArray(parsed.goals))
         throw new UlwLoopError(`Invalid ulw-loop plan at ${repoRelative(path, repoRoot)}.`, "ULW_LOOP_PLAN_INVALID");
-    }
     const previousObjective = parsed.codexObjective;
     if ((parsed.codexGoalMode ?? "per_story") === "aggregate" &&
-        isLegacyEnumeratedAggregateObjective(previousObjective)) {
-        const now = iso();
+        previousObjective !== undefined &&
+        (previousObjective === LEGACY_OBJECTIVE || previousObjective.startsWith(LEGACY_OBJECTIVE_PREFIX))) {
         parsed.codexObjective = aggregateCodexObjectiveForScope(scope);
         parsed.codexObjectiveAliases = [...new Set([...(parsed.codexObjectiveAliases ?? []), previousObjective])];
-        parsed.updatedAt = now;
-        await writePlan(repoRoot, parsed, scope);
-        await appendLedger(repoRoot, {
-            at: now,
-            kind: "aggregate_objective_migrated",
-            message: "Migrated legacy enumerated aggregate Codex objective to the stable pointer objective.",
-            before: { codexObjective: previousObjective },
-            after: { codexObjective: parsed.codexObjective },
-        }, scope);
+        heldLocks
+            .getStore()
+            ?.get(ulwLoopStateLockPath(repoRoot, scope))
+            ?.migrations.set(parsed.goalsPath, [
+            {
+                at: iso(),
+                kind: "aggregate_objective_migrated",
+                before: { codexObjective: previousObjective },
+                after: { codexObjective: parsed.codexObjective },
+            },
+        ]);
     }
     return parsed;
 }
+export async function readUlwLoopPlan(repoRoot, scope) {
+    if (heldLocks.getStore()?.has(ulwLoopStateLockPath(repoRoot, scope))) {
+        assertStateLockOwned(ulwLoopStateLockPath(repoRoot, scope));
+        await materialize(ulwLoopDir(repoRoot, scope));
+    }
+    return readUlwLoopPlanSync(repoRoot, scope);
+}
+export function listUlwLoopSessionIds(repoRoot) {
+    try {
+        return readdirSync(ulwLoopDir(repoRoot), { withFileTypes: true })
+            .filter((entry) => entry.isDirectory())
+            .map((entry) => entry.name)
+            .sort();
+    }
+    catch {
+        return [];
+    }
+}
 export async function writePlan(repoRoot, plan, scope) {
-    await mkdir(ulwLoopDir(repoRoot, scope), { recursive: true });
-    const path = ulwLoopGoalsPath(repoRoot, scope);
-    const tmpPath = `${path}.${process.pid}.${Date.now()}.tmp`;
-    await writeFile(tmpPath, `${JSON.stringify(plan, null, 2)}\n`, "utf8");
-    await rename(tmpPath, path);
+    await commit(repoRoot, scope, { plan, entries: [] });
 }
 export async function appendLedger(repoRoot, entry, scope) {
     await appendLedgerEntries(repoRoot, [entry], scope);
 }
 export async function appendLedgerEntries(repoRoot, entries, scope) {
-    if (entries.length === 0)
-        return;
-    await mkdir(ulwLoopDir(repoRoot, scope), { recursive: true });
-    await appendFile(ulwLoopLedgerPath(repoRoot, scope), `${entries.map((entry) => JSON.stringify(entry)).join("\n")}\n`, "utf8");
+    if (entries.length > 0)
+        await commit(repoRoot, scope, { plan: await readUlwLoopPlan(repoRoot, scope), entries });
 }
-/**
- * Streams raw ledger lines without materializing the file. Real ledgers reach
- * many MB (legacy entries embedded full-plan snapshots), so `readFile` here
- * ballooned every steer/dedup path; line-at-a-time keeps memory O(longest line).
- */
-async function* ledgerLines(repoRoot, scope) {
-    const stream = createReadStream(ulwLoopLedgerPath(repoRoot, scope), { encoding: "utf8" });
-    const lines = createInterface({ input: stream, crlfDelay: Number.POSITIVE_INFINITY });
-    try {
-        for await (const line of lines) {
-            if (line.trim().length > 0)
-                yield line;
-        }
-    }
-    catch (error) {
-        if (!hasCode(error, "ENOENT"))
-            throw error;
-    }
-    finally {
-        lines.close();
-        stream.destroy();
-    }
+function isSteeringKind(value) {
+    return (value === "steering_accepted" ||
+        value === "steering_rejected" ||
+        value === "criteria_revised" ||
+        value === "batch_updated");
 }
 export async function readSteeringLedgerEntries(repoRoot, scope) {
-    const entries = [];
-    for await (const line of ledgerLines(repoRoot, scope)) {
-        const entry = JSON.parse(line);
-        if (isSteeringKind(entry.kind))
-            entries.push(entry);
-    }
-    return entries;
+    return readLedger(repoRoot, scope).filter((entry) => isSteeringKind(entry.kind));
 }
-/**
- * First accepted steering entry matching an idempotency key/prompt signature.
- * A cheap substring probe on the raw line skips JSON.parse for the vast
- * majority of entries, so dedup stays flat even on legacy multi-MB ledgers.
- */
 export async function findAcceptedSteeringLedgerEntry(repoRoot, key, scope) {
-    const probe = JSON.stringify(key);
-    for await (const line of ledgerLines(repoRoot, scope)) {
-        if (!line.includes(probe))
-            continue;
-        const entry = JSON.parse(line);
-        if (!isSteeringKind(entry.kind))
-            continue;
-        if (entry.steering?.invariant.accepted !== true)
-            continue;
-        if (entry.idempotencyKey === key ||
+    return readLedger(repoRoot, scope).find((entry) => isSteeringKind(entry.kind) &&
+        entry.steering?.invariant.accepted === true &&
+        (entry.idempotencyKey === key ||
             entry.steering.idempotencyKey === key ||
-            entry.steering.promptSignature === key)
-            return entry;
-    }
-    return undefined;
+            entry.steering.promptSignature === key));
 }

package/packages/omo-codex/plugin/components/ulw-loop/dist/plan-log.d.ts

@@ -0,0 +1,16 @@
+import { type UlwLoopScope } from "./paths.js";
+import { type UlwLoopLedgerEntry, type UlwLoopPlan } from "./types.js";
+export interface PlanCommitRecord {
+    readonly version: 1;
+    readonly revision: number;
+    readonly plan: UlwLoopPlan;
+    readonly ledger: readonly UlwLoopLedgerEntry[];
+}
+export declare function hasCode(error: unknown, code: string): boolean;
+export declare function readOptional(path: string): string | undefined;
+export declare function logNames(dir: string): string[];
+export declare function readRecords(dir: string): PlanCommitRecord[];
+export declare function readNewestRecord(dir: string): PlanCommitRecord | undefined;
+export declare function reconcilePlan(dir: string): UlwLoopPlan | undefined;
+export declare function assertProjectionComplete(plan: UlwLoopPlan, ledger: readonly UlwLoopLedgerEntry[]): void;
+export declare function planExists(repoRoot: string, scope?: UlwLoopScope): boolean;

package/packages/omo-codex/plugin/components/ulw-loop/dist/plan-log.js

@@ -0,0 +1,115 @@
+import { existsSync, readdirSync, readFileSync } from "node:fs";
+import { join } from "node:path";
+import { ulwLoopDir } from "./paths.js";
+import { UlwLoopError } from "./types.js";
+export function hasCode(error, code) {
+    return error instanceof Error && "code" in error && error.code === code;
+}
+export function readOptional(path) {
+    try {
+        return readFileSync(path, "utf8");
+    }
+    catch (error) {
+        if (hasCode(error, "ENOENT"))
+            return undefined;
+        throw error;
+    }
+}
+export function logNames(dir) {
+    try {
+        return readdirSync(join(dir, "revisions"))
+            .filter((name) => /^\d{8,}\.json$/.test(name))
+            .sort();
+    }
+    catch (error) {
+        if (hasCode(error, "ENOENT"))
+            return [];
+        throw error;
+    }
+}
+function readRecord(dir, name) {
+    try {
+        const record = JSON.parse(readFileSync(join(dir, "revisions", name), "utf8"));
+        return record.version === 1 &&
+            Number.isInteger(record.revision) &&
+            record.plan?.version === 1 &&
+            Array.isArray(record.plan.goals) &&
+            Array.isArray(record.ledger)
+            ? record
+            : undefined;
+    }
+    catch (error) {
+        if (!(error instanceof SyntaxError))
+            throw error;
+        return undefined;
+    }
+}
+// Only the audit trail needs every record; plan reads use readNewestRecord.
+export function readRecords(dir) {
+    const records = [];
+    for (const name of logNames(dir)) {
+        const record = readRecord(dir, name);
+        if (record !== undefined)
+            records.push(record);
+    }
+    return records.sort((a, b) => a.revision - b.revision);
+}
+// Every ulw-loop status probe reads the plan, each record embeds a full plan copy, and records are never
+// deleted - so a plan read parses the newest record only, newest first, and stops there. Names are ordered
+// by their parsed revision because a wider zero-padding would break lexicographic order.
+export function readNewestRecord(dir) {
+    const names = logNames(dir).sort((a, b) => Number.parseInt(b, 10) - Number.parseInt(a, 10));
+    for (const name of names) {
+        const record = readRecord(dir, name);
+        if (record !== undefined)
+            return record;
+    }
+    return undefined;
+}
+export function reconcilePlan(dir) {
+    const raw = readOptional(join(dir, "goals.json"));
+    let cached;
+    if (raw !== undefined) {
+        try {
+            cached = JSON.parse(raw);
+        }
+        catch (error) {
+            if (!(error instanceof SyntaxError))
+                throw error;
+        }
+    }
+    const latest = readNewestRecord(dir);
+    if (latest === undefined)
+        return cached;
+    if (cached === undefined)
+        return latest.plan;
+    if ((cached.revision ?? 0) > latest.revision)
+        return cached;
+    // A goals.json written outside the commit log (the removed tool path rewrote it wholesale, never
+    // stamping `revision`) can hold goals no snapshot has. Serving the snapshot would drop them, so the
+    // cache wins and is stamped with the snapshot's revision: the next publish derives N+1 from it and
+    // folds the whole plan into a real record instead of colliding with an existing revision file.
+    // A cache that names an OLDER revision is a lagging view of a force-recreate and never wins.
+    if (cached.revision === undefined || cached.revision === latest.revision) {
+        const published = new Set(latest.plan.goals.map((goal) => goal.id));
+        if (Array.isArray(cached.goals) && cached.goals.some((goal) => !published.has(goal.id)))
+            return { ...cached, revision: latest.revision };
+    }
+    return latest.plan;
+}
+// Goals are never removed from a plan, so every `goal_added` the reconciled ledger still carries must
+// have a goal in the projection. A projection that lacks one is truncated and must not become goals.json.
+export function assertProjectionComplete(plan, ledger) {
+    const present = new Set(plan.goals.map((goal) => goal.id));
+    const missing = new Set();
+    for (const entry of ledger)
+        if (entry.kind === "goal_added" && entry.goalId !== undefined && !present.has(entry.goalId))
+            missing.add(entry.goalId);
+    if (missing.size === 0)
+        return;
+    throw new UlwLoopError(`Refusing to rewrite goals.json: the ledger records goals the plan projection lacks (${[...missing].join(", ")}). Restore those goals into the newest revisions/ record (keeping plan.revision equal to its file number) before mutating this run.`, "ULW_LOOP_PROJECTION_TRUNCATED", { details: { missingGoalIds: [...missing] } });
+}
+export function planExists(repoRoot, scope) {
+    const dir = ulwLoopDir(repoRoot, scope);
+    return existsSync(join(dir, "goals.json")) || logNames(dir).length > 0;
+}

package/packages/omo-codex/plugin/components/ulw-loop/dist/plan-missing-recovery.d.ts

@@ -0,0 +1,18 @@
+import { UlwLoopError } from "./runtime.js";
+import type { UlwLoopToolkitSurface } from "./surface.js";
+export declare const ULW_LOOP_CREATE_GOALS_COMMAND = "omo-agent-toolkit ulw-loop create-goals --brief \"<brief>\" --json";
+export declare function createGoalsAction(surface: UlwLoopToolkitSurface): string;
+export interface PlanMissingRecovery {
+    readonly message: string;
+    readonly details?: {
+        readonly existingSessionIds: readonly string[];
+    };
+}
+/**
+ * A missing plan is either "never bootstrapped" or "bootstrapped under a different
+ * session id"; the recovery text has to answer both without the caller guessing.
+ */
+export declare function planMissingRecovery(existingSessionIds: readonly string[], surface?: UlwLoopToolkitSurface): PlanMissingRecovery;
+export declare function planMissingError(planPath: string, existingSessionIds: readonly string[], surface?: UlwLoopToolkitSurface): UlwLoopError;
+export declare function sessionScopeRequiredMessage(flag: string, existingSessionIds: readonly string[]): string;
+export declare function sessionIdRequiredMessage(flag: string): string;

package/packages/omo-codex/plugin/components/ulw-loop/dist/plan-missing-recovery.js

@@ -0,0 +1,41 @@
+import { UlwLoopError } from "./runtime.js";
+export const ULW_LOOP_CREATE_GOALS_COMMAND = 'omo-agent-toolkit ulw-loop create-goals --brief "<brief>" --json';
+export function createGoalsAction(surface) {
+    return surface === "omo-senpi" ? 'agentToolkit.createGoals({ brief: "<brief>" })' : ULW_LOOP_CREATE_GOALS_COMMAND;
+}
+/**
+ * A missing plan is either "never bootstrapped" or "bootstrapped under a different
+ * session id"; the recovery text has to answer both without the caller guessing.
+ */
+export function planMissingRecovery(existingSessionIds, surface = "lazycodex") {
+    const lines = [`Recovery: bootstrap the plan with \`${createGoalsAction(surface)}\`.`];
+    if (existingSessionIds.length === 0)
+        return { message: lines.join("\n") };
+    lines.push(surface === "omo-senpi"
+        ? `Existing ulw-loop session ids under .omo/ulw-loop/: ${existingSessionIds.join(", ")}. The SDK is bound to the current session; resume the owning session to target its plan.`
+        : `Existing ulw-loop session ids under .omo/ulw-loop/: ${existingSessionIds.join(", ")}. Re-run with \`--session-id <id>\` to target one of them.`);
+    return { message: lines.join("\n"), details: { existingSessionIds } };
+}
+export function planMissingError(planPath, existingSessionIds, surface = "lazycodex") {
+    const recovery = planMissingRecovery(existingSessionIds, surface);
+    return new UlwLoopError(`No ulw-loop plan found at ${planPath}.\n${recovery.message}`, "ULW_LOOP_PLAN_MISSING", {
+        ...(recovery.details === undefined ? {} : { details: recovery.details }),
+    });
+}
+export function sessionScopeRequiredMessage(flag, existingSessionIds) {
+    const lines = [
+        "No ulw-loop session scope: neither the session env (OMO_ULW_LOOP_SESSION_ID / CODEX_SESSION_ID / CODEX_THREAD_ID / PI_SESSION_ID) nor the flag names this run, and the shared .omo/ulw-loop root is never used implicitly because every session in this directory would read and overwrite it.",
+        `Recovery: pass the scope explicitly: \`${flag} <id>\` (subprocess, eval, and hook contexts do not inherit the session env).`,
+    ];
+    if (existingSessionIds.length > 0) {
+        lines.push(`Existing ulw-loop session ids under .omo/ulw-loop/: ${existingSessionIds.join(", ")}.`);
+    }
+    return lines.join("\n");
+}
+export function sessionIdRequiredMessage(flag) {
+    return [
+        `${flag} requires a non-empty value.`,
+        "Recovery: subprocess, eval, and hook contexts do not inherit the ulw-loop session env (OMO_ULW_LOOP_SESSION_ID / CODEX_SESSION_ID / CODEX_THREAD_ID / PI_SESSION_ID),",
+        `so pass the scope explicitly: \`${flag} <id>\` (for example \`${flag} 01a05b8a-6763-7780-834f-319423b071ce\`).`,
+    ].join("\n");
+}

package/packages/omo-codex/plugin/components/ulw-loop/dist/quality-gate-aggregate.d.ts

@@ -0,0 +1,7 @@
+import type { ValidateQualityGateOptions } from "./quality-gate.js";
+/**
+ * Compatibility entry point for callers that used the former pre-pass API.
+ * Validation is performed by the real parser, which collects defects across
+ * every nested field before throwing one aggregate error.
+ */
+export declare function aggregateQualityGateDefects(input: unknown, opts: ValidateQualityGateOptions | undefined): void;

package/packages/omo-codex/plugin/components/ulw-loop/dist/quality-gate-aggregate.js

@@ -0,0 +1,9 @@
+import { validateQualityGate } from "./quality-gate.js";
+/**
+ * Compatibility entry point for callers that used the former pre-pass API.
+ * Validation is performed by the real parser, which collects defects across
+ * every nested field before throwing one aggregate error.
+ */
+export function aggregateQualityGateDefects(input, opts) {
+    validateQualityGate(input, opts);
+}

package/packages/omo-codex/plugin/components/ulw-loop/dist/quality-gate-artifacts.d.ts

@@ -0,0 +1,12 @@
+import type { ValidateQualityGateOptions } from "./quality-gate.js";
+import type { UlwLoopManualQaArtifactKind, UlwLoopManualQaArtifactRef, UlwLoopManualQaSurface } from "./types.js";
+export declare const SUPPORTED_SURFACES: readonly UlwLoopManualQaSurface[];
+export declare const SUPPORTED_KINDS: readonly UlwLoopManualQaArtifactKind[];
+export declare function surfaceField(value: unknown, field: string): UlwLoopManualQaSurface;
+export declare function kindField(value: unknown, field: string): UlwLoopManualQaArtifactKind;
+export declare function compatibleKindsFor(surface: UlwLoopManualQaSurface): readonly UlwLoopManualQaArtifactKind[];
+export declare function artifactCompatible(surface: UlwLoopManualQaSurface, kind: UlwLoopManualQaArtifactKind): boolean;
+export declare function checkFile(path: string, field: string, opts?: ValidateQualityGateOptions): void;
+export declare function artifactMap(refs: readonly UlwLoopManualQaArtifactRef[]): Map<string, UlwLoopManualQaArtifactRef>;
+export declare function parseArtifactRefs(value: unknown, opts?: ValidateQualityGateOptions): readonly UlwLoopManualQaArtifactRef[];
+export declare function referencedArtifacts(value: unknown, field: string, byId: ReadonlyMap<string, UlwLoopManualQaArtifactRef>): readonly UlwLoopManualQaArtifactRef[];

package/packages/omo-codex/plugin/components/ulw-loop/dist/quality-gate-artifacts.js

@@ -0,0 +1,104 @@
+import { resolve } from "node:path";
+import { isWithinAttemptDir } from "./paths.js";
+import { invalid, isPoisoned, markPoisonedArtifactKind, section, stringArray, textField, } from "./quality-gate-fields.js";
+export const SUPPORTED_SURFACES = ["cli", "http", "tmux", "browser", "gui", "data"];
+export const SUPPORTED_KINDS = [
+    "cli-transcript",
+    "log",
+    "screenshot",
+    "image",
+    "http-dump",
+    "data-diff",
+];
+const COMPATIBLE_KINDS = {
+    cli: ["cli-transcript", "log"],
+    tmux: ["cli-transcript", "log"],
+    http: ["http-dump"],
+    browser: ["screenshot", "image"],
+    gui: ["screenshot", "image"],
+    data: ["data-diff"],
+};
+function isSupportedSurface(value) {
+    return SUPPORTED_SURFACES.some((surface) => surface === value);
+}
+function isSupportedKind(value) {
+    return SUPPORTED_KINDS.some((kind) => kind === value);
+}
+export function surfaceField(value, field) {
+    if (isSupportedSurface(value))
+        return value;
+    invalid(`${field} must be a supported manual QA surface (${SUPPORTED_SURFACES.join(", ")}).`, field);
+    return "cli";
+}
+export function kindField(value, field) {
+    if (isSupportedKind(value))
+        return value;
+    invalid(`${field} must be a supported artifact kind (${SUPPORTED_KINDS.join(", ")}); review/QA reports belong in codeReview.reportPath or gateReview.reportPath, not artifactRefs.`, field);
+    return "log";
+}
+export function compatibleKindsFor(surface) {
+    return COMPATIBLE_KINDS[surface];
+}
+export function artifactCompatible(surface, kind) {
+    return compatibleKindsFor(surface).includes(kind);
+}
+export function checkFile(path, field, opts) {
+    if (opts?.repoRoot === undefined || opts.fs === undefined || isPoisoned(field))
+        return;
+    const absolute = resolve(opts.repoRoot, path);
+    if (!opts.fs.existsSync(absolute)) {
+        invalid(`${field} must point to an existing artifact.`, field);
+        return;
+    }
+    if (opts.fs.statSync(absolute).size <= 0)
+        invalid(`${field} must point to a non-empty artifact.`, field);
+    if (opts.currentAttemptDir !== undefined &&
+        !isWithinAttemptDir(absolute, resolve(opts.repoRoot, opts.currentAttemptDir)))
+        invalid(`${field} (${path}) must point to an artifact from the current attempt (${opts.currentAttemptDir}).`, field);
+}
+export function artifactMap(refs) {
+    const byId = new Map();
+    for (const ref of refs) {
+        if (byId.has(ref.id))
+            invalid(`manualQa.artifactRefs contains duplicate ${ref.id}.`, "manualQa.artifactRefs");
+        byId.set(ref.id, ref);
+    }
+    return byId;
+}
+export function parseArtifactRefs(value, opts) {
+    if (!Array.isArray(value) || value.length === 0) {
+        invalid("manualQa.artifactRefs must not be empty.", "manualQa.artifactRefs");
+        return [];
+    }
+    return value.flatMap((item, index) => {
+        const prefix = `manualQa.artifactRefs[${index}]`;
+        const ref = section(item, prefix);
+        if (isPoisoned(prefix))
+            return [];
+        const pathField = `${prefix}.path`;
+        const idField = `${prefix}.id`;
+        const kindFieldName = `${prefix}.kind`;
+        const descriptionField = `${prefix}.description`;
+        const path = textField(ref["path"], pathField);
+        const id = textField(ref["id"], idField);
+        const kind = kindField(ref["kind"], kindFieldName);
+        if (isPoisoned(kindFieldName))
+            markPoisonedArtifactKind(id);
+        const description = textField(ref["description"], descriptionField);
+        checkFile(path, pathField, opts);
+        return [{ id, kind, description, path }];
+    });
+}
+export function referencedArtifacts(value, field, byId) {
+    const ids = stringArray(value, field);
+    if (isPoisoned(field))
+        return [];
+    return ids.flatMap((id) => {
+        const artifact = byId.get(id);
+        if (artifact === undefined) {
+            invalid(`${field} references unknown artifact ${id}.`, field);
+            return [];
+        }
+        return [artifact];
+    });
+}

package/packages/omo-codex/plugin/components/ulw-loop/dist/quality-gate-fields.d.ts

@@ -1,4 +1,15 @@
-export declare function invalid(message: string, field: string): never;
+type QualityGateDefect = {
+    readonly field: string;
+    readonly message: string;
+};
+/** A recorded defect poisons only its field; consumers skip dependent checks while preserving valid siblings and entry identity. */
+export declare function withQualityGateCollector<T>(operation: () => T): T;
+export declare function throwQualityGateDefects(defects: readonly QualityGateDefect[]): never;
+export declare function invalid(message: string, field: string): undefined;
+export declare function isPoisoned(field: string): boolean;
+export declare function poisonField(field: string): void;
+export declare function markPoisonedArtifactKind(id: string): void;
+export declare function isPoisonedArtifactKind(id: string): boolean;
 export declare function isRecord(value: unknown): value is Record<string, unknown>;
 export declare function section(value: unknown, field: string): Record<string, unknown>;
 export declare function textField(value: unknown, field: string): string;
@@ -6,3 +17,4 @@ export declare function numberField(value: unknown, field: string): number;
 export declare function stringArray(value: unknown, field: string): readonly string[];
 export declare function emptyBlockers(value: unknown, field: string): readonly [];
 export declare function literal<T extends string | boolean>(value: unknown, expected: T, field: string): T;
+export {};