lazyclaw 5.4.3 → 6.0.0

package/workflow/persistent.mjs

@@ -7,6 +7,8 @@ import fs from 'node:fs';
 import path from 'node:path';
 import { performance } from 'node:perf_hooks';
 import { topologicalLevels, retryWithBackoff, runWithTimeout, settleWithConcurrency } from './executor.mjs';
+// Workflow state can carry transcript content; persist it owner-only (0600).
+import { writeJsonSecure } from '../secure_write.mjs';
 
 const DEFAULT_DIR = '.workflow-state';
 
@@ -46,7 +48,15 @@ export function statePath(sessionId, dir = DEFAULT_DIR) {
 export function loadState(sessionId, dir = DEFAULT_DIR) {
   const p = statePath(sessionId, dir);
   if (!fs.existsSync(p)) return null;
-  return JSON.parse(fs.readFileSync(p, 'utf8'));
+  // A corrupt/truncated state file (kill -9 mid-write, disk-full, hand-edit)
+  // must not crash `inspect`/`resume` with a raw SyntaxError — treat it as
+  // "no prior state" (start fresh), matching loops.readMeta / goals.getGoal.
+  try {
+    return JSON.parse(fs.readFileSync(p, 'utf8'));
+  } catch (e) {
+    process.stderr.write(`[workflow] ignoring unreadable state ${p}: ${e?.message || e}\n`);
+    return null;
+  }
 }
 
 /**
@@ -54,12 +64,9 @@ export function loadState(sessionId, dir = DEFAULT_DIR) {
  * @param {string} [dir]
  */
 export function saveState(state, dir = DEFAULT_DIR) {
-  fs.mkdirSync(dir, { recursive: true });
   state.updatedAt = Date.now();
-  const p = statePath(state.sessionId, dir);
-  const tmp = `${p}.tmp`;
-  fs.writeFileSync(tmp, JSON.stringify(state, null, 2));
-  fs.renameSync(tmp, p);
+  // Atomic owner-only write (tmp + rename + 0600), same as the gateway store.
+  writeJsonSecure(statePath(state.sessionId, dir), state);
 }
 
 function initState(sessionId, nodes) {

package/mas/tools/skill_view.mjs

@@ -1,43 +0,0 @@
-// skill_view tool — Phase 20.
-//
-// Read-only progressive-disclosure loader: the mention-router injects a
-// compact skills *index* (name + one-line summary) into the system
-// prompt, and the agent calls skill_view to pull the FULL text of a
-// skill only when it decides one is relevant. This keeps skill bodies
-// out of the prompt until they're actually needed.
-//
-// Unlike bash/read/write/grep this tool is rooted at the lazyclaw
-// config dir (where skills live), not the task cwd, so it takes
-// configDir from the tool-runner opts rather than cwd.
-
-import * as skills from '../../skills.mjs';
-
-export const NAME = 'skill_view';
-export const DESCRIPTION =
-  'Load the full text of a named skill from the skills index (its When-to-Use, Procedure, Pitfalls and Verification sections). Call this when a skill listed in the index looks relevant to the current task.';
-export const PARAMETERS = {
-  type: 'object',
-  properties: {
-    name: { type: 'string', description: 'The skill name exactly as shown in the skills index.' },
-  },
-  required: ['name'],
-};
-
-export async function exec(args, { configDir } = {}) {
-  if (!args || typeof args.name !== 'string' || !args.name.trim()) {
-    return { ok: false, error: 'skill_view: name is required' };
-  }
-  const name = args.name.trim();
-  try {
-    const content = skills.loadSkill(name, configDir);
-    // Record the recall so the curator can age out never-used skills.
-    // Best-effort: a usage-write hiccup must never fail the tool call.
-    try {
-      const curator = await import('../../skills_curator.mjs');
-      curator.recordUsage(name, configDir, Date.now());
-    } catch { /* non-fatal */ }
-    return { ok: true, name, content };
-  } catch (err) {
-    return { ok: false, error: `skill_view: ${err?.message || err}` };
-  }
-}