law-common 14.0.3-beta.4 → 14.0.3-beta.6

package/dist/src/api/interface/reimbursement.entity.response.d.ts

@@ -1,4 +1,4 @@
-import { IReimbursementEntity, IReimbursementExpenseEntity, IUserEntity, ParentChildFlowConfig, ReimbursementActionEnum, ReimbursementExpenseActionEnum, ReimbursementExpenseState, ReimbursementStatusEnum } from "../../entities";
+import { IReimbursementEntity, IReimbursementExpenseEntity, IUserEntity } from "../../entities";
 import { IProjectEntityGet } from "./project.entity.response";
 export type IReimbursementEntityGet = {
     reimbursements: IReimbursementResponse[];
@@ -7,14 +7,6 @@ export type IReimbursementEntityGet = {
     };
     projects: IProjectEntityGet;
 };
-/**
- * LW-828: this used to re-declare the parent/child flow-config shape by hand. It is now an alias of the
- * shared `ParentChildFlowConfig`, instantiated with `IReimbursementFlowContextData` for the parent and
- * `void` for the child — the child's `next` is called with no argument in
- * `ReimbursementExpenseService.getReimbursementNextStatusForChild`. Kept as a named type so every
- * existing consumer keeps compiling unchanged.
- */
-export type IReimbursementFlowConfig = ParentChildFlowConfig<ReimbursementStatusEnum, ReimbursementActionEnum, ReimbursementExpenseState, ReimbursementExpenseActionEnum, IReimbursementFlowContextData, void>;
 export type IReimbursementFlowContextData = {
     expenseDetails: IReimbursementExpenseEntity[];
 };

package/dist/src/entities/flow-configs/flow-config.type.d.ts

@@ -70,17 +70,3 @@ export interface IFlowConfigActionConfig<STATUS_ENUM_TYPE extends string, CONTEX
      */
     isApplicable?: (data: CONTEXT_DATA_TYPE) => boolean;
 }
-/**
- * A flow whose parent and child rows each have their own status/action vocabulary.
- *
- * @template T  context data passed to the parent's `next()`
- * @template CT context data passed to the child's `next()`. Defaults to `T` for flows where both
- *              levels resolve from the same context. Reimbursement is the case that needs them to
- *              differ: its parent derives the reimbursement status from the child rows, while its
- *              child transitions are all fixed and its `next()` is called with no argument at all —
- *              so the child is instantiated with `void`.
- */
-export type ParentChildFlowConfig<S extends string, A extends string, CS extends string = never, CA extends string = never, T extends Record<any, any> = never, CT = T> = {
-    parent: FlowConfig<S, A, T>;
-    child: FlowConfig<CS, CA, CT>;
-};

package/dist/src/entities/flow-configs/reimbursement_expense_flow.config.js

@@ -8,8 +8,8 @@ const base_flow_config_factory_1 = require("./base-flow-config.factory");
  * Reimbursement Expense — the child level of the reimbursement flow.
  *
  * Split out of `reimbursement_flow.config.ts` so each level can be read on its own: this file owns the
- * expense-row state machine, and the parent file owns the reimbursement status derivation plus the
- * composed `reimbursementConfigFlow` the services consume.
+ * expense-row state machine, and the parent file owns the reimbursement status derivation. The two are
+ * standalone `FlowConfig`s; each consumer imports the level it uses directly.
  *
  * Every transition here is a fixed target, and `ReimbursementExpenseService.getReimbursementNextStatusForChild`
  * calls `next()` with no argument, so the factory is instantiated with `void` — a `void` parameter may be

package/dist/src/entities/flow-configs/reimbursement_flow.config.d.ts

@@ -1,17 +1,9 @@
 import { IReimbursementFlowContextData } from "../../api";
 import { ReimbursementActionEnum } from "../enums/reimbursement_action_enum";
-import { ReimbursementExpenseActionEnum } from "../enums/reimbursement_expense_action_enum";
-import { ReimbursementExpenseState } from "../enums/reimbursement_expense_state_enum";
 import { ReimbursementStatusEnum } from "../enums/reimbursement_status_enum";
-import { FlowConfig, ParentChildFlowConfig } from "./flow-config.type";
+import { FlowConfig } from "./flow-config.type";
 /**
  * REJECTED, DELETED and PAYMENT_DISBURSE are reachable targets but have no block of their own — a
  * reimbursement that lands in any of them is final at the parent level.
  */
 export declare const reimbursementFlowConfig: FlowConfig<ReimbursementStatusEnum, ReimbursementActionEnum, IReimbursementFlowContextData>;
-/**
- * The two levels composed into the shape the services consume — `ReimbursementService` reads
- * `.parent` and `ReimbursementExpenseService` reads `.child`. Kept so splitting the files is invisible
- * to every consumer; each level can now also be imported on its own.
- */
-export declare const reimbursementConfigFlow: ParentChildFlowConfig<ReimbursementStatusEnum, ReimbursementActionEnum, ReimbursementExpenseState, ReimbursementExpenseActionEnum, IReimbursementFlowContextData, void>;

package/dist/src/entities/flow-configs/reimbursement_flow.config.js

@@ -1,16 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.reimbursementConfigFlow = exports.reimbursementFlowConfig = void 0;
+exports.reimbursementFlowConfig = void 0;
 const reimbursement_action_enum_1 = require("../enums/reimbursement_action_enum");
 const reimbursement_expense_state_enum_1 = require("../enums/reimbursement_expense_state_enum");
 const reimbursement_status_enum_1 = require("../enums/reimbursement_status_enum");
 const base_flow_config_factory_1 = require("./base-flow-config.factory");
-const reimbursement_expense_flow_config_1 = require("./reimbursement_expense_flow.config");
 /**
  * Reimbursement — the parent level of the reimbursement flow.
  *
- * The child level lives in `reimbursement_expense_flow.config.ts`; the two are composed at the bottom
- * of this file into `reimbursementConfigFlow`, which is what the services consume.
+ * The child level lives in `reimbursement_expense_flow.config.ts`; the two are standalone
+ * `FlowConfig`s and each consumer imports the level it uses directly.
  *
  * The parent takes `IReimbursementFlowContextData` because its UPDATE derives the reimbursement status
  * from the states of its expense rows — the helpers at the bottom of this file. The child takes `void`,
@@ -101,15 +100,6 @@ exports.reimbursementFlowConfig = {
         },
     },
 };
-/**
- * The two levels composed into the shape the services consume — `ReimbursementService` reads
- * `.parent` and `ReimbursementExpenseService` reads `.child`. Kept so splitting the files is invisible
- * to every consumer; each level can now also be imported on its own.
- */
-exports.reimbursementConfigFlow = {
-    parent: exports.reimbursementFlowConfig,
-    child: reimbursement_expense_flow_config_1.reimbursementExpenseFlowConfig,
-};
 function areAllRowApproved(data) {
     const { expenseDetails } = data;
     return expenseDetails.length > 0 ? expenseDetails.every((row) => row.state === reimbursement_expense_state_enum_1.ReimbursementExpenseState.APPROVED) : false;

package/dist/src/entities/interface/timesheet.entity.interface.d.ts

@@ -1,7 +1,6 @@
 import { TimesheetClassificationStatusEnum } from "../enums/timesheet_classification_status_enum";
 import { TimesheetStatusEnum } from "../enums/timesheet_status_enum";
 import { IEntityAuditColumn } from "./entity-audit-columns.interface";
-import { Nullable } from "./entity.utils.interface";
 export interface ITimesheetEntity extends IEntityAuditColumn {
     id: number;
     userId: number;
@@ -16,6 +15,6 @@ export interface ITimesheetEntity extends IEntityAuditColumn {
     billedDuration?: number;
     notBilledDuration?: number;
     classificationStatus: TimesheetClassificationStatusEnum;
-    classifiedBy?: Nullable<number>;
+    classifiedBy?: number;
 }
 export type PendingApprovalStatus = TimesheetStatusEnum.CREATE_APPROVAL_PENDING | TimesheetStatusEnum.UPDATE_APPROVAL_PENDING | TimesheetStatusEnum.DELETE_APPROVAL_PENDING | TimesheetStatusEnum.RESOLVED_REJECTED;

package/dist/src/entities/model/timesheet.entity.model.d.ts

@@ -1,4 +1,4 @@
-import { ITimesheetFlowContextData, ITimesheetUpdateDto } from "../../api";
+import { ITimesheetUpdateDto, ITimesheetFlowContextData } from "../../api";
 import { CurrencyEnum } from "../../enums";
 import { IClassificationWindowConfig, ITimesheetActionItem, SortableTimesheet } from "../../model/entities/interface/timesheet.model.interface";
 import { TimesheetClassificationStatusEnum } from "../enums/timesheet_classification_status_enum";
@@ -63,12 +63,5 @@ export declare class TimesheetEntityModel extends BaseEntityModel<EntityEnum.TIM
         startDay: number;
         endDay: Nullable<number>;
     }>;
-    /**
-     * Fields on a timesheet that, when changed via an UPDATE, reset the timesheet's
-     * `classificationStatus` back to `PENDING`. Shared by backend (toUpdateDto) and frontend
-     * (edit warning). `billingId` intentionally NOT included — a billing change does not reset
-     * classification. Anything not listed here is by definition "non-reset".
-     */
-    static timesheetClassificationResetFieldsSet(): string[];
     static sortByProjectAndDesignation(data: SortableTimesheet[], designations: IDesignationEntity[]): SortableTimesheet[];
 }

package/dist/src/entities/model/timesheet.entity.model.js

@@ -84,10 +84,8 @@ class TimesheetEntityModel extends base_entity_model_1.BaseEntityModel {
                 return false;
             if (actionKey === timesheet_action_enum_1.TimesheetActionEnum.CLASSIFY)
                 return false;
-            // LW-842: allow UPDATE regardless of classification status — the backend now resets
-            // classificationStatus to PENDING in toUpdateDto when a reset-field changes.
-            // if (actionKey === TimesheetActionEnum.UPDATE && this.classificationStatus && this.classificationStatus !== TimesheetClassificationStatusEnum.PENDING)
-            //   return false;
+            if (actionKey === timesheet_action_enum_1.TimesheetActionEnum.UPDATE && this.classificationStatus && this.classificationStatus !== timesheet_classification_status_enum_1.TimesheetClassificationStatusEnum.PENDING)
+                return false;
             return true;
         })
             .map(([actionKey, actionConfig]) => {
@@ -290,21 +288,6 @@ class TimesheetEntityModel extends base_entity_model_1.BaseEntityModel {
             };
         });
     }
-    /**
-     * Fields on a timesheet that, when changed via an UPDATE, reset the timesheet's
-     * `classificationStatus` back to `PENDING`. Shared by backend (toUpdateDto) and frontend
-     * (edit warning). `billingId` intentionally NOT included — a billing change does not reset
-     * classification. Anything not listed here is by definition "non-reset".
-     */
-    static timesheetClassificationResetFieldsSet() {
-        return [
-            "userId",
-            "projectId",
-            "dateCode",
-            "totalDuration",
-            // "task", "description",
-        ];
-    }
     static sortByProjectAndDesignation(data, designations) {
         const priorityMap = new Map();
         designations.forEach((d) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "law-common",
-  "version": "14.0.3-beta.4",
+  "version": "14.0.3-beta.6",
   "description": "",
   "main": "dist/index.js",
   "files": [