law-common 14.0.1-beta.7 → 14.0.1-beta.9

package/dist/src/api/interface/timesheet.entity.response.interface.d.ts

@@ -17,9 +17,7 @@ export type ITimesheetEntityGet = {
 };
 /**
  * LW-828: this used to re-declare the flow-config shape by hand. It is now an alias of the shared
- * `FlowConfig`, whose action config carries the `isApplicable` runtime guard this entity relies on
- * (LW-830 collapse — the previous `validActionPastThreshold` boolean is commented out in
- * `IFlowConfigActionConfig`). Kept as a named type so every existing consumer keeps compiling unchanged.
+ * `FlowConfig`. Kept as a named type so every existing consumer keeps compiling unchanged.
  */
 export type ITimesheetFlowConfig = FlowConfig<TimesheetStatusEnum, TimesheetActionEnum, ITimesheetFlowContextData>;
 export type ITimesheetFlowContextData = {

package/dist/src/entities/flow-configs/base-flow-config.factory.d.ts

@@ -113,11 +113,6 @@ export type ActionMap<A extends string, S extends string> = {
  * existed — the sixteen already-converted flow configs are byte-identical.
  *
  * @property isApplicable            runtime guard evaluated against the same context as `next()`
- * @property validActionPastThreshold whether the action survives a consumer's data-entry threshold
- *                                   (commented out below since the LW-830 collapse — see note)
- * @property isAvailable             unified runtime guard introduced by LW-830; preferred over
- *                                   `isApplicable` when both are present (commented out below
- *                                   since the LW-830 collapse — see note)
  * @property description             human-readable copy for this transition. Already part of
  *                                   `IFlowConfigActionConfig` and rendered by the entity-flow
  *                                   component, so a converted config must be able to emit it.

package/dist/src/entities/flow-configs/billing_transaction_flow.config.d.ts

@@ -10,8 +10,7 @@ export interface IBillingTransactionContextFlowData {
 /**
  * LW-828: this used to re-declare the flow-config shape by hand. It is now an alias of the shared
  * `FlowConfig`, which is a strict superset of the old declaration — same `permissions` and `next`, plus
- * the optional `description` / `isApplicable` this entity does not use (`validActionPastThreshold` was
- * commented out of the shared type during the LW-830 collapse).
+ * the optional `description` / `isApplicable` this entity does not use.
  * Kept as a named type so every existing consumer keeps compiling unchanged.
  */
 export type IBillingTransactionFlowConfig = FlowConfig<BillingTransactionStatusEnum, BillingTransactionActionEnum, IBillingTransactionContextFlowData>;

package/dist/src/entities/model/timesheet.entity.model.d.ts

@@ -1,6 +1,6 @@
 import { ITimesheetEntityUpdateDto, ITimesheetFlowContextData } from "../../api";
 import { CurrencyEnum } from "../../enums";
-import { TimesheetActionEnum } from "../enums/timesheet_action_enum";
+import { IClassificationWindowConfig, ITimesheetActionItem, SortableTimesheet } from "../../model/entities/interface/timesheet.model.interface";
 import { TimesheetClassificationStatusEnum } from "../enums/timesheet_classification_status_enum";
 import { TimesheetStatusEnum } from "../enums/timesheet_status_enum";
 import { IDesignationEntity } from "../interface/designation.entity.interface";
@@ -11,25 +11,6 @@ import { BaseEntityModel } from "./base.entity.model";
 import { EntityHistoryEntityModel } from "./entity_history.entity.model";
 import { ProjectEntityModel } from "./project.entity.model";
 import { UserEntityModel } from "./user.entity.model";
-export interface IClassificationWindowConfig {
-    bufferDays: number;
-    windows: Array<{
-        startDay: number;
-        endDay: Nullable<number>;
-    }>;
-}
-export interface SortableTimesheet {
-    projectId?: number;
-    projectClientName?: string;
-    designation?: string;
-    resourceName?: string;
-    dateCodeForsorting?: Date;
-}
-export interface ITimesheetActionItem {
-    label: string;
-    value: TimesheetActionEnum | string;
-    disabled?: boolean;
-}
 export declare class TimesheetEntityModel extends BaseEntityModel<EntityEnum.TIMESHEET> implements ITimesheetEntity {
     id: number;
     userId: number;

package/dist/src/entities/model/timesheet.entity.model.js

@@ -91,15 +91,6 @@ class TimesheetEntityModel extends base_entity_model_1.BaseEntityModel {
             const isVisible = actionPermissions.some((permission) => actionVisibilityConfig[permission] && actionVisibilityConfig[permission]());
             if (!isVisible)
                 return null;
-            // LW-830 collapse: `isApplicable` is the single runtime guard. Previous 3-way logic
-            // (isAvailable ?? isApplicable, else validActionPastThreshold ?? true) is commented out:
-            // const predicate = actionConfig.isAvailable ?? actionConfig.isApplicable;
-            // let available = true;
-            // if (predicate) {
-            //   available = predicate(context);
-            // } else {
-            //   available = actionConfig.validActionPastThreshold ?? true;
-            // }
             const predicate = actionConfig.isApplicable;
             let available = true;
             if (predicate) {
@@ -112,8 +103,6 @@ class TimesheetEntityModel extends base_entity_model_1.BaseEntityModel {
             };
         })
             .filter(Boolean);
-        console.log("actions before mergeApproveReject", actions, "hasApprove", actions.some((a) => a.value === timesheet_action_enum_1.TimesheetActionEnum.APPROVE), "hasReject", actions.some((a) => a.value === timesheet_action_enum_1.TimesheetActionEnum.REJECT));
-        console.log("actions", actions);
         const hasApprove = actions.some((a) => a.value === timesheet_action_enum_1.TimesheetActionEnum.APPROVE);
         const hasReject = actions.some((a) => a.value === timesheet_action_enum_1.TimesheetActionEnum.REJECT);
         if ((options === null || options === void 0 ? void 0 : options.mergeApproveReject) !== false && hasApprove && hasReject) {

package/dist/src/model/entities/interface/timesheet.model.interface.d.ts

@@ -1,3 +1,22 @@
-import { ITimesheetEntity } from "../../../entities";
+import { ITimesheetEntity, Nullable, TimesheetActionEnum } from "../../../entities";
 export interface ITimesheetEntityModel extends ITimesheetEntity {
 }
+export interface IClassificationWindowConfig {
+    bufferDays: number;
+    windows: Array<{
+        startDay: number;
+        endDay: Nullable<number>;
+    }>;
+}
+export interface SortableTimesheet {
+    projectId?: number;
+    projectClientName?: string;
+    designation?: string;
+    resourceName?: string;
+    dateCodeForsorting?: Date;
+}
+export interface ITimesheetActionItem {
+    label: string;
+    value: TimesheetActionEnum | "APPROVE_REJECT";
+    disabled?: boolean;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "law-common",
-  "version": "14.0.1-beta.7",
+  "version": "14.0.1-beta.9",
   "description": "",
   "main": "dist/index.js",
   "files": [