launchprep 0.5.2 → 0.5.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "launchprep",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "Launch readiness checker. Reads your code and tells you what will break before your users find out.",
   "type": "module",
   "bin": {

package/src/index.mjs

@@ -5,7 +5,7 @@ import { detectProfile, toGateProfile } from './detect.mjs';
 import { gate, missingFacts } from './gate.mjs';
 import { runChecks, runRootChecks, CHECKS } from './checks.mjs';
 import { render } from './report.mjs';
-import { askQuestions, confirm } from './interactive.mjs';
+import { askQuestions } from './interactive.mjs';
 import { questionFor } from './questions.mjs';
 import { existsSync, statSync } from 'node:fs';
 
@@ -153,28 +153,36 @@ if (asJson) {
     shallow: r.shallow.map(s => ({ id: s.id, title: s.title, severity: s.severity })),
   }, null, 2));
 } else {
-  process.stdout.write(render({ repo: target, ...r, stated }));
-
-  // The Q&A. Only in a real terminal, only when there is something to unlock,
-  // and never when the caller opted out - so a pipe, --json or a CI job is
-  // untouched. Answers are held in memory and merged; no file is written.
-  if (!noInteractive && process.stdin.isTTY && process.stdout.isTTY && r.questions.length) {
+  // Will we ask the questions in the terminal? Only in a real TTY, only when
+  // there is something to unlock, and never on --json / --yes / --no-interactive
+  // or a pipe. Decided BEFORE rendering so the report can drop the "write
+  // launchprep.json" instructions it would otherwise duplicate.
+  const willPrompt = !noInteractive && process.stdin.isTTY && process.stdout.isTTY && r.questions.length > 0;
+
+  process.stdout.write(render({ repo: target, ...r, stated, interactive: willPrompt }));
+
+  if (willPrompt) {
+    // No yes/no gate: a user typed their answers into the old [Y/n] and it read
+    // the whole sentence as "no". Go straight to the questions instead, each one
+    // clearly skippable with Enter, so there is only ever one thing to type.
     const unlocks = r.questions.reduce((n, [, c]) => n + c, 0);
-    const yes = await confirm(
-      `\n  \x1b[36mAnswer ${r.questions.length} quick question${r.questions.length === 1 ? '' : 's'}` +
-      ` to unlock up to ${unlocks} more checks?\x1b[0m \x1b[2m[Y/n]\x1b[0m `);
-    if (yes) {
-      const answers = await askQuestions(r.questions.map(([fact]) => fact));
-      if (Object.keys(answers).length) {
-        const before = new Set(r.findings.map(keyOf));
-        const ranBefore = r.coverage.ran;
-        stated = { ...(fileStated || {}), ...answers };
-        r = analyze(stated);
-        const fresh = r.findings.filter(f => !before.has(keyOf(f)));
-        printDelta(fresh, r.coverage.ran - ranBefore);
-      } else {
-        process.stdout.write(`\n  \x1b[2mNothing answered — the report above is unchanged.\x1b[0m\n\n`);
-      }
+    process.stdout.write(
+      `\n  \x1b[36m${r.questions.length} question${r.questions.length === 1 ? '' : 's'} unlock up to ` +
+      `${unlocks} more checks\x1b[0m \x1b[2m— they can't be read from your code. ` +
+      `Type a number for each, or press Enter to skip.\x1b[0m\n`);
+
+    const answers = await askQuestions(r.questions.map(([fact]) => fact));
+    if (Object.keys(answers).length) {
+      const before = new Set(r.findings.map(keyOf));
+      const ranBefore = r.coverage.ran;
+      stated = { ...(fileStated || {}), ...answers };
+      r = analyze(stated);
+      const fresh = r.findings.filter(f => !before.has(keyOf(f)));
+      printDelta(fresh, r.coverage.ran - ranBefore);
+    } else {
+      process.stdout.write(
+        `\n  \x1b[2mSkipped — the report above is unchanged. You can also put the answers in\x1b[0m` +
+        ` launchprep.json \x1b[2mand run again.\x1b[0m\n\n`);
     }
   }
 }

package/src/interactive.mjs

@@ -72,7 +72,7 @@ export async function askQuestions(facts, { input = process.stdin, output = proc
       // is worse than being asked again.
       let value = null;
       while (value === null) {
-        const raw = (await ask(`  ${C.b}›${C.o} `)).trim().toLowerCase();
+        const raw = (await ask(`  ${C.d}number, or Enter to skip${C.o} ${C.b}›${C.o} `)).trim().toLowerCase();
         if (raw === '') break;                                  // skip this one
         const n = Number(raw);
         if (Number.isInteger(n) && n >= 1 && n <= shape.choices.length) value = shape.choices[n - 1];
@@ -86,15 +86,3 @@ export async function askQuestions(facts, { input = process.stdin, output = proc
   }
   return stated;
 }
-
-// The yes/no gate before any of it. Returns true only on an explicit yes.
-export async function confirm(prompt, { input = process.stdin, output = process.stdout, readLine } = {}) {
-  const rl = readLine ? null : createInterface({ input, output });
-  const ask = readLine || ((q) => new Promise(res => rl.question(q, res)));
-  try {
-    const raw = (await ask(prompt)).trim().toLowerCase();
-    return raw === '' || raw === 'y' || raw === 'yes';        // default yes
-  } finally {
-    rl?.close();
-  }
-}

package/src/report.mjs

@@ -8,7 +8,7 @@ const SEV = { critical:[C.red,'CRITICAL'], high:[C.yel,'HIGH'], medium:[C.blu,'M
 // The wording lives in questions.mjs — 33 facts, not the 5 that had text.
 // A customer used to read "? llm_tools_enabled" as the last line of a scan.
 
-export function render({ repo, scanned, lead, findings, questions, shallow = [], coverage = null, stated = null }) {
+export function render({ repo, scanned, lead, findings, questions, shallow = [], coverage = null, stated = null, interactive = false }) {
   const L = [];
   const p = (s = '') => L.push(s);
   const pr = lead.profile;
@@ -130,7 +130,7 @@ export function render({ repo, scanned, lead, findings, questions, shallow = [],
     p(`      ${C.dim}${String(n).padStart(3)} because ${f} is ${JSON.stringify(lead.profile[f] ?? lead.profile.stack?.[f.split('.').pop()])}${C.off}`);
 
   // ---------- the three questions ----------
-  if (questions.length) {
+  if (questions.length && !interactive) {
     p(`\n${C.bold}${g.unknown.length} more checks need ${questions.length} answer${questions.length === 1 ? '' : 's'}${C.off}`);
     for (const [factName, n] of questions) {
       const q = questionFor(factName);
@@ -142,9 +142,9 @@ export function render({ repo, scanned, lead, findings, questions, shallow = [],
   // This used to say "Correct it and the checks adjust" with no way on earth to
   // do so — no flag, no file, no prompt. It was the last line of every scan and
   // it invited an action that did not exist. Now it names the file that works.
-  if (questions.length)
+  if (questions.length && !interactive)
     p(`\n  ${C.dim}Put those in ${C.off}launchprep.json${C.dim} at the top of your project and run again — the answers unlock the checks above.${C.off}\n`);
-  else
+  else if (!interactive)
     p(`\n  ${C.dim}Wrong about your app? Correct it in ${C.off}launchprep.json${C.dim} and run again.${C.off}\n`);
   return L.join('\n');
 }