launchdarkly-js-sdk-common 5.0.0-alpha.6 → 5.0.0

package/.ldrelease/config.yml

@@ -6,7 +6,8 @@ repo:
 
 branches:
   - name: main
-    description: 4.x
+    description: 5.x
+  - name: 4.x
   - name: 3.x
 
 publications:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "launchdarkly-js-sdk-common",
-  "version": "5.0.0-alpha.6",
+  "version": "5.0.0",
   "description": "LaunchDarkly SDK for JavaScript - common code",
   "author": "LaunchDarkly <team@launchdarkly.com>",
   "license": "Apache-2.0",

package/src/EventProcessor.js

@@ -136,7 +136,8 @@ function EventProcessor(
     }
     queue = [];
     logger.debug(messages.debugPostingEvents(eventsToSend.length));
-    return eventSender.sendEvents(eventsToSend, mainEventsUrl).then(responseInfo => {
+    return eventSender.sendEvents(eventsToSend, mainEventsUrl).then(responses => {
+      const responseInfo = responses && responses[0];
       if (responseInfo) {
         if (responseInfo.serverTime) {
           lastKnownPastTime = responseInfo.serverTime;

package/src/InspectorManager.js

@@ -57,12 +57,12 @@ function InspectorManager(inspectors, logger) {
    *
    * @param {string} flagKey The key for the flag.
    * @param {Object} detail The LDEvaluationDetail for the flag.
-   * @param {Object} user The LDUser for the flag.
+   * @param {Object} context The LDContext for the flag.
    */
-  manager.onFlagUsed = (flagKey, detail, user) => {
+  manager.onFlagUsed = (flagKey, detail, context) => {
     if (inspectorsByType[InspectorTypes.flagUsed].length) {
       onNextTick(() => {
-        inspectorsByType[InspectorTypes.flagUsed].forEach(inspector => inspector.method(flagKey, detail, user));
+        inspectorsByType[InspectorTypes.flagUsed].forEach(inspector => inspector.method(flagKey, detail, context));
       });
     }
   };
@@ -99,16 +99,16 @@ function InspectorManager(inspectors, logger) {
   };
 
   /**
-   * Notify the registered inspectors that the user identity has changed.
+   * Notify the registered inspectors that the context identity has changed.
    *
    * The notification itself will be dispatched asynchronously.
    *
-   * @param {Object} user The `LDUser` which is now identified.
+   * @param {Object} context The `LDContext` which is now identified.
    */
-  manager.onIdentityChanged = user => {
+  manager.onIdentityChanged = context => {
     if (inspectorsByType[InspectorTypes.clientIdentityChanged].length) {
       onNextTick(() => {
-        inspectorsByType[InspectorTypes.clientIdentityChanged].forEach(inspector => inspector.method(user));
+        inspectorsByType[InspectorTypes.clientIdentityChanged].forEach(inspector => inspector.method(context));
       });
     }
   };

package/src/__tests__/InspectorManager-test.js

@@ -39,16 +39,16 @@ describe('given an inspector with callbacks of every type', () => {
       {
         type: 'flag-used',
         name: 'my-flag-used-inspector',
-        method: (flagKey, flagDetail, user) => {
-          eventQueue.add({ type: 'flag-used', flagKey, flagDetail, user });
+        method: (flagKey, flagDetail, context) => {
+          eventQueue.add({ type: 'flag-used', flagKey, flagDetail, context });
         },
       },
       // 'flag-used registered twice.
       {
         type: 'flag-used',
         name: 'my-other-flag-used-inspector',
-        method: (flagKey, flagDetail, user) => {
-          eventQueue.add({ type: 'flag-used', flagKey, flagDetail, user });
+        method: (flagKey, flagDetail, context) => {
+          eventQueue.add({ type: 'flag-used', flagKey, flagDetail, context });
         },
       },
       {
@@ -75,10 +75,10 @@ describe('given an inspector with callbacks of every type', () => {
       {
         type: 'client-identity-changed',
         name: 'my-identity-inspector',
-        method: user => {
+        method: context => {
           eventQueue.add({
             type: 'client-identity-changed',
-            user,
+            context,
           });
         },
       },
@@ -137,7 +137,7 @@ describe('given an inspector with callbacks of every type', () => {
           kind: 'OFF',
         },
       },
-      user: { key: 'test-key' },
+      context: { key: 'test-key' },
     };
     const event1 = await eventQueue.take();
     expect(event1).toMatchObject(expectedEvent);
@@ -180,7 +180,7 @@ describe('given an inspector with callbacks of every type', () => {
     const event = await eventQueue.take();
     expect(event).toMatchObject({
       type: 'client-identity-changed',
-      user: { key: 'the-key' },
+      context: { key: 'the-key' },
     });
   });
 });

package/src/__tests__/LDClient-inspectors-test.js

@@ -3,7 +3,7 @@ const { respondJson } = require('./mockHttp');
 const stubPlatform = require('./stubPlatform');
 
 const envName = 'UNKNOWN_ENVIRONMENT_ID';
-const user = { key: 'user' };
+const context = { key: 'context-key' };
 
 describe('given a streaming client with registered inspectors', () => {
   const eventQueue = new AsyncQueue();
@@ -11,15 +11,15 @@ describe('given a streaming client with registered inspectors', () => {
   const inspectors = [
     {
       type: 'flag-used',
-      method: (flagKey, flagDetail, user) => {
-        eventQueue.add({ type: 'flag-used', flagKey, flagDetail, user });
+      method: (flagKey, flagDetail, context) => {
+        eventQueue.add({ type: 'flag-used', flagKey, flagDetail, context });
       },
     },
     // 'flag-used registered twice.
     {
       type: 'flag-used',
-      method: (flagKey, flagDetail, user) => {
-        eventQueue.add({ type: 'flag-used', flagKey, flagDetail, user });
+      method: (flagKey, flagDetail, context) => {
+        eventQueue.add({ type: 'flag-used', flagKey, flagDetail, context });
       },
     },
     {
@@ -43,10 +43,10 @@ describe('given a streaming client with registered inspectors', () => {
     },
     {
       type: 'client-identity-changed',
-      method: user => {
+      method: context => {
         eventQueue.add({
           type: 'client-identity-changed',
-          user,
+          context,
         });
       },
     },
@@ -60,7 +60,7 @@ describe('given a streaming client with registered inspectors', () => {
     const server = platform.testing.http.newServer();
     server.byDefault(respondJson({}));
     const config = { streaming: true, baseUrl: server.url, inspectors, sendEvents: false };
-    client = platform.testing.makeClient(envName, user, config);
+    client = platform.testing.makeClient(envName, context, config);
     await client.waitUntilReady();
   });
 
@@ -81,7 +81,7 @@ describe('given a streaming client with registered inspectors', () => {
     const ident = await eventQueue.take();
     expect(ident).toMatchObject({
       type: 'client-identity-changed',
-      user,
+      context,
     });
     const flagsEvent = await eventQueue.take();
     expect(flagsEvent).toMatchObject({

package/src/__tests__/PersistentFlagStore-test.js

@@ -7,10 +7,10 @@ import PersistentStorage from '../PersistentStorage';
 import * as utils from '../utils';
 
 describe('PersistentFlagStore', () => {
-  const user = { key: 'user' };
-  const ident = Identity(user);
+  const context = { key: 'context-key', kind: 'user' };
+  const ident = Identity(context);
   const env = 'ENVIRONMENT';
-  const lsKey = 'ld:' + env + ':' + utils.btoa(JSON.stringify(user));
+  const lsKey = 'ld:' + env + ':' + utils.btoa(JSON.stringify(context));
 
   it('stores flags', async () => {
     const platform = stubPlatform.defaults();
@@ -73,7 +73,7 @@ describe('PersistentFlagStore', () => {
     expect(platform.testing.getLocalStorageImmediately(lsKey)).toBe(undefined);
   });
 
-  it('uses hash, if present, instead of user properties', async () => {
+  it('uses hash, if present, instead of context properties', async () => {
     const platform = stubPlatform.defaults();
     const storage = PersistentStorage(platform.localStorage, platform.testing.logger);
     const hash = '12345';

package/src/__tests__/stubPlatform.js

@@ -83,14 +83,14 @@ export function defaults() {
 
       eventSourcesCreated,
 
-      makeClient: (env, user, options = {}) => {
+      makeClient: (env, context, options = {}) => {
         const config = { logger: p.testing.logger, ...options };
         // We want to simulate what the platform-specific SDKs will do in their own initialization functions.
         // They will call the common package's LDClient.initialize() and receive the clientVars object which
         // contains both the underlying client (in its "client" property) and some internal methods that the
         // platform-specific SDKs can use to do internal stuff. One of those is start(), which they will
         // call after doing any other initialization things they may need to do.
-        const clientVars = LDClient.initialize(env, user, config, p);
+        const clientVars = LDClient.initialize(env, context, config, p);
         clientVars.start();
         return clientVars.client;
       },

package/src/__tests__/testUtils.js

@@ -62,7 +62,7 @@ export function MockEventSender() {
     calls,
     sendEvents: (events, url) => {
       calls.add({ events, url });
-      return Promise.resolve({ serverTime, status });
+      return Promise.resolve([{ serverTime, status }]);
     },
     setServerTime: time => {
       serverTime = time;

package/src/__tests__/utils-test.js

@@ -66,8 +66,8 @@ describe('utils', () => {
 
   describe('chunkEventsForUrl', () => {
     it('should properly chunk the list of events', () => {
-      const user = { key: 'foo' };
-      const event = { kind: 'identify', key: user.key };
+      const context = { key: 'foo', kind: 'user' };
+      const event = { kind: 'identify', key: context.key };
       const eventLength = base64URLEncode(JSON.stringify(event)).length;
       const events = [event, event, event, event, event];
       const chunks = chunkEventsForUrl(eventLength * 2, events);

package/src/context.js

@@ -100,7 +100,7 @@ function getContextKeys(context, logger = commonBasicLogger()) {
   const { kind, key } = context;
 
   switch (kind) {
-    case typeof kind === 'undefined':
+    case undefined:
       keys.user = `${key}`;
       break;
     case 'multi':

package/src/diagnosticEvents.js

@@ -1,6 +1,6 @@
 const { v1: uuidv1 } = require('uuid');
 // Note that in the diagnostic events spec, these IDs are to be generated with UUID v4. However,
-// in JS we were already using v1 for unique user keys, so to avoid bringing in two packages we
+// in JS we were already using v1 for unique context keys, so to avoid bringing in two packages we
 // will use v1 here as well.
 
 const { baseOptionDefs } = require('./configuration');

package/src/index.js

@@ -189,8 +189,8 @@ function initialize(env, context, specifiedOptions, platform, extraOptionDefs) {
     }
   }
 
-  function onIdentifyChange(user) {
-    sendIdentifyEvent(user);
+  function onIdentifyChange(context) {
+    sendIdentifyEvent(context);
     notifyInspectionIdentityChanged();
   }
 

package/typings.d.ts

@@ -327,8 +327,7 @@ declare module 'launchdarkly-js-sdk-common' {
      * 
      * This is a metadata property, rather than an attribute that can be addressed in evaluations:
      * that is, a rule clause that references the attribute name "privateAttributes", will not use
-     * this value, but instead will use whatever value (if any) you have set for that name with a
-     * method such as SetString.
+     * this value, but would use a "privateAttributes" attribute set on the context.
      */
     privateAttributes?: string[];
   }