launchdarkly-js-sdk-common 4.0.1 → 4.0.2

package/.eslintrc.yaml

@@ -11,7 +11,6 @@ plugins:
   - babel
   - prettier
 globals:
-  VERSION: true
   describe: true
   it: true
   expect: true

package/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to the `launchdarkly-js-sdk-common` package will be documented in this file. Changes that affect the dependent SDKs such as `launchdarkly-js-client-sdk` should also be logged in those projects, in the next release that uses the updated version of this package. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [4.0.2] - 2022-01-25
+### Removed:
+- Removed the `version` export which was originally a constant inserted by the Rollup build, but was no longer usable since Rollup is no longer being used. The SDKs never used this export, since they have `version` properties of their own; the version string of `launchdarkly-js-sdk-common` was never meant to be exposed to applications.
+
 ## [4.0.1] - 2022-01-21
 ### Changed:
 - This package is now published as a regular Node module. Previously, it was published as minified bundles created by Rollup. There was no need for this since Rollup is only needed for web code, and the `js-client-sdk` build already runs Rollup to embed the `js-sdk-common` code. Using Rollup caused the platform-dependent behavior of `uuid` to fail because the code for only one platform (browser or Node) was embedded.

package/docs/typedoc.js

@@ -4,7 +4,7 @@ module.exports = {
     '**/node_modules/**',
     'test-types.ts'
   ],
-  name: "LaunchDarkly Javascript SDK Core Components (4.0.1)",
+  name: "LaunchDarkly Javascript SDK Core Components (4.0.2)",
   readme: 'none',                // don't add a home page with a copy of README.md
   entryPoints: "/tmp/project-releaser/project/typings.d.ts",
   entryPointStrategy: "expand"

package/jest.config.js

@@ -9,7 +9,4 @@ module.exports = {
   transform: {
     '^.+\\.js$': 'babel-jest',
   },
-  globals: {
-    VERSION: version,
-  },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "launchdarkly-js-sdk-common",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "description": "LaunchDarkly SDK for JavaScript - common code",
   "author": "LaunchDarkly <team@launchdarkly.com>",
   "license": "Apache-2.0",
@@ -40,8 +40,6 @@
     "launchdarkly-js-test-helpers": "1.1.0",
     "prettier": "1.11.1",
     "readline-sync": "^1.4.9",
-    "semver": "^5.5.0",
-    "semver-compare": "^1.0.0",
     "typescript": "~4.4.4"
   },
   "dependencies": {

package/src/__tests__/.eslintrc.yaml

@@ -1,6 +1,5 @@
 ---
 globals:
-  VERSION: true
   sinon: true
   expect: true
   requestor: true

package/src/__tests__/LDClient-test.js

@@ -2,7 +2,6 @@ import * as LDClient from '../index';
 import * as messages from '../messages';
 import * as utils from '../utils';
 
-import semverCompare from 'semver-compare';
 import { eventSink, promisifySingle, sleepAsync, withCloseable, AsyncQueue } from 'launchdarkly-js-test-helpers';
 
 import { respond, respondJson } from './mockHttp';
@@ -106,13 +105,6 @@ describe('LDClient', () => {
       });
     });
 
-    it('should contain package version', () => {
-      const version = LDClient.version;
-      // All client bundles above 1.0.7 should contain package version
-      const result = semverCompare(version, '1.0.6');
-      expect(result).toEqual(1);
-    });
-
     async function verifyCustomHeader(sendLDHeaders, shouldGetHeaders) {
       await withServers(async (baseConfig, pollServer) => {
         await withClient(user, { ...baseConfig, sendLDHeaders }, async client => {

package/src/__tests__/utils-test.js

@@ -120,11 +120,11 @@ describe('utils', () => {
   });
 
   describe('getLDUserAgentString', () => {
-    it('uses platform user-agent and package version by default', () => {
+    it('uses platform user-agent and unknown version by default', () => {
       const platform = stubPlatform.defaults();
       platform.version = undefined;
       const ua = getLDUserAgentString(platform);
-      expect(ua).toEqual('stubClient/' + VERSION);
+      expect(ua).toEqual('stubClient/?');
     });
 
     it('uses platform user-agent and platform version if provided', () => {

package/src/index.js

@@ -760,13 +760,10 @@ function initialize(env, user, specifiedOptions, platform, extraOptionDefs) {
   };
 }
 
-const version = VERSION;
-
 module.exports = {
   initialize,
   commonBasicLogger,
   errors,
   messages,
   utils,
-  version,
 };

package/src/utils.js

@@ -146,7 +146,7 @@ function chunkUserEventsForUrl(maxLength, events) {
 }
 
 function getLDUserAgentString(platform) {
-  const version = platform.version || VERSION;
+  const version = platform.version || '?';
   return platform.userAgent + '/' + version;
 }
 

package/test-types.ts

@@ -4,8 +4,6 @@
 
 import * as ld from 'launchdarkly-js-sdk-common';
 
-var ver: string = ld.version;
-
 var userWithKeyOnly: ld.LDUser = { key: 'user' };
 var anonUserWithNoKey: ld.LDUser = { anonymous: true };
 var anonUserWithKey: ld.LDUser = { key: 'anon-user', anonymous: true };

package/typings.d.ts

@@ -2,12 +2,6 @@
  * Basic LaunchDarkly JavaScript client interfaces, shared between the browser SDK and the Electron SDK.
  */
 declare module 'launchdarkly-js-sdk-common' {
-
-  /**
-   * The current version string of the SDK.
-   */
-  export const version: string;
-
   /**
    * The types of values a feature flag can have.
    *