launch-editor-middleware 2.10.0 → 2.11.1

package/index.js

@@ -1,4 +1,3 @@
-const url = require('url')
 const path = require('path')
 const launch = require('launch-editor')
 
@@ -15,13 +14,28 @@ module.exports = (specifiedEditor, srcRoot, onErrorCallback) => {
 
   srcRoot = srcRoot || process.cwd()
 
-  return function launchEditorMiddleware (req, res) {
-    const { file } = url.parse(req.url, true).query || {}
+  return function launchEditorMiddleware(req, res) {
+    let url
+
+    try {
+      const fullUrl = req.url.startsWith('http') ? req.url : `http://localhost${req.url}`
+      url = new URL(fullUrl)
+      // eslint-disable-next-line no-unused-vars
+    } catch (_err) {
+      res.statusCode = 500
+      res.end(`launch-editor-middleware: invalid URL.`)
+      return
+    }
+
+    const file = url.searchParams.get('file')
     if (!file) {
       res.statusCode = 500
-      res.end(`launch-editor-middleware: required query param "file" is missing.`)
+      res.end(
+        `launch-editor-middleware: required query param "file" is missing.`
+      )
     } else {
-      launch(path.resolve(srcRoot, file), specifiedEditor, onErrorCallback)
+      const resolved = file.startsWith('file://') ? file : path.resolve(srcRoot, file)
+      launch(resolved, specifiedEditor, onErrorCallback)
       res.end()
     }
   }

package/package.json

@@ -1,8 +1,11 @@
 {
   "name": "launch-editor-middleware",
-  "version": "2.10.0",
+  "version": "2.11.1",
   "description": "express middleware for launching editor",
   "main": "index.js",
+  "files": [
+    "index.js"
+  ],
   "repository": {
     "type": "git",
     "url": "git+https://github.com/yyx990803/launch-editor.git"
@@ -19,6 +22,9 @@
   },
   "homepage": "https://github.com/yyx990803/launch-editor#readme",
   "dependencies": {
-    "launch-editor": "^2.10.0"
+    "launch-editor": "^2.11.1"
+  },
+  "scripts": {
+    "test": "node --test --experimental-test-module-mocks"
   }
 }